package_protections 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c09fbdc359d1dc28d4168fc0041dc385ea8a5b78c77436c598d5f6fd3eb24d6
-  data.tar.gz: 7ab7d9d30955c98c8213434b80923a96602a2489e2b822b9e8f75f3ff25145e8
+  metadata.gz: 217ae8f6eee7f084ff39ce7c4cf0bb06a08c361abff49e411d730a3a79592b71
+  data.tar.gz: 21a4eea2876078f531a67d3705e7a0d38c11b3bf87cd265e552bda9e8661638a
 SHA512:
-  metadata.gz: 0027653c627faaacdc1e7dfe57342d10130b93cd833a5083091c54fbc48ba106366768671ce703cdf5c4576dcd53db10a39cc59f0262fc18b06153d00ddcc284
-  data.tar.gz: 1494769fd3a1120add3da651cba6b0c826cc990890669810eb1532404ef1e2820470628bc89a77794589b819ed557da9cb3127910deebe2780854d560760ad9d
+  metadata.gz: 1633812b257db230cf9f0244c8dd397197d4feb98f37abcd9906e5660adbfb7985c82fc6758254f99771726d49d3796c2e30438a54bd14a75c9ed3b64dbca1a0
+  data.tar.gz: e1aafb82c4a5a93425cbfc28135bae436b792681f6cbd8257f95e2d51d985a436e80d191313d2959a3e9c37423f970608109bca773a5ffe0ad01af3d6214b6da

data/README.md

@@ -56,7 +56,7 @@ This protection only looks at files in `packs/your_pack/app` (it ignores spec fi
 This protection is implemented via Rubocop -- expect to see results for this when running `rubocop` however you normally do. To add to the TODO list, add to `.rubocop_todo.yml`
 Lastly – this protection can be configured by setting `globally_permitted_namespaces`, e.g.:
 ```ruby
-PackageProtections.configure do |config|
+RuboCop::Packs.configure do |config|
   config.globally_permitted_namespaces = ['SomeGlobalNamespace']
 end
 ```

data/lib/rubocop/cop/package_protections/namespaced_under_package_name.rb

@@ -34,7 +34,7 @@ module RuboCop
               enabled: include_packs.any?,
               metadata: {
                 'IncludePacks' => include_packs,
-                'GloballyPermittedNamespaces' => ::PackageProtections.config.globally_permitted_namespaces
+                'GloballyPermittedNamespaces' => ::RuboCop::Packs.config.globally_permitted_namespaces
               }
             )
           ]
@@ -57,23 +57,19 @@ module RuboCop
 
         sig { override.params(behavior: ::PackageProtections::ViolationBehavior, package: ParsePackwerk::Package).returns(T.nilable(String)) }
         def unmet_preconditions_for_behavior(behavior, package)
-          if !behavior.enabled? && !package.metadata['global_namespaces'].nil?
-            "Invalid configuration for package `#{package.name}`. `#{identifier}` must be turned on to use `global_namespaces` configuration."
-          else
-            # We don't need to validate if the behavior is currentely fail_never
-            return if behavior.fail_never?
+          # We don't need to validate if the behavior is currentely fail_never
+          return if behavior.fail_never?
 
-            # The reason for this is precondition is the `MultipleNamespacesProtection` assumes this to work properly.
-            # To remove this precondition, we need to modify `MultipleNamespacesProtection` to be more generalized!
-            is_root_package = package.name == ParsePackwerk::ROOT_PACKAGE_NAME
-            in_allowed_directory = ::PackageProtections::EXPECTED_PACK_DIRECTORIES.any? do |expected_package_directory|
-              package.directory.to_s.start_with?(expected_package_directory)
-            end
-            if in_allowed_directory || is_root_package
-              nil
-            else
-              "Package #{package.name} must be located in one of #{::PackageProtections::EXPECTED_PACK_DIRECTORIES.join(', ')} (or be the root) to use this protection"
-            end
+          # The reason for this is precondition is the `MultipleNamespacesProtection` assumes this to work properly.
+          # To remove this precondition, we need to modify `MultipleNamespacesProtection` to be more generalized!
+          is_root_package = package.name == ParsePackwerk::ROOT_PACKAGE_NAME
+          in_allowed_directory = ::PackageProtections::EXPECTED_PACK_DIRECTORIES.any? do |expected_package_directory|
+            package.directory.to_s.start_with?(expected_package_directory)
+          end
+          if in_allowed_directory || is_root_package
+            nil
+          else
+            "Package #{package.name} must be located in one of #{::PackageProtections::EXPECTED_PACK_DIRECTORIES.join(', ')} (or be the root) to use this protection"
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: package_protections
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-24 00:00:00.000000000 Z
+date: 2022-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport