pack_api 1.0.3 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 246f379e82f7226306211a320a9f7ec9d7f9d251be0f2817c815a071b8159422
-  data.tar.gz: 939d5be377373d26a4e62ba7fb2870c595aadb52c7527f01c89c512d8af77856
+  metadata.gz: ac4e447544be25898609198e72112c0da8840ff64e9efdb143d463eec2a34c80
+  data.tar.gz: 7576d9e011b764ca396623d7faec591b962c7d3bd407d2f360351e37bdd5efaa
 SHA512:
-  metadata.gz: 58ac5c88da900f602058aa151a38193bbda938baafd761380c1257079b7ded5e9b107c065dc251b4bc66e39e87fd1f6f623222798c9f50e3cb4dae251a02e6b2
-  data.tar.gz: eaf29a74517055cf5c97596da942d0d2f42197791b53931a2b59d67130e2afa2a6b0db8efa11a24d7c938279e2e111728440aabdef08e9a9282370ba390a001b
+  metadata.gz: 6c17deb6c83f2e79c9d16ed89caec0aa4baa11476285444956ed653a98badb778283636c3d2361c01b3587e0b9d573b7f5e805e019f05243457cd44420c90df0
+  data.tar.gz: b23f8c03c9f2c3bf122102222e0a9380f4870679fa0b335ae8fcb2e8485cad5d6768f4b74120c6e8811e0222c131d868532db57c230ed75e6e8ed1903ec10750

data/lib/pack_api/mapping/error_hash_to_api_attributes_transformer.rb

@@ -68,6 +68,10 @@ module PackAPI::Mapping
       collection_associations.include?(model_attribute)
     end
 
+    def accepts_nested_attributes_for?(association_name)
+      model_type.nested_attributes_options.key?(association_name)
+    end
+
     def resource_associations
       @resource_associations ||= model_type.reflect_on_all_associations
                                            .reject(&:collection?)
@@ -81,7 +85,9 @@ module PackAPI::Mapping
     end
 
     def normalize_association_reference(api_attribute, model_attribute)
-      if resource_association?(model_attribute)
+      if accepts_nested_attributes_for?(model_attribute)
+        api_attribute
+      elsif resource_association?(model_attribute)
         normalize_resource_association_reference(api_attribute)
       elsif collection_association?(model_attribute)
         normalize_collection_association_reference(api_attribute)

data/lib/pack_api/querying/collection_query.rb

@@ -109,11 +109,21 @@ module PackAPI::Querying
     end
 
     def apply_filters(filters:)
-      filtered_query = ComposableQuery.new(@query)
-      filter_factory.create_filters(filters).each { |filter| filter.apply_to(filtered_query) }
+      filter_objects = filter_factory.create_filters(filters)
+      validate_filters(filter_objects)
+      filtered_query = filter_objects.each_with_object(ComposableQuery.new(@query)) do |filter, composable_query|
+        filter.apply_to(composable_query)
+      end
       @query = filtered_query.build
     end
 
+    def validate_filters(filter_objects)
+      errors = filter_objects.select { |filter| filter.respond_to?(:valid?) && !filter.valid? }
+                             .map { |invalid_filter| { invalid_filter.filter_name => invalid_filter.errors.messages } }
+                             .reduce({}, :merge)
+      raise PackAPI::InternalError.new(object: errors) if errors.present?
+    end
+
     def stable_sort(sort)
       return sort if sort.is_a?(Arel::Nodes::SqlLiteral)
 

data/lib/pack_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PackAPI
-  VERSION = "1.0.3"
+  VERSION = "1.0.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pack_api
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.5
 platform: ruby
 authors:
 - Flytedesk