pacecar 1.5.3 → 2.0.0

data/spec/dummy/config/locales/en.yml

@@ -1,5 +1,23 @@
-# Sample localization file for English. Add more files in this directory for other locales.
-# See http://github.com/svenfuchs/rails-i18n/tree/master/rails%2Flocale for starting points.
+# Files in the config/locales directory are used for internationalization
+# and are automatically loaded by Rails. If you want to use locales other
+# than English, add the necessary files in this directory.
+#
+# To use the locales, use `I18n.t`:
+#
+#     I18n.t 'hello'
+#
+# In views, this is aliased to just `t`:
+#
+#     <%= t('hello') %>
+#
+# To use a different locale, set it with `I18n.locale`:
+#
+#     I18n.locale = :es
+#
+# This would use the information in config/locales/es.yml.
+#
+# To learn more, please read the Rails Internationalization guide
+# available at http://guides.rubyonrails.org/i18n.html.
 
 en:
   hello: "Hello world"

data/spec/dummy/config/routes.rb

@@ -1,19 +1,20 @@
 Dummy::Application.routes.draw do
-  # The priority is based upon order of creation:
-  # first created -> highest priority.
+  # The priority is based upon order of creation: first created -> highest priority.
+  # See how all your routes lay out with "rake routes".
 
-  # Sample of regular route:
-  #   match 'products/:id' => 'catalog#view'
-  # Keep in mind you can assign values other than :controller and :action
+  # You can have the root of your site routed with "root"
+  # root 'welcome#index'
+
+  # Example of regular route:
+  #   get 'products/:id' => 'catalog#view'
 
-  # Sample of named route:
-  #   match 'products/:id/purchase' => 'catalog#purchase', :as => :purchase
-  # This route can be invoked with purchase_url(:id => product.id)
+  # Example of named route that can be invoked with purchase_url(id: product.id)
+  #   get 'products/:id/purchase' => 'catalog#purchase', as: :purchase
 
-  # Sample resource route (maps HTTP verbs to controller actions automatically):
+  # Example resource route (maps HTTP verbs to controller actions automatically):
   #   resources :products
 
-  # Sample resource route with options:
+  # Example resource route with options:
   #   resources :products do
   #     member do
   #       get 'short'
@@ -25,34 +26,31 @@ Dummy::Application.routes.draw do
   #     end
   #   end
 
-  # Sample resource route with sub-resources:
+  # Example resource route with sub-resources:
   #   resources :products do
   #     resources :comments, :sales
   #     resource :seller
   #   end
 
-  # Sample resource route with more complex sub-resources
+  # Example resource route with more complex sub-resources:
   #   resources :products do
   #     resources :comments
   #     resources :sales do
-  #       get 'recent', :on => :collection
+  #       get 'recent', on: :collection
   #     end
   #   end
+  
+  # Example resource route with concerns:
+  #   concern :toggleable do
+  #     post 'toggle'
+  #   end
+  #   resources :posts, concerns: :toggleable
+  #   resources :photos, concerns: :toggleable
 
-  # Sample resource route within a namespace:
+  # Example resource route within a namespace:
   #   namespace :admin do
   #     # Directs /admin/products/* to Admin::ProductsController
   #     # (app/controllers/admin/products_controller.rb)
   #     resources :products
   #   end
-
-  # You can have the root of your site routed with "root"
-  # just remember to delete public/index.html.
-  # root :to => "welcome#index"
-
-  # See how all your routes lay out with "rake routes"
-
-  # This is a legacy wild controller route that's not recommended for RESTful applications.
-  # Note: This route will make all actions in every controller accessible via GET requests.
-  # match ':controller(/:action(/:id(.:format)))'
 end

data/spec/factories.rb

@@ -19,8 +19,8 @@ FactoryGirl.define do
   end
 
   factory :user do
-    age     { Factory.next :age }
-    rating  { Factory.next :rating }
+    age
+    rating
   end
 
 end

data/spec/helpers_spec.rb

@@ -2,47 +2,39 @@ require 'spec_helper'
 
 describe 'Helpers' do
 
-  describe "A class without a db table" do
-    it "should return an empty array when asked about #safe_columns" do
-      Article.send(:safe_columns).should == []
+  describe 'A class without a db table' do
+    it 'Returns an empty array when asked about #safe_columns' do
+      expect(Article.send(:safe_columns)).to eq []
     end
 
-    it "should survive an include of Pacecar" do
-      lambda { Article.send :include, Pacecar }.should_not raise_error
+    it 'Survives an include of Pacecar' do
+      expect { Article.send :include, Pacecar }.to_not raise_error
     end
   end
 
-  describe "A class with a db table" do
-    it "should  should return columns for #safe_column_names" do
-      Comment.safe_column_names.should == ['id', 'user_id', 'description', 'rating', 'created_at', 'updated_at']
+  describe 'A class with a db table' do
+    it 'Returns columns for #safe_column_names' do
+      expect(Comment.safe_column_names).to eq ['id', 'user_id', 'description', 'rating', 'created_at', 'updated_at']
     end
   end
 
-  describe "A class with many column types" do
-    it "should return boolean columns for #boolean_column_names" do
-      User.boolean_column_names.should == ['admin']
+  describe 'A class with many column types' do
+    it 'Returns boolean columns for #boolean_column_names' do
+      expect(User.boolean_column_names).to eq ['admin']
     end
 
-    it "should return non boolean columns for #non_boolean_column_names" do
-      User.non_boolean_column_names.should == ['id', 'approved_at', 'rejected_at', 'last_posted_on', 'first_name', 'last_name', 'description', 'age', 'rating', 'balance', 'created_at', 'updated_at']
+    it 'Returns non boolean columns for #non_boolean_column_names' do
+      expect(User.non_boolean_column_names).to eq ['id', 'approved_at', 'rejected_at', 'last_posted_on', 'first_name', 'last_name', 'description', 'age', 'rating', 'balance', 'created_at', 'updated_at']
     end
 
-    it "should  return datetime columns for #datetime_column_names" do
-      User.datetime_column_names.should == ['approved_at', 'rejected_at', 'last_posted_on', 'created_at', 'updated_at']
-    end
-
-    it "should  return text and string columns for #text_and_string_column_names" do
-      User.text_and_string_column_names.should == ['first_name', 'last_name', 'description']
-    end
-
-    it "should  return numeric columns for #numeric_column_names" do
-      User.numeric_column_names.should == ['id', 'age', 'rating', 'balance']
+    it 'Returns text and string columns for #text_and_string_column_names' do
+      expect(User.text_and_string_column_names).to eq ['first_name', 'last_name', 'description']
     end
   end
 
-  describe "A class with a state column should" do
-    it "should return all non state text and string columns for #non_state_text_and_string_column_names" do
-      Post.non_state_text_and_string_columns.should == ['title', 'body']
+  describe 'A class with a state column should' do
+    it 'Returns all non state text and string columns for #non_state_text_and_string_column_names' do
+      expect(Post.non_state_text_and_string_columns).to eq ['title', 'body']
     end
   end
 

data/spec/integration/navigation_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 
-describe "Navigation" do
-  include Capybara::DSL
-  
-  it "should be a valid app" do
-    ::Rails.application.should be_a(Dummy::Application)
+describe 'Navigation' do
+
+  it 'should be a valid app' do
+    expect(::Rails.application).to be_a(Dummy::Application)
   end
 end

data/spec/limit_spec.rb

@@ -3,23 +3,23 @@ require 'spec_helper'
 describe 'Limit' do
 
   before do
-    50.times { Factory :user }
+    create_list(:user, 15)
   end
 
-  it "should set the correct expected values for a by_ column method" do
-    User.count.should == 50
-    User.limited.all.size.should == 10
+  it 'Limits the results to the default value' do
+    expect(User.count).to eq 15
+    expect(User.limited.size).to eq 10
   end
 
-  it "should set the correct expected values for a by_ column method when sent args" do
-    User.count.should == 50
-    User.limited(20).all.size.should == 20
+  it 'Limits the results to the supplied value when sent args' do
+    expect(User.count).to eq 15
+    expect(User.limited(5).size).to eq 5
   end
 
-  it "should set the correct expected values for a by_ column method when per_page defined" do
-    User.expects(:per_page).returns 30
-    User.count.should == 50
-    User.limited.all.size.should == 30
+  it 'Limits the results to the per_page value of the class' do
+    User.expects(:per_page).returns 2
+    expect(User.count).to eq 15
+    expect(User.limited.size).to eq 2
   end
 
 end

data/spec/order_spec.rb

@@ -3,20 +3,20 @@ require 'spec_helper'
 describe 'Order' do
 
   before do
-    @first = Factory :user, :first_name => 'Abe'
-    @last  = Factory :user, :first_name => 'Zed'
+    @first = create :user, first_name: 'Abe'
+    @last  = create :user, first_name: 'Zed'
   end
 
-  it "should set the correct expected values for a by_ column method with no args" do
-    User.by_first_name.should == [@first, @last]
+  it 'Returns the correct results for a by_ column method with no args' do
+    expect(User.by_first_name).to eq [@first, @last]
   end
 
-  it "should set the correct expected values for a by_ column method with asc args" do
-    User.by_first_name(:asc).should == [@first, @last]
+  it 'Returns the correct results for a by_ column method with asc args' do
+    expect(User.by_first_name(:asc)).to eq [@first, @last]
   end
 
-  it "should set the correct expected values for a by_ column method with desc args" do
-    User.by_first_name(:desc).should == [@last, @first]
+  it 'Returns the correct results for a by_ column method with desc args' do
+    expect(User.by_first_name(:desc)).to eq [@last, @first]
   end
 
 end

data/spec/pacecar_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Pacecar do
-  it "should be valid" do
-    Pacecar.should be_a(Module)
+  it 'Is a valid module' do
+    expect(Pacecar).to be_a(Module)
   end
-end
+end

data/spec/polymorph_spec.rb

@@ -3,16 +3,16 @@ require 'spec_helper'
 describe 'Polymorph' do
 
   before do
-    @owned_by_user = Factory :post, :owner_type => 'User'
-    @owned_by_mammal = Factory :post, :owner_type => 'Mammal'
+    @owned_by_user = create :post, owner_type: 'User'
+    @owned_by_mammal = create :post, owner_type: 'Mammal'
   end
 
-  it "should set the correct expected values on a _for column method with Class" do
-    Post.for_owner_type(User).should == [@owned_by_user]
+  it 'Returns records on a _for column method with Class' do
+    expect(Post.for_owner_type(User)).to eq [@owned_by_user]
   end
 
-  it "should set the correct expected values on a _for column method with String" do
-    Post.for_owner_type('User').should == [@owned_by_user]
+  it 'Returns records on a _for column method with String' do
+    expect(Post.for_owner_type('User')).to eq [@owned_by_user]
   end
 
 end

data/spec/presence_spec.rb

@@ -3,21 +3,21 @@ require 'spec_helper'
 describe 'Presence' do
 
   before do
-    @not_null = Factory :user, :first_name => 'Fake'
-    @null = Factory :user, :first_name => nil
+    @not_null = create :user, first_name: 'Fake'
+    @null = create :user, first_name: nil
   end
 
-  it "should set the correct expected values for a _present column method" do
-    User.first_name_present.should == [@not_null]
+  it 'Returns records for a _present column method' do
+    expect(User.first_name_present).to eq [@not_null]
   end
 
-  it "should set the correct expected values for a _missing column method" do
-    User.first_name_missing.should == [@null]
+  it 'Returns records for a _missing column method' do
+    expect(User.first_name_missing).to eq [@null]
   end
 
-  it "should not setup methods for boolean columns" do
-    lambda { User.admin_missing }.should raise_error(NoMethodError)
-    lambda { User.admin_present }.should raise_error(NoMethodError)
+  it 'Does not setup methods for boolean columns' do
+    expect { User.admin_missing }.to raise_error(NoMethodError)
+    expect { User.admin_present }.to raise_error(NoMethodError)
   end
 
 end

data/spec/search_spec.rb

@@ -3,61 +3,27 @@ require 'spec_helper'
 describe 'Search' do
 
   before do
-    @abe      = Factory :user, :first_name => 'Abe',    :last_name => 'Anderson', :description => 'Apple'
-    @bob      = Factory :user, :first_name => 'Bob',    :last_name => 'Babson',   :description => 'Banana'
-    @cindy    = Factory :user, :first_name => 'Cindy',  :last_name => 'Clarkson', :description => 'Cookie'
-    @dave     = Factory :user, :first_name => 'Dave'
-    @ed       = Factory :user, :last_name => 'Dave'
-    @frank    = Factory :user, :description => 'Dave'
-    @george   = Factory :user, :first_name => 'Dave',   :last_name => 'Dave',     :description => 'Dave'
+    @abe    = create :user, first_name:  'Abe',    last_name: 'Anderson', description: 'Apple'
+    @bob    = create :user, first_name:  'Bob',    last_name: 'Babson',   description: 'Banana'
+    @cindy  = create :user, first_name:  'Cindy',  last_name: 'Clarkson', description: 'Cookie'
+    @dave   = create :user, first_name:  'Dave'
+    @ed     = create :user, last_name:   'Dave'
+    @frank  = create :user, description: 'Dave'
+    @george = create :user, first_name:  'Dave',   last_name: 'Dave',     description: 'Dave'
 
-    @null     = Factory :user, :first_name => nil,      :last_name => nil,        :description => nil
+    @null   = create :user, first_name: nil,      last_name: nil,        description: nil
   end
 
-  it "should set the correct expected values for a _equals column method" do
-    User.first_name_equals('Abe').should == [@abe]
+  it 'Returns records which match the supplied term' do
+    expect(User.first_name_equals('Abe')).to eq [@abe]
   end
 
-  it "should set the correct expected values for a _equals column method with an Array as value" do
-    User.first_name_equals(['Abe', 'Bob']).should == [@abe, @bob]
+  it 'Returns records which match any of the supplied terms' do
+    expect(User.first_name_equals(['Abe', 'Bob'])).to eq [@abe, @bob]
   end
 
-  it "should set the correct expected values for a _equals column method with nil as value" do
-    User.first_name_equals(nil).should == [@ed, @frank, @null]
-  end
-
-  it "should set the correct expected values for a _matches column method" do
-    User.first_name_matches('ind').should == [@cindy]
-    User.first_name_matches('IND').should == [@cindy]
-  end
-
-  it "should set the correct expected values for a _starts_with column method" do
-    User.first_name_starts_with('Ab').should == [@abe]
-    User.first_name_starts_with('aB').should == [@abe]
-  end
-
-  it "should set the correct expected values for a _ends_with column method" do
-    User.first_name_ends_with('ob').should == [@bob]
-    User.first_name_ends_with('Ob').should == [@bob]
-  end
-
-  it "should set the correct expected values for a search_for method" do
-    User.search_for('Dave').should == [@dave, @ed, @frank, @george]
-    User.search_for('dave').should == [@dave, @ed, @frank, @george]
-  end
-
-  it "should set the correct expected values for a search_for method with :on option" do
-    User.search_for('Dave', :on => [:first_name, :description]).should == [@dave, @frank, @george]
-    User.search_for('dave', :on => [:first_name, :description]).should == [@dave, @frank, @george]
-  end
-
-  it "should set the correct expected values for a search_for method with an :require option" do
-    User.search_for('Dave', :require => :all).should == [@george]
-    User.search_for('dave', :require => :all).should == [@george]
-  end
-
-  it "should set the correct expected values for a search_for method on a class with no columns" do
-    Mammal.search_for('test').should == []
+  it 'Returns records which match the supplied term when the term is nil' do
+    expect(User.first_name_equals(nil)).to eq [@ed, @frank, @null]
   end
 
 end

data/spec/spec_helper.rb

@@ -1,27 +1,22 @@
 # Configure Rails Envinronment
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-require "rails/test_help"
-require "rspec/rails"
+require File.expand_path('../dummy/config/environment.rb',  __FILE__)
+require 'rails/test_help'
+require 'rspec/rails'
 
 ActionMailer::Base.delivery_method = :test
 ActionMailer::Base.perform_deliveries = true
-ActionMailer::Base.default_url_options[:host] = "test.com"
+ActionMailer::Base.default_url_options[:host] = 'test.com'
 
 Rails.backtrace_cleaner.remove_silencers!
 
-# Configure capybara for integration testing
-require "capybara/rails"
-Capybara.default_driver   = :rack_test
-Capybara.default_selector = :css
-
-# Run any available migration
-ActiveRecord::Migrator.migrate File.expand_path("../dummy/db/migrate/", __FILE__)
-
 # Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
+require 'factory_girl'
+require 'factories'
+
 RSpec.configure do |config|
   # Remove this line if you don't want RSpec's should and should_not
   # methods or matchers
@@ -29,10 +24,9 @@ RSpec.configure do |config|
   config.include RSpec::Matchers
 
   # == Mock Framework
-  config.mock_with :mocha
+  config.mock_framework = :mocha
 
   config.use_transactional_fixtures = true
-end
 
-require 'factory_girl'
-require 'factories'
+  config.include FactoryGirl::Syntax::Methods
+end