oxidized 0.28.0 → 0.29.0

data/lib/oxidized/model/netscaler.rb

@@ -14,12 +14,49 @@ class NetScaler < Oxidized::Model
     comment cfg
   end
 
+  cmd 'show partition' do |cfg|
+    comment cfg
+  end
+
   cmd :secret do |cfg|
     cfg.gsub! /\w+\s(-encrypted)/, '<secret hidden> \\1'
     cfg
   end
 
-  cmd 'show ns ns.conf'
+  # check for multiple partitions
+  cmd 'show partition' do |cfg|
+    @is_multiple_partition = cfg.include? 'Name:'
+  end
+
+  post do
+    if @is_multiple_partition
+      multiple_partition
+    else
+      single_partition
+    end
+  end
+
+  def single_partition
+    # Single partition mode
+    cmd 'show ns ns.conf' do |cfg|
+      cfg
+    end
+  end
+
+  def multiple_partition
+    # Multiple partition mode
+    cmd 'show partition' do |cfg|
+      allcfg = ""
+      partitions = [["default"]] + cfg.scan(/Name: (\S+)$/)
+      partitions.each do |part|
+        allcfg = allcfg + "\n\n####################### [ partition " + part.join(" ") + " ] #######################\n\n"
+        cmd "switch ns partition " + part.join(" ") + "; show ns ns.conf; switch ns partition default" do |cfgpartition|
+          allcfg += cfgpartition
+        end
+      end
+      allcfg
+    end
+  end
 
   cfg :ssh do
     pre_logout 'exit'

data/lib/oxidized/model/nodegrid.rb

@@ -0,0 +1,23 @@
+class Nodegrid < Oxidized::Model
+  # ZPE Nodegrid (Tested with Nodegrid Gate/Bold/NSR)
+  # https://www.zpesystems.com/products/
+
+  prompt(%r{(?<!@)\[(.*?\s/)\]#})
+  comment '# '
+
+  cmd 'show system/about/' do |cfg|
+    comment cfg # Show System, Model, Software Version
+  end
+
+  cmd 'show settings/license/' do |cfg|
+    comment cfg # Show License information
+  end
+
+  cmd 'export_settings settings/ --plain-password' do |cfg|
+    cfg # Print all system config including keys to be importable via import_settings function
+  end
+
+  cfg :ssh do
+    pre_logout 'exit'
+  end
+end

data/lib/oxidized/model/nxos.rb

@@ -10,15 +10,16 @@ class NXOS < Oxidized::Model
   cmd :secret do |cfg|
     cfg.gsub! /^(snmp-server community).*/, '\\1 <configuration removed>'
     cfg.gsub! /^(snmp-server user (\S+) (\S+) auth (\S+)) (\S+) (priv) (\S+)/, '\\1 <configuration removed> '
-    cfg.gsub! /^(username \S+ password \d) (\S+)/, '\\1 <secret hidden>'
+    cfg.gsub! /(password \d+) (\S+)/, '\\1 <secret hidden>'
     cfg.gsub! /^(radius-server key).*/, '\\1 <secret hidden>'
+    cfg.gsub! /^(tacacs-server host .+ key(?: \d+)?) \S+/, '\\1 <secret hidden>'
     cfg
   end
 
   cmd 'show version' do |cfg|
     cfg = filter cfg
     cfg = cfg.each_line.take_while { |line| not line.match(/uptime/i) }
-    comment cfg.join ""
+    comment cfg.join
   end
 
   cmd 'show inventory' do |cfg|

data/lib/oxidized/model/openbsd.rb

@@ -48,6 +48,15 @@ class Openbsd < Oxidized::Model
     cfg += add_comment('PASSWD FILE')
     cfg += cmd('cat /etc/passwd')
 
+    cfg += add_comment('BGPD FILE')
+    cfg += cmd('cat /etc/bgpd.conf')
+
+    cfg += add_comment('OSPFD FILE')
+    cfg += cmd('cat /etc/ospfd.conf')
+
+    cfg += add_comment('OSPF6D FILE')
+    cfg += cmd('cat /etc/ospf6d.conf')
+
     cfg += add_small_comment('END')
     cfg
   end

data/lib/oxidized/model/opengear.rb

@@ -11,7 +11,7 @@ class OpenGear < Oxidized::Model
 
   cmd('cat /etc/version') { |cfg| comment cfg }
 
-  cmd 'config -g config'
+  cmd('config -g config') { |cfg| cfg }
 
   cfg :ssh do
     exec true # don't run shell, run each command in exec channel

data/lib/oxidized/model/opnsense.rb

@@ -2,16 +2,24 @@ class OpnSense < Oxidized::Model
   # minimum required permissions: "System: Shell account access"
   # must enable SSH and password-based SSH access
 
-  cmd :all do |cfg|
-    cfg.cut_head
-  end
-
   cmd 'cat /conf/config.xml' do |cfg|
     cfg.gsub! /\s<revision>\s*<time>\d*<\/time>\s*.*\s*.*\s*<\/revision>/, ''
     cfg.gsub! /\s<last_rule_upd_time>\d*<\/last_rule_upd_time>/, ''
     cfg
   end
 
+  # The comment output has to be at the end since and XML file may not start
+  # with a comment.
+
+  # This gets the version using the opnsense-version command, or from the
+  # /usr/local/opnsense/version/opnsense file for earlier versions of OPNsense
+  # that lack the opnsense-version command. Newer versions of OPNsense no longer
+  # store the version information in this file, so both versions have to be
+  # supported here for now.
+  cmd 'opnsense-version 2>/dev/null || echo "OPNsense "`cat /usr/local/opnsense/version/opnsense`' do |version|
+    xmlcomment version
+  end
+
   cfg :ssh do
     exec true
     pre_logout 'exit'

data/lib/oxidized/model/panos_api.rb

@@ -0,0 +1,71 @@
+# PanOS API-based model for Oxidized
+#
+# The API-based model produced an XML configuration file that can actually be
+# restored as a configuration backup. Make sure to use the "http" input for
+# this module.
+
+begin
+  # Nokogiri is required because the PanOS API, as well as the
+  # configuration file format uses XML. It is required to parse API
+  # responses, as well as to pretty-print the configuration XML file
+  # when saving it.
+  require 'nokogiri'
+rescue LoadError
+  # Oxidized itself depends on mechanize, which in turn depends on
+  # nokogiri, so this should never happen.
+  raise Oxidized::OxidizedError, 'nokogiri not found: sudo gem install nokogiri'
+end
+
+class PanOS_API < Oxidized::Model # rubocop:disable Naming/ClassAndModuleCamelCase
+  # Callback function for getting the configuration file.
+  cfg_cb = lambda do
+    url_param = URI.encode_www_form(
+      user:     @node.auth[:username],
+      password: @node.auth[:password],
+      type:     'keygen'
+    )
+
+    kg_r = get_http "/api?#{url_param}"
+
+    # Parse the XML API response for the keygen request.
+    kg_x = Nokogiri::XML(kg_r)
+
+    # Check if keygen was successful. If not we'll throw an error.
+    status = kg_x.xpath('//response/@status').first
+    if status.to_s != 'success'
+      msg = kg_x.xpath('//response/result/msg').text
+      raise Oxidized::OxidizedError, "Could not generate PanOS API key: #{msg}"
+    end
+
+    # If we reach here, keygen was successful, so get the API key
+    # out of the keygen XML response.
+    apikey = kg_x.xpath('//response/result/key').text.to_s
+
+    # Now that we have the API key, we can request a configuration
+    # export.
+    url_param = URI.encode_www_form(
+      key:      apikey,
+      category: 'configuration',
+      type:     'export'
+    )
+
+    cfg = get_http "/api?#{url_param}"
+
+    # The configuration export is in XML format. Unfortunately,
+    # it's just one long line of XML that's not especially human
+    # readable or diffable.
+    #
+    # Thus, we will load the XML document and then emit it again
+    # with indentation set up, so that it's still a valid
+    # configuration, and also possible to read.
+    Nokogiri::XML(cfg).to_xml(indent: 2)
+  end
+
+  # Define the command based on the callback above.
+  cmd cfg_cb
+
+  cfg :http do
+    # Palo Alto's API always requires HTTPS as far as I know.
+    @secure = true
+  end
+end

data/lib/oxidized/model/pfsense.rb

@@ -1,23 +1,28 @@
 class PfSense < Oxidized::Model
   # use other use than 'admin' user, 'admin' user cannot get ssh/exec. See issue #535
 
-  cmd :all do |cfg|
-    cfg.cut_head
-  end
-
   cmd :secret do |cfg|
-    cfg.gsub! /(\s+<bcrypt-hash>)[^<]+(<\/bcrypt-hash>)/, '\\1<secret hidden>\\2'
-    cfg.gsub! /(\s+<password>)[^<]+(<\/password>)/, '\\1<secret hidden>\\2'
-    cfg.gsub! /(\s+<lighttpd_ls_password>)[^<]+(<\/lighttpd_ls_password>)/, '\\1<secret hidden>\\2'
+    cfg.gsub! /(\s+<bcrypt-hash>).+?(<\/bcrypt-hash>)/, '\\1[secret hidden]\\2'
+    cfg.gsub! /(\s+<password>).+?(<\/password>)/, '\\1[secret hidden]\\2'
+    cfg.gsub! /(\s+<lighttpd_ls_password>).+?(<\/lighttpd_ls_password>)/, '\\1[secret hidden]\\2'
     cfg
   end
 
   cmd 'cat /cf/conf/config.xml' do |cfg|
+    raise "<pfsense> missing in config file!" unless cfg.include? "<pfsense>"
+
     cfg.gsub! /\s<revision>\s*<time>\d*<\/time>\s*.*\s*.*\s*<\/revision>/, ''
     cfg.gsub! /\s<last_rule_upd_time>\d*<\/last_rule_upd_time>/, ''
     cfg
   end
 
+  # The comment output has to be at the end since and XML file may not start
+  # with a comment.
+
+  cmd 'cat /etc/version' do |version|
+    xmlcomment "PFsense #{version}"
+  end
+
   cfg :ssh do
     exec true
     pre_logout 'exit'

data/lib/oxidized/model/powerconnect.rb

@@ -19,9 +19,7 @@ class PowerConnect < Oxidized::Model
   end
 
   cmd 'show version' do |cfg|
-    if @stackable.nil?
-      @stackable = true if cfg =~ /(U|u)nit\s/
-    end
+    @stackable = true if @stackable.nil? && (cfg =~ /(U|u)nit\s/)
     cfg = cfg.split("\n").reject { |line| line[/Up\sTime/] }
     comment cfg.join("\n") + "\n"
   end

data/lib/oxidized/model/procurve.rb

@@ -1,9 +1,9 @@
 class Procurve < Oxidized::Model
   # previous command is repeated followed by "\eE", which sometimes ends up on last line
   # ssh switches prompt may start with \r, followed by the prompt itself, regex ([\w\s.-]+[#>] ), which ends the line
-  # telnet switchs may start with various vt100 control characters, regex (\e\[24;[0-9][hH]), follwed by the prompt, followed
+  # telnet switches may start with various vt100 control characters, regex (\e\[24;[0-9][hH]), followed by the prompt, followed
   # by at least 3 other vt100 characters
-  prompt /(^\r|\e\[24;[0-9][hH])?([\w\s.-]+[#>] )($|(\e\[24;[0-9][0-9]?[hH]){3})/
+  prompt /(^\r|\e\[24;[0-9][hH])?([\w\s.-]+(\((config|vlan-[0-9]{1,4}|y\/n)\)|\(o\)nce)?[#>:?\]] {1,2})($|(\e\[24;[0-9][0-9]?[hH]){3})/
 
   comment '! '
 

data/lib/oxidized/model/purityos.rb

@@ -4,9 +4,16 @@ class PurityOS < Oxidized::Model
   prompt /\w+@\S+(\s+\S+)*\s?>\s?$/
   comment '# '
 
-  cmd 'pureconfig list'
+  cmd 'pureconfig list' do |cfg|
+    cfg.gsub! /^purealert flag \d+$/, ''
+    cfg.gsub! /(.*VEEAM-StorageLUNSnap-[0-9a-f].*)/, ''
+    cfg.gsub! /(.*VEEAM-ExportLUNSnap-[0-9A-F].*)/, ''
+    # remove empty lines
+    cfg.each_line.reject { |line| line.match /^[\r\n\s\u0000#]+$/ }.join
+  end
 
   cfg :ssh do
+    pty_options(term: "dumb")
     pre_logout 'exit'
   end
 end

data/lib/oxidized/model/quantaos.rb

@@ -18,11 +18,7 @@ class QuantaOS < Oxidized::Model
   cfg :telnet, :ssh do
     post_login do
       send "enable\n"
-      if vars :enable
-        cmd vars(:enable)
-      else
-        cmd ""
-      end
+      cmd vars(:enable) || ""
     end
     post_login 'terminal length 0'
     pre_logout do

data/lib/oxidized/model/routeros.rb

@@ -13,11 +13,14 @@ class RouterOS < Oxidized::Model
   end
 
   cmd '/system routerboard print without-paging' do |cfg|
+    cfg = cfg.each_line.grep(/(model|firmware-type|current-firmware|serial-number):/).join
     comment cfg
   end
 
   cmd '/system package update print without-paging' do |cfg|
-    comment cfg
+    version_line = cfg.each_line.grep(/installed-version: /)[0]
+    @ros_version = /: ([0-9])/.match(version_line)[1].to_i
+    comment version_line
   end
 
   cmd '/system history print without-paging' do |cfg|
@@ -25,11 +28,21 @@ class RouterOS < Oxidized::Model
   end
 
   post do
-    run_cmd = vars(:remove_secret) ? '/export hide-sensitive' : '/export'
+    Oxidized.logger.debug "lib/oxidized/model/routeros.rb: running /export for routeros version #{@ros_version}"
+    run_cmd = if vars(:remove_secret)
+                '/export hide-sensitive'
+              elsif (not @ros_version.nil?) && (@ros_version >= 7)
+                '/export show-sensitive'
+              else
+                '/export'
+              end
     cmd run_cmd do |cfg|
       cfg.gsub! /\\\r?\n\s+/, '' # strip new line
       cfg.gsub! /# inactive time\r\n/, '' # Remove time based system comment
       cfg.gsub! /# received packet from \S+ bad format\r\n/, '' # Remove intermittent VRRP/CARP collision comment
+      cfg.gsub! /# poe-out status: short_circuit\r\n/, '' # Remove intermittent POE short_circuit comment
+      cfg.gsub! /# Firmware upgraded successfully, please reboot for changes to take effect!\r\n/, '' # Remove transient firmware upgrade comment
+      cfg.gsub! /# \S+ not ready\r\n/, '' # Remove intermittent $interface not ready comment
       cfg = cfg.split("\n").reject { |line| line[/^#\s\w{3}\/\d{2}\/\d{4}.*$/] }
       cfg.join("\n") + "\n"
     end

data/lib/oxidized/model/slxos.rb

@@ -12,6 +12,7 @@ class SLXOS < Oxidized::Model
   cmd 'show chassis' do |cfg|
     cfg.encode!("UTF-8", invalid: :replace, undef: :replace) # sometimes ironware returns broken encoding
     cfg.gsub! /.*Power Usage.*/, '' # remove unwanted lines power usage
+    cfg.gsub! /^Update\:.*$/, '' # remove unwanted current date
     cfg.gsub! /Time A(live|wake).*/, '' # remove unwanted lines time alive/awake
     cfg.gsub! /([\[]*)1([\]]*)<->([\[]*)2([\]]*)(<->([\[]*)3([\]]*))*/, ''
 

data/lib/oxidized/model/smartcs.rb

@@ -0,0 +1,40 @@
+class SmartCS < Oxidized::Model
+  prompt /^\r?([\w.@() -]+[#>]\s?)$/
+  comment '# '
+
+  expect /-more <Press SPACE for another page, 'q' to quit>-/ do |data, re|
+    send ' '
+    data.sub re, ''
+  end
+
+  cmd :all do |cfg|
+    cfg
+  end
+
+  cmd 'show version' do |cfg|
+    comment cfg.insert(0, "--------------------------------------------------------------------------------! \n")
+    # Unhash below to write a comment in the config file.
+    cfg.insert(0, "Starting: show version cmd \n")
+    cfg << "\n \nEnding: show version cmd"
+    comment cfg << "\n--------------------------------------------------------------------------------! \n \n"
+    comment cfg
+  end
+
+  cmd 'show config' do |cfg|
+    # remove "Press SPACE for another page" add SPACE(\s)
+    cfg.gsub! /\s{5,}/, ""
+  end
+
+  cfg :telnet, :ssh do
+    # preferred way to handle additional passwords
+    post_login do
+      pw = vars(:enable)
+      pw ||= ""
+      send "su\r"
+      expect /[pP]assword:\s?$/
+      cmd pw
+    end
+    pre_logout 'exit'
+    pre_logout 'exit'
+  end
+end

data/lib/oxidized/model/sonicos.rb

@@ -17,6 +17,12 @@ class SonicOS < Oxidized::Model
     cfg.gsub! /bind-password \d\,(\S+)/, 'bind-password <secret hidden> \2'
     cfg.gsub! /authentication sha1 \d\,(\S+)/, 'authentication sha1 <secret hidden> \2'
     cfg.gsub! /encryption aes \d\,(\S+)/, 'encryption aes <secret hidden> \2'
+    cfg.gsub! /smtp-pass \d\,(\S+)/, 'smtp-pass <secret hidden> \2'
+    cfg.gsub! /pop-pass \d\,(\S+)/, 'pop-pass <secret hidden> \2'
+    cfg.gsub! /sslvpn password \d\,(\S+)/, 'sslvpn password <secret hidden> \2'
+    cfg.gsub! /administrator password \d\,(\S+)/, 'administrator password <secret hidden> \2'
+    cfg.gsub! /ftp password \d\,(\S+)/, 'ftp password <secret hidden> \2'
+    cfg.gsub! /shared-key \d\,(\S+)/, 'shared-key <secret hidden> \2'
     cfg
   end
 
@@ -38,8 +44,10 @@ class SonicOS < Oxidized::Model
   def clean(cfg)
     out = []
     cfg.each_line do |line|
+      next if line =~ /date \d{4}\:\d{2}\:\d{2}/
+      next if line =~ /time \d{2}\:\d{2}:\d{2}/
       next if line =~ /system-time \"\d{2}\/\d{2}\/\d{4} \d{2}\:\d{2}:\d{2}.\d+\"/
-      next if line =~ /system-uptime "(\s+up\s+\d+\s+)|(.*Days.*)"/
+      next if line =~ /system-uptime "((\s+up\s+\d+\s+)|(\d+\s\w+(,\s)?)*)"/
       next if line =~ /checksum \d+/
 
       line = line[1..-1] if line[0] == "\r"

data/lib/oxidized/model/srosmd.rb

@@ -0,0 +1,97 @@
+class SROSMD < Oxidized::Model
+  #
+  # Nokia SR OS (TiMOS) (formerly TiMetra, Alcatel, Alcatel-Lucent)
+  # Working in Model-Driven CLI mode.
+  # Used in 7705 SAR, 7210 SAS, 7450 ESS, 7750 SR, 7950 XRS, and NSP.
+  #
+
+  comment '# '
+
+  prompt /^([-\w.@:>*]+\s?[#>]\s?)$/
+
+  cmd :all do |cfg, cmdstring|
+    new_cfg = comment "COMMAND: #{cmdstring}\n"
+    cfg.gsub! /# Finished .*/, ''
+    cfg.gsub! /# Generated .*/, ''
+    cfg.delete! "\r"
+    new_cfg << cfg.cut_both
+  end
+
+  #
+  # Show the system information.
+  #
+  cmd 'show system information' do |cfg|
+    #
+    # Strip uptime.
+    #
+    cfg.sub! /^System Up Time.*\n/, ''
+    comment cfg
+  end
+
+  #
+  # Show the card state.
+  #
+  cmd 'show card state' do |cfg|
+    comment cfg
+  end
+
+  #
+  # Show the chassis information.
+  #
+  cmd 'show chassis' do |cfg|
+    comment cfg.lines.to_a[0..25].reject { |line| line.match /state|Time|Temperature|Status/ }.join
+  end
+
+  #
+  # Show the boot log.
+  #
+  cmd 'file show bootlog.txt' do |cfg|
+    cfg.gsub! /[\b][\b][\b]/, "\n"
+    comment cfg
+  end
+
+  #
+  # Show the running debug configuration.
+  #
+  cmd 'admin show configuration debug full-context' do |cfg|
+    comment cfg
+  end
+
+  #
+  # Show the saved debug configuration (admin debug-save).
+  #
+  cmd 'file show config.dbg' do |cfg|
+    comment cfg
+  end
+
+  #
+  # Show the running persistent indices.
+  #
+  cmd 'admin show configuration configure | match persistent-indices post-lines 10000' do |cfg|
+    comment cfg
+  end
+
+  #
+  # Show the boot options file.
+  #
+  cmd 'admin show configuration bof full-context' do |cfg|
+    cfg
+  end
+
+  #
+  # Show the running configuration.
+  #
+  cmd 'admin show configuration configure full-context' do |cfg|
+    cfg
+  end
+
+  cfg :telnet do
+    username /^Login: /
+    password /^Password: /
+  end
+
+  cfg :telnet, :ssh do
+    post_login 'environment more false'
+    pre_logout 'logout'
+  end
+end

data/lib/oxidized/model/stoneos.rb

@@ -1,7 +1,7 @@
 class StoneOS < Oxidized::Model
   # Hillstone Networks StoneOS software
 
-  prompt /^\r?[\w.()-]+[#>](\s)?$/
+  prompt /^\r?[\w.()-]+~?[#>](\s)?$/
   comment '# '
 
   expect /^\s.*--More--.*$/ do |data, re|
@@ -10,12 +10,16 @@ class StoneOS < Oxidized::Model
   end
 
   cmd :all do |cfg|
+    cfg.gsub! /+.*+/, '' # Linebreak handling
     cfg.cut_both
   end
 
-  cmd 'show configuration running'
+  cmd 'show configuration running' do |cfg|
+    cfg.gsub! /^Building configuration.*$/, ''
+  end
 
   cmd 'show version' do |cfg|
+    cfg.gsub! /^Uptime is .*$/, ''
     comment cfg
   end
 

data/lib/oxidized/model/supermicro.rb

@@ -1,7 +1,7 @@
 # Backward compatibility shim for deprecated model `supermicro`.
 # Migrate your source from `supermicro` to `edgecos`.
 
-require_relative 'edgecos.rb'
+require_relative 'edgecos'
 
 Supermicro = EdgeCOS
 

data/lib/oxidized/model/swos.rb

@@ -0,0 +1,9 @@
+# Mikrotik SwOS (Lite)
+class SwOS < Oxidized::Model
+  cmd '/backup.swb'
+  cfg :http do
+    @username = @node.auth[:username]
+    @password = @node.auth[:password]
+    @secure = false
+  end
+end

data/lib/oxidized/model/timos.rb

@@ -1,7 +1,7 @@
 # Backward compatibility shim for deprecated model `timos`.
 # Migrate your source from `timos` to `sros`.
 
-require_relative 'sros.rb'
+require_relative 'sros'
 
 TiMOS = SROS
 

data/lib/oxidized/model/tmos.rb

@@ -18,6 +18,7 @@ class TMOS < Oxidized::Model
   cmd 'tmsh -q show sys hardware field-fmt' do |cfg|
     cfg.gsub!(/fan-speed (\S+)/, '')
     cfg.gsub!(/temperature (\S+)/, '')
+    cfg.gsub!(/humidity (\S+)/, '')
     comment cfg
   end
 
@@ -47,7 +48,7 @@ class TMOS < Oxidized::Model
 
   cmd('[ -d "/config/zebos" ] && cat /config/zebos/*/ZebOS.conf') { |cfg| comment cfg }
 
-  cmd('cat /config/partitions/*/bigip.conf') { |cfg| comment cfg }
+  cmd('cat /config/partitions/*/bigip*.conf') { |cfg| comment cfg }
 
   cfg :ssh do
     exec true # don't run shell, run each command in exec channel

data/lib/oxidized/model/tplink.rb

@@ -35,6 +35,8 @@ class TPLink < Oxidized::Model
   end
 
   cmd 'show system-info' do |cfg|
+    cfg.gsub! /(System Time\s+-).*/, '\\1 <stripped>'
+    cfg.gsub! /(Running Time\s+-).*/, '\\1 <stripped>'
     comment cfg.each_line.to_a[3..-3].join
   end
 

data/lib/oxidized/model/trango.rb

@@ -9,16 +9,16 @@ class Trango < Oxidized::Model
     comments = []
     cfg.each_line do |line|
       if line =~ /\[Opmode\] (off|on) \[Default Opmode\] (off|on)/
-        out << "opmode " + Regexp.last_match[1]
-        out << "defaultopmode " + Regexp.last_match[2]
+        out << ("opmode " + Regexp.last_match[1])
+        out << ("defaultopmode " + Regexp.last_match[2])
       end
-      out << "power " + Regexp.last_match[1] if line =~ /\[Tx Power\] ([\-\d]+) dBm/
-      out << "freq " + Regexp.last_match[1] + ' ' + Regexp.last_match[2] if line =~ /\[Active Channel\] (\d+) (v|h)/
-      out << "peerid " + Regexp.last_match[1] if line =~ /\[Peer ID\] ([A-F0-9]+)/
-      out << "utype " + Regexp.last_match[1] if line =~ /\[Unit Type\] (\S+)/
-      comments << '# ' + Regexp.last_match[1] + ': ' + Regexp.last_match[2] if line =~ /\[(Hardware Version|Firmware Version|Model|S\/N)\] (\S+)/
-      out << "remarks " + Regexp.last_match[1] if line =~ /\[Remarks\] (\S+)/
-      out << "rssiled " + Regexp.last_match[1] if line =~ /\[RSSI LED\] (on|off)/
+      out << ("power " + Regexp.last_match[1]) if line =~ /\[Tx Power\] ([\-\d]+) dBm/
+      out << ("freq " + Regexp.last_match[1] + ' ' + Regexp.last_match[2]) if line =~ /\[Active Channel\] (\d+) (v|h)/
+      out << ("peerid " + Regexp.last_match[1]) if line =~ /\[Peer ID\] ([A-F0-9]+)/
+      out << ("utype " + Regexp.last_match[1]) if line =~ /\[Unit Type\] (\S+)/
+      comments << ('# ' + Regexp.last_match[1] + ': ' + Regexp.last_match[2]) if line =~ /\[(Hardware Version|Firmware Version|Model|S\/N)\] (\S+)/
+      out << ("remarks " + Regexp.last_match[1]) if line =~ /\[Remarks\] (\S+)/
+      out << ("rssiled " + Regexp.last_match[1]) if line =~ /\[RSSI LED\] (on|off)/
       speed = Regexp.last_match[1] if line =~ /\[Speed\] (\d+) Mbps/
       out << "mir ".concat(Regexp.last_match[1]) if line =~ /\[Tx MIR\] (\d+) Kbps/
       if line =~ /\[Auto Rate Shift\] (on|off)/
@@ -27,9 +27,9 @@ class Trango < Oxidized::Model
       end
       next unless line =~ /\[IP\] (\S+) \[Subnet Mask\] (\S+) \[Gateway\] (\S+)/
 
-      out << "ipconfig " + Regexp.last_match[1] + ' ' +
+      out << ("ipconfig " + Regexp.last_match[1] + ' ' +
              Regexp.last_match[2] + ' ' +
-             Regexp.last_match[3]
+             Regexp.last_match[3])
     end
     comments.push(*out).join "\n"
   end