oxidized-web 0.13.1 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a0d392d1d8dc6166e75fd562f853c8119ceb9b2fb370a754d0b60acacc0de20
-  data.tar.gz: 7f6a971a151cb06ce0044647b5cb101b95f3563e93539ff9d63a5bee2d73552f
+  metadata.gz: a515263e99de223e65d1e1e0a9d4e0602fa005fbc9d1b30b99ad83e1f8ab6a26
+  data.tar.gz: c4a0eec1d16723e088fffe26dbb781ee18a6b3e6a70b48cd1ff1bfcd9c135fda
 SHA512:
-  metadata.gz: e0e38327ab5c7e92e071d0baad334ea5b0dd8f0cff995dd11c8d7ba3133f5091b931c3df9a64b7970613792c2f65387a498318cf81fa11a83cefb4237b57193a
-  data.tar.gz: 150d902906c3f603eb0dbeeb6e42833c9287f6a6334e651042350cf95cb75c13ecd8aec3d436d80b1775b214072092401ebd5443ea6d945c28a760ed99f22f5d
+  metadata.gz: ad7b334289a032e4c83c80e0f5d1b8de8db8ad4e00b4e9ac5c6a60b8ea4c1f1d16851b6219cd7713512704e6f3c47359ecd0331a9dea9c0fd32916a8a9c58438
+  data.tar.gz: 33c2f33ef670646da9bd87d50efe1b0d3aabcb07c101d929c874d750431eac4f5c00aa24e80741fcf3207a4e6e0f2430f30dae780f839532e16f99be8da47fc8

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,12 @@
+## Pre-Request Checklist
+<!-- Not all items apply to each PR, but a great PR addresses all applicable items. -->
+
+- [ ] Passes rubocop code analysis (try `rubocop --auto-correct`)
+- [ ] Tests added or adapted (try `rake test`)
+- [ ] Changes are reflected in the documentation
+- [ ] User-visible changes appended to [CHANGELOG.md](/CHANGELOG.md)
+
+## Description
+<!-- Describe your changes here. -->
+
+<!-- Add a text similar to "Closes issue #" if this PR relates to an existing issue. -->

data/.github/dependabot.yml

@@ -0,0 +1,25 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    target-branch: "master"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    open-pull-requests-limit: 10
+  - package-ecosystem: "bundler"
+    target-branch: "master"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    open-pull-requests-limit: 10
+  - package-ecosystem: "npm"
+    target-branch: "master"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    open-pull-requests-limit: 10

data/.github/workflows/codeql.yml

@@ -0,0 +1,76 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "master" ]
+  schedule:
+    - cron: '44 21 * * 0'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'ruby' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Use only 'java' to analyze code written in Java, Kotlin or both
+        # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v3
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+
+        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        # queries: security-extended,security-and-quality
+
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v3
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+    #   If the Autobuild fails above, remove it and uncomment the following three lines.
+    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+    # - run: |
+    #     echo "Run, Build Application using script"
+    #     ./location_of_script_within_repo/buildscript.sh
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v3
+      with:
+        category: "/language:${{matrix.language}}"

data/.github/workflows/ruby.yml

@@ -0,0 +1,41 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: CI
+
+on: [ push, pull_request ]
+#  push:
+#    branches: [ master ]
+#  pull_request:
+#    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['3.1', '3.2', '3.3', '3.4', 'ruby-head']
+    continue-on-error: ${{ matrix.ruby-version == 'ruby-head' }}
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: rubocop
+      uses: reviewdog/action-rubocop@v2
+      with:
+        rubocop_version: gemfile
+        rubocop_extensions: rubocop-minitest:gemfile rubocop-rake:gemfile rubocop-rails:gemfile
+        reporter: github-pr-review
+    - name: Run tests
+      run: bundle exec rake

data/.github/workflows/stale.yml

@@ -0,0 +1,20 @@
+name: "Stale Issue/PR cleanup"
+on:
+  schedule:
+    - cron: "30 1 * * *"
+
+permissions:
+  issues: write
+  pull-requests: write
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v9
+        with:
+          stale-issue-message: 'This issue is stale because it has been open 90 days with no activity.'
+          stale-pr-message: 'This PR is stale because it has been open 90 days with no activity.'
+          operations-per-run: 500
+          days-before-stale: 90
+          days-before-close: -1

data/.gitignore

@@ -49,3 +49,6 @@ Gemfile.lock
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc
+
+# npm files
+/node_modules/

data/.rubocop.yml

@@ -1,20 +1,43 @@
 inherit_from: .rubocop_todo.yml
+plugins:
+  - rubocop-rails
+  - rubocop-rake
+  - rubocop-minitest
 
 # Do not attempt to police vendored code, and exclude special cases
 AllCops:
-  TargetRubyVersion: 2.3
+  NewCops: enable
+  TargetRubyVersion: 3.1
   Exclude:
     - 'vendor/**/*'
 
-StringLiterals:
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec
+
+Metrics/ClassLength:
+  Max: 300
+
+Metrics/BlockLength:
+  Max: 150
+
+Style/Documentation:
+  Enabled: false
+
+Style/StringLiterals:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-LineLength:
+Layout/LineLength:
   Enabled: false
 
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
 # Stick to verbose until https://bugs.ruby-lang.org/issues/10177 is closed.
 Style/PreferredHashMethods:
   EnforcedStyle: verbose
@@ -32,6 +55,18 @@ Style/FormatString:
 Style/FormatStringToken:
   EnforcedStyle: unannotated
 
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/HashSyntax:
+  EnforcedShorthandSyntax: either
+
 Style/RescueModifier:
   Enabled: false
 

data/.rubocop_todo.yml

@@ -1,248 +1,64 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-03-03 09:40:37 +0100 using RuboCop version 0.65.0.
+# on 2025-02-17 07:41:09 UTC using RuboCop version 1.72.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
-# Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'oxidized-web.gemspec'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-
-# Offense count: 1
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-
-# Offense count: 1
-Lint/HandleExceptions:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 7
+# Offense count: 5
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 47
-
-# Offense count: 2
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
-Metrics/BlockLength:
-  Max: 33
-
-# Offense count: 1
-# Configuration parameters: CountBlocks.
-Metrics/BlockNesting:
-  Max: 5
-
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 272
+  Max: 52
 
 # Offense count: 2
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 9
 
 # Offense count: 9
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 36
+  Max: 33
 
-# Offense count: 3
+# Offense count: 2
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 11
 
-# Offense count: 5
-# Cop supports --auto-correct.
-Performance/RedundantMatch:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Performance/StringReplacement:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-
 # Offense count: 1
-Security/Eval:
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
+Rails/Exit:
   Exclude:
-    - 'Rakefile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Security/JSONLoad:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 3
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
     - 'lib/oxidized/web.rb'
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLiteral:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: each, for
-Style/For:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 9
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
-Style/MethodDefParentheses:
-  Exclude:
-    - 'lib/oxidized/web.rb'
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: both, prefix, postfix
-Style/NegatedIf:
-  Exclude:
-    - 'lib/oxidized/web.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, MinBodyLength.
-# SupportedStyles: skip_modifier_ifs, always
-Style/Next:
-  Exclude:
-    - 'lib/oxidized/web/mig.rb'
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IncludeSemanticChanges.
-Style/NonNilCheck:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
 # Offense count: 1
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
+# This cop supports safe autocorrection (--autocorrect).
+Rake/Desc:
   Exclude:
-    - 'lib/oxidized/web.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/Proc:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/RedundantParentheses:
-  Exclude:
-    - 'lib/oxidized/web/webapp.rb'
+    - 'Rakefile'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/SelfAssignment:
+# Offense count: 2
+Rake/DuplicateTask:
   Exclude:
-    - 'lib/oxidized/web/webapp.rb'
+    - 'Rakefile'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInHashLiteral:
+Security/Eval:
   Exclude:
-    - 'lib/oxidized/web.rb'
+    - 'Rakefile'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Style/WhileUntilDo:
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Security/JSONLoad:
   Exclude:
     - 'lib/oxidized/web/webapp.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 3

data/CHANGELOG.md

@@ -0,0 +1,46 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
+
+## [0.15.0 – 2025-02-17]
+This release fixes a security issue on the RANCID migration page.
+A non-authenticated user could gain control over the Linux user running
+oxidized-web. The RANCID migration page was already deprecated in version
+0.14.0, so it has been completely removed in this new version.
+Thank you to Jon O'Reilly and Jamie Riden from NetSPI for discovering and
+reporting this security issue!
+
+### Changed
+- Update datatables.net to 2.2.2 and datatables.net-buttons to 3.2.2 (@robertcheramy)
+- remove the RANCID migration page (@robertchreamy)
+- dependency on oxidized 0.31  (@robertchreamy)
+- Update datatables.net to 2.2.1 and datatables.net-buttons to 3.2.1 (@robertcheramy)
+
+### Fixed
+- #302: group name containing a '/' produced a Sinatra error (@robertcheramy)
+
+
+## [0.14.0 - 2024-06-28]
+
+### Added
+- CHANGELOG.md created (@robertchreamy)
+- First minitest: get / (@robertchreamy)
+- docs/development.md created (@robertchreamy)
+- weblibs are maintained with npm (@robertchreamy)
+- display Oxidized-web version in the footer (@robertcheramy)
+
+### Changed
+- gem dependencies updated (@robertchreamy)
+- support for ruby 3.0 dropped (@robertchreamy)
+- #215: weblibs (jQuery, bootstrap, datatables.net) updated (@robertchreamy)
+- the web design follows where possible bootstrap without specific css (@robertchreamy)
+- deprecating the RANCID migration page (@robertchreamy)
+
+### Fixed
+- #232: escape_once not supported in haml 6.0 (@robertchreamy)
+- #253: deprecated sass dependency dropped (@robertchreamy)
+- rubocop warnings fixed (@robertchreamy)
+- #234: removed link to not working live demo (@robertchreamy)
+- group name containing a '/' producing a Sinatra error (@robertcheramy)

data/README.md

@@ -1,17 +1,20 @@
-# Oxidized Web [![Build Status](https://travis-ci.com/ytti/oxidized-web.svg)](https://travis-ci.com/ytti/oxidized-web) [![Gem Version](https://badge.fury.io/rb/oxidized-web.svg)](http://badge.fury.io/rb/oxidized-web)
+# Oxidized Web
+
+[![Build Status](https://github.com/ytti/oxidized-web/actions/workflows/ruby.yml/badge.svg)](https://github.com/ytti/oxidized-web/actions/workflows/ruby.yml)
+[![Gem Version](https://badge.fury.io/rb/oxidized-web.svg)](http://badge.fury.io/rb/oxidized-web)
 
 Web userinterface and RESTful API for Oxidized.
 
-This is not useful independently, see https://github.com/ytti/oxidized for install instructions
+This is not useful independently, see https://github.com/ytti/oxidized for install instructions.
 
-Live demo: http://oxidized.arahant.net
+If you wonder how to run oxidized-web from git for development, have a look at
+[docs/development.md](docs/development.md).
 
-# License and Copyright
+## License and Copyright
 
 Copyright 2013-2015 Saku Ytti <saku@ytti.fi>
           2013-2015 Samer Abdel-Hafez <sam@arahant.net>
 
-
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at