ox 2.14.8 → 2.14.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 141360789b82c7bdc927d64818b673c91f2c0ca585c9d00eab8f81324c5b56e2
-  data.tar.gz: 0b19c86cce35dcc00c4da5b526722580eedcb7dd5edce9eb96ccd99407f4ca84
+  metadata.gz: a654851f11a761fdb77beb9cb4ec9ae07b4697cec9a4c5578a973a344779ca97
+  data.tar.gz: b4b004cc4fd90e3c52e142bd4007c471515a520d52a42ca2d81f332c11e6b2ba
 SHA512:
-  metadata.gz: cbfe081ac34c6fbea4719156f0666d9554d2c25b23e52546c95cc5fbae89105dfe1aef0c6b5ad659bea540bbcf6bd87b4ea661d9e82fdd3798db6f41eecb3bcd
-  data.tar.gz: a7946c2929b553b5c019dc5ee43a07fb289aa7e5f93ae3ad890862f018310efb5fa172822944a2be5178f88884d6404daa0d7bdc9dd8b733e1a8a55547909ca8
+  metadata.gz: 6b0595691afa3021e1abada2fd0fc4fb21992a10155f744846b01eb40bd74e33bf52041db37ec502b3f916295b64bde60816c20d99ed9954633342d035225d8a
+  data.tar.gz: e38010c8dcf091b983d17774464bd727a0f33538548d6b5d1820c6d043ba602d83552837a4ce4dd963c554ec19657475c21add9246323e5d5a9fbd7773c20e55

data/CHANGELOG.md

@@ -2,6 +2,24 @@
 
 All changes to the Ox gem are documented here. Releases follow semantic versioning.
 
+## [2.14.11] - 2022-03-31
+
+### Fixed
+
+- Missing attribute value no longer crashes with the SAX parser.
+
+## [2.14.10] - 2022-03-10
+
+### Fixed
+
+- Writing strings over 16K to a file with builder no longer causes a crash.
+
+## [2.14.9] - 2022-02-11
+
+### Fixed
+
+- Fixed the `\r` replacement with `\n` with the SAX parser according to https://www.w3.org/TR/2008/REC-xml-20081126/#sec-line-ends.
+
 ## [2.14.8] - 2022-02-09
 
 ### Fixed

data/ext/ox/buf.h

@@ -86,8 +86,16 @@ buf_append_string(Buf buf, const char *s, size_t slen) {
 
 	    if (len != (size_t)write(buf->fd, buf->head, len)) {
 		buf->err = true;
+		return;
 	    }
 	    buf->tail = buf->head;
+	    if (sizeof(buf->base) <= slen) {
+		if (slen != (size_t)write(buf->fd, s, slen)) {
+		    buf->err = true;
+		    return;
+		}
+		return;
+	    }
 	} else {
 	    size_t	len = buf->end - buf->head;
 	    size_t	toff = buf->tail - buf->head;

data/ext/ox/parse.c

@@ -108,7 +108,7 @@ static void fix_newlines(char *buf) {
 		if ('\n' == *(s + 1)) {
 		    continue;
 		}
-		*s = '\n';
+		*d = '\n';
 	    } else if (d < s) {
 		*d = *s;
 	    }

data/ext/ox/sax.c

@@ -117,7 +117,7 @@ static void attr_text(SaxDrive dr, VALUE name, char *value, long pos, long line,
     VALUE args[2];
 
     args[0] = name;
-    if (dr->options.convert_special) {
+    if (dr->options.convert_special && '\0' != value[0]) {
         ox_sax_collapse_special(dr, value, pos, line, col);
     }
     args[1] = rb_str_new2(value);
@@ -307,8 +307,8 @@ static void sax_drive_init(SaxDrive dr, VALUE handler, VALUE io, SaxOptions opti
         dr->encoding = rb_enc_find(ox_default_options.encoding);
     }
     dr->utf8 = (NULL == dr->encoding || rb_utf8_encoding() == dr->encoding);
-    if (NULL == dr->encoding || rb_utf8_encoding() == dr->encoding) {  // UTF-8
-        dr->get_name = dr->options.symbolize ? ox_utf8_sym : ox_utf8_name; // TBD UTF8 sym?
+    if (NULL == dr->encoding || rb_utf8_encoding() == dr->encoding) {       // UTF-8
+        dr->get_name = dr->options.symbolize ? ox_utf8_sym : ox_utf8_name;  // TBD UTF8 sym?
     } else {
         dr->get_name = dr->options.symbolize ? ox_enc_sym : ox_enc_name;
     }
@@ -334,7 +334,7 @@ static char skipBOM(SaxDrive dr) {
     if (0xEF == (uint8_t)c) { /* only UTF8 is supported */
         if (0xBB == (uint8_t)buf_get(&dr->buf) && 0xBF == (uint8_t)buf_get(&dr->buf)) {
             dr->encoding = ox_utf8_encoding;
-            c = buf_get(&dr->buf);
+            c            = buf_get(&dr->buf);
         } else {
             ox_sax_drive_error(dr, BAD_BOM "invalid BOM or a binary file.");
             c = '\0';
@@ -1215,9 +1215,10 @@ static char read_attrs(SaxDrive dr, char c, char termc, char term2, int is_xml,
             col        = dr->buf.col + 1;
             c          = read_quoted_value(dr);
             attr_value = dr->buf.str;
+
             if (is_encoding) {
                 dr->encoding = rb_enc_find(dr->buf.str);
-                is_encoding = 0;
+                is_encoding  = 0;
             }
         }
         if (0 >= dr->blocked && (NULL == h || ActiveOverlay == h->overlay || NestOverlay == h->overlay)) {
@@ -1368,7 +1369,8 @@ int ox_sax_collapse_special(SaxDrive dr, char *str, long pos, long line, long co
     char *b = str;
 
     while ('\0' != *s) {
-        if ('&' == *s) {
+        switch (*s) {
+        case '&': {
             int   c = 0;
             char *end;
 
@@ -1458,13 +1460,25 @@ int ox_sax_collapse_special(SaxDrive dr, char *str, long pos, long line, long co
             }
             *b++ = (char)c;
             col++;
-        } else {
+            break;
+        }
+        case '\r':
+	    s++;
             if ('\n' == *s) {
-                line++;
-                col = 0;
-            }
+		continue;
+	    }
+	    line++;
+	    col = 1;
+            *b++ = '\n';
+	    break;
+	case '\n':
+	    line++;
+	    col = 0;
+	    // fall through
+        default:
             col++;
             *b++ = *s++;
+            break;
         }
     }
     *b = '\0';

data/lib/ox/version.rb

@@ -1,5 +1,5 @@
 
 module Ox
   # Current version of the module.
-  VERSION = '2.14.8'
+  VERSION = '2.14.11'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ox
 version: !ruby/object:Gem::Version
-  version: 2.14.8
+  version: 2.14.11
 platform: ruby
 authors:
 - Peter Ohler
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-09 00:00:00.000000000 Z
+date: 2022-03-31 00:00:00.000000000 Z
 dependencies: []
 description: "A fast XML parser and object serializer that uses only standard C lib.\n\nOptimized
   XML (Ox), as the name implies was written to provide speed optimized\nXML handling.