owmo 2.1.2 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edf9511c6a44ae70b3f4823aef686e12f5b7f13e530526364a1f6dc9c476b96b
-  data.tar.gz: 0f10c539d774fc03f682d1c2977c12518f9e028288d9a7584d220e76dd2e55fe
+  metadata.gz: 7206b29a014088dd08403d1199d6b410a4d2d2e7dd1087290058d542add26f79
+  data.tar.gz: 0115ffba7abd0eca441f6117c2cb20561a09c2556b606af56c1cde829372fe7c
 SHA512:
-  metadata.gz: 37250290ebe64c1bee4757b68dcfb79058765ab0c25776e8d556730899098a454ea8afa23fc6f7f5ec06a658789024d5460e8259e5117ba318e727e36838f415
-  data.tar.gz: 29d07afd68aecc136cbc7a6e4b60c302bd005fb0bd762721edc183c1a7ea40b4df0170c0b9d6c7f40a0228ed102b03e02ee6bfe020cc8ae8ac60318bbfeeb80d
+  metadata.gz: 48059ce954439c46e4c19edc050c9b0d8193caf6b9e464726b255f88aa42b5591dc69b6bbd17c227728bf89a16e4c8adfe744ad0891d1f9bd448c6250ceadc01
+  data.tar.gz: 73af163549823603d7222ed682367c91baa4dab7276bd2bcd318ede49e435b03c4480abb318e3425cec3a5ace4dd8f5c393a5591622c519a8cc75c8e86a9c5e6

data/.github/workflows/{ruby-publish-gem.yml → rake-release.yml}

@@ -1,4 +1,4 @@
-name: Publish Gem
+name: Publish to Rubygems
 
 on:
   push:
@@ -13,9 +13,9 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
-      - name: Release Gem
+      - name: Publish to Rubygems
         if: contains(github.ref, 'refs/tags/v')
-        uses: cadwallion/publish-rubygems-action@master
+        uses: cadwallion/publish-rubygems-action@v1.0.0
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
           RUBYGEMS_API_KEY: ${{secrets.RUBYGEMS_API_KEY}}

data/.github/workflows/rake.yml

@@ -0,0 +1,23 @@
+name: Ruby CI
+
+on: [push]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version: ['3.1', '3.0', '2.7']
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -13,6 +13,5 @@
 
 
 *.gem
-test.rb
-scratch.rb
 api_key.txt
+coverage

data/.rubocop.yml

@@ -0,0 +1,7 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+

data/Gemfile

@@ -4,5 +4,12 @@ source 'https://rubygems.org'
 
 gemspec
 
+gem 'rake_tasks', '>= 5.x'
+
 gem 'rspec'
+
+gem 'rubocop', require: false
+gem 'rubocop-rake', require: false
+gem 'rubocop-rspec', require: false
+
 gem 'simplecov', require: false, group: :test

data/Rakefile

@@ -2,7 +2,12 @@
 
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new :spec
 
-task default: :spec
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.requires << 'rubocop-rake'
+end
+
+task default: %i[rubocop spec]

data/bin/examples

@@ -4,40 +4,73 @@
 require 'bundler/setup'
 require 'owmo'
 
-# Create a file at the root of the repo with your api key and call it api_key.txt
-api_key = File.read('api_key.txt')
-
-
-
-examples = [
-    { description: 'current_box', path: :box, query: { bbox: [12, 32, 15, 37, 10].join(',') } },
-    { description: 'current_circle', path: :circle, query: { lat: 55.5, lon: 37.5, cnt: 10 } },
-    #{ description: 'current_group', path: :group, query: { id: [4_850_751, 4_887_398, 2_643_743, 4_164_138, 5_368_361].join(',') } },
-    { description: 'current', path: :current, query: { city_name: 'London,UK' } },
-    { description: 'forecast16', path: :forecast16, query: { city_name: 'London,UK' } },
-    { description: 'forecast5', path: :forecast5, query: { city_name: 'London,UK' } },
-    { description: 'query_all', path: :current, query: { city_name: 'London,UK', mode: 'json', units: 'imperial', lang: 'fr' } },
-    { description: 'query_geocode', path: :current, query: { city_id: 5_328_041 } },
-    { description: 'query_geocode', path: :current, query: { city_name: 'Beverly Hills' } },
-    { description: 'query_geocode', path: :current, query: { id: 5_328_041 } },
-    { description: 'query_geocode', path: :current, query: { lon: -118.41, lat: 34.09 } },
-    { description: 'query_geocode', path: :current, query: { q: 'Beverly Hills' } },
-    { description: 'query_geocode', path: :current, query: { zip: 90_210 } },
-    { description: 'query_geocode', path: :current, query: { zip_code: 90_210 } },
-    { description: 'query_mode', path: :current, query: { city_name: 'London,UK' } },
-    { description: 'query_mode', path: :current, query: { city_name: 'London,UK', mode: :html } },
-    { description: 'query_mode', path: :current, query: { city_name: 'London,UK', mode: :json } },
-    { description: 'query_mode', path: :current, query: { city_name: 'London,UK', mode: :xml } },
-    { description: 'query_units', path: :current, query: { city_name: 'London,UK' } },
-    { description: 'query_units', path: :current, query: { city_name: 'London,UK', units: :imperial } },
-    { description: 'query_units', path: :current, query: { city_name: 'London,UK', units: :metric } }
-]
+# Read the API key
+api_key_file = 'api_key.txt'
+
+unless File.exist? api_key_file
+  puts %(
+    File `#{api_key_file}` does not exist in the root of the repository.
+    Please create the file with your OpenWeatherMap API key and rerun bin/example.
+
+      # #{api_key_file} << cat '<your api key>'
+  )
+  exit(1)
+end
+
+api_key = File.read(api_key_file).chomp
+
+unless api_key.length == 32
+  puts %(
+    File `#{api_key_file}` does not contain a valid OpenWeatherMap API key.
+    Please update the file with a valid key and rerun bin/example.
+
+    Found: '#{api_key}'
+  )
+  exit(1)
+end
+
+examples = {
+  'current_box' => { path: :box, query: { bbox: [12, 32, 15, 37, 10].join(',') } },
+  'current_circle' => { path: :circle, query: { lat: 55.5, lon: 37.5, cnt: 10 } },
+  'current_group' => { path: :group,
+                       query: { id: [4_850_751, 4_887_398, 2_643_743, 4_164_138, 5_368_361].join(',') } },
+  'forecast16 by city_name' => { path: :forecast16, query: { city_name: 'London,UK' } },
+  'forecast5 by city_name' => { path: :forecast5, query: { city_name: 'London,UK' } },
+  'current by city_name, (json/imperial/fr)' => { path: :current,
+                                                  query: { city_name: 'London,UK', mode: 'json', units: 'imperial',
+                                                           lang: 'fr' } },
+  'current by city_id' => { path: :current, query: { city_id: 5_328_041 } },
+  'current by city_name' => { path: :current, query: { city_name: 'Beverly Hills' } },
+  'current by id' => { path: :current, query: { id: 5_328_041 } },
+  'current by lon/lat' => { path: :current, query: { lon: -118.41, lat: 34.09 } },
+  'current by q' => { path: :current, query: { q: 'Beverly Hills' } },
+  'current by zip' => { path: :current, query: { zip: 90_210 } },
+  'current by zip_code' => { path: :current, query: { zip_code: 90_210 } },
+  'current by city_name (html)' => { path: :current, query: { city_name: 'London,UK', mode: :html } },
+  'current by city_name (json)' => { path: :current, query: { city_name: 'London,UK', mode: :json } },
+  'current by city_name (xml)' => { path: :current, query: { city_name: 'London,UK', mode: :xml } },
+  'current by city_name (imperial)' => { path: :current, query: { city_name: 'London,UK', units: :imperial } },
+  'current by city_name (metric)' => { path: :current, query: { city_name: 'London,UK', units: :metric } }
+}
+
+execution_output = {}
 
 puts "OWMO Version #{OWMO::VERSION}"
 
 OWMO.weather(api_key) do |weather|
-    examples.each do |example|
-        puts '', '/********************', example[:description], '********************/'
-        pp weather.get example[:path], **example[:query]
+  examples.each do |name, params|
+    puts '', '/********************', name, '********************/'
+    begin
+      pp weather.get params[:path], **params[:query]
+      execution_output[name] = 'SUCCESS'
+    rescue StandardError => e
+      pp e.message
+      execution_output[name] = 'FAILURE'
     end
-end
+  end
+end
+
+puts "\n\nSummary:"
+execution_output.each do |name, outcome|
+  puts "  - [#{outcome}] #{name.capitalize}"
+end

data/bin/rake

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+bundle_binstub = File.expand_path('bundle', __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('rake', 'rake')

data/bin/rspec

@@ -8,12 +8,12 @@
 # this file is here to facilitate running it.
 #
 
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 
-bundle_binstub = File.expand_path("bundle", __dir__)
+bundle_binstub = File.expand_path('bundle', __dir__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+  if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
@@ -21,7 +21,7 @@ Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this
   end
 end
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rspec-core", "rspec")
+load Gem.bin_path('rspec-core', 'rspec')

data/bin/rubocop

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+bundle_binstub = File.expand_path('bundle', __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('rubocop', 'rubocop')

data/lib/owmo/version.rb

@@ -3,5 +3,5 @@
 module OWMO
   # rdoc
   # Gem Version
-  VERSION = '2.1.2'
+  VERSION = '2.1.5'
 end

data/lib/owmo/weather.rb

@@ -121,11 +121,9 @@ module OWMO
     # Sends the GET request to OpenWeatherMap.org
     # :nocov:
     def http_get(uri)
-      response = Net::HTTP.start(uri.hostname, uri.port) do |http|
+      Net::HTTP.start(uri.hostname, uri.port) do |http|
         http.request(Net::HTTP::Get.new(uri))
       end
-
-      response
     end
   end
   # :nocov:

data/lib/owmo/weather_response.rb

@@ -3,27 +3,34 @@
 require 'json'
 
 module OWMO
+  # Weather response class
+  class WeatherResponse
+    attr_reader :weather, :code
+
+    def initialize(http_response)
+      # JSON
+      @weather = JSON.parse(http_response.body)
+      @code = parse_code
+    rescue JSON::ParserError, TypeError
+      # Assume XML or HTML
+      @weather = http_response.body
+      @code = weather.length > 10 ? 200 : 500
+    end
 
-    class WeatherResponse
-
-        attr_reader :weather, :code
-
-        def initialize http_response
-            begin
-                # JSON
-                @weather = JSON.parse(http_response.body)
-                @code = self.weather["cod"].to_i
-            rescue JSON::ParserError, TypeError
-                # Assume XML or HTML
-                @weather = http_response.body
-                @code = self.weather.length > 10 ? 200 : 500
-            end
-        end
+    def error?
+      code != 200
+    end
 
-        def error?
-            self.code != 200
-        end
+    private
 
+    def parse_code
+      if weather.key? 'cod'
+        weather['cod'].to_i
+      elsif weather.key? 'cnt'
+        weather['cnt'].to_i >= 0 ? 200 : 500
+      else
+        500
+      end
     end
-
-end
+  end
+end

data/owmo.gemspec

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# coding: utf-8
 
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
@@ -24,7 +23,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '>= 2.7'
   spec.add_development_dependency 'bundler', '~> 2.x'
   spec.add_development_dependency 'rake', '~> 13.x'
   spec.add_development_dependency 'rspec', '~> 3.x'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: owmo
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.1.5
 platform: ruby
 authors:
 - Robb Randall
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-15 00:00:00.000000000 Z
+date: 2023-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -59,10 +59,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/ruby-publish-gem.yml"
-- ".github/workflows/ruby.yml"
+- ".github/workflows/rake-release.yml"
+- ".github/workflows/rake.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CONTRIBUTING.MD
 - Gemfile
@@ -72,7 +73,9 @@ files:
 - _config.yml
 - bin/console
 - bin/examples
+- bin/rake
 - bin/rspec
+- bin/rubocop
 - bin/setup
 - examples/current.rb
 - examples/current_box.rb
@@ -93,7 +96,8 @@ files:
 homepage: https://github.com/robb-randall/owmo
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -102,7 +106,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.github/workflows/ruby.yml

@@ -1,38 +0,0 @@
-# This workflow uses actions that are not certified by GitHub.
-# They are provided by a third-party and are governed by
-# separate terms of service, privacy policy, and support
-# documentation.
-# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
-# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
-
-name: Ruby
-
-on:
-  push:
-    branches: [ "main" ]
-  pull_request:
-    branches: [ "main" ]
-
-permissions:
-  contents: read
-
-jobs:
-  test:
-
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        ruby-version: ['2.7', '3.0']
-
-    steps:
-    - uses: actions/checkout@v3
-    - name: Set up Ruby
-    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
-    # change this to (see https://github.com/ruby/setup-ruby#versioning):
-    # uses: ruby/setup-ruby@v1
-      uses: ruby/setup-ruby@ee2113536afb7f793eed4ce60e8d3b26db912da4 # v1.127.0
-      with:
-        ruby-version: ${{ matrix.ruby-version }}
-        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - name: Run tests
-      run: bundle exec rake