ovirt-engine-sdk 4.2.0.alpha4 → 4.2.0.alpha5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 230614a52420a3f291acff2868274b00220cfe6a
-  data.tar.gz: 4480ebcee091051f2acaf8dbca74e9d3903e4196
+  metadata.gz: 7f0298f105fe0d7aa9600b45168f07acdb64d873
+  data.tar.gz: d337cd19f0b89175915a6ba3e33758d399c8682c
 SHA512:
-  metadata.gz: ae02f9d1e89464b19f72438d726f4d30a416fe30d18db16fc3f4fec2f08230f7ba3e64326d2e17a638b23de0ce0405725121793c3736385d30b34b59e2ebb5ea
-  data.tar.gz: d3e7722a5ecba2632d1f8259f43d61691463e63be959c8f66bb1289f4a61cf3dc1a774aa0dc2a0df13bd8376a37bb01ae7210860027e9f0d769cd6eff412cf40
+  metadata.gz: 5b7dfc32b268afc784640669f1c094c10721b1f5756e9d973783b3bfc0b655901e13d098742a402abe15a212e96f7da80702137ee9bdf87d2a4720f55bc5aece
+  data.tar.gz: aa05e77fae64684a463350641d5abe8b0c11a6bd56a5194f43ff947e3fc4524e06950f2b28e59015562859254d5850ce23ddf240581adf2ab33b8041772b8746

data/CHANGES.adoc

@@ -2,6 +2,41 @@
 
 This document describes the relevant changes between releases of the SDK.
 
+== 4.2.0-alpha5 / Nov 8 2017
+
+Update to model 4.2.24:
+
+* Add the `follow` parameter to all the `Get` and `List` operations.
+
+* Add the `force` parameter to the operation that puts a storage domain
+  into maintenance mode https://bugzilla.redhat.com/1321585[#1321585].
+
+* Deprecate the _OpenStack_ network provider `pluginType` attribute,
+  replacing it with `externalPluginType`.
+
+* Add `quota` and `diskProfile` parameters to the operations that move
+  and copy disks https://bugzilla.redhat.com/1496704[#1496704].
+
+* Add `authenticatedUser` and `effectiveUser` links to the `Api` type
+  https://bugzilla.redhat.com/1472418[#1472418].
+
+New features:
+
+* Add support for cookies.
+
+* Add `connect_timeout` parameter
+  https://bugzilla.redhat.com/1508944[#1508944].
+
+Bug fixes:
+
+* Check the types of the `HttpClient` constructor parameters.
+
+* Require `redhat-rpm-config` for building
+  https://bugzilla.redhat.com/1505427[#1505427].
+
+* Don't send `Expect: 100-continue`
+  https://bugzilla.redhat.com/1509910[#1509910].
+
 == 4.2.0-alpha4 / Oct 23 2017
 
 Update to model 4.2.23:

data/README.adoc

@@ -41,16 +41,41 @@ CentOS:
   gcc \
   libcurl-devel \
   libxml2-devel \
-  ruby-devel
+  redhat-rpm-config \
+  ruby \
+  ruby-devel \
+  rubygems \
+  rubygems-devel
+
+NOTE: The installation of the `ruby`, `ruby-devel`, `rubygems` and
+`rubygems-devel` packages is necessary if you are going to use the Ruby
+version included in your distribution. If you are using tools like
+`rbenv` or `rvm` then this is not necessary.
 
 If you are using distributions like Debian, or Ubuntu:
 
   # apt-get --assume-yes install \
   gcc \
+  libcurl4-openssl-dev \
   libxml2-dev \
-  libcurl-dev \
+  ruby \
   ruby-dev
 
+NOTE: The installation of the `ruby` and `ruby-dev` packages is
+necessary if you are going to use the Ruby version included in your
+distribution. If you are using tools like `rbenv` or `rvm` then this is
+not necessary.
+
+Some Linux distributions, like Debian and Ubuntu, provide multiple
+versions of `libcurl`, compiled with support for different TLS
+libraries: OpenSSL, NSS and GnuTLS. Currently the SDK only supports
+OpenSSL, so make sure that you have that version of `libcurl` installed.
+For example, in Ubuntu 16.04 if you have the NSS version installed, you
+will have to remove it and then install the OpenSSL version:
+
+  # apt-get --assume-yes remove libcurl4-nss-dev
+  # apt-get --assume-yes install libcurl4-openssl-dev
+
 NOTE: The examples above use the `dnf` command, which is the default in
 Fedora 24. In CentOS 7 you may need to use the `yum` command, as `dnf`
 is optional.

data/ext/ovirtsdk4c/ov_http_client.c

@@ -50,6 +50,7 @@ static VALUE PROXY_PASSWORD_SYMBOL;
 static VALUE PROXY_URL_SYMBOL;
 static VALUE PROXY_USERNAME_SYMBOL;
 static VALUE TIMEOUT_SYMBOL;
+static VALUE CONNECT_TIMEOUT_SYMBOL;
 static VALUE COOKIES_SYMBOL;
 
 /* Method identifiers: */
@@ -201,6 +202,7 @@ static VALUE ov_http_client_alloc(VALUE klass) {
     ptr->proxy_username = NULL;
     ptr->proxy_password = NULL;
     ptr->timeout = 0;
+    ptr->connect_timeout = 0;
     ptr->cookies = NULL;
     return TypedData_Wrap_Struct(klass, &ov_http_client_type, ptr);
 }
@@ -512,6 +514,16 @@ static VALUE ov_http_client_initialize(int argc, VALUE* argv, VALUE self) {
         ptr->timeout = NUM2INT(opt);
     }
 
+    /* Get the value of the 'connect_timeout' parameter: */
+    opt = rb_hash_aref(opts, CONNECT_TIMEOUT_SYMBOL);
+    if (NIL_P(opt)) {
+        ptr->connect_timeout = 0;
+    }
+    else {
+        Check_Type(opt, T_FIXNUM);
+        ptr->connect_timeout = NUM2INT(opt);
+    }
+
     /* Get the value of the 'proxy_url' parameter: */
     opt = rb_hash_aref(opts, PROXY_URL_SYMBOL);
     if (NIL_P(opt)) {
@@ -800,6 +812,7 @@ static void ov_http_client_prepare_handle(ov_http_client_object* client_ptr, ov_
     VALUE header;
     VALUE url;
     int timeout;
+    int connect_timeout;
 
     /* Configure sharing of cookies with other handlers created by the client: */
     curl_easy_setopt(handle, CURLOPT_SHARE, client_ptr->share);
@@ -817,13 +830,20 @@ static void ov_http_client_prepare_handle(ov_http_client_object* client_ptr, ov_
         curl_easy_setopt(handle, CURLOPT_CAINFO, client_ptr->ca_file);
     }
 
-    /* Configure the timeout: */
+    /* Configure the total timeout: */
     timeout = client_ptr->timeout;
     if (!NIL_P(request_ptr->timeout)) {
         timeout = NUM2INT(request_ptr->timeout);
     }
     curl_easy_setopt(handle, CURLOPT_TIMEOUT, timeout);
 
+    /* Configure the connect timeout: */
+    connect_timeout = client_ptr->connect_timeout;
+    if (!NIL_P(request_ptr->connect_timeout)) {
+        connect_timeout = NUM2INT(request_ptr->connect_timeout);
+    }
+    curl_easy_setopt(handle, CURLOPT_CONNECTTIMEOUT, connect_timeout);
+
     /* Configure compression of responses (setting the value to zero length string means accepting all the
        compression types that libcurl supports): */
     if (client_ptr->compress) {
@@ -861,6 +881,7 @@ static void ov_http_client_prepare_handle(ov_http_client_object* client_ptr, ov_
        curl_easy_setopt(handle, CURLOPT_POST, 1L);
     }
     else if (rb_eql(request_ptr->method, PUT_SYMBOL)) {
+       *headers = curl_slist_append(*headers, "Expect:");
        curl_easy_setopt(handle, CURLOPT_UPLOAD, 1L);
        curl_easy_setopt(handle, CURLOPT_PUT, 1L);
     }
@@ -1026,19 +1047,20 @@ void ov_http_client_define(void) {
     rb_define_method(ov_http_client_class, "wait",  ov_http_client_wait,  1);
 
     /* Define the symbols: */
-    CA_FILE_SYMBOL        = ID2SYM(rb_intern("ca_file"));
-    COMPRESS_SYMBOL       = ID2SYM(rb_intern("compress"));
-    CONNECTIONS_SYMBOL    = ID2SYM(rb_intern("connections"));
-    DEBUG_SYMBOL          = ID2SYM(rb_intern("debug"));
-    INSECURE_SYMBOL       = ID2SYM(rb_intern("insecure"));
-    LOG_SYMBOL            = ID2SYM(rb_intern("log"));
-    PASSWORD_SYMBOL       = ID2SYM(rb_intern("password"));
-    PIPELINE_SYMBOL       = ID2SYM(rb_intern("pipeline"));
-    PROXY_PASSWORD_SYMBOL = ID2SYM(rb_intern("proxy_password"));
-    PROXY_URL_SYMBOL      = ID2SYM(rb_intern("proxy_url"));
-    PROXY_USERNAME_SYMBOL = ID2SYM(rb_intern("proxy_username"));
-    TIMEOUT_SYMBOL        = ID2SYM(rb_intern("timeout"));
-    COOKIES_SYMBOL        = ID2SYM(rb_intern("cookies"));
+    CA_FILE_SYMBOL         = ID2SYM(rb_intern("ca_file"));
+    COMPRESS_SYMBOL        = ID2SYM(rb_intern("compress"));
+    CONNECTIONS_SYMBOL     = ID2SYM(rb_intern("connections"));
+    DEBUG_SYMBOL           = ID2SYM(rb_intern("debug"));
+    INSECURE_SYMBOL        = ID2SYM(rb_intern("insecure"));
+    LOG_SYMBOL             = ID2SYM(rb_intern("log"));
+    PASSWORD_SYMBOL        = ID2SYM(rb_intern("password"));
+    PIPELINE_SYMBOL        = ID2SYM(rb_intern("pipeline"));
+    PROXY_PASSWORD_SYMBOL  = ID2SYM(rb_intern("proxy_password"));
+    PROXY_URL_SYMBOL       = ID2SYM(rb_intern("proxy_url"));
+    PROXY_USERNAME_SYMBOL  = ID2SYM(rb_intern("proxy_username"));
+    TIMEOUT_SYMBOL         = ID2SYM(rb_intern("timeout"));
+    CONNECT_TIMEOUT_SYMBOL = ID2SYM(rb_intern("connect_timeout"));
+    COOKIES_SYMBOL         = ID2SYM(rb_intern("cookies"));
 
     /* Define the method identifiers: */
     COMPARE_BY_IDENTITY_ID = rb_intern("compare_by_identity");

data/ext/ovirtsdk4c/ov_http_client.h

@@ -54,6 +54,7 @@ typedef struct {
     char* proxy_username;
     char* proxy_password;
     int timeout;
+    int connect_timeout;
     char* cookies;
 } ov_http_client_object;
 

data/ext/ovirtsdk4c/ov_http_request.c

@@ -40,6 +40,7 @@ static VALUE TOKEN_SYMBOL;
 static VALUE KERBEROS_SYMBOL;
 static VALUE BODY_SYMBOL;
 static VALUE TIMEOUT_SYMBOL;
+static VALUE CONNECT_TIMEOUT_SYMBOL;
 
 static void ov_http_request_mark(void* vptr) {
     ov_http_request_object* ptr;
@@ -55,6 +56,7 @@ static void ov_http_request_mark(void* vptr) {
     rb_gc_mark(ptr->kerberos);
     rb_gc_mark(ptr->body);
     rb_gc_mark(ptr->timeout);
+    rb_gc_mark(ptr->connect_timeout);
 }
 
 static void ov_http_request_free(void* vptr) {
@@ -83,16 +85,17 @@ static VALUE ov_http_request_alloc(VALUE klass) {
     ov_http_request_object* ptr;
 
     ptr = ALLOC(ov_http_request_object);
-    ptr->method   = Qnil;
-    ptr->url      = Qnil;
-    ptr->query    = Qnil;
-    ptr->headers  = Qnil;
-    ptr->username = Qnil;
-    ptr->password = Qnil;
-    ptr->token    = Qnil;
-    ptr->kerberos = Qnil;
-    ptr->body     = Qnil;
-    ptr->timeout  = Qnil;
+    ptr->method          = Qnil;
+    ptr->url             = Qnil;
+    ptr->query           = Qnil;
+    ptr->headers         = Qnil;
+    ptr->username        = Qnil;
+    ptr->password        = Qnil;
+    ptr->token           = Qnil;
+    ptr->kerberos        = Qnil;
+    ptr->body            = Qnil;
+    ptr->timeout         = Qnil;
+    ptr->connect_timeout = Qnil;
     return TypedData_Wrap_Struct(klass, &ov_http_request_type, ptr);
 }
 
@@ -279,6 +282,24 @@ static VALUE ov_http_request_set_timeout(VALUE self, VALUE value) {
     return Qnil;
 }
 
+static VALUE ov_http_request_get_connect_timeout(VALUE self) {
+    ov_http_request_object* ptr;
+
+    ov_http_request_ptr(self, ptr);
+    return ptr->connect_timeout;
+}
+
+static VALUE ov_http_request_set_connect_timeout(VALUE self, VALUE value) {
+    ov_http_request_object* ptr;
+
+    ov_http_request_ptr(self, ptr);
+    if (!NIL_P(value)) {
+        Check_Type(value, T_FIXNUM);
+    }
+    ptr->connect_timeout = value;
+    return Qnil;
+}
+
 static VALUE ov_http_request_initialize(int argc, VALUE* argv, VALUE self) {
     VALUE opts;
 
@@ -304,6 +325,7 @@ static VALUE ov_http_request_initialize(int argc, VALUE* argv, VALUE self) {
     ov_http_request_set_token(self, rb_hash_aref(opts, TOKEN_SYMBOL));
     ov_http_request_set_body(self, rb_hash_aref(opts, BODY_SYMBOL));
     ov_http_request_set_timeout(self, rb_hash_aref(opts, TIMEOUT_SYMBOL));
+    ov_http_request_set_connect_timeout(self, rb_hash_aref(opts, CONNECT_TIMEOUT_SYMBOL));
 
     return self;
 }
@@ -317,38 +339,41 @@ void ov_http_request_define(void) {
     rb_define_method(ov_http_request_class, "initialize", ov_http_request_initialize, -1);
 
     /* Define the methods: */
-    rb_define_method(ov_http_request_class, "method",    ov_http_request_get_method,   0);
-    rb_define_method(ov_http_request_class, "method=",   ov_http_request_set_method,   1);
-    rb_define_method(ov_http_request_class, "url",       ov_http_request_get_url,      0);
-    rb_define_method(ov_http_request_class, "url=",      ov_http_request_set_url,      1);
-    rb_define_method(ov_http_request_class, "query",     ov_http_request_get_query,    0);
-    rb_define_method(ov_http_request_class, "query=",    ov_http_request_set_query,    1);
-    rb_define_method(ov_http_request_class, "headers",   ov_http_request_get_headers,  0);
-    rb_define_method(ov_http_request_class, "headers=",  ov_http_request_set_headers,  1);
-    rb_define_method(ov_http_request_class, "username",  ov_http_request_get_username, 0);
-    rb_define_method(ov_http_request_class, "username=", ov_http_request_set_username, 1);
-    rb_define_method(ov_http_request_class, "password",  ov_http_request_get_password, 0);
-    rb_define_method(ov_http_request_class, "password=", ov_http_request_set_password, 1);
-    rb_define_method(ov_http_request_class, "token",     ov_http_request_get_token,    0);
-    rb_define_method(ov_http_request_class, "token=",    ov_http_request_set_token,    1);
-    rb_define_method(ov_http_request_class, "kerberos",  ov_http_request_get_kerberos, 0);
-    rb_define_method(ov_http_request_class, "kerberos=", ov_http_request_set_kerberos, 1);
-    rb_define_method(ov_http_request_class, "body",      ov_http_request_get_body,     0);
-    rb_define_method(ov_http_request_class, "body=",     ov_http_request_set_body,     1);
-    rb_define_method(ov_http_request_class, "timeout",   ov_http_request_get_timeout,  0);
-    rb_define_method(ov_http_request_class, "timeout=",  ov_http_request_set_timeout,  1);
+    rb_define_method(ov_http_request_class, "method",           ov_http_request_get_method,          0);
+    rb_define_method(ov_http_request_class, "method=",          ov_http_request_set_method,          1);
+    rb_define_method(ov_http_request_class, "url",              ov_http_request_get_url,             0);
+    rb_define_method(ov_http_request_class, "url=",             ov_http_request_set_url,             1);
+    rb_define_method(ov_http_request_class, "query",            ov_http_request_get_query,           0);
+    rb_define_method(ov_http_request_class, "query=",           ov_http_request_set_query,           1);
+    rb_define_method(ov_http_request_class, "headers",          ov_http_request_get_headers,         0);
+    rb_define_method(ov_http_request_class, "headers=",         ov_http_request_set_headers,         1);
+    rb_define_method(ov_http_request_class, "username",         ov_http_request_get_username,        0);
+    rb_define_method(ov_http_request_class, "username=",        ov_http_request_set_username,        1);
+    rb_define_method(ov_http_request_class, "password",         ov_http_request_get_password,        0);
+    rb_define_method(ov_http_request_class, "password=",        ov_http_request_set_password,        1);
+    rb_define_method(ov_http_request_class, "token",            ov_http_request_get_token,           0);
+    rb_define_method(ov_http_request_class, "token=",           ov_http_request_set_token,           1);
+    rb_define_method(ov_http_request_class, "kerberos",         ov_http_request_get_kerberos,        0);
+    rb_define_method(ov_http_request_class, "kerberos=",        ov_http_request_set_kerberos,        1);
+    rb_define_method(ov_http_request_class, "body",             ov_http_request_get_body,            0);
+    rb_define_method(ov_http_request_class, "body=",            ov_http_request_set_body,            1);
+    rb_define_method(ov_http_request_class, "timeout",          ov_http_request_get_timeout,         0);
+    rb_define_method(ov_http_request_class, "timeout=",         ov_http_request_set_timeout,         1);
+    rb_define_method(ov_http_request_class, "connect_timeout",  ov_http_request_get_connect_timeout, 0);
+    rb_define_method(ov_http_request_class, "connect_timeout=", ov_http_request_set_connect_timeout, 1);
 
     /* Define the symbols for the attributes: */
-    URL_SYMBOL      = ID2SYM(rb_intern("url"));
-    METHOD_SYMBOL   = ID2SYM(rb_intern("method"));
-    QUERY_SYMBOL    = ID2SYM(rb_intern("query"));
-    HEADERS_SYMBOL  = ID2SYM(rb_intern("headers"));
-    USERNAME_SYMBOL = ID2SYM(rb_intern("username"));
-    PASSWORD_SYMBOL = ID2SYM(rb_intern("password"));
-    TOKEN_SYMBOL    = ID2SYM(rb_intern("token"));
-    KERBEROS_SYMBOL = ID2SYM(rb_intern("kerberos"));
-    BODY_SYMBOL     = ID2SYM(rb_intern("body"));
-    TIMEOUT_SYMBOL  = ID2SYM(rb_intern("timeout"));
+    URL_SYMBOL             = ID2SYM(rb_intern("url"));
+    METHOD_SYMBOL          = ID2SYM(rb_intern("method"));
+    QUERY_SYMBOL           = ID2SYM(rb_intern("query"));
+    HEADERS_SYMBOL         = ID2SYM(rb_intern("headers"));
+    USERNAME_SYMBOL        = ID2SYM(rb_intern("username"));
+    PASSWORD_SYMBOL        = ID2SYM(rb_intern("password"));
+    TOKEN_SYMBOL           = ID2SYM(rb_intern("token"));
+    KERBEROS_SYMBOL        = ID2SYM(rb_intern("kerberos"));
+    BODY_SYMBOL            = ID2SYM(rb_intern("body"));
+    TIMEOUT_SYMBOL         = ID2SYM(rb_intern("timeout"));
+    CONNECT_TIMEOUT_SYMBOL = ID2SYM(rb_intern("connect_timeout"));
 
     /* Define the symbols for the HTTP methods: */
     GET_SYMBOL    = ID2SYM(rb_intern("GET"));

data/ext/ovirtsdk4c/ov_http_request.h

@@ -31,16 +31,17 @@ extern VALUE DELETE_SYMBOL;
 
 /* Content: */
 typedef struct {
-    VALUE method;   /* Symbol */
-    VALUE url;      /* String */
-    VALUE query;    /* Hash<String, String> */
-    VALUE headers;  /* Hash<String, String> */
-    VALUE username; /* String */
-    VALUE password; /* String */
-    VALUE token;    /* String */
-    VALUE kerberos; /* Boolean */
-    VALUE body;     /* String */
-    VALUE timeout;  /* Integer */
+    VALUE method;          /* Symbol */
+    VALUE url;             /* String */
+    VALUE query;           /* Hash<String, String> */
+    VALUE headers;         /* Hash<String, String> */
+    VALUE username;        /* String */
+    VALUE password;        /* String */
+    VALUE token;           /* String */
+    VALUE kerberos;        /* Boolean */
+    VALUE body;            /* String */
+    VALUE timeout;         /* Integer */
+    VALUE connect_timeout; /* Integer */
 } ov_http_request_object;
 
 /* Macro to get the pointer: */

data/lib/ovirtsdk4/connection.rb

@@ -75,8 +75,11 @@ module OvirtSDK4
     #   instead of user name and password to obtain the OAuth token.
     #
     # @option opts [Integer] :timeout (0) The maximun total time to wait for the response, in seconds. A value of zero
-    #   (the default) means wait for ever. If the timeout expires before the response is received an exception will be
-    #   raised.
+    #   (the default) means wait for ever. If the timeout expires before the response is received a `TimeoutError`
+    #   exception will be raised.
+    #
+    # @option opts [Integer] :connect_timeout (300) The maximun time to wait for connection establishment, in seconds.
+    #   If the timeout expires before the connection is established a `TimeoutError` exception will be raised.
     #
     # @option opts [Boolean] :compress (true) A boolean flag indicating if the SDK should ask the server to send
     #   compressed responses. Note that this is a hint for the server, and that it may return uncompressed data even
@@ -117,6 +120,7 @@ module OvirtSDK4
       @log = opts[:log]
       @kerberos = opts[:kerberos] || false
       @timeout = opts[:timeout] || 0
+      @connect_timeout = opts[:connect_timeout] || 0
       @compress = opts[:compress] || true
       @proxy_url = opts[:proxy_url]
       @proxy_username = opts[:proxy_username]
@@ -156,6 +160,7 @@ module OvirtSDK4
         debug: @debug,
         log: @log,
         timeout: @timeout,
+        connect_timeout: @connect_timeout,
         compress: @compress,
         proxy_url: @proxy_url,
         proxy_username: @proxy_username,

data/lib/ovirtsdk4/readers.rb

@@ -151,6 +151,8 @@ module OvirtSDK4
           object.discard_snapshots = Reader.read_boolean(reader)
         when 'disk'
           object.disk = DiskReader.read_one(reader)
+        when 'disk_profile'
+          object.disk_profile = DiskProfileReader.read_one(reader)
         when 'disks'
           object.disks = DiskReader.read_many(reader)
         when 'exclusive'
@@ -207,6 +209,8 @@ module OvirtSDK4
           object.power_management = PowerManagementReader.read_one(reader)
         when 'proxy_ticket'
           object.proxy_ticket = ProxyTicketReader.read_one(reader)
+        when 'quota'
+          object.quota = QuotaReader.read_one(reader)
         when 'reason'
           object.reason = Reader.read_string(reader)
         when 'reassign_bad_macs'
@@ -809,6 +813,10 @@ module OvirtSDK4
           object.summary = ApiSummaryReader.read_one(reader)
         when 'time'
           object.time = Reader.read_date(reader)
+        when 'authenticated_user'
+          object.authenticated_user = UserReader.read_one(reader)
+        when 'effective_user'
+          object.effective_user = UserReader.read_one(reader)
         else
           reader.next_element
         end
@@ -11559,6 +11567,8 @@ module OvirtSDK4
       object.comment = value if not value.nil?
       value = reader.get_attribute('description')
       object.description = value if not value.nil?
+      value = reader.get_attribute('external_plugin_type')
+      object.external_plugin_type = value if not value.nil?
       value = reader.get_attribute('id')
       object.id = value if not value.nil?
       value = reader.get_attribute('name')
@@ -11596,6 +11606,8 @@ module OvirtSDK4
           object.comment = Reader.read_string(reader)
         when 'description'
           object.description = Reader.read_string(reader)
+        when 'external_plugin_type'
+          object.external_plugin_type = Reader.read_string(reader)
         when 'id'
           object.id = Reader.read_string(reader)
         when 'name'