overcommit 0.67.1 → 0.69.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e81508d0f9854d0ad04bb88a192e479efd14d2dcb72520656e96ffbd42d2a10c
-  data.tar.gz: 58cf91765bfd9b4fc13f287f7d8d0fc5de9abdd5f4306e8c06a6e98b49df005e
+  metadata.gz: 3e487ccda9c90ec94450f359fa29f757077ca716801db2c86033d41c51e695c5
+  data.tar.gz: a61032840d8181959755fecfa98334903e4d2004ea0fb5b2f7f8b5981a4c2338
 SHA512:
-  metadata.gz: 87650f7f66f4f2d1b652154f44a853aa6486e57befbc91c520f05ac28cce74ca291a7cb5681efcde73436f3bbc7bc7fa0c6eceb9fc8f4abeea44de94c54cd7f0
-  data.tar.gz: e9872666ee60dc587668c17331e476d3287e22a2b2ca3ddf656f9bf863d1c315f208458c2c5c21c0e0d7ae779e1cbd7357ebe5fd361be1812799b7018095257a
+  metadata.gz: 71d5ff6fb55f8936f94eda4a436cf5da48b9334d17c99f309759ccae0054ed4a7375e44a7885c9deebe7c5227737e61facf800c449e2fc4c6a1e5faf9b2f54c5
+  data.tar.gz: 0e8c1866c1cf004f5bd171cc59c31ba661b482a8e33e8febf43c6c4b12e60880c508546dc23f90b3f28357b64ddb9e73a582c9201e5edfd0d87b4688a3f5f342

data/config/default.yml

@@ -799,6 +799,20 @@ PreCommit:
     install_command: 'gem install slim_lint'
     include: '**/*.slim'
 
+  Solargraph:
+    enabled: false
+    description: 'Typecheck with Solargraph'
+    requires_files: true
+    required_executable: 'solargraph'
+    install_command: 'gem install solargraph'
+    flags: ['typecheck', '--level', 'strong']
+    include: '**/*.rb'
+    exclude:
+      - 'spec/**/*.rb'
+      - 'test/**/*.rb'
+      - 'vendor/**/*.rb'
+      - '.bundle/**/*.rb'
+
   Sorbet:
     enabled: false
     description: 'Analyze with Sorbet'

data/lib/overcommit/hook/pre_commit/scalastyle.rb

@@ -24,7 +24,7 @@ module Overcommit::Hook::PreCommit
       extract_messages(
         messages,
         MESSAGE_REGEX,
-        lambda { |type| type.to_sym }
+        lambda(&:to_sym)
       )
     end
   end

data/lib/overcommit/hook/pre_commit/solargraph.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require 'overcommit'
+require 'overcommit/hook/pre_commit/base'
+
+module Overcommit
+  module Hook
+    module PreCommit
+      # Runs `solargraph typecheck` against any modified Ruby files.
+      #
+      # @see https://github.com/castwide/solargraph
+      class Solargraph < Base
+        MESSAGE_REGEX = /^\s*(?<file>(?:\w:)?[^:]+):(?<line>\d+) - /.freeze
+
+        def run
+          result = execute(command, args: applicable_files)
+          return :pass if result.success?
+
+          stderr_lines = remove_harmless_glitches(result.stderr)
+          violation_lines = result.stdout.split("\n").grep(MESSAGE_REGEX)
+          if violation_lines.empty?
+            if stderr_lines.empty?
+              [:fail, 'Solargraph failed to run']
+            else
+              # let's feed it stderr so users see the errors
+              extract_messages(stderr_lines, MESSAGE_REGEX)
+            end
+          else
+            extract_messages(violation_lines, MESSAGE_REGEX)
+          end
+        end
+
+        private
+
+        # @param stderr [String]
+        #
+        # @return [Array<String>]
+        def remove_harmless_glitches(stderr)
+          stderr.split("\n").reject do |line|
+            line.include?('[WARN]') ||
+              line.include?('warning: parser/current is loading') ||
+              line.include?('Please see https://github.com/whitequark')
+          end
+        end
+      end
+    end
+  end
+end

data/lib/overcommit/utils.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'etc'
 require 'pathname'
 require 'overcommit/os'
 require 'overcommit/subprocess'
@@ -150,6 +151,9 @@ module Overcommit
         else
           `ps -ocommand= -p #{Process.ppid}`.chomp
         end
+      rescue Errno::EPERM, Errno::ENOENT
+        # Process information may not be available, such as inside sandboxed environments
+        nil
       end
 
       # Execute a command in a subprocess, capturing exit status and output from
@@ -212,40 +216,8 @@ module Overcommit
       end
 
       # Return the number of processors used by the OS for process scheduling.
-      #
-      # @see https://github.com/grosser/parallel/blob/v1.6.1/lib/parallel/processor_count.rb#L17-L51
-      def processor_count # rubocop:disable all
-        @processor_count ||=
-          begin
-            if Overcommit::OS.windows?
-              require 'win32ole'
-              result = WIN32OLE.connect('winmgmts://').ExecQuery(
-                'select NumberOfLogicalProcessors from Win32_Processor'
-              )
-              result.to_enum.collect(&:NumberOfLogicalProcessors).reduce(:+)
-            elsif File.readable?('/proc/cpuinfo')
-              IO.read('/proc/cpuinfo').scan(/^processor/).size
-            elsif File.executable?('/usr/bin/hwprefs')
-              IO.popen('/usr/bin/hwprefs thread_count').read.to_i
-            elsif File.executable?('/usr/sbin/psrinfo')
-              IO.popen('/usr/sbin/psrinfo').read.scan(/^.*on-*line/).size
-            elsif File.executable?('/usr/sbin/ioscan')
-              IO.popen('/usr/sbin/ioscan -kC processor') do |out|
-                out.read.scan(/^.*processor/).size
-              end
-            elsif File.executable?('/usr/sbin/pmcycles')
-              IO.popen('/usr/sbin/pmcycles -m').read.count("\n")
-            elsif File.executable?('/usr/sbin/lsdev')
-              IO.popen('/usr/sbin/lsdev -Cc processor -S 1').read.count("\n")
-            elsif File.executable?('/usr/sbin/sysctl')
-              IO.popen('/usr/sbin/sysctl -n hw.ncpu').read.to_i
-            elsif File.executable?('/sbin/sysctl')
-              IO.popen('/sbin/sysctl -n hw.ncpu').read.to_i
-            else
-              # Unknown platform; assume 1 processor
-              1
-            end
-          end
+      def processor_count
+        @processor_count ||= Etc.nprocessors
       end
 
       # Calls a block of code with a modified set of environment variables,

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.67.1'
+  VERSION = '0.69.0'
 end

data/template-dir/hooks/commit-msg

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/overcommit-hook

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-checkout

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-commit

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-merge

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-rewrite

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-commit

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-push

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-rebase

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/prepare-commit-msg

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.67.1
+  version: 0.69.0
 platform: ruby
 authors:
 - Shane da Silva
 bindir: bin
 cert_chain: []
-date: 2025-03-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -209,6 +209,7 @@ files:
 - lib/overcommit/hook/pre_commit/semi_standard.rb
 - lib/overcommit/hook/pre_commit/shell_check.rb
 - lib/overcommit/hook/pre_commit/slim_lint.rb
+- lib/overcommit/hook/pre_commit/solargraph.rb
 - lib/overcommit/hook/pre_commit/sorbet.rb
 - lib/overcommit/hook/pre_commit/sqlint.rb
 - lib/overcommit/hook/pre_commit/standard.rb
@@ -322,7 +323,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Git hook manager
 test_files: []