overcommit 0.67.0 → 0.68.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5294dbf6a9c2979b0cc06483c7db55887ad4e62095f14258cbfdd2efadecdee
-  data.tar.gz: 0cda279207d7551cc87b89f4e8c928f5041463996b9ea77f2feebd64dcb2da3f
+  metadata.gz: 57b026be0de6f8992a7959d366a7c131025b1de64e442d5fdbf3e73481501645
+  data.tar.gz: 17e3e01c75287dcfac05d6e8b8114db2aa772cd407efed388bd68674714ff46c
 SHA512:
-  metadata.gz: 471264205b4f078dfe3453cedc209f3723cd31a1139cd9da7c30a36740730eceba813fbb69364e08e03ecb4ec25dd8e19109b41556b8df58fd0e9cd361ac40d2
-  data.tar.gz: 72bec31dcc6cea0510dd21bf6371997c88e591b7330b4e5ff985cc8c8616f1cbe5a674d5201a3a4c435ce23de3afbfa221eb96a3e2c51f984ff524b70068176d
+  metadata.gz: 6a0f34b82082e8b20eb23c7cb77066d2a2f6135d38b8a700c247f014100c2bd6f4ab6f0e0ff14517e219891eafa54a4d0bf4796604971d91d5125e2435d17e11
+  data.tar.gz: a7f96cef415b1722d62f4cede3af1808005c16f892095ea1ff7f420eef00bd448dad778fc699c5e4360dab1f21847cd892375187c2a6ad8ef1d14944573a5d1a

data/config/default.yml

@@ -32,6 +32,10 @@
 # your repository, and then set the `gemfile` option below to the name you gave
 # the file.
 # (Generate lock file by running `bundle install --gemfile=.overcommit_gems.rb`)
+#
+# NOTE: the following line will be parsed by a regexp rather than a proper YAML
+# parser, so avoid any values other than false or a string, and don't use inline
+# comments
 gemfile: false
 
 # Where to store hook plugins specific to a repository. These are loaded in
@@ -795,6 +799,20 @@ PreCommit:
     install_command: 'gem install slim_lint'
     include: '**/*.slim'
 
+  Solargraph:
+    enabled: false
+    description: 'Typecheck with Solargraph'
+    requires_files: true
+    required_executable: 'solargraph'
+    install_command: 'gem install solargraph'
+    flags: ['typecheck', '--level', 'strong']
+    include: '**/*.rb'
+    exclude:
+      - 'spec/**/*.rb'
+      - 'test/**/*.rb'
+      - 'vendor/**/*.rb'
+      - '.bundle/**/*.rb'
+
   Sorbet:
     enabled: false
     description: 'Analyze with Sorbet'

data/lib/overcommit/hook/pre_commit/scalastyle.rb

@@ -24,7 +24,7 @@ module Overcommit::Hook::PreCommit
       extract_messages(
         messages,
         MESSAGE_REGEX,
-        lambda { |type| type.to_sym }
+        lambda(&:to_sym)
       )
     end
   end

data/lib/overcommit/hook/pre_commit/solargraph.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require 'overcommit'
+require 'overcommit/hook/pre_commit/base'
+
+module Overcommit
+  module Hook
+    module PreCommit
+      # Runs `solargraph typecheck` against any modified Ruby files.
+      #
+      # @see https://github.com/castwide/solargraph
+      class Solargraph < Base
+        MESSAGE_REGEX = /^\s*(?<file>(?:\w:)?[^:]+):(?<line>\d+) - /.freeze
+
+        def run
+          result = execute(command, args: applicable_files)
+          return :pass if result.success?
+
+          stderr_lines = remove_harmless_glitches(result.stderr)
+          violation_lines = result.stdout.split("\n").grep(MESSAGE_REGEX)
+          if violation_lines.empty?
+            if stderr_lines.empty?
+              [:fail, 'Solargraph failed to run']
+            else
+              # let's feed it stderr so users see the errors
+              extract_messages(stderr_lines, MESSAGE_REGEX)
+            end
+          else
+            extract_messages(violation_lines, MESSAGE_REGEX)
+          end
+        end
+
+        private
+
+        # @param stderr [String]
+        #
+        # @return [Array<String>]
+        def remove_harmless_glitches(stderr)
+          stderr.split("\n").reject do |line|
+            line.include?('[WARN]') ||
+              line.include?('warning: parser/current is loading') ||
+              line.include?('Please see https://github.com/whitequark')
+          end
+        end
+      end
+    end
+  end
+end

data/lib/overcommit/hook_context/diff.rb

@@ -2,6 +2,8 @@
 
 require 'overcommit/git_repo'
 
+require 'set'
+
 module Overcommit::HookContext
   # Simulates a pre-commit context based on the diff with another git ref.
   #

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.67.0'
+  VERSION = '0.68.0'
 end

data/template-dir/hooks/commit-msg

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/overcommit-hook

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-checkout

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-commit

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-merge

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/post-rewrite

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-commit

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-push

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/pre-rebase

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

data/template-dir/hooks/prepare-commit-msg

@@ -42,7 +42,6 @@ if gemfile
     exit 78 # EX_CONFIG
   end
 end
-# rubocop:enable Style/RescueModifier
 
 begin
   require 'overcommit'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.67.0
+  version: 0.68.0
 platform: ruby
 authors:
 - Shane da Silva
 bindir: bin
 cert_chain: []
-date: 2025-02-16 00:00:00.000000000 Z
+date: 2025-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -209,6 +209,7 @@ files:
 - lib/overcommit/hook/pre_commit/semi_standard.rb
 - lib/overcommit/hook/pre_commit/shell_check.rb
 - lib/overcommit/hook/pre_commit/slim_lint.rb
+- lib/overcommit/hook/pre_commit/solargraph.rb
 - lib/overcommit/hook/pre_commit/sorbet.rb
 - lib/overcommit/hook/pre_commit/sqlint.rb
 - lib/overcommit/hook/pre_commit/standard.rb