overcommit 0.49.0 → 0.49.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a28cd7dfaf56d9588e2f9f789f49f4da01e50ebaa835a18d3d2f00c76863901d
-  data.tar.gz: 3112089cea167f58128d085f5c02cd9ec3589f6b3ac1cbb934e6d6a9d8c7982d
+  metadata.gz: 57eb73c3921856cf864136fbf263df0b07d1b07a6acc25a2c0fca6ed1d13a727
+  data.tar.gz: 922db4b368ca43001b2118b2322dbcbb33686ebe8cd434375b52f7b4fc85be14
 SHA512:
-  metadata.gz: e282603906588c02990acb714d2b767599295b4fd66102a9a1a705fd57eca4ff4eee29772c03e33c2a632692167898837b469a909979e043cc3dce9c24dc0d67
-  data.tar.gz: 281d5bd19cdbd57a036bd9985764271b8616e673b12c796a9832150bb8fa7a779f7e59d332aa877b4eefdce0f2332923b2a4c7e6487ef4b7df259e8ad23c8d74
+  metadata.gz: 795ef9d40b3652122d29c453e572e24d6c3ac363ff1f544d5fbfe806498233b3de445011b11ee5b8679c61796bedb5d69c68ff3e991f9db316e9bf4d01616104
+  data.tar.gz: 91a0072f7c15479c5a78cca91082a32d99b3018cca244e54a10685abad1da8ac11d06193fda4c2434cad69119775d55370b887a4e012fb670917e43fd4f3811d

data/config/default.yml

@@ -330,6 +330,13 @@ PreCommit:
     quiet: true
     branch_patterns: ['master']
 
+  GinkgoFocus:
+    enabled: false
+    description: 'Check for "focused" tests'
+    required_executable: 'grep'
+    flags: ['-IEHnw']
+    keywords: ['FContext','FDescribe','FIt','FMeasure','FSpecify','FWhen']
+
   GoLint:
     enabled: false
     description: 'Analyze with golint'
@@ -759,7 +766,7 @@ PreCommit:
   Stylelint:
     enabled: false
     description: 'Check styles with Stylelint'
-    require_executable: 'stylelint'
+    required_executable: 'stylelint'
     flags: ['-f', 'compact']
     install_command: 'npm install -g stylelint'
     include:

data/lib/overcommit/hook/pre_commit/ginkgo_focus.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Overcommit::Hook::PreCommit
+  # Check for "focused" tests
+  class GinkgoFocus < Base
+    def run
+      keywords = config['keywords']
+      result = execute(command, args: [keywords.join('|')] + applicable_files)
+
+      extract_messages(
+        result.stdout.split("\n"),
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/,
+        lambda { |_type| :warning }
+      )
+    end
+
+    def applicable_test_files
+      applicable_files.select do |f|
+        f if f =~ /_test\.go/
+      end
+    end
+  end
+end

data/lib/overcommit/hook_context/pre_commit.rb

@@ -15,6 +15,7 @@ module Overcommit::HookContext
       return @amendment unless @amendment.nil?
 
       cmd = Overcommit::Utils.parent_command
+      return unless cmd
       amend_pattern = 'commit(\s.*)?\s--amend(\s|$)'
 
       # Since the ps command can return invalid byte sequences for commands

data/lib/overcommit/utils.rb

@@ -133,7 +133,12 @@ module Overcommit
       end
 
       # Return the parent command that triggered this hook run
+      #
+      # @return [String,nil] the command as a string, if a parent exists.
       def parent_command
+        # When run in Docker containers, there may be no parent process.
+        return if Process.ppid.zero?
+
         if OS.windows?
           `wmic process where ProcessId=#{Process.ppid} get CommandLine /FORMAT:VALUE`.
             strip.

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.49.0'
+  VERSION = '0.49.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.49.0
+  version: 0.49.1
 platform: ruby
 authors:
 - Shane da Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-10 00:00:00.000000000 Z
+date: 2019-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -138,6 +138,7 @@ files:
 - lib/overcommit/hook/pre_commit/flay.rb
 - lib/overcommit/hook/pre_commit/foodcritic.rb
 - lib/overcommit/hook/pre_commit/forbidden_branches.rb
+- lib/overcommit/hook/pre_commit/ginkgo_focus.rb
 - lib/overcommit/hook/pre_commit/go_lint.rb
 - lib/overcommit/hook/pre_commit/go_vet.rb
 - lib/overcommit/hook/pre_commit/hadolint.rb