overcommit 0.35.0 → 0.36.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e016461ee6c3433ae240bf3146a4b2ebbcd3917f
-  data.tar.gz: 5dabc49a054dbb3bd35a133ae1d69bef8fe3f0cb
+  metadata.gz: 3b67aff142df04c21f3edc1e45cb5e8e71b0f613
+  data.tar.gz: 148dede395ec550657a9d3b7c4bb9fa661784b7e
 SHA512:
-  metadata.gz: 0e883bebdc91a518fca9afad6c731b92f25af2634cc5057d9e5aa3e9a9e4e60732c511374766b311ceda7c3c253efeadff50518f913fb117c3d280a7702e2a2c
-  data.tar.gz: 403d7632314359323d12f44a672e3a5c782eb6c65d8f8eab0b4d6ef0088a3c7a2fc7ef8b7265cce129277ce006c8b0c804fdb4175d5b4eb091a0409f51339748
+  metadata.gz: d9ec483cba901e73e9346682f6597f9d75dfc793bbabfc30a706cb04a633e2f33e20502d936478d34b834a53ea300402458adecee606d261dd55bf61838bc60f
+  data.tar.gz: 91ca7dd2c169bfc3ee5f464094d5decd186324bd765b7d7fd7a04f91a0335267eec065d7f21b1cf3756f64ff537d10c2dd26515d42dd9c027d77ef355ad8cf54

data/config/default.yml

@@ -247,6 +247,13 @@ PreCommit:
     description: 'Check for file execute permissions'
     quiet: true
 
+  Fasterer:
+    enabled: false
+    description: 'Analyzing for potential speed improvements'
+    required_executable: 'fasterer'
+    install_command: 'gem install fasterer'
+    include: '**/*.rb'
+
   ForbiddenBranches:
     enabled: false
     description: 'Check for commit to forbidden branch'
@@ -549,6 +556,14 @@ PreCommit:
     install_command: 'npm install -g standard'
     include: '**/*.js'
 
+  TsLint:
+      enabled: false
+      description: 'Analyze with TSLint'
+      required_executable: 'tslint'
+      install_command: 'npm install -g tslint typescript'
+      flags: ['--t=prose']
+      include: '**/*.ts'
+
   TrailingWhitespace:
     enabled: false
     description: 'Check for trailing whitespace'
@@ -855,6 +870,13 @@ PrePush:
     description: 'Run Test::Unit test suite'
     command: ['ruby', '-Ilib:test', '-rtest/unit', "-e 'exit! Test::Unit::AutoRunner.run'"]
 
+  Brakeman:
+    enabled: false
+    description: 'Check for security vulnerabilities'
+    required_executable: 'brakeman'
+    flags: ['--exit-on-warn', '--quiet', '--summary']
+    install_command: 'gem install brakeman'
+
 # Hooks that run during `git rebase`, before any commits are rebased.
 # If a hook fails, the rebase is aborted.
 PreRebase:

data/lib/overcommit/configuration_validator.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
 module Overcommit
   # Validates and normalizes a configuration.
   class ConfigurationValidator
@@ -16,6 +17,7 @@ module Overcommit
       hash = convert_nils_to_empty_hashes(hash)
       ensure_hook_type_sections_exist(hash)
       check_hook_name_format(hash)
+      check_hook_env(hash)
       check_for_missing_enabled_option(hash) unless @options[:default]
       check_for_too_many_processors(config, hash)
       check_for_verify_plugin_signatures_option(hash)
@@ -51,6 +53,42 @@ module Overcommit
       end
     end
 
+    def check_hook_env(hash)
+      errors = []
+
+      Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
+        hash.fetch(hook_type, {}).each do |hook_name, hook_config|
+          hook_env = hook_config.fetch('env', {})
+
+          unless hook_env.is_a?(Hash)
+            errors << "#{hook_type}::#{hook_name} has an invalid `env` specified: " \
+                      'must be a hash of environment variable name to string value.'
+            next
+          end
+
+          hook_env.each do |var_name, var_value|
+            if var_name.include?('=')
+              errors << "#{hook_type}::#{hook_name} has an invalid `env` specified: " \
+                        "variable name `#{var_name}` cannot contain `=`."
+            end
+
+            unless var_value.nil? || var_value.is_a?(String)
+              errors << "#{hook_type}::#{hook_name} has an invalid `env` specified: " \
+                        "value of `#{var_name}` must be a string or `nil`, but was " \
+                        "#{var_value.inspect} (#{var_value.class})"
+            end
+          end
+        end
+      end
+
+      if errors.any?
+        @log.error errors.join("\n") if @log
+        @log.newline if @log
+        raise Overcommit::Exceptions::ConfigurationError,
+              'One or more hooks had an invalid `env` configuration option'
+      end
+    end
+
     # Prints an error message and raises an exception if a hook has an
     # invalid name, since this can result in strange errors elsewhere.
     def check_hook_name_format(hash)

data/lib/overcommit/hook/pre_commit/fasterer.rb

@@ -0,0 +1,23 @@
+module Overcommit::Hook::PreCommit
+  # Runs `fasterer` against any modified Ruby files.
+  #
+  # @see https://github.com/DamirSvrtan/fasterer
+  class Fasterer < Base
+    def run
+      result = execute(command, args: applicable_files)
+      output = result.stdout
+
+      if extract_offense_num(output) == 0
+        :pass
+      else
+        return [:warn, output]
+      end
+    end
+
+    private
+
+    def extract_offense_num(raw_output)
+      raw_output.scan(/(\d+) offense detected/).flatten.map(&:to_i).inject(0, :+)
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/ts_lint.rb

@@ -0,0 +1,18 @@
+module Overcommit::Hook::PreCommit
+  # Runs `tslint` against modified TypeScript files.
+  # @see http://palantir.github.io/tslint/
+  class TsLint < Base
+    def run
+      result = execute(command, args: applicable_files)
+      output = result.stdout.chomp
+      return :pass if result.success? && output.empty?
+
+      # example message:
+      # src/file/anotherfile.ts[298, 1]: exceeds maximum line length of 140
+      extract_messages(
+          output.split("\n"),
+          /^(?<file>.+?(?=\[))[^\d]+(?<line>\d+).*?/
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_push/brakeman.rb

@@ -0,0 +1,13 @@
+module Overcommit::Hook::PrePush
+  # Runs `brakeman` whenever Ruby/Rails files change.
+  #
+  # @see http://brakemanscanner.org/
+  class Brakeman < Base
+    def run
+      result = execute(command)
+      return :pass if result.success?
+
+      [:fail, result.stdout]
+    end
+  end
+end

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.35.0'.freeze
+  VERSION = '0.36.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.36.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-09 00:00:00.000000000 Z
+date: 2016-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -116,6 +116,7 @@ files:
 - lib/overcommit/hook/pre_commit/dogma.rb
 - lib/overcommit/hook/pre_commit/es_lint.rb
 - lib/overcommit/hook/pre_commit/execute_permissions.rb
+- lib/overcommit/hook/pre_commit/fasterer.rb
 - lib/overcommit/hook/pre_commit/forbidden_branches.rb
 - lib/overcommit/hook/pre_commit/go_lint.rb
 - lib/overcommit/hook/pre_commit/go_vet.rb
@@ -156,6 +157,7 @@ files:
 - lib/overcommit/hook/pre_commit/standard.rb
 - lib/overcommit/hook/pre_commit/trailing_whitespace.rb
 - lib/overcommit/hook/pre_commit/travis_lint.rb
+- lib/overcommit/hook/pre_commit/ts_lint.rb
 - lib/overcommit/hook/pre_commit/vint.rb
 - lib/overcommit/hook/pre_commit/w3c_css.rb
 - lib/overcommit/hook/pre_commit/w3c_html.rb
@@ -163,6 +165,7 @@ files:
 - lib/overcommit/hook/pre_commit/xml_syntax.rb
 - lib/overcommit/hook/pre_commit/yaml_syntax.rb
 - lib/overcommit/hook/pre_push/base.rb
+- lib/overcommit/hook/pre_push/brakeman.rb
 - lib/overcommit/hook/pre_push/minitest.rb
 - lib/overcommit/hook/pre_push/protected_branches.rb
 - lib/overcommit/hook/pre_push/r_spec.rb