overcommit 0.34.2 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86cc1bfaf7e0821dd1e60ef45df97899608fcdf2
-  data.tar.gz: 01c697905ca074ece97b021c3e00413883b93f87
+  metadata.gz: e016461ee6c3433ae240bf3146a4b2ebbcd3917f
+  data.tar.gz: 5dabc49a054dbb3bd35a133ae1d69bef8fe3f0cb
 SHA512:
-  metadata.gz: a8c3fe3d46646d86c24c4628ab9d552e2f167090deebc8b5ce0abf21828e9013e3cf4cd82f1fac349e01677b6883ec2705939da4eaacb23fe4e72efc3b9f6682
-  data.tar.gz: d99729195dedd3ad2a7058c95f4fb6071886a151bf153cb8e724ba0784212a9cc06e7336266ecd9a91273e69f19a96d5f31bb74640465d8b8bd497bb87bf9fcf
+  metadata.gz: 0e883bebdc91a518fca9afad6c731b92f25af2634cc5057d9e5aa3e9a9e4e60732c511374766b311ceda7c3c253efeadff50518f913fb117c3d280a7702e2a2c
+  data.tar.gz: 403d7632314359323d12f44a672e3a5c782eb6c65d8f8eab0b4d6ef0088a3c7a2fc7ef8b7265cce129277ce006c8b0c804fdb4175d5b4eb091a0409f51339748

data/config/default.yml

@@ -114,6 +114,12 @@ CommitMsg:
     enabled: true
     description: 'Check for trailing periods in subject'
 
+  Commitplease:
+    enabled: false
+    description: 'Analyze with Commitplease'
+    required_executable: './node_modules/.bin/commitplease'
+    install_command: 'npm install --save-dev commitplease'
+
 # Hooks that are run after `git commit` is executed, before the commit message
 # editor is displayed. These hooks are ideal for syntax checkers, linters, and
 # other checks that you want to run before you allow a commit object to be
@@ -150,20 +156,17 @@ PreCommit:
       - 'Berksfile'
       - 'Berksfile.lock'
 
-  Brakeman:
-    enabled: false
-    description: 'Check for security vulnerabilities'
-    required_executable: 'brakeman'
-    flags: ['--exit-on-warn', '--quiet', '--summary', '--only-files']
-    install_command: 'gem install brakeman'
-    include:
-      - '**/*.rb'
-
   BrokenSymlinks:
     enabled: true
     description: 'Check for broken symlinks'
     quiet: true
 
+  BundleAudit:
+    enabled: false
+    description: 'Check for vulnerable versions of gems'
+    required_executable: 'bundle-audit'
+    install_command: 'gem install bundler-audit'
+
   BundleCheck:
     enabled: false
     description: 'Check Gemfile dependencies'
@@ -205,6 +208,15 @@ PreCommit:
     install_command: 'npm install -g coffeelint'
     include: '**/*.coffee'
 
+  Credo:
+    enabled: false
+    description: 'Analyze with credo'
+    required_executable: 'mix'
+    flags: ['credo', '--all', '--strict', '--format', 'flycheck']
+    include:
+      - '**/*.ex'
+      - '**/*.exs'
+
   CssLint:
     enabled: false
     description: 'Analyze with csslint'
@@ -838,6 +850,11 @@ PrePush:
     command: ['ruby', '-Ilib:test', '-rminitest', "-e 'exit! Minitest.run'"]
     include: 'test/**/*_test.rb'
 
+  TestUnit:
+    enabled: false
+    description: 'Run Test::Unit test suite'
+    command: ['ruby', '-Ilib:test', '-rtest/unit', "-e 'exit! Test::Unit::AutoRunner.run'"]
+
 # Hooks that run during `git rebase`, before any commits are rebased.
 # If a hook fails, the rebase is aborted.
 PreRebase:

data/lib/overcommit/hook/commit_msg/commitplease.rb

@@ -0,0 +1,14 @@
+module Overcommit::Hook::CommitMsg
+  # Check that a commit message conforms to a certain style
+  #
+  # @see https://www.npmjs.com/package/commitplease
+  class Commitplease < Base
+    def run
+      result = execute(command)
+      output = result.stderr
+      return :pass if result.success? && output.empty?
+
+      [:fail, output]
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/bundle_audit.rb

@@ -0,0 +1,21 @@
+module Overcommit::Hook::PreCommit
+  # Checks for vulnerable versions of gems in Gemfile.lock.
+  #
+  # @see https://github.com/rubysec/bundler-audit
+  class BundleAudit < Base
+    LOCK_FILE = 'Gemfile.lock'.freeze
+
+    def run
+      # Ignore if Gemfile.lock is not tracked by git
+      ignored_files = execute(%w[git ls-files -o -i --exclude-standard]).stdout.split("\n")
+      return :pass if ignored_files.include?(LOCK_FILE)
+
+      result = execute(command)
+      if result.success?
+        :pass
+      else
+        return [:warn, result.stdout]
+      end
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/credo.rb

@@ -0,0 +1,25 @@
+module Overcommit::Hook::PreCommit
+  # Runs `credo` against any modified ex files.
+  #
+  # @see https://github.com/rrrene/credo
+  class Credo < Base
+    # example message:
+    # lib/file1.ex:1:11: R: Modules should have a @moduledoc tag.
+    # lib/file2.ex:12:81: R: Line is too long (max is 80, was 81).
+
+    def run
+      result = execute command
+      return :pass if result.success?
+
+      result.stdout.split("\n").map(&:strip).reject(&:empty?).
+        map { |error| message(error) }
+    end
+
+    private
+
+    def message(error)
+      file, line = error.split(':')
+      Overcommit::Hook::Message.new(:error, file, Integer(line), error)
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/java_checkstyle.rb

@@ -3,18 +3,22 @@ module Overcommit::Hook::PreCommit
   #
   # @see http://checkstyle.sourceforge.net/
   class JavaCheckstyle < Base
-    MESSAGE_REGEX = /^(\[[^\]]+\]\s+)?(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
+    MESSAGE_REGEX = /^(\[(?<type>[^\]]+)\]\s+)?(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
+
+    MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      %w[WARN INFO].include?(type.to_s) ? :warning : :error
+    end
 
     def run
       result = execute(command, args: applicable_files)
       output = result.stdout.chomp
-      return :pass if result.success?
 
       # example message:
       #   path/to/file.java:3:5: Error message
       extract_messages(
         output.split("\n").grep(MESSAGE_REGEX),
-        MESSAGE_REGEX
+        MESSAGE_REGEX,
+        MESSAGE_TYPE_CATEGORIZER
       )
     end
   end

data/lib/overcommit/hook/pre_push/test_unit.rb

@@ -0,0 +1,14 @@
+module Overcommit::Hook::PrePush
+  # Runs `test-unit` test suite before push
+  #
+  # @see https://github.com/test-unit/test-unit
+  class TestUnit < Base
+    def run
+      result = execute(command)
+      return :pass if result.success?
+
+      output = result.stdout + result.stderr
+      [:fail, output]
+    end
+  end
+end

data/lib/overcommit/installer.rb

@@ -33,7 +33,7 @@ module Overcommit
       ensure_directory(hooks_path)
       preserve_old_hooks
       install_master_hook
-      install_hook_symlinks
+      install_hook_files
       install_starter_config
 
       log.success "Successfully installed hooks into #{@target}"
@@ -42,7 +42,7 @@ module Overcommit
     def uninstall
       log.log "Removing hooks from #{@target}"
 
-      uninstall_hook_symlinks
+      uninstall_hook_files
       uninstall_master_hook
       restore_old_hooks
 
@@ -54,7 +54,7 @@ module Overcommit
       unless FileUtils.compare_file(MASTER_HOOK, master_hook_install_path)
         preserve_old_hooks
         install_master_hook
-        install_hook_symlinks
+        install_hook_files
 
         log.success "Hooks updated to Overcommit version #{Overcommit::VERSION}"
         true
@@ -103,10 +103,8 @@ module Overcommit
       FileUtils.rm_rf(master_hook_install_path, secure: true)
     end
 
-    def install_hook_symlinks
-      # Link each hook type (pre-commit, commit-msg, etc.) to the master hook.
-      # We change directories so that the relative symlink paths work regardless
-      # of where the repository is located.
+    def install_hook_files
+      # Copy each hook type (pre-commit, commit-msg, etc.) from the master hook.
       Dir.chdir(hooks_path) do
         Overcommit::Utils.supported_hook_types.each do |hook_type|
           unless can_replace_file?(hook_type)
@@ -115,7 +113,7 @@ module Overcommit
                   'was not installed by Overcommit'
           end
           FileUtils.rm_f(hook_type)
-          Overcommit::Utils::FileUtils.symlink('overcommit-hook', hook_type)
+          FileUtils.cp('overcommit-hook', hook_type)
         end
       end
     end
@@ -158,7 +156,7 @@ module Overcommit
       log.success "Successfully restored old hooks from #{old_hooks_path}"
     end
 
-    def uninstall_hook_symlinks
+    def uninstall_hook_files
       return unless File.directory?(hooks_path)
 
       Dir.chdir(hooks_path) do
@@ -176,10 +174,7 @@ module Overcommit
     end
 
     def overcommit_hook?(file)
-      return true if File.read(file) =~ /OVERCOMMIT_DISABLE/
-      # TODO: Remove these checks once we hit version 1.0
-      Overcommit::Utils::FileUtils.symlink?(file) &&
-        Overcommit::Utils::FileUtils.readlink(file) == 'overcommit-hook'
+      File.read(file) =~ /OVERCOMMIT_DISABLE/
     rescue Errno::ENOENT
       # Some Ruby implementations (e.g. JRuby) raise an error when the file
       # doesn't exist. Standardize the behavior to return false.

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.34.2'.freeze
+  VERSION = '0.35.0'.freeze
 end

data/template-dir/hooks/commit-msg

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/overcommit-hook

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/post-checkout

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/post-commit

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/post-merge

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/post-rewrite

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/pre-commit

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/pre-push

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

data/template-dir/hooks/pre-rebase

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 # Entrypoint for Overcommit hook integration. Installing Overcommit will result
-# in all of your git hooks being symlinked to this file, allowing the framework
+# in all of your git hooks being copied from this file, allowing the framework
 # to manage your hooks for you.
 
 # Prevent a Ruby stack trace from appearing when we interrupt the hook.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.34.2
+  version: 0.35.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-27 00:00:00.000000000 Z
+date: 2016-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -65,6 +65,7 @@ files:
 - lib/overcommit/hook/base.rb
 - lib/overcommit/hook/commit_msg/base.rb
 - lib/overcommit/hook/commit_msg/capitalized_subject.rb
+- lib/overcommit/hook/commit_msg/commitplease.rb
 - lib/overcommit/hook/commit_msg/empty_message.rb
 - lib/overcommit/hook/commit_msg/gerrit_change_id.rb
 - lib/overcommit/hook/commit_msg/hard_tabs.rb
@@ -103,13 +104,14 @@ files:
 - lib/overcommit/hook/pre_commit/author_name.rb
 - lib/overcommit/hook/pre_commit/base.rb
 - lib/overcommit/hook/pre_commit/berksfile_check.rb
-- lib/overcommit/hook/pre_commit/brakeman.rb
 - lib/overcommit/hook/pre_commit/broken_symlinks.rb
+- lib/overcommit/hook/pre_commit/bundle_audit.rb
 - lib/overcommit/hook/pre_commit/bundle_check.rb
 - lib/overcommit/hook/pre_commit/bundle_outdated.rb
 - lib/overcommit/hook/pre_commit/case_conflicts.rb
 - lib/overcommit/hook/pre_commit/chamber_security.rb
 - lib/overcommit/hook/pre_commit/coffee_lint.rb
+- lib/overcommit/hook/pre_commit/credo.rb
 - lib/overcommit/hook/pre_commit/css_lint.rb
 - lib/overcommit/hook/pre_commit/dogma.rb
 - lib/overcommit/hook/pre_commit/es_lint.rb
@@ -164,6 +166,7 @@ files:
 - lib/overcommit/hook/pre_push/minitest.rb
 - lib/overcommit/hook/pre_push/protected_branches.rb
 - lib/overcommit/hook/pre_push/r_spec.rb
+- lib/overcommit/hook/pre_push/test_unit.rb
 - lib/overcommit/hook/pre_rebase/base.rb
 - lib/overcommit/hook/pre_rebase/merged_commits.rb
 - lib/overcommit/hook/shared/bower_install.rb
@@ -221,7 +224,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/overcommit/hook/pre_commit/brakeman.rb

@@ -1,13 +0,0 @@
-module Overcommit::Hook::PreCommit
-  # Runs `brakeman` against any modified Ruby/Rails files.
-  #
-  # @see http://brakemanscanner.org/
-  class Brakeman < Base
-    def run
-      result = execute(command + [applicable_files.join(',')])
-      return :pass if result.success?
-
-      [:fail, result.stdout]
-    end
-  end
-end