overcommit 0.32.0.rc1 → 0.32.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b45a46c1290a6ddd0fd418f28012e7138f01470e
-  data.tar.gz: 1443470dae06fb17b84fe99823d8e2c655bdb792
+  metadata.gz: e0c2c570d206163b748a1aefa226cacfbe1987a6
+  data.tar.gz: fd391b54a75ca207031562fc896d2dfa57494088
 SHA512:
-  metadata.gz: 133dc22840e178a2473670780a385fb0b4c46a48d175c5ab7ad391eccfb0fc1517a1f4318f8ad91e1ef53ca40cd2925d3e3912fb203b91e8aeeb8a9285892df1
-  data.tar.gz: 0847b5f3045de5b413be8704a76fbd6fdef908a34e11b64414a58628eadc3f961d77efa1e2257ef0a7b77b6e861b2496a1ec97f5752a02cbe1f9a17fe1cd1adb
+  metadata.gz: df5aecb87481a132a0fc6b0d5ee0ac651a9ca74ba962a0563fc66b5a5583d19aad33293e25bd71626aecbdfe186d7af0e2be1bbda440c8ec2ffc5b5c4507dc8e
+  data.tar.gz: d2eb883b0d1bb0bfd0a4b970150e466eb5a5fe5631d49d876b8c9b751463120efb99a9c788c2079b6907679dbc778b6ab780fed382c14d510df702ee406988da

data/config/default.yml

@@ -62,46 +62,53 @@ CommitMsg:
 
   CapitalizedSubject:
     enabled: true
-    description: 'Checking subject capitalization'
+    description: 'Check subject capitalization'
 
   EmptyMessage:
     enabled: true
-    description: 'Checking for empty commit message'
+    description: 'Check for empty commit message'
     quiet: true
 
   GerritChangeId:
     enabled: false
-    description: 'Ensuring Gerrit Change-Id is present'
+    description: 'Ensure Gerrit Change-Id is present'
     required: true
 
   HardTabs:
     enabled: false
-    description: 'Checking for hard tabs'
+    description: 'Check for hard tabs'
+
+  MessageFormat:
+    enabled: false
+    description: 'Check commit message matches expected pattern'
+    pattern: '(.+)[|](.+)[|](.+)'
+    expected_pattern_message: '<Issue Id> | <Commit Message Description> | <Developer(s)>'
+    sample_message: 'DEFECT-1234 | Refactored Onboarding flow | John Doe'
 
   RussianNovel:
     enabled: false
-    description: 'Checking length of commit message'
+    description: 'Check length of commit message'
     quiet: true
 
   SingleLineSubject:
     enabled: true
-    description: 'Checking subject line'
+    description: 'Check subject line'
 
   SpellCheck:
     enabled: false
-    description: 'Checking for misspelled words'
+    description: 'Check for misspelled words'
     required_executable: 'hunspell'
     flags: ['-a']
 
   TextWidth:
     enabled: true
-    description: 'Checking text width'
+    description: 'Check text width'
     max_subject_width: 60
     max_body_width: 72
 
   TrailingPeriod:
     enabled: true
-    description: 'Checking for trailing periods in subject'
+    description: 'Check for trailing periods in subject'
 
 # Hooks that are run after `git commit` is executed, before the commit message
 # editor is displayed. These hooks are ideal for syntax checkers, linters, and
@@ -116,7 +123,7 @@ PreCommit:
 
   AuthorEmail:
     enabled: true
-    description: 'Checking author email'
+    description: 'Check author email'
     requires_files: false
     required: true
     quiet: true
@@ -124,14 +131,14 @@ PreCommit:
 
   AuthorName:
     enabled: true
-    description: 'Checking for author name'
+    description: 'Check for author name'
     requires_files: false
     required: true
     quiet: true
 
   BerksfileCheck:
     enabled: false
-    description: 'Checking Berksfile lock'
+    description: 'Check Berksfile lock'
     required_executable: 'berks'
     flags: ['list', '--quiet']
     install_command: 'gem install berks'
@@ -141,7 +148,7 @@ PreCommit:
 
   Brakeman:
     enabled: false
-    description: 'Checking for security vulnerabilities'
+    description: 'Check for security vulnerabilities'
     required_executable: 'brakeman'
     flags: ['--exit-on-warn', '--quiet', '--summary', '--only-files']
     install_command: 'gem install brakeman'
@@ -150,12 +157,12 @@ PreCommit:
 
   BrokenSymlinks:
     enabled: true
-    description: 'Checking for broken symlinks'
+    description: 'Check for broken symlinks'
     quiet: true
 
   BundleCheck:
     enabled: false
-    description: 'Checking Gemfile dependencies'
+    description: 'Check Gemfile dependencies'
     required_executable: 'bundle'
     flags: ['check']
     install_command: 'gem install bundler'
@@ -166,12 +173,12 @@ PreCommit:
 
   CaseConflicts:
     enabled: true
-    description: 'Checking for case-insensitivity conflicts'
+    description: 'Check for case-insensitivity conflicts'
     quiet: true
 
   ChamberSecurity:
     enabled: false
-    description: 'Checking that settings have been secured with Chamber'
+    description: 'Check that settings have been secured with Chamber'
     required_executable: 'chamber'
     flags: ['secure', '--files']
     install_command: 'gem install chamber'
@@ -181,7 +188,7 @@ PreCommit:
 
   CoffeeLint:
     enabled: false
-    description: 'Analyzing with coffeelint'
+    description: 'Analyze with coffeelint'
     required_executable: 'coffeelint'
     flags: ['--reporter=csv']
     install_command: 'npm install -g coffeelint'
@@ -189,7 +196,7 @@ PreCommit:
 
   CssLint:
     enabled: false
-    description: 'Analyzing with csslint'
+    description: 'Analyze with csslint'
     required_executable: 'csslint'
     flags: ['--quiet', '--format=compact']
     install_command: 'npm install -g csslint'
@@ -197,7 +204,7 @@ PreCommit:
 
   Dogma:
     enabled: false
-    description: 'Analyzing with dogma'
+    description: 'Analyze with dogma'
     required_executable: 'mix'
     flags: ['dogma']
     include:
@@ -206,7 +213,7 @@ PreCommit:
 
   EsLint:
     enabled: false
-    description: 'Analyzing with ESLint'
+    description: 'Analyze with ESLint'
     required_executable: 'eslint'
     flags: ['--format=compact']
     install_command: 'npm install -g eslint'
@@ -214,19 +221,25 @@ PreCommit:
 
   ExecutePermissions:
     enabled: false
-    description: 'Checking for file execute permissions'
+    description: 'Check for file execute permissions'
+    quiet: true
+
+  ForbiddenBranches:
+    enabled: false
+    description: 'Check for commit to forbidden branch'
     quiet: true
+    branch_patterns: ['master']
 
   GoLint:
     enabled: false
-    description: 'Analyzing with golint'
+    description: 'Analyze with golint'
     required_executable: 'golint'
     install_command: 'go get github.com/golang/lint/golint'
     include: '**/*.go'
 
   GoVet:
     enabled: false
-    description: 'Analyzing with go vet'
+    description: 'Analyze with go vet'
     required_executable: 'go'
     flags: ['tool', 'vet']
     install_command: 'go get golang.org/x/tools/cmd/vet'
@@ -234,42 +247,42 @@ PreCommit:
 
   HamlLint:
     enabled: false
-    description: 'Analyzing with haml-lint'
+    description: 'Analyze with haml-lint'
     required_executable: 'haml-lint'
     install_command: 'gem install haml-lint'
     include: '**/*.haml'
 
   HardTabs:
     enabled: false
-    description: 'Checking for hard tabs'
+    description: 'Check for hard tabs'
     quiet: true
     required_executable: 'grep'
     flags: ['-IHn', "\t"]
 
   Hlint:
     enabled: false
-    description: 'Analyzing with hlint'
+    description: 'Analyze with hlint'
     required_executable: 'hlint'
     install_command: 'cabal install hlint'
     include: '**/*.hs'
 
   HtmlHint:
     enabled: false
-    description: 'Analyzing with HTMLHint'
+    description: 'Analyze with HTMLHint'
     required_executable: 'htmlhint'
     install_command: 'npm install -g htmlhint'
     include: '**/*.html'
 
   HtmlTidy:
     enabled: false
-    description: 'Analyzing HTML with tidy'
+    description: 'Analyze HTML with tidy'
     required_executable: 'tidy'
     flags: ['-errors', '-quiet', '-utf8']
     include: '**/*.html'
 
   ImageOptim:
     enabled: false
-    description: 'Checking for optimizable images'
+    description: 'Check for optimizable images'
     required_executable: 'image_optim'
     install_command: 'gem install image_optim'
     include:
@@ -281,14 +294,14 @@ PreCommit:
 
   JavaCheckstyle:
     enabled: false
-    description: 'Analyzing with checkstyle'
+    description: 'Analyze with checkstyle'
     required_executable: 'checkstyle'
     flags: ['-c', '/sun_checks.xml']
     include: '**/*.java'
 
   Jscs:
     enabled: false
-    description: 'Analyzing with JSCS'
+    description: 'Analyze with JSCS'
     required_executable: 'jscs'
     flags: ['--reporter=inline', '--verbose']
     install_command: 'npm install -g jscs'
@@ -296,7 +309,7 @@ PreCommit:
 
   JsHint:
     enabled: false
-    description: 'Analyzing with JSHint'
+    description: 'Analyze with JSHint'
     required_executable: 'jshint'
     flags: ['--verbose']
     install_command: 'npm install -g jshint'
@@ -304,7 +317,7 @@ PreCommit:
 
   JsLint:
     enabled: false
-    description: 'Analyzing with JSLint'
+    description: 'Analyze with JSLint'
     required_executable: 'jslint'
     flags: ['--terse']
     install_command: 'npm install -g jslint'
@@ -312,63 +325,63 @@ PreCommit:
 
   Jsl:
     enabled: false
-    description: 'Analyzing with JSL'
+    description: 'Analyze with JSL'
     required_executable: 'jsl'
     flags: ['-nologo', '-nofilelisting', '-nocontext', '-nosummary']
     include: '**/*.js'
 
   JsonSyntax:
     enabled: false
-    description: 'Validating JSON syntax'
+    description: 'Validate JSON syntax'
     required_library: 'json'
     install_command: 'gem install json'
     include: '**/*.json'
 
   LocalPathsInGemfile:
     enabled: false
-    description: 'Checking for local paths in Gemfile'
+    description: 'Check for local paths in Gemfile'
     required_executable: 'grep'
     flags: ['-IHnE', "^[^#]*((\\bpath:)|(:path[ \t]*=>))"]
     include: '**/Gemfile'
 
   Mdl:
     enabled: false
-    description: 'Analyzing with mdl'
+    description: 'Analyze with mdl'
     required_executable: 'mdl'
     install_command: 'gem install mdl'
     include: '**/*.md'
 
   MergeConflicts:
     enabled: true
-    description: 'Checking for merge conflicts'
+    description: 'Check for merge conflicts'
     quiet: true
     required_executable: 'grep'
     flags: ['-IHn', "^<<<<<<<[ \t]"]
 
   NginxTest:
     enabled: false
-    description: 'Testing nginx configs'
+    description: 'Test nginx configs'
     required_executable: 'nginx'
     flags: ['-t']
     include: '**/nginx.conf'
 
   Pep257:
     enabled: false
-    description: 'Analyzing docstrings with pep257'
+    description: 'Analyze docstrings with pep257'
     required_executable: 'pep257'
     install_command: 'pip install pep257'
     include: '**/*.py'
 
   Pep8:
     enabled: false
-    description: 'Analyzing with pep8'
+    description: 'Analyze with pep8'
     required_executable: 'pep8'
     install_command: 'pip install pep8'
     include: '**/*.py'
 
   PuppetLint:
     enabled: false
-    description: 'Analyzing with puppet-lint'
+    description: 'Analyze with puppet-lint'
     required_executable: 'puppet-lint'
     install_command: 'gem install puppet-lint'
     flags:
@@ -379,14 +392,14 @@ PreCommit:
 
   Pyflakes:
     enabled: false
-    description: 'Analyzing with pyflakes'
+    description: 'Analyze with pyflakes'
     required_executable: 'pyflakes'
     install_command: 'pip install pyflakes'
     include: '**/*.py'
 
   Pylint:
     enabled: false
-    description: 'Analyzing with Pylint'
+    description: 'Analyze with Pylint'
     required_executable: 'pylint'
     install_command: 'pip install pylint'
     flags:
@@ -397,21 +410,21 @@ PreCommit:
 
   PythonFlake8:
     enabled: false
-    description: 'Analyzing with flake8'
+    description: 'Analyze with flake8'
     required_executable: 'flake8'
     install_command: 'pip install flake8'
     include: '**/*.py'
 
   RailsBestPractices:
     enabled: false
-    description: 'Analyzing with RailsBestPractices'
+    description: 'Analyze with RailsBestPractices'
     required_executable: 'rails_best_practices'
     flags: ['--without-color']
     install_command: 'gem install rails_best_practices'
 
   RailsSchemaUpToDate:
     enabled: false
-    description: 'Checking if database schema is up to date'
+    description: 'Check if database schema is up to date'
     include:
       - 'db/migrate/*.rb'
       - 'db/schema.rb'
@@ -419,7 +432,7 @@ PreCommit:
 
   Reek:
     enabled: false
-    description: 'Analyzing with Reek'
+    description: 'Analyze with Reek'
     required_executable: 'reek'
     flags: ['--single-line', '--no-color']
     install_command: 'gem install reek'
@@ -432,7 +445,7 @@ PreCommit:
 
   RuboCop:
     enabled: false
-    description: 'Analyzing with RuboCop'
+    description: 'Analyze with RuboCop'
     required_executable: 'rubocop'
     flags: ['--format=emacs', '--force-exclusion', '--display-cop-names']
     install_command: 'gem install rubocop'
@@ -445,7 +458,7 @@ PreCommit:
 
   RubyLint:
     enabled: false
-    description: 'Analyzing with ruby-lint'
+    description: 'Analyze with ruby-lint'
     required_executable: 'ruby-lint'
     flags: ['--presenter=syntastic', '--levels=error,warning']
     install_command: 'gem install ruby-lint'
@@ -455,27 +468,29 @@ PreCommit:
 
   Scalariform:
     enabled: false
-    description: 'Checking formatting with Scalariform'
+    description: 'Check formatting with Scalariform'
     required_executable: 'scalariform'
     flags: ['--test']
     include: '**/*.scala'
 
   Scalastyle:
     enabled: false
-    description: 'Analyzing with Scalastyle'
+    description: 'Analyze with Scalastyle'
     required_executable: 'scalastyle'
     include: '**/*.scala'
 
   ScssLint:
     enabled: false
-    description: 'Analyzing with scss-lint'
+    description: 'Analyze with scss-lint'
+    required_library: 'json'
     required_executable: 'scss-lint'
+    flags: ['--format', 'JSON']
     install_command: 'gem install scss-lint'
     include: '**/*.scss'
 
   SemiStandard:
     enabled: false
-    description: 'Analyzing with semistandard'
+    description: 'Analyze with semistandard'
     required_executable: 'semistandard'
     flags: ['--verbose']
     install_command: 'npm install -g semistandard'
@@ -483,28 +498,28 @@ PreCommit:
 
   ShellCheck:
     enabled: false
-    description: 'Analyzing with ShellCheck'
+    description: 'Analyze with ShellCheck'
     required_executable: 'shellcheck'
     flags: ['--format=gcc']
     include: '**/*.sh'
 
   SlimLint:
     enabled: false
-    description: 'Analyzing with slim-lint'
+    description: 'Analyze with slim-lint'
     required_executable: 'slim-lint'
     install_command: 'gem install slim_lint'
     include: '**/*.slim'
 
   Sqlint:
     enabled: false
-    description: 'Analyzing with sqlint'
+    description: 'Analyze with sqlint'
     required_executable: 'sqlint'
     install_command: 'gem install sqlint'
     include: '**/*.sql'
 
   Standard:
     enabled: false
-    description: 'Analyzing with standard'
+    description: 'Analyze with standard'
     required_executable: 'standard'
     flags: ['--verbose']
     install_command: 'npm install -g standard'
@@ -512,13 +527,13 @@ PreCommit:
 
   TrailingWhitespace:
     enabled: false
-    description: 'Checking for trailing whitespace'
+    description: 'Check for trailing whitespace'
     required_executable: 'grep'
     flags: ['-IHn', "[ \t]$"]
 
   TravisLint:
     enabled: false
-    description: 'Checking Travis CI configuration'
+    description: 'Check Travis CI configuration'
     required_executable: 'travis'
     flags: ['lint']
     install_command: 'gem install travis'
@@ -526,7 +541,7 @@ PreCommit:
 
   Vint:
     enabled: false
-    description: 'Analyzing with Vint'
+    description: 'Analyze with Vint'
     required_executable: 'vint'
     install_command: 'pip install vim-vint'
     include:
@@ -535,7 +550,7 @@ PreCommit:
 
   W3cCss:
     enabled: false
-    description: 'Analyzing with W3C CSS validation service'
+    description: 'Analyze with W3C CSS validation service'
     required_library: 'w3c_validators'
     install_command: 'gem install w3c_validators'
     validator_uri: 'http://jigsaw.w3.org/css-validator/validator'
@@ -547,7 +562,7 @@ PreCommit:
 
   W3cHtml:
     enabled: false
-    description: 'Analyzing with W3C HTML validation service'
+    description: 'Analyze with W3C HTML validation service'
     required_library: 'w3c_validators'
     install_command: 'gem install w3c_validators'
     validator_uri: 'http://validator.w3.org/check'
@@ -558,7 +573,7 @@ PreCommit:
 
   XmlLint:
     enabled: false
-    description: 'Analyzing with xmllint'
+    description: 'Analyze with xmllint'
     required_executable: 'xmllint'
     flags: ['--noout']
     include:
@@ -567,7 +582,7 @@ PreCommit:
 
   XmlSyntax:
     enabled: false
-    description: 'Checking XML syntax'
+    description: 'Check XML syntax'
     required_library: 'rexml/document'
     include:
       - '**/*.xml'
@@ -575,7 +590,7 @@ PreCommit:
 
   YamlSyntax:
     enabled: false
-    description: 'Checking YAML syntax'
+    description: 'Check YAML syntax'
     required_library: 'yaml'
     include:
       - '**/*.yaml'
@@ -589,7 +604,7 @@ PostCheckout:
 
   BowerInstall:
     enabled: false
-    description: 'Installing bower dependencies'
+    description: 'Install bower dependencies'
     requires_files: true
     required_executable: 'bower'
     install_command: 'npm install -g bower'
@@ -598,7 +613,7 @@ PostCheckout:
 
   BundleInstall:
     enabled: false
-    description: 'Installing Bundler dependencies'
+    description: 'Install Bundler dependencies'
     requires_files: true
     required_executable: 'bundle'
     install_command: 'gem install bundler'
@@ -610,13 +625,13 @@ PostCheckout:
 
   IndexTags:
     enabled: false
-    description: 'Generating tags file from source'
+    description: 'Generate tags file from source'
     quiet: true
     required_executable: 'ctags'
 
   NpmInstall:
     enabled: false
-    description: 'Installing NPM dependencies'
+    description: 'Install NPM dependencies'
     requires_files: true
     required_executable: 'npm'
     flags: ['install']
@@ -626,7 +641,7 @@ PostCheckout:
 
   SubmoduleStatus:
     enabled: false
-    description: 'Checking submodule status'
+    description: 'Check submodule status'
     quiet: true
     recursive: false
 
@@ -639,7 +654,7 @@ PostCommit:
 
   BowerInstall:
     enabled: false
-    description: 'Installing bower dependencies'
+    description: 'Install bower dependencies'
     requires_files: true
     required_executable: 'bower'
     install_command: 'npm install -g bower'
@@ -648,7 +663,7 @@ PostCommit:
 
   BundleInstall:
     enabled: false
-    description: 'Installing Bundler dependencies'
+    description: 'Install Bundler dependencies'
     requires_files: true
     required_executable: 'bundle'
     install_command: 'gem install bundler'
@@ -660,7 +675,7 @@ PostCommit:
 
   GitGuilt:
     enabled: false
-    description: 'Calculating changes in blame since last commit'
+    description: 'Calculate changes in blame since last commit'
     requires_files: true
     required_executable: 'git-guilt'
     flags: ['HEAD~', 'HEAD']
@@ -668,13 +683,13 @@ PostCommit:
 
   IndexTags:
     enabled: false
-    description: 'Generating tags file from source'
+    description: 'Generate tags file from source'
     quiet: true
     required_executable: 'ctags'
 
   NpmInstall:
     enabled: false
-    description: 'Installing NPM dependencies'
+    description: 'Install NPM dependencies'
     requires_files: true
     required_executable: 'npm'
     flags: ['install']
@@ -684,7 +699,7 @@ PostCommit:
 
   SubmoduleStatus:
     enabled: false
-    description: 'Checking submodule status'
+    description: 'Check submodule status'
     quiet: true
     recursive: false
 
@@ -696,7 +711,7 @@ PostMerge:
 
   BowerInstall:
     enabled: false
-    description: 'Installing bower dependencies'
+    description: 'Install bower dependencies'
     requires_files: true
     required_executable: 'bower'
     install_command: 'npm install -g bower'
@@ -705,7 +720,7 @@ PostMerge:
 
   BundleInstall:
     enabled: false
-    description: 'Installing Bundler dependencies'
+    description: 'Install Bundler dependencies'
     requires_files: true
     required_executable: 'bundle'
     install_command: 'gem install bundler'
@@ -717,13 +732,13 @@ PostMerge:
 
   IndexTags:
     enabled: false
-    description: 'Generating tags file from source'
+    description: 'Generate tags file from source'
     quiet: true
     required_executable: 'ctags'
 
   NpmInstall:
     enabled: false
-    description: 'Installing NPM dependencies'
+    description: 'Install NPM dependencies'
     requires_files: true
     required_executable: 'npm'
     flags: ['install']
@@ -733,7 +748,7 @@ PostMerge:
 
   SubmoduleStatus:
     enabled: false
-    description: 'Checking submodule status'
+    description: 'Check submodule status'
     quiet: true
     recursive: false
 
@@ -745,7 +760,7 @@ PostRewrite:
 
   BowerInstall:
     enabled: false
-    description: 'Installing bower dependencies'
+    description: 'Install bower dependencies'
     requires_files: true
     required_executable: 'bower'
     install_command: 'npm install -g bower'
@@ -754,7 +769,7 @@ PostRewrite:
 
   BundleInstall:
     enabled: false
-    description: 'Installing Bundler dependencies'
+    description: 'Install Bundler dependencies'
     requires_files: true
     required_executable: 'bundle'
     install_command: 'gem install bundler'
@@ -766,13 +781,13 @@ PostRewrite:
 
   IndexTags:
     enabled: false
-    description: 'Generating tags file from source'
+    description: 'Generate tags file from source'
     quiet: true
     required_executable: 'ctags'
 
   NpmInstall:
     enabled: false
-    description: 'Installing NPM dependencies'
+    description: 'Install NPM dependencies'
     requires_files: true
     required_executable: 'npm'
     flags: ['install']
@@ -782,7 +797,7 @@ PostRewrite:
 
   SubmoduleStatus:
     enabled: false
-    description: 'Checking submodule status'
+    description: 'Check submodule status'
     quiet: true
     recursive: false
 
@@ -796,19 +811,19 @@ PrePush:
 
   ProtectedBranches:
     enabled: false
-    description: 'Checking for illegal pushes to protected branches'
+    description: 'Check for illegal pushes to protected branches'
     branches: ['master']
 
   RSpec:
     enabled: false
-    description: 'Running RSpec test suite'
+    description: 'Run RSpec test suite'
     required_executable: 'rspec'
 
   Minitest:
     enabled: false
-    description: 'Running Minitest test suite'
-    command: ['ruby', '-Ilib:test', 'test']
-    required_library: 'minitest'
+    description: 'Run Minitest test suite'
+    command: ['ruby', '-Ilib:test', '-rminitest', "-e 'exit! Minitest.run'"]
+    include: 'test/**/*_test.rb'
 
 # Hooks that run during `git rebase`, before any commits are rebased.
 # If a hook fails, the rebase is aborted.
@@ -820,5 +835,5 @@ PreRebase:
 
   MergedCommits:
     enabled: false
-    description: 'Checking for commits that have already been merged'
+    description: 'Check for commits that have already been merged'
     branches: ['master']

data/lib/overcommit/exceptions.rb

@@ -42,6 +42,9 @@ module Overcommit::Exceptions
   # Raised when one or more hook plugin signatures have changed.
   class InvalidHookSignature < StandardError; end
 
+  # Raised when there is a problem processing output into {Hook::Messages}s.
+  class MessageProcessingError < StandardError; end
+
   # Raised when an installation target already contains non-Overcommit hooks.
   class PreExistingHooks < StandardError; end
 end

data/lib/overcommit/git_repo.rb

@@ -266,5 +266,11 @@ module Overcommit
         split(/\s+/).
         reject { |s| s.empty? || s == '*' }
     end
+
+    # Returns the name of the currently checked out branch.
+    # @return [String]
+    def current_branch
+      `git symbolic-ref --short -q HEAD`.chomp
+    end
   end
 end

data/lib/overcommit/hook/base.rb

@@ -17,7 +17,7 @@ module Overcommit::Hook
   class Base # rubocop:disable Metrics/ClassLength
     extend Forwardable
 
-    def_delegators :@context, :modified_files
+    def_delegators :@context, :all_files, :modified_files
     attr_reader :config
 
     # @param config [Overcommit::Configuration]
@@ -54,7 +54,7 @@ module Overcommit::Hook
     end
 
     def description
-      @config['description'] || "Running #{name}"
+      @config['description'] || "Run #{name}"
     end
 
     def required?
@@ -155,11 +155,21 @@ module Overcommit::Hook
     # Gets a list of staged files that apply to this hook based on its
     # configured `include` and `exclude` lists.
     def applicable_files
-      @applicable_files ||= modified_files.select { |file| applicable_file?(file) }.sort
+      @applicable_files ||= select_applicable(modified_files)
+    end
+
+    # Gets a list of all files that apply to this hook based on its
+    # configured `include` and `exclude` lists.
+    def included_files
+      @included_files ||= select_applicable(all_files)
     end
 
     private
 
+    def select_applicable(list)
+      list.select { |file| applicable_file?(file) }.sort
+    end
+
     def applicable_file?(file)
       includes = Array(@config['include']).flatten.map do |glob|
         Overcommit::Utils.convert_glob_to_absolute(glob)

data/lib/overcommit/hook/commit_msg/message_format.rb

@@ -0,0 +1,27 @@
+module Overcommit::Hook::CommitMsg
+  # Ensures the commit message follows a specific format.
+  class MessageFormat < Base
+    def run
+      error_msg = validate_pattern(commit_message_lines.join("\n"))
+      return :fail, error_msg if error_msg
+
+      :pass
+    end
+
+    private
+
+    def validate_pattern(message)
+      pattern = config['pattern']
+      return if pattern.empty?
+
+      expected_pattern_message = config['expected_pattern_message']
+      sample_message = config['sample_message']
+
+      [
+        'Commit message pattern mismatch.',
+        "Expected : #{expected_pattern_message}",
+        "Sample : #{sample_message}"
+      ].join("\n") unless message =~ /#{pattern}/
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/base.rb

@@ -22,13 +22,16 @@ module Overcommit::Hook::PreCommit
     # @param type_categorizer [Proc] function executed against the `type`
     #   capture group to convert it to a `:warning` or `:error` symbol. Assumes
     #   `:error` if `nil`.
-    # @raise [RuntimeError] line of output did not match regex
+    # @raise [Overcommit::Exceptions::MessageProcessingError] line of output did
+    #   not match regex
     # @return [Array<Message>]
     def extract_messages(output_messages, regex, type_categorizer = nil)
-      output_messages.map do |message|
+      output_messages.map.with_index do |message, index|
         unless match = message.match(regex)
-          raise 'Unexpected output: unable to determine line number or type ' \
-                "of error/warning for message '#{message}'"
+          raise Overcommit::Exceptions::MessageProcessingError,
+                'Unexpected output: unable to determine line number or type ' \
+                "of error/warning for output:\n" \
+                "#{output_messages[index..-1].join("\n")}"
         end
 
         file = extract_file(match, message)
@@ -43,7 +46,8 @@ module Overcommit::Hook::PreCommit
       return unless match.names.include?('file')
 
       if match[:file].to_s.empty?
-        raise "Unexpected output: no file found in '#{message}'"
+        raise Overcommit::Exceptions::MessageProcessingError,
+              "Unexpected output: no file found in '#{message}'"
       end
 
       match[:file]
@@ -53,7 +57,8 @@ module Overcommit::Hook::PreCommit
       return unless match.names.include?('line')
       Integer(match[:line])
     rescue ArgumentError, TypeError
-      raise "Unexpected output: invalid line number found in '#{message}'"
+      raise Overcommit::Exceptions::MessageProcessingError,
+            "Unexpected output: invalid line number found in '#{message}'"
     end
 
     def extract_type(match, message, type_categorizer)
@@ -61,7 +66,8 @@ module Overcommit::Hook::PreCommit
         type_match = match.names.include?('type') ? match[:type] : nil
         type = type_categorizer.call(type_match)
         unless Overcommit::Hook::MESSAGE_TYPES.include?(type)
-          raise "Invalid message type '#{type}' for '#{message}': must " \
+          raise Overcommit::Exceptions::MessageProcessingError,
+                "Invalid message type '#{type}' for '#{message}': must " \
                 "be one of #{Overcommit::Hook::MESSAGE_TYPES.inspect}"
         end
         type

data/lib/overcommit/hook/pre_commit/es_lint.rb

@@ -1,6 +1,16 @@
 module Overcommit::Hook::PreCommit
   # Runs `eslint` against any modified JavaScript files.
   #
+  # Protip: if you have an npm script set up to run eslint, you can configure
+  # this hook to run eslint via your npm script by using the `command` option in
+  # your .overcommit.yml file. This can be useful if you have some eslint
+  # configuration built into your npm script that you don't want to repeat
+  # somewhere else. Example:
+  #
+  #   EsLint:
+  #     enabled: true
+  #     command: ['npm', 'run', 'lint']
+  #
   # @see http://eslint.org/
   class EsLint < Base
     def run

data/lib/overcommit/hook/pre_commit/execute_permissions.rb

@@ -2,6 +2,16 @@ module Overcommit::Hook::PreCommit
   # Checks for files with execute permissions, which are usually not necessary
   # in source code files (and are typically caused by a misconfigured editor
   # assigning incorrect default permissions).
+  #
+  # Protip: if you have some files that you want to allow execute permissions
+  # on, you can disable this hook for those files by using the `exclude` option
+  # on your .overcommit.yml file. Example:
+  #
+  #   ExecutePermissions:
+  #     enabled: true
+  #     exclude:
+  #       - 'path/to/my/file/that/should/have/execute/permissions.sh'
+  #       - 'directory/that/should/have/execute/permissions/**/*'
   class ExecutePermissions < Base
     def run
       file_modes = {}

data/lib/overcommit/hook/pre_commit/forbidden_branches.rb

@@ -0,0 +1,24 @@
+module Overcommit::Hook::PreCommit
+  # Prevents commits to branches matching one of the configured patterns.
+  class ForbiddenBranches < Base
+    def run
+      return :pass unless forbidden_commit?
+
+      [:fail, "Committing to #{current_branch} is forbidden"]
+    end
+
+    private
+
+    def forbidden_commit?
+      forbidden_branch_patterns.any? { |p| File.fnmatch(p, current_branch) }
+    end
+
+    def forbidden_branch_patterns
+      @forbidden_branch_patterns ||= Array(config['branch_patterns'])
+    end
+
+    def current_branch
+      @current_branch ||= Overcommit::GitRepo.current_branch
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/scss_lint.rb

@@ -3,10 +3,6 @@ module Overcommit::Hook::PreCommit
   #
   # @see https://github.com/brigade/scss-lint
   class ScssLint < Base
-    MESSAGE_TYPE_CATEGORIZER = lambda do |type|
-      type.include?('W') ? :warning : :error
-    end
-
     def run
       result = execute(command, args: applicable_files)
 
@@ -16,13 +12,30 @@ module Overcommit::Hook::PreCommit
       return :pass if [0, 81].include?(result.status)
 
       # Any status that isn't indicating lint warnings or errors indicates failure
-      return :fail, result.stdout unless [1, 2].include?(result.status)
+      return :fail, (result.stdout + result.stderr) unless [1, 2].include?(result.status)
+
+      begin
+        collect_lint_messages(JSON.parse(result.stdout))
+      rescue JSON::ParserError => ex
+        return :fail, "Unable to parse JSON returned by SCSS-Lint: #{ex.message}\n" \
+                      "STDOUT: #{result.stdout}\nSTDERR: #{result.stderr}"
+      end
+    end
+
+    private
+
+    def collect_lint_messages(files_to_lints)
+      files_to_lints.flat_map do |path, lints|
+        lints.map do |lint|
+          severity = lint['severity'] == 'warning' ? :warning : :error
+
+          message = lint['reason']
+          message = "#{lint['linter']}: #{message}" if lint['linter']
+          message = "#{path}:#{lint['line']} #{message}"
 
-      extract_messages(
-        result.stdout.split("\n"),
-        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)[^ ]* (?<type>[^ ]+)/,
-        MESSAGE_TYPE_CATEGORIZER,
-      )
+          Overcommit::Hook::Message.new(severity, path, lint['line'], message)
+        end
+      end
     end
   end
 end

data/lib/overcommit/hook/pre_push/minitest.rb

@@ -10,5 +10,9 @@ module Overcommit::Hook::PrePush
       output = result.stdout + result.stderr
       [:fail, output]
     end
+
+    def command
+      super + included_files.map { |file| "-r#{file}" }
+    end
   end
 end

data/lib/overcommit/hook_context/base.rb

@@ -79,6 +79,13 @@ module Overcommit::HookContext
       []
     end
 
+    # Returns the full list of files tracked by git
+    #
+    # @return [Array<String>]
+    def all_files
+      Overcommit::GitRepo.all_files
+    end
+
     # Returns the contents of the entire standard input stream that were passed
     # to the hook.
     #

data/lib/overcommit/hook_context/pre_commit.rb

@@ -15,6 +15,13 @@ module Overcommit::HookContext
       cmd = Overcommit::Utils.parent_command
       amend_pattern = 'commit(\s.*)?\s--amend(\s|$)'
 
+      # Since the ps command can return invalid byte sequences for commands
+      # containing unicode characters, we replace the offending characters,
+      # since the pattern we're looking for will consist of ASCII characters
+      unless cmd.valid_encoding?
+        cmd.encode!('UTF-16be', invalid: :replace, replace: '?').encode!('UTF-8')
+      end
+
       return @amendment if
         # True if the command is a commit with the --amend flag
         @amendment = !(/\s#{amend_pattern}/ =~ cmd).nil?

data/lib/overcommit/hook_context/run_all.rb

@@ -7,7 +7,7 @@ module Overcommit::HookContext
   # which is useful for automated CI scripts.
   class RunAll < Base
     def modified_files
-      @modified_files ||= Overcommit::GitRepo.all_files
+      @modified_files ||= all_files
     end
 
     # Returns all lines in the file since in this context the entire repo is

data/lib/overcommit/hook_runner.rb

@@ -150,6 +150,9 @@ module Overcommit
         return if should_skip?(hook)
 
         status, output = hook.run_and_transform
+      rescue Overcommit::Exceptions::MessageProcessingError => ex
+        status = :fail
+        output = ex.message
       rescue => ex
         status = :fail
         output = "Hook raised unexpected error\n#{ex.message}\n#{ex.backtrace.join("\n")}"

data/lib/overcommit/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.32.0.rc1'.freeze
+  VERSION = '0.32.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.32.0.rc1
+  version: 0.32.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-29 00:00:00.000000000 Z
+date: 2016-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -110,6 +110,7 @@ files:
 - lib/overcommit/hook/commit_msg/empty_message.rb
 - lib/overcommit/hook/commit_msg/gerrit_change_id.rb
 - lib/overcommit/hook/commit_msg/hard_tabs.rb
+- lib/overcommit/hook/commit_msg/message_format.rb
 - lib/overcommit/hook/commit_msg/russian_novel.rb
 - lib/overcommit/hook/commit_msg/single_line_subject.rb
 - lib/overcommit/hook/commit_msg/spell_check.rb
@@ -154,6 +155,7 @@ files:
 - lib/overcommit/hook/pre_commit/dogma.rb
 - lib/overcommit/hook/pre_commit/es_lint.rb
 - lib/overcommit/hook/pre_commit/execute_permissions.rb
+- lib/overcommit/hook/pre_commit/forbidden_branches.rb
 - lib/overcommit/hook/pre_commit/go_lint.rb
 - lib/overcommit/hook/pre_commit/go_vet.rb
 - lib/overcommit/hook/pre_commit/haml_lint.rb
@@ -263,9 +265,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5.1