overcommit 0.29.1 → 0.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91af002cf7828227351dd72b5c6bf2b27e3b217d
-  data.tar.gz: 025444e49ce27a05f6fc54134ae0ce70a466f851
+  metadata.gz: 6b041ebaa80bcfe3013027b461fd01453c6b9206
+  data.tar.gz: aa64ece4843d4d6153850d9e8e2a3bc14399257c
 SHA512:
-  metadata.gz: 602cf07b0687009d092330706d3f6d54179d2cbfcd1d58fb3cfa3c9fe92195ee1a0af3d452d5649666e534d5d352ab2ca52d5dd1711bda55ec1f20d7bc5fbbcc
-  data.tar.gz: 642bc0ec26c0af5dcfa44a30ea930f847f1cda71dd6bcd0d78003624f5b10c3c227918dea4d68d110c4b5844e7c40fe2a4538848685d185f28297516bddc4f62
+  metadata.gz: c2c6d61a99022f38a43bcaa286bb5907fda839325d0334112450e45226b52b51b3b52841121ef767dbabaed8bec3d595a8129c9fabbee2691eff8f994fea9a68
+  data.tar.gz: c36a4c528cb64b8387caeeedee2dda72207da0d42fc4c92b849fd9d9c0e7ee5bfa2a3a998165fdea66a4d7c91632dcc5521b2e7d47cffc3550910480e99ad446

data/config/default.yml

@@ -188,6 +188,15 @@ PreCommit:
     install_command: 'npm install -g csslint'
     include: '**/*.css'
 
+  Dogma:
+    enabled: false
+    description: 'Analyzing with dogma'
+    required_executable: 'mix'
+    flags: ['dogma']
+    include:
+      - '**/*.ex'
+      - '**/*.exs'
+
   EsLint:
     enabled: false
     description: 'Analyzing with ESLint'
@@ -379,6 +388,12 @@ PreCommit:
     install_command: 'pip install flake8'
     include: '**/*.py'
 
+  RailsBestPractices:
+    enabled: false
+    description: 'Analyzing with RailsBestPractices'
+    required_executable: 'rails_best_practices'
+    install_command: 'gem install rails_best_practices'
+
   RailsSchemaUpToDate:
     enabled: false
     description: 'Checking if database schema is up to date'
@@ -774,6 +789,12 @@ PrePush:
     description: 'Running RSpec test suite'
     required_executable: 'rspec'
 
+  Minitest:
+    enabled: false
+    description: 'Running Minitest test suite'
+    command: ['ruby', '-Ilib:test', 'test']
+    required_library: 'minitest'
+
 # Hooks that run during `git rebase`, before any commits are rebased.
 # If a hook fails, the rebase is aborted.
 PreRebase:

data/lib/overcommit/cli.rb

@@ -193,7 +193,8 @@ module Overcommit
     end
 
     def run_all
-      context = Overcommit::HookContext.create('run-all', config, @arguments, @input)
+      empty_stdin = File.open(File::NULL) # pre-commit hooks don't take input
+      context = Overcommit::HookContext.create('run-all', config, @arguments, empty_stdin)
       config.apply_environment!(context, ENV)
 
       printer = Overcommit::Printer.new(log, context)

data/lib/overcommit/hook/base.rb

@@ -184,7 +184,8 @@ module Overcommit::Hook
     def check_for_executable
       return unless required_executable && !in_path?(required_executable)
 
-      output = "'#{required_executable}' is not installed (or is not in your PATH)"
+      output = "'#{required_executable}' is not installed, not in your PATH, " \
+               'or does not have execute permissions'
       output << install_command_prompt
 
       output

data/lib/overcommit/hook/commit_msg/text_width.rb

@@ -7,7 +7,7 @@ module Overcommit::Hook::CommitMsg
 
       @errors = []
 
-      find_errors_in_subject(commit_message_lines.first)
+      find_errors_in_subject(commit_message_lines.first.chomp)
       find_errors_in_body(commit_message_lines)
 
       return :warn, @errors.join("\n") if @errors.any?

data/lib/overcommit/hook/pre_commit/dogma.rb

@@ -0,0 +1,31 @@
+module Overcommit::Hook::PreCommit
+  # Runs `dogma` against any modified ex files.
+  #
+  # @see https://github.com/lpil/dogma
+  class Dogma < Base
+    def run
+      result = execute command
+      return :pass if result.success?
+
+      messages = []
+      # example message:
+      #  == web/channels/user_socket.ex ==
+      #  26: LineLength: Line length should not exceed 80 chars (was 83).
+      #  1: ModuleDoc: Module Sample.UserSocket is missing a @moduledoc.
+      output = result.stdout.chomp.match(/(==.+)/m)
+
+      if output
+        output.captures.first.split(/\n\n/).each do |error_group|
+          errors = error_group.split /\n/
+          file = errors.shift.gsub /[ =]/, ''
+          errors.each do |error|
+            line = error.split(': ').first
+            messages << Overcommit::Hook::Message.new(:error, file, line, "#{file}: #{error}")
+          end
+        end
+      end
+
+      messages
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/rails_best_practices.rb

@@ -0,0 +1,32 @@
+module Overcommit
+  module Hook
+    module PreCommit
+      # Runs `rails_best_practices` against Ruby files
+      #
+      # @see https://github.com/railsbp/rails_best_practices
+      class RailsBestPractices < Base
+        ERROR_REGEXP = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)\s-\s(?<type>.+)/
+
+        def run
+          result = execute(command)
+
+          return :pass if result.success?
+          return [:fail, result.stderr] unless result.stderr.empty?
+
+          extract_messages(
+            filter_output(result.stdout),
+            ERROR_REGEXP
+          )
+        end
+
+        private
+
+        def filter_output(stdout)
+          stdout.split("\n").select do |message|
+            message.match ERROR_REGEXP
+          end
+        end
+      end
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/rubo_cop.rb

@@ -10,6 +10,7 @@ module Overcommit::Hook::PreCommit
     def run
       result = execute(command, args: applicable_files)
       return :pass if result.success?
+      return [:fail, result.stderr] unless result.stderr.empty?
 
       extract_messages(
         result.stdout.split("\n"),

data/lib/overcommit/hook/pre_push/minitest.rb

@@ -0,0 +1,14 @@
+module Overcommit::Hook::PrePush
+  # Runs `minitest` test suite before push
+  #
+  # @see https://github.com/seattlerb/minitest
+  class Minitest < Base
+    def run
+      result = execute(command)
+      return :pass if result.success?
+
+      output = result.stdout + result.stderr
+      [:fail, output]
+    end
+  end
+end

data/lib/overcommit/os.rb

@@ -30,5 +30,7 @@ module Overcommit
         @os ||= ::RbConfig::CONFIG['host_os']
       end
     end
+
+    SEPARATOR = self.windows? ? '\\' : File::SEPARATOR
   end
 end

data/lib/overcommit/utils/file_utils.rb

@@ -58,7 +58,7 @@ module Overcommit::Utils
       end
 
       def win32_fix_pathsep(path)
-        path.tr('/', '\\')
+        path.tr(File::SEPARATOR, Overcommit::OS::SEPARATOR)
       end
 
       def win32_symlink?(dir_output)

data/lib/overcommit/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module Overcommit
-  VERSION = '0.29.1'
+  VERSION = '0.30.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.29.1
+  version: 0.30.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-18 00:00:00.000000000 Z
+date: 2015-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -137,6 +137,7 @@ files:
 - lib/overcommit/hook/pre_commit/chamber_security.rb
 - lib/overcommit/hook/pre_commit/coffee_lint.rb
 - lib/overcommit/hook/pre_commit/css_lint.rb
+- lib/overcommit/hook/pre_commit/dogma.rb
 - lib/overcommit/hook/pre_commit/es_lint.rb
 - lib/overcommit/hook/pre_commit/execute_permissions.rb
 - lib/overcommit/hook/pre_commit/go_lint.rb
@@ -162,6 +163,7 @@ files:
 - lib/overcommit/hook/pre_commit/pyflakes.rb
 - lib/overcommit/hook/pre_commit/pylint.rb
 - lib/overcommit/hook/pre_commit/python_flake8.rb
+- lib/overcommit/hook/pre_commit/rails_best_practices.rb
 - lib/overcommit/hook/pre_commit/rails_schema_up_to_date.rb
 - lib/overcommit/hook/pre_commit/reek.rb
 - lib/overcommit/hook/pre_commit/rubo_cop.rb
@@ -183,6 +185,7 @@ files:
 - lib/overcommit/hook/pre_commit/xml_syntax.rb
 - lib/overcommit/hook/pre_commit/yaml_syntax.rb
 - lib/overcommit/hook/pre_push/base.rb
+- lib/overcommit/hook/pre_push/minitest.rb
 - lib/overcommit/hook/pre_push/protected_branches.rb
 - lib/overcommit/hook/pre_push/r_spec.rb
 - lib/overcommit/hook/pre_rebase/base.rb