overcommit 0.27.0 → 0.28.0

data/lib/overcommit/hook/post_rewrite/bundle_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/bundle_install'
+
+module Overcommit::Hook::PostRewrite
+  # Runs `bundle install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::BundleInstall}
+  class BundleInstall < Base
+    include Overcommit::Hook::Shared::BundleInstall
+  end
+end

data/lib/overcommit/hook/post_rewrite/npm_install.rb

@@ -0,0 +1,11 @@
+require 'overcommit/hook/shared/npm_install'
+
+module Overcommit::Hook::PostRewrite
+  # Runs `npm install` when a change is detected in the repository's
+  # dependencies.
+  #
+  # @see {Overcommit::Hook::Shared::NpmInstall}
+  class NpmInstall < Base
+    include Overcommit::Hook::Shared::NpmInstall
+  end
+end

data/lib/overcommit/hook/pre_commit/base.rb

@@ -5,7 +5,7 @@ module Overcommit::Hook::PreCommit
   class Base < Overcommit::Hook::Base
     extend Forwardable
 
-    def_delegators :@context, :modified_lines_in_file, :amendment?
+    def_delegators :@context, :modified_lines_in_file, :amendment?, :initial_commit?
 
     private
 

data/lib/overcommit/hook/pre_commit/chamber_security.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://github.com/thekompanee/chamber
   class ChamberSecurity < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
 
       return :pass if result.stdout.empty?
       [:fail, "These settings appear to need to be secured but were not: #{result.stdout}"]

data/lib/overcommit/hook/pre_commit/coffee_lint.rb

@@ -3,38 +3,30 @@ module Overcommit::Hook::PreCommit
   #
   # @see http://www.coffeelint.org/
   class CoffeeLint < Base
-    def run
-      result = execute(command + applicable_files)
+    MESSAGE_REGEX = /
+      ^(?<file>.+)
+      ,(?<line>\d*),\d*
+      ,(?<type>\w+)
+      ,(?<msg>.+)$
+    /x
 
-      begin
-        parse_json_messages(result.stdout)
-      rescue JSON::ParserError => e
-        [:fail, "Error parsing coffeelint output: #{e.message}"]
-      end
+    MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      type.include?('w') ? :warning : :error
     end
 
-    private
-
-    def parse_json_messages(output)
-      JSON.parse(output).collect do |file, messages|
-        messages.collect { |msg| extract_message(file, msg) }
-      end.flatten
+    def run
+      result = execute(command, args: applicable_files)
+      parse_messages(result.stdout)
     end
 
-    def extract_message(file, message_hash)
-      type = message_hash['level'].include?('w') ? :warning : :error
-      line = message_hash['lineNumber']
-      rule = message_hash['rule']
-      msg = message_hash['message']
-      text =
-        if rule == 'coffeescript_error'
-          # Syntax errors are output in different format.
-          # Splice in the file name and grab the first line.
-          msg.sub('[stdin]', file).split("\n")[0]
-        else
-          "#{file}:#{line}: #{msg} (#{rule})"
-        end
-      Overcommit::Hook::Message.new(type, file, line, text)
+    private
+
+    def parse_messages(output)
+      output.scan(MESSAGE_REGEX).map do |file, line, type, msg|
+        type = MESSAGE_TYPE_CATEGORIZER.call(type)
+        text = "#{file}:#{line}:#{type} #{msg}"
+        Overcommit::Hook::Message.new(type, file, line, text)
+      end
     end
   end
 end

data/lib/overcommit/hook/pre_commit/css_lint.rb

@@ -4,13 +4,13 @@ module Overcommit::Hook::PreCommit
   # @see https://github.com/CSSLint/csslint
   class CssLint < Base
     MESSAGE_REGEX = /
-      ^(?<file>[^:]+):\s
+      ^(?<file>(?:\w:)?[^:]+):\s
       (?:line\s(?<line>\d+)[^EW]+)?
       (?<type>Error|Warning)
     /x
 
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout.chomp
       return :pass if result.success? && output.empty?
 

data/lib/overcommit/hook/pre_commit/es_lint.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see http://eslint.org/
   class EsLint < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout.chomp
       return :pass if result.success? && output.empty?
 
@@ -12,7 +12,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.js: line 1, col 0, Error - Error message (ruleName)
       extract_messages(
         output.split("\n").grep(/Warning|Error/),
-        /^(?<file>[^:]+):[^\d]+(?<line>\d+).*?(?<type>Error|Warning)/,
+        /^(?<file>(?:\w:)?[^:]+):[^\d]+(?<line>\d+).*?(?<type>Error|Warning)/,
         lambda { |type| type.downcase.to_sym }
       )
     end

data/lib/overcommit/hook/pre_commit/execute_permissions.rb

@@ -0,0 +1,64 @@
+module Overcommit::Hook::PreCommit
+  # Checks for files with execute permissions, which are usually not necessary
+  # in source code files (and are typically caused by a misconfigured editor
+  # assigning incorrect default permissions).
+  class ExecutePermissions < Base
+    def run
+      file_modes = {}
+
+      # We have to look in two places to determine the execute permissions of a
+      # file. The first is the Git tree for currently known file modes of all
+      # files, the second is the index for any staged changes to file modes.
+      # Staged changes take priority if they exist.
+      #
+      # This complexity is necessary because this hook can be run in the RunAll
+      # context, where there may be no staged changes but we stil want to check
+      # the permissions.
+      extract_from_git_tree(file_modes) unless initial_commit?
+      extract_from_git_index(file_modes)
+
+      file_modes.map do |file, mode|
+        next unless execute_permissions?(mode)
+
+        Overcommit::Hook::Message.new(
+          :error,
+          file,
+          nil,
+          "File #{file} has unnecessary execute permissions",
+        )
+      end.compact
+    end
+
+    private
+
+    def extract_from_git_tree(file_modes)
+      result = execute(%w[git ls-tree HEAD --], args: applicable_files)
+      raise 'Unable to access git tree' unless result.success?
+
+      result.stdout.split("\n").each do |line|
+        mode, _type, _hash, file = line.split(/\s+/, 4)
+        file_modes[file] = mode
+      end
+    end
+
+    def extract_from_git_index(file_modes)
+      result = execute(%w[git diff --raw --cached --], args: applicable_files)
+      raise 'Unable to access git index' unless result.success?
+
+      result.stdout.split("\n").each do |line|
+        _old_mode, new_mode, _old_hash, _new_hash, _status, file = line.split(/\s+/, 6)
+        file_modes[file] = new_mode
+      end
+    end
+
+    # Check if the 1st bit is toggled, indicating execute permissions.
+    #
+    # Git tracks only execute permissions, not individual read/write/execute
+    # permissions for user, group, and other, since that concept does not exist
+    # on all operating systems. If any of the user/group/other permissions
+    # have the executable bit set, they all will. Thus we check the first bit.
+    def execute_permissions?(mode)
+      (mode.to_i(8) & 1) == 1
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/go_lint.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://github.com/golang/lint
   class GoLint < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout + result.stderr
       # Unfortunately the exit code is always 0
       return :pass if output.empty?
@@ -13,7 +13,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.go:1:1: Error message
       extract_messages(
         output.split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+)/
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
       )
     end
   end

data/lib/overcommit/hook/pre_commit/go_vet.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://godoc.org/code.google.com/p/go-zh.tools/cmd/vet
   class GoVet < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return :pass if result.success?
 
       if result.stderr =~ /no such tool "vet"/
@@ -15,7 +15,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.go:7: Error message
       extract_messages(
         result.stderr.split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+)/
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
       )
     end
   end

data/lib/overcommit/hook/pre_commit/haml_lint.rb

@@ -8,12 +8,12 @@ module Overcommit::Hook::PreCommit
     end
 
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return :pass if result.success?
 
       extract_messages(
         result.stdout.split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+)[^ ]* (?<type>[^ ]+)/,
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)[^ ]* (?<type>[^ ]+)/,
         MESSAGE_TYPE_CATEGORIZER,
       )
     end

data/lib/overcommit/hook/pre_commit/hard_tabs.rb

@@ -6,7 +6,7 @@ module Overcommit::Hook::PreCommit
 
       extract_messages(
         result.stdout.split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+)/,
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/,
       )
     end
   end

data/lib/overcommit/hook/pre_commit/hlint.rb

@@ -0,0 +1,32 @@
+module Overcommit::Hook::PreCommit
+  # Runs `hlint` against any modified Haskell files.
+  #
+  # @see https://github.com/ndmitchell/hlint
+  class Hlint < Base
+    MESSAGE_REGEX = /
+      ^(?<file>(?:\w:)?[^:]+)
+      :(?<line>\d+)
+      :\d+
+      :\s*(?<type>\w+)
+    /x
+
+    MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      type.include?('W') ? :warning : :error
+    end
+
+    def run
+      result = execute(command, args: applicable_files)
+      return :pass if result.success?
+
+      raw_messages = result.stdout.split("\n").grep(MESSAGE_REGEX)
+
+      # example message:
+      #   path/to/file.hs:1:0: Error: message
+      extract_messages(
+        raw_messages,
+        MESSAGE_REGEX,
+        MESSAGE_TYPE_CATEGORIZER
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/html_hint.rb

@@ -13,7 +13,7 @@ module Overcommit::Hook::PreCommit
         file = lines[0][/(.+):/, 1]
         extract_messages(
           lines[1..-1].map { |msg| "#{file}: #{msg}" },
-          /^(?<file>[^:]+): line (?<line>\d+)/
+          /^(?<file>(?:\w:)?[^:]+): line (?<line>\d+)/
         )
       end.flatten
     end

data/lib/overcommit/hook/pre_commit/html_tidy.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see http://www.html-tidy.org/
   class HtmlTidy < Base
     MESSAGE_REGEX = /
-      ^(?<file>[^:]+):\s
+      ^(?<file>(?:\w:)?[^:]+):\s
       line\s(?<line>\d+)\s
       column\s(?<col>\d+)\s-\s
       (?<type>Error|Warning):\s(?<message>.+)$

data/lib/overcommit/hook/pre_commit/image_optim.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://github.com/toy/image_optim
   class ImageOptim < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return [:fail, result.stdout + result.stderr] unless result.success?
 
       optimized_files = extract_optimized_files(result.stdout)

data/lib/overcommit/hook/pre_commit/java_checkstyle.rb

@@ -3,10 +3,10 @@ module Overcommit::Hook::PreCommit
   #
   # @see http://checkstyle.sourceforge.net/
   class JavaCheckstyle < Base
-    MESSAGE_REGEX = /^(?<file>[^:]+):(?<line>\d+)/
+    MESSAGE_REGEX = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
 
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout.chomp
       return :pass if result.success?
 

data/lib/overcommit/hook/pre_commit/js_hint.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see http://jshint.com/
   class JsHint < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout.chomp
 
       return :pass if result.success? && output.empty?
@@ -13,7 +13,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.js: line 1, col 0, Error message (E001)
       extract_messages(
         output.split("\n").grep(/E|W/),
-        /^(?<file>[^:]+):[^\d]+(?<line>\d+).+\((?<type>E|W)\d+\)/,
+        /^(?<file>(?:\w:)?[^:]+):[^\d]+(?<line>\d+).+\((?<type>E|W)\d+\)/,
         lambda { |type| type.include?('W') ? :warning : :error }
       )
     end

data/lib/overcommit/hook/pre_commit/js_lint.rb

@@ -3,10 +3,10 @@ module Overcommit::Hook::PreCommit
   #
   # @see http://www.jslint.com/
   class JsLint < Base
-    MESSAGE_REGEX = /(?<file>[^:]+):(?<line>\d+)/
+    MESSAGE_REGEX = /(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
 
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return :pass if result.success?
 
       # example message:

data/lib/overcommit/hook/pre_commit/jscs.rb

@@ -5,7 +5,7 @@ module Overcommit::Hook::PreCommit
   # @see http://jscs.info/
   class Jscs < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return :pass if result.success?
 
       if result.status == 1
@@ -17,7 +17,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.js: line 7, col 0, ruleName: Error message
       extract_messages(
         result.stdout.split("\n"),
-        /^(?<file>[^:]+):[^\d]+(?<line>\d+)/,
+        /^(?<file>(?:\w:)?[^:]+):[^\d]+(?<line>\d+)/,
       )
     end
   end

data/lib/overcommit/hook/pre_commit/jsl.rb

@@ -3,7 +3,7 @@ module Overcommit::Hook::PreCommit
   #
   # @see http://www.javascriptlint.com/
   class Jsl < Base
-    MESSAGE_REGEX = /(?<file>.+)\((?<line>\d+)\):(?<type>[^:]+)/
+    MESSAGE_REGEX = /(?<file>(?:\w:)?.+)\((?<line>\d+)\):(?<type>[^:]+)/
 
     MESSAGE_TYPE_CATEGORIZER = lambda do |type|
       type =~ /warning/ ? :warning : :error

data/lib/overcommit/hook/pre_commit/pep257.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://pypi.python.org/pypi/pep257
   class Pep257 < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       return :pass if result.success?
 
       output = result.stderr.chomp
@@ -14,7 +14,7 @@ module Overcommit::Hook::PreCommit
       #           D102: Docstring missing
       extract_messages(
         output.gsub(/:\s+/, ': ').split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+)/
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/
       )
     end
   end

data/lib/overcommit/hook/pre_commit/pep8.rb

@@ -4,7 +4,7 @@ module Overcommit::Hook::PreCommit
   # @see https://pypi.python.org/pypi/pep8
   class Pep8 < Base
     def run
-      result = execute(command + applicable_files)
+      result = execute(command, args: applicable_files)
       output = result.stdout.chomp
 
       return :pass if result.success? && output.empty?
@@ -13,7 +13,7 @@ module Overcommit::Hook::PreCommit
       #   path/to/file.py:88:5: E301 expected 1 blank line, found 0
       extract_messages(
         output.split("\n"),
-        /^(?<file>[^:]+):(?<line>\d+):\d+:\s(?<type>E|W)/,
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+):\d+:\s(?<type>E|W)/,
         lambda { |type| type.include?('W') ? :warning : :error }
       )
     end