overcommit 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e133359ae61ef154b91a8194178ee5a89af7c5da
-  data.tar.gz: 6c9f6191fea07ac695999e4ea0a7ff48b1858010
+  metadata.gz: f8d7eb3f46bb777b61a7691c1eef669daf7993b5
+  data.tar.gz: cf0dc9b2c995254856a82ddf449d271a1d886d8c
 SHA512:
-  metadata.gz: 426352f6c848e421e356761aff3d729c264f1dea63b6e411061eaed03f698eae30cad5fc9716765386dd32324c756ecf9d460cfa3030ad110d217e566f98ab4d
-  data.tar.gz: 099133f6f3f22074fea07a299ba94e73bef8e5a8cf2052656b10df81833d22f770282bc2e9931bb02ad5b92725348f3cd38fbfee711fc1e3e7143b41c105f94f
+  metadata.gz: f0fa19bb49c780b3d0a89d3488458339ed81bd20a2d26dc1e9a85f8f26dd3e6c315a75c3e9e1eafd627f09725062450b8a5da0b29ab07e6567b78bd1772a54aa
+  data.tar.gz: ffbbb87fadc8db06a91fbf052954a13e7d68063935225ff6480b834599ef3a70945f80903dbf6a5d7756170eb559db0c74d296b13c9502380b209dfdaade2add

data/lib/overcommit/configuration.rb

@@ -22,16 +22,12 @@ module Overcommit
     # Given the current configuration, return a set of paths which should be
     # loaded as plugins (`require`d)
     def desired_plugins
-      excludes    = repo_settings['excludes']
-      skip_checks = ENV.fetch('SKIP_CHECKS', '').split(/[:, ]/)
-
-      return [] if skip_checks.include? 'all'
+      excludes = repo_settings['excludes']
 
       plugin_directories.map do |dir|
         Dir[File.join(dir, Utils.hook_name, '*.rb')].map do |plugin|
           basename = File.basename(plugin, '.rb')
-          if !skip_checks.include?(basename) &&
-             !(excludes[Utils.hook_name] || []).include?(basename)
+          if !(excludes[Utils.hook_name] || []).include?(basename)
             plugin
           end
         end.compact

data/lib/overcommit/git_hook.rb

@@ -15,7 +15,7 @@ module Overcommit
       def run(*args)
         # Support 'bare' installation where we don't have any hooks yet.
         # Silently pass.
-        exit unless (checks = HookRegistry.checks) && checks.any?
+        exit unless (checks = registered_checks) && checks.any?
 
         exit if requires_modified_files? && Utils.modified_files.empty?
 
@@ -41,6 +41,23 @@ module Overcommit
 
     private
 
+      # Return all loaded plugins, skipping those that are skippable and have
+      # been asked to be skipped by the environment variable SKIP_CHECKS.
+      #
+      # Note that required checks are not skipped even if
+      # `ENV['SKIP_CHECKS'] == 'all'`
+      def registered_checks
+        @registered_checks ||= begin
+          skip_checks = ENV.fetch('SKIP_CHECKS', '').split(/[:, ]/)
+          skip_all    = skip_checks.include? 'all'
+          HookRegistry.checks.reject do |check|
+            hook_name = Utils.underscorize check.name
+
+            check.skippable? && (skip_all || skip_checks.include?(hook_name))
+          end
+        end
+      end
+
       # If true, only run this check when there are modified files.
       def requires_modified_files?
         false

data/lib/overcommit/hook_specific_check.rb

@@ -4,6 +4,7 @@ module Overcommit
       @checks = []
       class << self
         attr_reader :checks
+
         def included(base)
           @checks << base
         end
@@ -12,12 +13,21 @@ module Overcommit
 
     class HookSpecificCheck
       class << self
-        attr_accessor :filetype
-        attr_accessor :stealth
+        attr_accessor :filetype, :stealth, :required
 
         def stealth!
           self.stealth = true
         end
+
+        def required!
+          self.required = true
+        end
+
+        # Can the check be skipped by environment variables? This can always be
+        # overriden with `--no-verify`.
+        def skippable?
+          !required
+        end
       end
 
       def initialize(*args)

data/lib/overcommit/plugins/commit_msg/change_id.rb

@@ -3,6 +3,7 @@ module Overcommit::GitHook
     include HookRegistry
 
     stealth! # Not really a 'check', but we need it to run
+    required! # Not skipped when ENV['SKIP_CHECKS'] == 'all'
 
     SCRIPT_LOCATION = Overcommit::Utils.script_path 'gerrit-change-id'
 

data/lib/overcommit/version.rb

@@ -1,3 +1,3 @@
 module Overcommit
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: overcommit
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Causes Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-24 00:00:00.000000000 Z
+date: 2013-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -31,49 +31,49 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/overcommit.rb
-- lib/overcommit/utils.rb
-- lib/overcommit/errors.rb
+- lib/overcommit/cli.rb
+- lib/overcommit/configuration.rb
 - lib/overcommit/console_methods.rb
-- lib/overcommit/plugins/pre_commit/scss_lint.rb
+- lib/overcommit/errors.rb
+- lib/overcommit/git_hook.rb
+- lib/overcommit/hook_specific_check.rb
+- lib/overcommit/hooks/commit_msg.rb
+- lib/overcommit/hooks/pre_commit.rb
+- lib/overcommit/installer.rb
+- lib/overcommit/plugins/commit_msg/change_id.rb
+- lib/overcommit/plugins/commit_msg/release_note.rb
+- lib/overcommit/plugins/commit_msg/russian_novel.rb
+- lib/overcommit/plugins/commit_msg/text_width.rb
+- lib/overcommit/plugins/commit_msg/trailing_period.rb
+- lib/overcommit/plugins/pre_commit/author_name.rb
 - lib/overcommit/plugins/pre_commit/causes_email.rb
-- lib/overcommit/plugins/pre_commit/ruby_syntax.rb
+- lib/overcommit/plugins/pre_commit/css_linter.rb
+- lib/overcommit/plugins/pre_commit/erb_syntax.rb
 - lib/overcommit/plugins/pre_commit/haml_syntax.rb
-- lib/overcommit/plugins/pre_commit/test_history.rb
-- lib/overcommit/plugins/pre_commit/yaml_syntax.rb
-- lib/overcommit/plugins/pre_commit/restricted_paths.rb
 - lib/overcommit/plugins/pre_commit/js_console_log.rb
 - lib/overcommit/plugins/pre_commit/js_syntax.rb
-- lib/overcommit/plugins/pre_commit/author_name.rb
+- lib/overcommit/plugins/pre_commit/restricted_paths.rb
+- lib/overcommit/plugins/pre_commit/ruby_syntax.rb
+- lib/overcommit/plugins/pre_commit/scss_lint.rb
+- lib/overcommit/plugins/pre_commit/test_history.rb
 - lib/overcommit/plugins/pre_commit/whitespace.rb
-- lib/overcommit/plugins/pre_commit/css_linter.rb
-- lib/overcommit/plugins/pre_commit/erb_syntax.rb
-- lib/overcommit/plugins/commit_msg/text_width.rb
-- lib/overcommit/plugins/commit_msg/trailing_period.rb
-- lib/overcommit/plugins/commit_msg/release_note.rb
-- lib/overcommit/plugins/commit_msg/russian_novel.rb
-- lib/overcommit/plugins/commit_msg/change_id.rb
+- lib/overcommit/plugins/pre_commit/yaml_syntax.rb
 - lib/overcommit/reporter.rb
-- lib/overcommit/git_hook.rb
-- lib/overcommit/hook_specific_check.rb
-- lib/overcommit/hooks/commit_msg.rb
-- lib/overcommit/hooks/pre_commit.rb
-- lib/overcommit/configuration.rb
-- lib/overcommit/installer.rb
-- lib/overcommit/cli.rb
+- lib/overcommit/utils.rb
 - lib/overcommit/version.rb
-- bin/scripts/jshint.js
-- bin/scripts/gerrit-change-id
-- bin/scripts/jshint_runner.js
-- bin/scripts/index-tags
-- bin/scripts/csslint-rhino.js
-- bin/hooks/pre-commit
+- lib/overcommit.rb
 - bin/hooks/commit-msg
-- bin/hooks/prepare-commit-msg
 - bin/hooks/post-checkout
 - bin/hooks/post-merge
+- bin/hooks/pre-commit
+- bin/hooks/prepare-commit-msg
 - bin/overcommit
 - bin/run-hook
+- bin/scripts/csslint-rhino.js
+- bin/scripts/gerrit-change-id
+- bin/scripts/index-tags
+- bin/scripts/jshint.js
+- bin/scripts/jshint_runner.js
 - config/templates.yml
 homepage: http://github.com/causes/overcommit
 licenses:
@@ -100,4 +100,3 @@ signing_key:
 specification_version: 4
 summary: Opinionated Git hook manager
 test_files: []
-has_rdoc: