outrigger 2.1.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afe3d83c6bdd3dcb7cca66b9c4dafb871003caa20a67054059ebed4ab22bf516
-  data.tar.gz: ef8343569aaa000a0cc61897f8d33e6404cd4833d54b187cb364922f91f18ed1
+  metadata.gz: 392d8062869e177e23c6860452029c08aad9ecdcf50cdf066c2adf2acbfa986f
+  data.tar.gz: 6e88773c9dc2c53f6d248018c54498ff4d824d79ae0fdc02c6577a0b4e154d2b
 SHA512:
-  metadata.gz: 594e9b14db63bdc8742dc34e809a088c30c41ae2624313d1be3580d58d5ced891bd8b799ad15cf69571541c19f2698f34185832686996b9777c61cc49bf8717a
-  data.tar.gz: 535727d4166e69a14b1fa6d188d3608d5b3e4e21f0d3c4601c130523d9e0ef7f900d78dbab4766cbcddf65f71a4f4db8939db5eb84934fe6661f49c44d31a885
+  metadata.gz: 19200055e92e31aa92dd87003a17df97752544847754957db78420a6470c08d2e63d812095a088e05a326593ba2b7ade2c1fbf764e78cad7f92a1a236a6ac546
+  data.tar.gz: 23710d99de6a88968cc2f812a600ad62364a4bd39d9124206ac0fe541f7d5153ddc463d54e89d41c6a210eeda386bccd91d00866fe6133fe09747fb4e86da315

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 
 begin
@@ -6,14 +8,6 @@ begin
   RSpec::Core::RakeTask.new(:spec)
 
   task(default: :spec)
-rescue LoadError # rubocop:disable Lint/HandleExceptions
-  # no rspec available
-end
-
-task :console do
-  require 'irb'
-  require 'irb/completion'
-  require 'outrigger'
-  ARGV.clear
-  IRB.start
+rescue LoadError
+  nil
 end

data/lib/outrigger/cops/migration/tagged.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Migration
@@ -5,6 +7,7 @@ module RuboCop
         def on_class(node)
           _name, _superclass, body = *node
           return unless body && migration_class?(node)
+
           check(node, body)
         end
 
@@ -33,6 +36,7 @@ module RuboCop
                         message: 'No allowed tags have been defined in the RuboCop configuration.'
           elsif tag
             return if allowed_tags.include? tag.children.last.to_a.last
+
             add_offense tag,
                         location: :expression,
                         message: "Tags may only be one of #{allowed_tags}."

data/lib/outrigger/migrator.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Outrigger
+  module Migrator
+    def runnable
+      result = super
+      return result unless Outrigger.ordered
+
+      # re-order according to configuration
+      result.sort_by! { |m| [Outrigger.ordered[m.tags.first] || 0, m.version] }
+      result.reverse! if down?
+      result
+    end
+  end
+end

data/lib/outrigger/railtie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Outrigger
   class Railtie < Rails::Railtie
     railtie_name :taggable_migrations
@@ -8,8 +10,9 @@ module Outrigger
 
     initializer 'extend_migrations' do
       ActiveSupport.on_load :active_record do
-        ActiveRecord::Migration.send :include, Outrigger::Taggable
-        ActiveRecord::MigrationProxy.send :include, Outrigger::TaggableProxy
+        ActiveRecord::Migration.include(Outrigger::Taggable)
+        ActiveRecord::MigrationProxy.include(Outrigger::TaggableProxy)
+        ActiveRecord::Migrator.prepend(Outrigger::Migrator)
       end
     end
   end

data/lib/outrigger/taggable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Outrigger
   module Taggable
     def self.included(base)

data/lib/outrigger/taggable_proxy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Outrigger
   module TaggableProxy
     def self.included(_body)

data/lib/outrigger/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Outrigger
-  VERSION = '2.1.0'.freeze
+  VERSION = '3.0.1'
 end

data/lib/outrigger.rb

@@ -1,13 +1,20 @@
+# frozen_string_literal: true
+
 require 'active_record' unless defined? ActiveRecord
 
+require 'outrigger/migrator'
 require 'outrigger/taggable'
 require 'outrigger/taggable_proxy'
 
 require 'outrigger/railtie' if defined? Rails::Railtie
 
 module Outrigger
-  def self.filter(*tags)
-    tags = tags.flatten.map(&:to_sym)
-    proc { |migration| (tags - migration.tags).empty? }
+  class << self
+    attr_accessor :ordered
+
+    def filter(*tags)
+      tags = tags.flatten.map(&:to_sym)
+      proc { |migration| (tags - migration.tags).empty? }
+    end
   end
 end

data/lib/tasks/outrigger.rake

@@ -1,13 +1,11 @@
+# frozen_string_literal: true
+
 namespace :db do
   namespace :migrate do
     desc 'Run migrations for a Tag'
     task tagged: %i[environment load_config] do |_t, args|
       puts("Migrating Tags: #{args.extras}")
-      if ActiveRecord.gem_version >= Gem::Version.new('5.2.0')
-        ActiveRecord::Base.connection.migration_context.migrate(nil, &Outrigger.filter(args.extras))
-      else
-        ActiveRecord::Migrator.migrate(ActiveRecord::Migrator.migrations_paths, &Outrigger.filter(args.extras))
-      end
+      ActiveRecord::Base.connection.migration_context.migrate(nil, &Outrigger.filter(args.extras))
     end
   end
 end

data/spec/outrigger/cops/migration/tagged_spec.rb

@@ -1,7 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
 require 'outrigger/cops/migration/tagged'
 
-RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable Metrics/BlockLength
+RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable RSpec/FilePath
   let(:config_hash) do
     {
       'Migration/Tagged' => {
@@ -23,7 +24,7 @@ RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable Metrics/Bloc
     RUBY
   end
 
-  subject(:cop) { described_class.new(config) }
+  subject(:cop) { described_class.new(config) } # rubocop:disable RSpec/LeadingSubject
 
   shared_examples_for 'valid migrations' do
     it 'passes valid versioned migration' do
@@ -32,10 +33,10 @@ RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable Metrics/Bloc
     end
   end
 
-  context 'valid config' do # rubocop:disable Metrics/BlockLength
+  context 'with valid config' do
     include_examples 'valid migrations'
 
-    context 'missing tags' do
+    context 'with missing tags' do
       let(:migration_class) do
         <<~RUBY
           class Test < ActiveRecord::Migration[4.2]
@@ -52,7 +53,7 @@ RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable Metrics/Bloc
       end
     end
 
-    context 'invalid tag' do
+    context 'with invalid tag' do
       let(:migration_class) do
         <<~RUBY
           class Test < ActiveRecord::Migration[4.2]
@@ -71,7 +72,7 @@ RSpec.describe RuboCop::Cop::Migration::Tagged do # rubocop:disable Metrics/Bloc
     end
   end
 
-  context 'invalid config' do
+  context 'with invalid config' do
     let(:config_hash) do
       {
         'Migration/Tagged' => {

data/spec/outrigger/migrator_spec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Outrigger
+  describe Migrator do
+    around do |example|
+      Outrigger.ordered = { predeploy: -1, postdeploy: 1 }
+      example.call
+    ensure
+      Outrigger.ordered = nil
+    end
+
+    let(:migrations) do
+      [PostDeployMigration.new(nil, 1), UntaggedMigration.new(nil, 2), PreDeployMigration.new(nil, 3),
+       MultiMigration.new(nil, 4)]
+    end
+
+    before do
+      allow(ActiveRecord::InternalMetadata).to receive(:create_table)
+    end
+
+    it 'sorts' do
+      schema_migration = object_double(ActiveRecord::SchemaMigration, create_table: nil, all_versions: [])
+      expect(ActiveRecord::Migrator.new(:up, migrations, schema_migration).runnable.map(&:class)).to eq(
+        [
+          PreDeployMigration, MultiMigration, UntaggedMigration, PostDeployMigration
+        ]
+      )
+    end
+
+    it 'reverse sorts when going down' do
+      schema_migration = object_double(ActiveRecord::SchemaMigration, create_table: nil, all_versions: [1, 2, 3, 4])
+      expect(ActiveRecord::Migrator.new(:down, migrations, schema_migration).runnable.map(&:class)).to eq(
+        [
+          PostDeployMigration, UntaggedMigration, MultiMigration, PreDeployMigration
+        ]
+      )
+    end
+  end
+end

data/spec/outrigger/outrigger_spec.rb

@@ -1,18 +1,18 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Outrigger do
   describe 'filter' do
-    it 'should return a proc that tests migrations' do
-      filter = Outrigger.filter(:predeploy)
+    it 'returns a proc that tests migrations' do
+      filter = described_class.filter(:predeploy)
 
-      expect(filter.call(PreDeployMigration)).to eq(true)
+      expect(filter.call(PreDeployMigration)).to be(true)
     end
 
-    it 'should accept multiple tags' do
-      filter = Outrigger.filter(:predeploy, :postdeploy)
+    it 'accepts multiple tags' do
+      filter = described_class.filter(:predeploy, :postdeploy)
 
-      expect(filter.call(MultiMigration)).to eq(true)
-      expect(filter.call(PreDeployMigration)).to eq(false)
+      expect(filter.call(MultiMigration)).to be(true)
+      expect(filter.call(PreDeployMigration)).to be(false)
     end
   end
 end

data/spec/outrigger/railtie_spec.rb

@@ -1,9 +1,7 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Outrigger::Railtie do
-  let(:subject) { Outrigger::Railtie }
-
   it 'provides a railtie_name' do
-    expect(subject.railtie_name).to eq 'taggable_migrations'
+    expect(described_class.railtie_name).to eq 'taggable_migrations'
   end
 end

data/spec/outrigger/taggable_proxy_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 class TestProxy
   include Outrigger::TaggableProxy
@@ -6,7 +6,7 @@ class TestProxy
 end
 
 describe Outrigger::TaggableProxy do
-  it 'it should delegate tags to the migration' do
+  it 'delegates tags to the migration' do
     proxy = TestProxy.new
     proxy.migration = PreDeployMigration.new
 

data/spec/outrigger/taggable_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Outrigger::Taggable do
   it 'PreDeployMigration should be predeploy' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter 'lib/outrigger/version.rb'
@@ -7,14 +9,16 @@ end
 SimpleCov.minimum_coverage(85)
 
 require 'bundler/setup'
+require 'byebug'
 require 'rails/railtie'
 require 'rubocop'
 require 'rubocop/rspec/support'
 
 require 'outrigger'
 
-ActiveRecord::Migration.send :include, Outrigger::Taggable
-ActiveRecord::MigrationProxy.send :include, Outrigger::TaggableProxy
+ActiveRecord::Migration.include(Outrigger::Taggable)
+ActiveRecord::MigrationProxy.include(Outrigger::TaggableProxy)
+ActiveRecord::Migrator.prepend(Outrigger::Migrator)
 
 class PreDeployMigration < ActiveRecord::Migration[5.0]
   tag :predeploy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: outrigger
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Drew Bowman
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-11-20 00:00:00.000000000 Z
+date: 2022-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,22 +16,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: railties
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
+- !ruby/object:Gem::Dependency
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -45,25 +65,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
-    - - "<"
+        version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '11.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '11.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -98,44 +126,58 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: '1.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: '1.20'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
-  name: wwtd
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.4'
+- !ruby/object:Gem::Dependency
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.21'
 description: Migrations
-email: 
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -143,16 +185,14 @@ files:
 - Rakefile
 - lib/outrigger.rb
 - lib/outrigger/cops/migration/tagged.rb
+- lib/outrigger/migrator.rb
 - lib/outrigger/railtie.rb
 - lib/outrigger/taggable.rb
 - lib/outrigger/taggable_proxy.rb
 - lib/outrigger/version.rb
 - lib/tasks/outrigger.rake
-- spec/gemfiles/rails-5.0.gemfile
-- spec/gemfiles/rails-5.1.gemfile
-- spec/gemfiles/rails-5.2.gemfile
-- spec/gemfiles/rails-6.0.gemfile
 - spec/outrigger/cops/migration/tagged_spec.rb
+- spec/outrigger/migrator_spec.rb
 - spec/outrigger/outrigger_spec.rb
 - spec/outrigger/railtie_spec.rb
 - spec/outrigger/taggable_proxy_spec.rb
@@ -161,8 +201,9 @@ files:
 homepage: https://github.com/instructure/outrigger
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -170,23 +211,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Tag migrations and run them separately
 test_files:
-- spec/gemfiles/rails-5.0.gemfile
-- spec/gemfiles/rails-5.1.gemfile
-- spec/gemfiles/rails-5.2.gemfile
-- spec/gemfiles/rails-6.0.gemfile
 - spec/outrigger/cops/migration/tagged_spec.rb
+- spec/outrigger/migrator_spec.rb
 - spec/outrigger/outrigger_spec.rb
 - spec/outrigger/railtie_spec.rb
 - spec/outrigger/taggable_proxy_spec.rb

data/spec/gemfiles/rails-5.0.gemfile

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '../../'
-
-gem 'activerecord', '~> 5.0.7'

data/spec/gemfiles/rails-5.1.gemfile

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '../../'
-
-gem 'activerecord', '~> 5.1.6'

data/spec/gemfiles/rails-5.2.gemfile

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '../../'
-
-gem 'activerecord', '~> 5.2.0'

data/spec/gemfiles/rails-6.0.gemfile

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '../../'
-
-gem 'activerecord', '~> 6.0.0'