outliers 0.3.3 → 0.5.0.beta1

data/spec/fixtures/{credentials2.yml → account2.yml}

@@ -1,4 +1,4 @@
-test_credentials_2:
+test_account_2:
   region: us-west-1
   provider: aws_ec2
   access_key_id: 01234567890123456789

data/spec/handlers/outliers_api_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe Outliers::Handlers::OutliersApi do
+  let(:resource1) {stub 'resource1', id: 1}
+  let(:resource2) {stub 'resource2', id: 2}
+  let(:result) { Outliers::Result.new account_name:      'cnt',
+                                      failing_resources: [resource1],
+                                      name:              'evalme',
+                                      passing_resources: [resource2],
+                                      provider_name:     'aws',
+                                      resource_name:     'instance',
+                                      verification_name: 'vpc' }
+  let(:header) {({ 'Content-Type' => 'application/json',
+                   'Accept'       => 'application/vnd.outliers-v1+json' })}
+  let(:req) { mock 'req' }
+  let(:session) { mock 'session' }
+  let(:http) { mock 'http' }
+
+  before { stub_logger }
+
+  context "#post" do
+    before do
+      Net::HTTP::Post.should_receive(:new).with("/results", header).and_return req
+      body = { 'key' => "abc123", 'result' => result.to_hash }.to_json
+      req.should_receive(:body=).with(body)
+      Net::HTTP.should_receive(:new).with("api.getoutliers.com", 443).and_return session
+      session.should_receive(:use_ssl=).with true
+    end
+
+    context "when connection established" do
+      before do
+        session.should_receive(:start).and_yield http
+        http.should_receive(:request).with(req).and_return response
+      end
+
+      context "when successful" do
+        let(:response) { stub 'response', code: "200", body: "Some details." }
+
+        it "should return true" do
+          subject.post(result, "abc123", "https://api.getoutliers.com/results").should be_true 
+        end
+      end
+
+      context "when failure" do
+        let(:response) { stub 'response', code: "500", body: "Some details." }
+
+        it "should return false" do
+          subject.post(result, "abc123", "https://api.getoutliers.com/results").should be_false 
+        end
+      end
+    end
+
+    context "connection error" do
+      it "should return false if connection to url refused." do
+        session.should_receive(:start).and_raise Errno::ECONNREFUSED
+        subject.post(result, "abc123", "https://api.getoutliers.com/results").should be_false 
+      end
+    end
+  end
+
+end

data/spec/info_spec.rb

@@ -33,9 +33,9 @@ describe Outliers::Info do
       end
     end
 
-    it "should validate each resource has a list of credentials" do
+    it "should validate each resource has a list of account" do
       subject.reference.each_pair do |name,provider_data|
-        expect(provider_data['credentials'].class).to eq(Hash)
+        expect(provider_data['account'].class).to eq(Hash)
       end
     end
   end

data/spec/provider_spec.rb

@@ -4,18 +4,18 @@ describe Outliers::Provider do
   subject { Outliers::Provider }
 
   context "#connect_to" do
-    let(:credentials) { ( { :name               => "test_credentials_1",
-                            "provider"          => "aws_ec2",
-                            "secret_access_key" => "abc",
-                            "access_key_id"     => "123" } ) }
+    let(:account) { ( { :name               => "test_account_1",
+                        "provider"          => "aws_ec2",
+                        "secret_access_key" => "abc",
+                        "access_key_id"     => "123" } ) }
 
-    it "should connect to the provider specified in the given credentials" do
-      expect(subject.connect_to(credentials).class).to eq(Outliers::Providers::Aws::Ec2)
+    it "should connect to the provider specified in the given account" do
+      expect(subject.connect_to(account).class).to eq(Outliers::Providers::Aws::Ec2)
     end
 
-    it "should set the credentials instance variable" do
-      expect(subject.connect_to(credentials).credentials).
-        to eq({ :name               => "test_credentials_1",
+    it "should set the account instance variable" do
+      expect(subject.connect_to(account).account).
+        to eq({ :name               => "test_account_1",
                 "provider"          => "aws_ec2",
                 "secret_access_key" => "abc",
                 "access_key_id"     => "123" })

data/spec/results_spec.rb

@@ -1,16 +1,18 @@
 require 'spec_helper'
 
 describe Outliers::Result do
+  let(:resource1) {stub 'resource1', id: 1}
+  let(:resource2) {stub 'resource2', id: 2}
+
   context "passing" do
-    subject { Outliers::Result.new evaluation:        'evalme',
+    subject { Outliers::Result.new account_name:      'cnt',
+                                   arguments:         ['test123'],
                                    failing_resources: [],
-                                   passing_resources: ['key1', 'key2'],
-                                   resource:          'instance',
-                                   verification:      'vpc' }
-                                   
-    it "should return passed" do
-      expect(subject.to_s).to eq 'passed'
-    end
+                                   name:              'evalme',
+                                   passing_resources: [resource1, resource2],
+                                   provider_name:     'aws',
+                                   resource_name:     'instance',
+                                   verification_name: 'vpc' }
 
     it "should return true for passing verification" do
       expect(subject.passed?).to be_true
@@ -21,19 +23,66 @@ describe Outliers::Result do
     end
 
     it "should return the result information" do
-      expect(subject.passing_resources).to eq(['key1', 'key2'])
+      expect(subject.passing_resources).to eq([resource1, resource2])
+    end
+
+
+    it "should return the result information" do
+      expect(subject.account_name).to eq('cnt')
+      expect(subject.failing_resources).to eq([])
+      expect(subject.name).to eq('evalme')
+      expect(subject.passing_resources).to eq([resource1, resource2])
+      expect(subject.provider_name).to eq('aws')
+      expect(subject.resource_name).to eq('instance')
+      expect(subject.verification_name).to eq('vpc')
+    end
+
+    context "#name" do
+      subject { Outliers::Result.new({}) }
+
+      it "should set the name to unspecified if not set" do
+        expect(subject.name).to eq('unspecified')
+      end
+    end
+
+    context "#to_json" do
+      it "should return the results as json" do
+        resources = [ { 'id' => 1, 'passing' => 1 }, { 'id' => 2, 'passing' => 1 } ]
+        json =  { 'account_name'         => 'cnt',
+                  'arguments'            => ['test123'],
+                  'name'                 => 'evalme',
+                  'provider_name'        => 'aws',
+                  'resource_name'        => 'instance',
+                  'verification_name'    => 'vpc',
+                  'resources'            => resources }.to_json
+        expect(subject.to_json).to eq(json)
+      end
+    end
+
+    context "#to_hash" do
+      it "should return the results as hash" do
+        resources = [ { 'id' => 1, 'passing' => 1 }, { 'id' => 2, 'passing' => 1 } ]
+        hash =  { 'account_name'         => 'cnt',
+                  'arguments'            => ['test123'],
+                  'name'                 => 'evalme',
+                  'provider_name'        => 'aws',
+                  'resource_name'        => 'instance',
+                  'verification_name'    => 'vpc',
+                  'resources'            => resources }
+        expect(subject.to_hash).to eq(hash)
+      end
     end
   end
 
   context "failing" do
-    subject { Outliers::Result.new evaluation:        'evalme',
-                                   failing_resources: ['key3', 'key4'],
+    subject { Outliers::Result.new account_name:      'cnt',
+                                   arguments:         ['test123'],
+                                   failing_resources: [resource1, resource2],
+                                   name:              'evalme',
                                    passing_resources: [],
-                                   resource:          'instance',
-                                   verification:      'vpc' }
-    it "should return failed" do
-      expect(subject.to_s).to eq 'failed'
-    end
+                                   provider_name:     'aws',
+                                   resource_name:     'instance',
+                                   verification_name: 'vpc' }
 
     it "should return false for passing verification" do
       expect(subject.passed?).to be_false

data/spec/run_spec.rb

@@ -94,8 +94,8 @@ describe Outliers::Run do
   end
 
   context "returning results" do
-    let(:result1) { Outliers::Result.new name: 'result1', passing_resources: [], failing_resources: [], evaluation: 'test', verification: 'ver' }
-    let(:result2) { Outliers::Result.new name: 'result2', passing_resources: [], failing_resources: ['failed'], evaluation: 'test', verification: 'ver' }
+    let(:result1) { Outliers::Result.new name: 'result1', passing_resources: [], failing_resources: [], verification_name: 'ver' }
+    let(:result2) { Outliers::Result.new name: 'result2', passing_resources: [], failing_resources: ['failed'], verification_name: 'ver' }
 
     before do
       subject.results << result1
@@ -104,13 +104,13 @@ describe Outliers::Run do
 
     describe "#passed" do
       it "should return an array of all passing results" do
-        expect(subject.passed).to eq([result1])
+        expect(subject.passing_results).to eq([result1])
       end
     end
 
     describe "#failed" do
       it "should return an array of all failing results" do
-        expect(subject.failed).to eq([result2])
+        expect(subject.failing_results).to eq([result2])
       end
     end
   end

data/spec/spec_helper.rb

@@ -7,13 +7,13 @@ Dir[File.expand_path(File.join(File.dirname(__FILE__),'helpers', '*.rb'))].each
   require f
 end
 
-def credentials
-  YAML.load(fixture_file 'credentials1.yml')
+def account
+  YAML.load(fixture_file 'account1.yml')
 end
 
 def stub_logger
   Outliers.logger stub 'test'
-  Outliers.logger.stub :debug => true, :info => true, :warn => true
+  Outliers.logger.stub :debug => true, :info => true, :warn => true, :error => true
 end
          
 RSpec.configure do |config|

data/spec/verifications/shared_spec.rb

@@ -26,17 +26,17 @@ describe Outliers::Verifications::Shared do
   context "#equals?" do
     it "should verify the list of resources equals the list of keys and return no failing reosurces" do
       subject.stub :list_by_key => ['resource1'], :list => [resource1]
-      expect(subject.equals?(:keys => ['resource1'])).to eq([])
+      expect(subject.equals?(['resource1'])).to eq([])
     end
 
     it "should verify the list of resources equals the single key and return no failing resources" do
       subject.stub :list_by_key => ['resource1'], :list => [resource1]
-      expect(subject.equals?(:keys => 'resource1')).to eq([])
+      expect(subject.equals?('resource1')).to eq([])
     end
 
     it "should return resources which do not match the given list" do
       subject.stub :list_by_key => ['resource1', 'resource2'], :list => [resource1, resource2]
-      expect(subject.equals?(:keys => 'resource1')).to eq([resource2])
+      expect(subject.equals?('resource1')).to eq([resource2])
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: outliers
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.5.0.beta1
 platform: ruby
 authors:
 - Brett Weaver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-28 00:00:00.000000000 Z
+date: 2013-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -85,16 +85,19 @@ files:
 - Rakefile
 - bin/outliers
 - lib/outliers.rb
+- lib/outliers/account.rb
 - lib/outliers/cli.rb
 - lib/outliers/cli/process.rb
 - lib/outliers/collection.rb
-- lib/outliers/credentials.rb
 - lib/outliers/evaluation.rb
 - lib/outliers/exceptions.rb
 - lib/outliers/filters.rb
 - lib/outliers/filters/aws.rb
 - lib/outliers/filters/aws/ec2.rb
 - lib/outliers/filters/aws/ec2/tags.rb
+- lib/outliers/handlers.rb
+- lib/outliers/handlers/json.rb
+- lib/outliers/handlers/outliers_api.rb
 - lib/outliers/info.rb
 - lib/outliers/mixins.rb
 - lib/outliers/provider.rb
@@ -139,12 +142,13 @@ files:
 - outliers.gemspec
 - reference.yaml
 - shared.yaml
+- spec/account_spec.rb
 - spec/collection_spec.rb
-- spec/credentials_spec.rb
 - spec/evaluation_spec.rb
 - spec/filters/aws/ec2/tags_spec.rb
-- spec/fixtures/credentials1.yml
-- spec/fixtures/credentials2.yml
+- spec/fixtures/account1.yml
+- spec/fixtures/account2.yml
+- spec/handlers/outliers_api_spec.rb
 - spec/helpers/fixtures.rb
 - spec/info_spec.rb
 - spec/mixins_spec.rb
@@ -156,7 +160,7 @@ files:
 - spec/run_spec.rb
 - spec/spec_helper.rb
 - spec/verifications/shared_spec.rb
-homepage: https://github.com/brettweavnet/outliers
+homepage: http://www.getoutliers.com/documentation
 licenses:
 - Apache2
 metadata: {}
@@ -171,22 +175,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.5
 signing_key: 
 specification_version: 4
 summary: Configuration verification framework.
 test_files:
+- spec/account_spec.rb
 - spec/collection_spec.rb
-- spec/credentials_spec.rb
 - spec/evaluation_spec.rb
 - spec/filters/aws/ec2/tags_spec.rb
-- spec/fixtures/credentials1.yml
-- spec/fixtures/credentials2.yml
+- spec/fixtures/account1.yml
+- spec/fixtures/account2.yml
+- spec/handlers/outliers_api_spec.rb
 - spec/helpers/fixtures.rb
 - spec/info_spec.rb
 - spec/mixins_spec.rb