outdated 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c2b48dd866fe64d213403ec5803a72057d7f4079a69cdba6700505e0ea5d1fa
-  data.tar.gz: e2f9f9a8a6df9c58852641d09f8d78c0fef887f7ff79717bafad6535bcea38c2
+  metadata.gz: 2b201356ed3043dda5fc24fd4811b6aed2b24107f520bac4c47a3c253712ddae
+  data.tar.gz: 49300438741f16d9c260be8877bb158ec8e9e567db526f7da722a33eb360aee9
 SHA512:
-  metadata.gz: c1a0aff5d524fd0512e31cfa72ddc7e5282d403b0f5f57572820b448666a750eec6f19e9bd0b9e36c92cdeb7a36c1c49dea5d6a15c153213435125b4101ee3ad
-  data.tar.gz: 2208411c03af98e1c10a54bca51c0395f0f521cae76b3e740c175094136e46928760c1ca3870e3e89b56d5ad1ad0696cefbd99ce5a60ad0e587e24bcebb4cfa6
+  metadata.gz: e5a3f7ab8f0e9c8dbbd479cac1b036b85dcf5f690117a7aaa2fd49277673ab6e2adb853f1c4956c19f5ce1c35a58830e820c868f7060556caad706af6627f475
+  data.tar.gz: 2e0c9772eb5252844f87c7b4ed5718aeffdc702aee76260805761ef34d34936a65f919788218bfb43da9c29ea4722590fe84f85b3cd8bf3ad98e7eab75c0fe49

data/lib/outdated.rb

@@ -5,9 +5,13 @@ require 'pry'
 
 require_relative 'outdated/cli'
 require_relative 'outdated/ruby_gems'
-require_relative 'outdated/ruby_gems/spec_set'
+require_relative 'outdated/ruby_gems/gem'
+require_relative 'outdated/ruby_gems/spec'
 require_relative 'outdated/version'
 
 module Outdated
   class Error < StandardError; end
+
+  IMMATURE = 'Immature'
+  OUTDATED = 'Outdated'
 end

data/lib/outdated/cli.rb

@@ -3,7 +3,10 @@
 module Outdated
   module CLI
     def self.run
-      one_week_ago = Time.now - 7 * 24 * 60 * 60 # 1 week ago
+      filename = '.outdated.json'
+      options = File.exist?(filename) ? JSON.parse(File.read(filename)) : {}
+      exclusions = options["exclusions"] || []
+
       Bundler.ui = Bundler::UI::Shell.new
       current_specs = Bundler.definition.resolve
       definition = Bundler.definition(true)
@@ -19,34 +22,41 @@ module Outdated
 
       gemfile_specs.sort_by(&:name).each do |used|
         name = used.name
-        # puts "\n" + name
-        # next unless name == 's3_backup'
+        gem_exclusions = exclusions.find { |exc| exc['gem'] == name } || {}
+        excluded_rules = gem_exclusions['rules'] || []
+
+        gem = Outdated::RubyGems.gem(name)
+        next if gem.specs.empty?
 
-        spec_set = Outdated::RubyGems.spec_set(name)
-        next if spec_set.empty?
+        used = gem.get(used.version)
+        next unless used
 
-        used = spec_set.get(used.version)
-        recommended = spec_set.recommend(used, one_week_ago)
+        recommended_spec, code = gem.recommend(used, 1.week.ago)
 
-        outdated = recommended.version > used.version
-        too_new = recommended.version < used.version
+        if code == Outdated::OUTDATED
+          next if excluded_rules.include? Outdated::OUTDATED
 
-        if outdated
           puts "\n#{name} #{used.version} is outdated. " \
-               "#{recommended.version} published #{recommended.created_at}."
+               "#{recommended_spec.version} published #{recommended_spec.created_at}."
           exit_status = 1
-        elsif too_new
+          next
+        end
+
+        if code == Outdated::IMMATURE
+          next if excluded_rules.include? Outdated::IMMATURE
+
           puts "\n#{name} #{used.version} is too new and may contain bugs or " \
                'vulnerabilities that are as yet unknown. It was published ' \
-               "#{used.created_at}. For now use #{recommended.version} " \
-               'instead.'
+               "#{used.created_at}."
+          puts " For now use #{recommended_spec.version} instead." if recommended_spec.present?
           exit_status = 1
-        else
-          putc '.'
+          next
         end
+
+        putc '.'
       end
 
-      puts "\nGem versions deemed to be sufficiently up-to-date." if exit_status == 0
+      puts "\nGem versions deemed to be sufficiently up-to-date." if exit_status.zero?
       exit_status
     end
   end

data/lib/outdated/ruby_gems.rb

@@ -2,9 +2,9 @@ require 'http'
 
 module Outdated
   module RubyGems
-    def self.spec_set(name)
+    def self.gem(name)
       response = HTTP.get("https://rubygems.org/api/v1/versions/#{name}.json")
-      Outdated::RubyGems::SpecSet.from_response(response)
+      Outdated::RubyGems::Gem.from_response(name, response)
     end
   end
 end

data/lib/outdated/ruby_gems/gem.rb

@@ -0,0 +1,65 @@
+module Outdated
+  module RubyGems
+    class Gem
+      def self.from_response(name, response)
+        return new if response.code == 404
+
+        body = response.body
+        specs = JSON.parse(body).map { |spec| Outdated::RubyGems::Spec.from_response_object(name, spec) }
+        new(specs)
+      end
+
+      attr_reader :specs
+
+      def initialize(specs = [])
+        @specs = specs
+
+        raise ArgumentError, "conflicting spec names" unless specs.uniq(&:name).count < 2
+      end
+
+      def name
+        specs.first.name
+      end
+
+      def empty?
+        specs.empty?
+      end
+
+      def size
+        specs.size
+      end
+
+      def first
+        specs.first
+      end
+
+      def get(version)
+        specs.find { |spec| spec.version == version }
+      end
+
+      def recommend(currently_used_spec, cut_off)
+        recommended_spec = specs.find do |spec|
+          semver = spec.version.to_s.split(/\./).map(&:to_i)
+          currently_used_semver = currently_used_spec.version.to_s.split(/\./).map(&:to_i)
+          prerelease = spec.prerelease
+          too_new = cut_off < spec.created_at
+          minor_or_major_upgrade =
+            semver[0] > currently_used_semver[0] || semver[1] > currently_used_semver[1]
+
+          !prerelease && !too_new && !minor_or_major_upgrade
+        end
+
+        code =
+          if recommended_spec.nil?
+            Outdated::IMMATURE
+          elsif recommended_spec > currently_used_spec
+            Outdated::OUTDATED
+          elsif recommended_spec < currently_used_spec
+            Outdated::IMMATURE
+          end
+
+        [recommended_spec, code]
+      end
+    end
+  end
+end

data/lib/outdated/ruby_gems/spec.rb

@@ -0,0 +1,30 @@
+module Outdated
+  module RubyGems
+    class Spec
+      include Comparable
+
+      def self.from_response_object(name, response_object)
+        Outdated::RubyGems::Spec.new(created_at: response_object['created_at'].to_time,
+                                     name: name,
+                                     prerelease: response_object['prerelease'],
+                                     version: ::Gem::Version.new(response_object['number']))
+      end
+
+      attr_reader :created_at, :name, :prerelease, :version
+
+      def initialize(args)
+        @created_at = args[:created_at] or raise ArgumentError, "missing created_at"
+        @name = args[:name] or raise ArgumentError, "missing name"
+
+        @prerelease = args[:prerelease]
+        raise ArgumentError, "missing prerelease" if @prerelease.nil?
+
+        @version = args[:version] or raise ArgumentError, "missing version"
+      end
+
+      def <=>(other)
+        version <=> other.version
+      end
+    end
+  end
+end

data/lib/outdated/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Outdated
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: outdated
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Keith Broughton
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-26 00:00:00.000000000 Z
+date: 2019-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -119,7 +119,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".safe.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -132,7 +131,8 @@ files:
 - lib/outdated.rb
 - lib/outdated/cli.rb
 - lib/outdated/ruby_gems.rb
-- lib/outdated/ruby_gems/spec_set.rb
+- lib/outdated/ruby_gems/gem.rb
+- lib/outdated/ruby_gems/spec.rb
 - lib/outdated/version.rb
 - outdated.gemspec
 homepage: https://github.com/keithbro/outdated

data/.safe.yml

@@ -1,4 +0,0 @@
----
-
-Exclude:
-  - http

data/lib/outdated/ruby_gems/spec_set.rb

@@ -1,53 +0,0 @@
-module Outdated
-  module RubyGems
-    class SpecSet
-      def self.from_response(response)
-        return new if response.code == 404
-
-        body = response.body
-        specs = JSON.parse(body).map do |spec|
-          spec['created_at'] = Time.parse(spec['created_at'])
-          spec['version'] = Gem::Version.new(spec['number'])
-
-          OpenStruct.new(spec)
-        end
-        new(specs)
-      end
-
-      attr_reader :specs
-
-      def initialize(specs = [])
-        @specs = specs
-      end
-
-      def empty?
-        specs.empty?
-      end
-
-      def size
-        specs.size
-      end
-
-      def first
-        specs.first
-      end
-
-      def get(version)
-        specs.find { |spec| spec.version == version }
-      end
-
-      def recommend(status_quo_spec, cut_off)
-        specs.find do |spec|
-          semver = spec.version.to_s.split(/\./).map(&:to_i)
-          status_quo_semver = status_quo_spec.version.to_s.split(/\./).map(&:to_i)
-          prerelease = spec.prerelease
-          too_new = cut_off < spec.created_at
-          minor_or_major_upgrade =
-            semver[0] > status_quo_semver[0] || semver[1] > status_quo_semver[1]
-
-          !prerelease && !too_new && !minor_or_major_upgrade
-        end
-      end
-    end
-  end
-end