outbox-bandwidth 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe84da290b87177f84735ff437f2d5600d8efbfda6c55920db8ea720882061b9
-  data.tar.gz: bb13853fa6ae2fa479cb5349cf2f909824b16cbdbf161e5d1e023387e7ffe2fb
+  metadata.gz: 60b94af8abf93c73a1d8b43a086cd6ff394470230c7e7da25c0d0934fe6f2463
+  data.tar.gz: d093735ad46d6758aa39eb9ab79283672cad1a20d7aeaf62f3476c3c9a401a43
 SHA512:
-  metadata.gz: '08f16ee11879814ac458d923dee1e94717a8e6402ce94cb15e05fbcae2dfa3891b4506595113d5084b3e642faaad5e715256474934e96a3fa61938af9ea1c894'
-  data.tar.gz: 8c1387469eaddb1eb2225ef320e5477653e31d6258d392b59d2c136afbd93d92791a1769791121ba0f2c8b49f0e78ec8160b479e9324aa24ea14b77f2fec7b2b
+  metadata.gz: eb1d5bc634ac50b29c9347e366c4286b503fa74999765cc6974532f2d9e04054539a4bf10f78ccabd662434f599249fce88b843e90b94312dd6aa8cf8f8e8946
+  data.tar.gz: 1eaef2caa45b6f8044bf73c786204dec73bcb2e32e5e89957c6b94837c747296c0c3e2d06e5e18d501b440076d01d2fdb9041bc7754be96bd9e0962b6be9541a

data/lib/outbox/bandwidth/client.rb

@@ -7,12 +7,8 @@ module Outbox
     # Uses Bandwidth's official Ruby API client (bandwidth) to deliver
     # SMS messages.
     #
-    #   Outbox::Messages::SMS.default_client(
-    #     :bandwidth,
-    #     account_sid: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
-    #     token: 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy',
-    #     secret: 'zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz'
-    #   )
+    # https://dev.bandwidth.com/sdks/ruby.html
+    #
     #   sms = Outbox::Messages::SMS.new(
     #     to: '+15552224444',
     #     from: '+15551115555',
@@ -25,14 +21,22 @@ module Outbox
 
       def initialize(settings = nil)
         super
-
         options = @settings.dup
-        @api_client = ::Bandwidth::Client.new(
-          messaging_basic_auth_user_name: options[:token],
-          messaging_basic_auth_password: options[:secret]
+        bandwidth_client_settings = options.slice(
+          :messaging_basic_auth_user_name, 
+          :messaging_basic_auth_password, 
+          :voice_basic_auth_user_name, 
+          :voice_basic_auth_password,
+          :two_factor_auth_basic_auth_user_name,
+          :two_factor_auth_basic_auth_password,
+          :environment,
+          :base_url
         )
         @account_id = options[:subaccount_id] || options[:account_id]
         @application_id = options[:application_id]
+        @api_client = ::Bandwidth::Client.new(
+          bandwidth_client_settings
+        )
       end
 
       def deliver(sms)

data/lib/outbox/bandwidth/version.rb

@@ -2,6 +2,6 @@
 
 module Outbox
   module Bandwidth
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/spec/outbox/bandwidth/client_spec.rb

@@ -5,17 +5,37 @@ require 'ostruct'
 
 describe Outbox::Bandwidth::Client do
   describe '.new' do
-    it 'configures the Bandwidth API client' do
-      api_client = double(:api_client)
-      expect(::Bandwidth::Client).to receive(:new).with(
-        messaging_basic_auth_user_name: 'AC1',
-        messaging_basic_auth_password: 'abcdef'
-      ).and_return(api_client)
-      client = Outbox::Bandwidth::Client.new(
-        token: 'AC1',
-        secret: 'abcdef'
-      )
-      expect(client.api_client).to be(api_client)
+    context 'with a messaging_basic_auth' do
+      it 'configures the Bandwidth API client' do
+        api_client = double(:api_client)
+        expect(::Bandwidth::Client).to receive(:new).with(
+          messaging_basic_auth_user_name: 'AC1',
+          messaging_basic_auth_password: 'abcdef'
+        ).and_return(api_client)
+        client = Outbox::Bandwidth::Client.new(
+          messaging_basic_auth_user_name: 'AC1',
+          messaging_basic_auth_password: 'abcdef'
+        )
+        expect(client.api_client).to be(api_client)
+      end
+    end
+    context 'with a custom environment and base url' do
+      it 'configures the Bandwidth API client' do
+        api_client = double(:api_client)
+        expect(::Bandwidth::Client).to receive(:new).with(
+          messaging_basic_auth_user_name: 'AC1',
+          messaging_basic_auth_password: 'abcdef',
+          environment: 'custom_env',
+          base_url: 'custom.test.com'
+        ).and_return(api_client)
+        client = Outbox::Bandwidth::Client.new(
+          messaging_basic_auth_user_name: 'AC1',
+          messaging_basic_auth_password: 'abcdef',
+          environment: 'custom_env',
+          base_url: 'custom.test.com'
+        )
+        expect(client.api_client).to be(api_client)
+      end
     end
   end
 
@@ -30,8 +50,8 @@ describe Outbox::Bandwidth::Client do
         messaging_basic_auth_password: 'abcdef'
       ).and_return(@api_client)
       @client = Outbox::Bandwidth::Client.new(
-        token: 'AC1',
-        secret: 'abcdef',
+        messaging_basic_auth_user_name: 'AC1',
+        messaging_basic_auth_password: 'abcdef',
         account_id: 'account_1'
       )
       @sms = Outbox::Messages::SMS.new do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: outbox-bandwidth
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Pete Browne
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-22 00:00:00.000000000 Z
+date: 2020-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bandwidth-sdk