otto 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c17a841334ba79be6d1c4625eb8e8e39eda301be3a77813c8ea6386bb3d0d6b5
-  data.tar.gz: 2639d6f7ef18aa85bf75646d5c9d97814d1bf3a585e53003de7ccb4e8ce1eccf
+  metadata.gz: 7974135aa7b516b1d0424fd1fb7f686524f0d091168a19df5527ec1e69d7314f
+  data.tar.gz: a20a52ce1479f00f880afa3ad43ed43bb85f34e519c9e024cd717a7d873dad5c
 SHA512:
-  metadata.gz: 40e9f5ed072e4d86dd27c49d397fa3ece8904420a3264166ad187aeea9c26c3818c32c45986903914df664cbb7671c8edabad18601f60013c8f05d2ce742d65f
-  data.tar.gz: 95d85cabd00d26658ce816021289ca7a21600dee34ac051ccfa6cf79b8713742d5389e67042d49991a1a63794fe30e3cd76d11bfb7d3ee52a8281e42e184174b
+  metadata.gz: 6a69222b7e5234e487d0098a25bbd36b2e9fc7637f563cf9f6b8562e5b03a314f06b97de755a1ec061310222c8c8ac35f215a8f6ad2b0d3e541ba1eec658f73d
+  data.tar.gz: 503f510059cc42f553981cd5ec27a19c5655d2047e11263eb81c63d7b2a49a09ebcd7f5df83da6f68e295b9927f8859812a2240ad4b1e05e8365702cfb89f91b

data/.gitignore

@@ -9,6 +9,7 @@
 *.md
 *.txt
 !LICENSE.txt
+!spec/fixtures/*.txt
 .ruby-version
 appendonlydir
 etc/config

data/.rubocop.yml

@@ -8,66 +8,410 @@
 # refer to the RuboCop documentation:
 # https://docs.rubocop.org/rubocop/cops.html
 #
-# Running `rubocop --regenerate-todo` will update the todo file
-# with the latest state of the onion (using the same options
-# as those documented at the top of the todo file). This is
-# useful for a gradual migration of the codebase.
-#
-inherit_from: .rubocop_todo.yml
 
 plugins:
   - rubocop-performance
   - rubocop-thread_safety
+  - rubocop-rspec
 
 AllCops:
   NewCops: enable
+  DisabledByDefault: false # flip to true for a good autocorrect time
   UseCache: true
   MaxFilesInCache: 100
   TargetRubyVersion: 3.4
   Exclude:
-    - "migrate/**/*.rb"
-    - "migrate/*.rb"
-    - "try/**/*"
-    - "try/*.rb"
+    - "spec/**/*.rb"
     - "vendor/**/*"
 
+Layout/CaseIndentation:
+  Enabled: true
+  EnforcedStyle: end # case, end
+  IndentOneStep: false
+  IndentationWidth: 2
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+  EnforcedStyle: new_line # symmetrical, new_line, same_line
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: false
+
+# Use parentheses around a logical expression if it makes easier to read.
+Style/RedundantParentheses:
+  Enabled: false
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+
+Lint/UselessAssignment:
+  Enabled: true
+
+Lint/DuplicateBranch:
+  Enabled: true
+  IgnoreLiteralBranches: false
+  IgnoreConstantBranches: false
+  IgnoreDuplicateElseBranch: false
+
+# Offense count: 3
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 20
+
+# Offense count: 186
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Enabled: false
+
+Style/RescueStandardError:
+  Enabled: true
+  EnforcedStyle: explicit
+
+# When true: Use match? instead of =~ when MatchData is not used. True is preferred but not for autocorrection. Regexs are too picky. Need to manually check every time.
+Performance/RegexpMatch:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: single_quotes
+
+# The Style/DoubleNegation cop is disabled because double negation provides
+# a concise, idiomatic way to convert values to boolean in Ruby. Alternative
+# approaches like ternary expressions or comparison with nil create unnecessary
+# verbosity without adding clarity. In cases where boolean coercion is the
+# explicit intent, !! clearly communicates this purpose to other Ruby developers.
+Style/DoubleNegation:
+  Enabled: false
+
+# Offense count: non-0
+Style/FormatString:
+  EnforcedStyle: format
+  Enabled: true
+
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
+  Enabled: true
+
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+# We prefer `extend self` and `class << self`.
+Style/ModuleFunction:
+  Enabled: true
+  AutoCorrect: false
+  EnforcedStyle: extend_self
+
+# Prefer 3 line if/else over one-liner
+Style/GuardClause:
+  Enabled: true
+  MinBodyLength: 3
+  AllowConsecutiveConditionals: false
+
+Style/SymbolArray:
+  EnforcedStyle: brackets
+  Enabled: true
+
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+
+Style/BlockDelimiters:
+  Enabled: true
+
+Naming/PredicateMethod:
+  Enabled: true
+  Mode: "conservative"
+  AllowedMethods:
+    - validate!
+    - migrate
+
+# We use class instance variables quite a bit, mostly for readonly values set
+# at boot time. Except for our models with have redis-rb Redis instances
+# connected on their associated db via ModelClass.dbclient. We're well aware
+# so keeping this disabled reduces warning noise.
+ThreadSafety/ClassInstanceVariable:
+  Enabled: false
+
+Naming/RescuedExceptionsVariableName:
+  Enabled: true
+  PreferredName: ex # Default is 'e'
+
+Naming/PredicatePrefix:
+  Enabled: true
+  ForbiddenPrefixes: [is_, has_, have_]
+  AllowedMethods: [
+      has_passphrase?, # correlates with the REST API field `has_passphrase`
+    ]
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+  IndentationWidth: 2
+
 Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 
 Gemspec/DevelopmentDependencies:
   Enabled: true
 
-Layout/HashAlignment:
+Layout/ElseAlignment:
   Enabled: false
 
-Lint/Void:
+Layout/EndAlignment:
   Enabled: false
+  # Severity: low
+  # SupportedStylesAlignWith: 2
+  # Leave commented out. When we set align with, endless "error occurred"
+  # EnforcedStyle: keyword # keyword, variable, start_of_line
 
+Layout/ExtraSpacing:
+  Enabled: true
+  AllowForAlignment: true
+  AllowBeforeTrailingComments: true
+  ForceEqualSignAlignment: true
+
+Layout/IndentationConsistency:
+  EnforcedStyle: indented_internal_methods
+  Enabled: true
+
+Layout/IndentationWidth:
+  # We don't want to enforce indentation width because it's doing weird things
+  # with if/else statements that capture values. The `if` expression is aligned
+  # with the right side of the `test` but the `else` expression is aligned with
+  # the start of the line.
+  Width: 2
+  Enabled: false
+
+Layout/HashAlignment:
+  Enabled: true
+
+Layout/FirstHashElementIndentation:
+  Enabled: true
+
+Lint/Void:
+  Enabled: true
+
+Lint/CopDirectiveSyntax:
+  Enabled: true
+
+# Offense count: 122
+# Assignment Branch Condition size
 Metrics/AbcSize:
   Enabled: false
   Max: 20
 
-Metrics/ClassLength:
+# Offense count: 217
+Layout/LineLength:
+  Enabled: false
+  AllowHeredoc: true
+  AllowURI: true
+  URISchemes:
+    - https
+  IgnoreCopDirectives: true
+  AllowedPatterns: []
+  SplitStrings: false
+  Max: 100
+
+# Align the arguments of a method call if they span more than one line.
+Layout/ArgumentAlignment:
   Enabled: true
-  Max: 200
+  EnforcedStyle: with_fixed_indentation # with_first_argument, with_fixed_indentation
+  IndentationWidth: 2
 
-Metrics/CyclomaticComplexity:
-  Enabled: false
+Layout/EmptyLineAfterGuardClause:
+  Enabled: true
 
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: true
+
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Metrics/ClassLength:
+  Enabled: true
+  Max: 350
+
+# Offense count: non-0
 Metrics/MethodLength:
   Enabled: true
-  Max: 40
+  Max: 50
   CountAsOne: ["method_call"]
 
 Metrics/ModuleLength:
   Enabled: true
-  Max: 250
+  Max: 350
   CountAsOne: ["method_call"]
 
 Performance/Size:
   Enabled: true
-  Exclude:
-  #   - lib/example.rb
+  Exclude: []
+
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
 
 Style/NegatedIfElseCondition:
   Enabled: true
+
+Style/TrailingCommaInArguments:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+# Use #empty? when testing for objects of length 0.
+Style/ZeroLengthPredicate:
+  Enabled: true
+  Safe: true
+
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: never
+
+Style/SuperArguments:
+  Enabled: true
+
+# Offense count: non-0
+ThreadSafety/ClassAndModuleAttributes:
+  Description: Avoid mutating class and module attributes.
+  Enabled: true
+  ActiveSupportClassAttributeAllowed: false
+
+ThreadSafety/DirChdir:
+  Description: Avoid using `Dir.chdir` due to its process-wide effect.
+  Enabled: true
+  AllowCallWithBlock: false
+
+# Do not assign mutable objects to class instance variables.
+ThreadSafety/MutableClassInstanceVariable:
+  Description:
+  Enabled: true
+  EnforcedStyle: literals # one of literals, strict
+  SafeAutoCorrect: false
+
+# Avoid starting new threads. Let a framework like Sidekiq handle the threads.
+ThreadSafety/NewThread:
+  Enabled: true
+
+# Avoid instance variables in Rack middleware.
+ThreadSafety/RackMiddlewareInstanceVariable:
+  Description:
+  Enabled: true
+  Include:
+    - lib/middleware/*.rb
+    - lib/middleware/onetime/*.rb
+
+# Unsafe autocorrect:
+Performance/MapCompact:
+  Enabled: false
+Performance/StringInclude:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/GlobalStdStream:
+  Enabled: false
+Style/HashConversion:
+  Enabled: false
+Style/HashEachMethods:
+  Enabled: false
+Style/IdenticalConditionalBranches:
+  Enabled: false
+Style/MinMaxComparison:
+  Enabled: false
+Style/MutableConstant:
+  Enabled: false
+Style/NumericPredicate:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Style/RedundantInterpolation:
+  Enabled: false
+Style/SafeNavigation:
+  Enabled: false
+Style/SpecialGlobalVars:
+  Enabled: false
+Style/StringConcatenation:
+  Enabled: false
+Style/SymbolProc:
+  Enabled: false
+
+# warnings
+Lint/RedundantCopDisableDirective:
+  Enabled: false
+Lint/AssignmentInCondition:
+  Enabled: false
+
+# Manual corrections
+Metrics/BlockLength:
+  Enabled: false
+Metrics/BlockNesting:
+  Enabled: false
+Metrics/ParameterLists:
+  Enabled: false
+Naming/AccessorMethodName:
+  Enabled: false
+Naming/MethodParameterName:
+  Enabled: false
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+# warnings
+Lint/DuplicateMethods:
+  Enabled: false
+Lint/UselessOr:
+  Enabled: false
+Lint/UnreachableLoop:
+  Enabled: false
+Lint/MissingCopEnableDirective:
+  Enabled: false
+Lint/MissingSuper:
+  Enabled: false
+Lint/EmptyFile:
+  Enabled: false
+Lint/RescueException:
+  Enabled: false

data/Gemfile

@@ -5,8 +5,8 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'rspec', '~> 3.12'
   gem 'rack-test'
+  gem 'rspec', '~> 3.12'
 end
 
 group 'development' do

data/Gemfile.lock

@@ -1,8 +1,7 @@
 PATH
   remote: .
   specs:
-    otto (1.2.0)
-      addressable (~> 2.2, < 3)
+    otto (1.3.0)
       rack (~> 3.1, < 4.0)
       rack-parser (~> 0.7)
       rexml (>= 3.3.6)
@@ -10,32 +9,45 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.7)
-      public_suffix (>= 2.0.2, < 7.0)
-    ast (2.4.2)
-    byebug (11.1.3)
+    ast (2.4.3)
+    byebug (12.0.0)
     coderay (1.1.3)
+    date (3.4.1)
     diff-lcs (1.6.2)
-    drydock (0.6.9)
-    json (2.7.2)
-    language_server-protocol (3.17.0.3)
+    erb (5.0.2)
+    io-console (0.8.1)
+    irb (1.15.2)
+      pp (>= 0.6.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    json (2.13.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     logger (1.7.0)
-    method_source (1.0.0)
-    parallel (1.24.0)
-    parser (3.3.0.5)
+    method_source (1.1.0)
+    minitest (5.25.5)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
+    pastel (0.8.0)
+      tty-color (~> 0.5)
+    pp (0.6.2)
+      prettyprint
     prettier_print (1.2.1)
+    prettyprint (0.2.0)
     prism (1.4.0)
-    pry (0.14.2)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.10.1)
-      byebug (~> 11.0)
-      pry (>= 0.13, < 0.15)
-    public_suffix (6.0.1)
-    racc (1.7.3)
-    rack (3.1.16)
+    pry-byebug (3.11.0)
+      byebug (~> 12.0)
+      pry (>= 0.13, < 0.16)
+    psych (5.2.6)
+      date
+      stringio
+    racc (1.8.1)
+    rack (3.2.0)
     rack-parser (0.7.0)
       rack
     rack-test (2.2.0)
@@ -43,8 +55,13 @@ GEM
     rainbow (3.1.1)
     rbs (3.9.4)
       logger
-    regexp_parser (2.9.0)
-    rexml (3.3.7)
+    rdoc (6.14.2)
+      erb
+      psych (>= 4.0.0)
+    regexp_parser (2.11.0)
+    reline (0.6.2)
+      io-console (~> 0.5)
+    rexml (3.4.1)
     rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -58,44 +75,57 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.4)
-    rubocop (1.62.1)
+    rubocop (1.79.1)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.2)
-      parser (>= 3.3.0.4)
-    rubocop-performance (1.23.1)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (3.4.0)
-      rubocop (~> 1.61)
-    rubocop-thread_safety (0.6.0)
-      rubocop (>= 1.48.1)
-    ruby-lsp (0.26.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-thread_safety (0.7.3)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    ruby-lsp (0.26.1)
       language_server-protocol (~> 3.17.0)
       prism (>= 1.2, < 2.0)
       rbs (>= 3, < 5)
     ruby-progressbar (1.13.0)
     stackprof (0.2.27)
-    storable (0.10.0)
+    stringio (3.1.7)
     syntax_tree (6.3.0)
       prettier_print (>= 1.2.0)
-    sysinfo (0.10.0)
-      drydock (< 1.0)
-      storable (~> 0.10)
-    tryouts (2.2.0)
-      sysinfo (~> 0.10)
-    unicode-display_width (2.5.0)
+    tryouts (3.2.1)
+      irb
+      minitest (~> 5.0)
+      pastel (~> 0.8)
+      prism (~> 1.0)
+      rspec (~> 3.0)
+      tty-cursor (~> 0.7)
+      tty-screen (~> 0.8)
+    tty-color (0.6.0)
+    tty-cursor (0.7.1)
+    tty-screen (0.8.2)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
-  arm64-darwin-22
+  arm64-darwin-24
   ruby
 
 DEPENDENCIES
@@ -113,4 +143,4 @@ DEPENDENCIES
   tryouts
 
 BUNDLED WITH
-   2.5.7
+   2.6.9