osu-ctl-scraper 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f61f5674ffa411e662d676ca6a1a5c68c3c35b8
-  data.tar.gz: 08336a7892b67f47adf6ad823005f23b057ff9b6
+  metadata.gz: 37bb61bf74de86fd115f1b1f882cd7ba718a1c58
+  data.tar.gz: ae2c386e394e04c5dcaf47b0d4305279522388fa
 SHA512:
-  metadata.gz: b9283653ac17768853f815ecad02e26011df72bf67b099e70b5469c60a4873e73ca717457ba568948b4f473ac646905521d1a5c48298831c63494c8ea144ecb1
-  data.tar.gz: d427cdc637e0eecf8072ba812b7d1d08b44b8614f09e25537c415b39b94c634a74e3027ab77fd47d9281ad797ad65763d85d987c6d09a0f583c86f7adc964ad8
+  metadata.gz: 60432b3d327c03fc4b351bb9209b101d1cca9b0e26d092cc541cfb26dcd16b6d6ff1f1530013a447287c21f5494fbcc627ccccb279028c6f0f0d922fd3b89e34
+  data.tar.gz: df06011ff10ca5aeecfbba2544ab3497185a06b2cc1a7ec3827eba54ccea108774dc3f447da829acc46c5111e097c3491fdd5f3bf69482959b7ad8494b0e58d2

data/lib/osu-ctl-scraper.rb

@@ -4,6 +4,7 @@ require "json"
 require "open-uri"
 
 module OsuCtlScraper
+  ENDPOINT = "http://osubeaverstore.com"
 end
 
 require "osu-ctl-scraper/department"

data/lib/osu-ctl-scraper/book.rb

@@ -1,10 +1,14 @@
 module OsuCtlScraper
   class Book
-    # Returns an array of Books for the given options
+    RESOURCE = "/Faculty/GetTextbooks/"
+
+    # Returns an array of Books
     #
-    # @param  [Hash] options
+    # @param  [String] subject_code
+    # @param  [Integer] year
+    # @param  [Symbol] term Must be one of: "winter", "spring", "summer", or "fall"
     # @return [Array<Hash>]
-    def self.where(subject_code, year, term)
+    def self.find_by(subject_code, year, term)
       res = get_html(subject_code, year, term)
       html = format_response(res.body)
       process_html(subject_code, html)
@@ -15,7 +19,7 @@ module OsuCtlScraper
     # @param  [Symbol] term Must be one of: "winter", "spring", "summer", or "fall"
     # @return [String]
     def self.get_html(subject_code, year, term)
-      url = URI.parse("http://osubeaverstore.com/Faculty/GetTextbooks/")
+      url = URI.parse("#{ENDPOINT}#{RESOURCE}")
       params = form_params(subject_code, year, term)
       res = Net::HTTP.post_form(url, params)
     end
@@ -60,16 +64,18 @@ module OsuCtlScraper
       ng = Nokogiri::HTML(html)
       ng.css("tr:not(:first-child)").each do |row|
         book = process_row(row)
-        book[:subject_code] = subject_code
-        books << book
+        unless book.nil?
+          book[:subject_code] = subject_code
+          books << book
+        end
       end
       books
     end
 
     # @param  [Nokogiri::XML::Element] row
-    # @return [Hash]
+    # @return [Hash, nil]
     def self.process_row(row)
-      {
+      book = {
         course:      row.css("td:nth-child(1)").text.strip,
         section:     row.css("td:nth-child(2)").text.strip,
         instructor:  row.css("td:nth-child(3)").text.strip,
@@ -83,6 +89,9 @@ module OsuCtlScraper
         comments:    row.css("td:nth-child(11)").text.strip,
         req_date:    row.css("td:nth-child(12)").text.strip
       }
+
+      # Only return the book if is has an ISBN
+      book[:isbn].empty? ? nil : book
     end
   end
 end

data/lib/osu-ctl-scraper/department.rb

@@ -1,5 +1,7 @@
 module OsuCtlScraper
   class Department
+    RESOURCE = "/faculty/textbooks/"
+
     # @return [Array<Hash>]
     def self.all
       html = get_html
@@ -8,7 +10,7 @@ module OsuCtlScraper
 
     # @return [String] html
     def self.get_html
-      open("http://osubeaverstore.com/faculty/textbooks/").read
+      open("#{ENDPOINT}#{RESOURCE}").read
     end
 
     # @param  [String] html

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: osu-ctl-scraper
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jonah George