osm 1.2.0 → 1.2.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 1.2.1
+
+  * Add section\_id read-only attribute to Osm::Error::NoCurrentTerm
+
 ## Version 1.2.0
 
   * Trying to fetch the currrent Term for a Section which doesn;t have one now raises an Osm::Error::NoCurrentTerm instead of an Osm::Error 

data/lib/osm.rb

@@ -14,7 +14,15 @@ module Osm
   class Forbidden < Osm::Error; end
   class ArgumentIsInvalid < ArgumentError; end
   class ObjectIsInvalid < Error; end
-  class Osm::Error::NoCurrentTerm < Osm::Error; end
+  class Osm::Error::NoCurrentTerm < Osm::Error
+    # @!attribute [r] section_id
+    #   @return [Fixnum] the id of the section causing the error
+    attr_reader :section_id
+    def initialize(message = nil, section_id = nil)
+      super(message)
+      @section_id = section_id
+    end
+  end
 
   private
   # Set constants

data/lib/osm/term.rb

@@ -114,7 +114,7 @@ module Osm
         return term if term.current?
       end
 
-      raise Osm::Error::NoCurrentTerm, 'There is no current term for the section.'
+      raise Osm::Error::NoCurrentTerm.new('There is no current term for the section.', section_id)
     end
 
     # Create a term in OSM

data/osm.gemspec

@@ -4,6 +4,7 @@ require File.join(File.dirname(__FILE__), 'version')
 
 Gem::Specification.new do |s|
   s.name        = "osm"
+  s.license     = 'BSD 3 clause'
   s.version     = Osm::VERSION
   s.authors     = ['Robert Gauld']
   s.email       = ['robert@robertgauld.co.uk']

data/spec/osm/term_spec.rb

@@ -190,8 +190,12 @@ describe "Term" do
         body += '{"termid":"1","name":"Term 1","sectionid":"9","startdate":"' + (Date.today + 31).strftime('%Y-%m-%d') + '","enddate":"' + (Date.today + 90).strftime('%Y-%m-%d') + '"}'
         body += ']}'
         FakeWeb.register_uri(:post, "https://www.onlinescoutmanager.co.uk/api.php?action=getTerms", :body => body)
-    
-        expect{ Osm::Term.get_current_term_for_section(@api, 9) }.to raise_error(Osm::Error::NoCurrentTerm, 'There is no current term for the section.')
+
+        expect{ Osm::Term.get_current_term_for_section(@api, 9) }.to raise_error do |error|
+          error.should be_a(Osm::Error::NoCurrentTerm)
+          error.message.should == 'There is no current term for the section.'
+          error.section_id.should == 9
+        end
       end
     end
 

data/version.rb

@@ -1,3 +1,3 @@
 module Osm
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: osm
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-02 00:00:00.000000000 Z
+date: 2013-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -232,7 +232,8 @@ files:
 - spec/spec_helper.rb
 - version.rb
 homepage: https://github.com/robertgauld/osm
-licenses: []
+licenses:
+- BSD 3 clause
 post_install_message: 
 rdoc_options: []
 require_paths: