osc_ruby 0.1.13 → 0.2.0

data/spec/core/client_spec.rb

@@ -36,23 +36,62 @@ describe OSCRuby::Client do
 			end.to raise_error("Password cannot be nil or blank")
 		end
 
-		it 'should create a configuration object' do
+		it 'should raise exception if no_ssl_verify not a TrueClass nor a FalseClass' do
 			expect do
-				client = OSCRuby::Client.new do |config|
+				OSCRuby::Client.new do |config|
 					config.interface = 'test'
 					config.username = 'test_username'
-					config.password = 'test_password'
+					config.password = 'password'
+					config.no_ssl_verify = 'true'
 				end
+			end.to raise_error("The no SSL verification setting must be set to true or false")
+		end
 
-				client.config.interface.should eq('test')
-				client.config.interface.should !='test1'
-
-				client.config.username.should eq('test_username')
-				client.config.username.should !='test1_username'
+		it 'should raise exception if Connect Version is null' do
+			expect do
+				OSCRuby::Client.new do |config|
+					config.interface = 'test'
+					config.username = 'test_username'
+					config.password = 'password'
+					config.version = nil
+				end
+			end.to raise_error("Connect version cannot be null")
+		end
 
-				client.config.interface.should eq('test_password')
-				client.config.interface.should !='test1_password'
+		let(:client){
+			OSCRuby::Client.new do |config|
+				config.interface = 'test'
+				config.username = 'test_username'
+				config.password = 'test_password'
+				config.no_ssl_verify = true
 			end
+		}
+
+		it 'should create a configuration object' do
+
+			expect{client}.to_not raise_error
+
+		end
+
+		it 'should have interface set to "test" and not "test1"' do
+			expect(client.config.interface).to eq('test')
+			expect(client.config.interface).not_to eq('test1')
+		end
+
+		it 'should have username set to "test_username" and not "test1_username"' do
+			expect(client.config.username).to eq('test_username')
+			expect(client.config.username).not_to eq('test1_username')
 		end
+
+		it 'should have password set to "test_password" and not "test1_password"' do
+			expect(client.config.password).to eq('test_password')
+			expect(client.config.password).not_to eq('test1_password')
+		end
+
+		it 'should have no_ssl set to true and not false' do
+			expect(client.config.no_ssl_verify).to eq(true)
+			expect(client.config.no_ssl_verify).not_to eq(false)
+		end
+
 	end
 end

data/spec/core/connect_spec.rb

@@ -135,7 +135,7 @@ describe OSCRuby::Connect do
 
 	context '#post_or_patch' do
 
-		it 'should take at least a config parameter that is an instance of an OSCRuby::Client' do
+		it 'should take at least a config parameter that is an instance of an OSCRuby::Client', :vcr do
 
 			expect(client).to be_an(OSCRuby::Client)
 
@@ -178,7 +178,7 @@ describe OSCRuby::Connect do
 
 		end
 
-		it 'should produce a Net::HTTPResponse, should produce a 201 response code, and should produce a JSON Response form the response body' do
+		it 'should produce a Net::HTTPResponse, should produce a 201 response code, and should produce a JSON Response form the response body', :vcr do
 
 			names = []
 
@@ -213,15 +213,11 @@ describe OSCRuby::Connect do
 				
 		end
 
-	end
-
-	let(:test){
-		OSCRuby::Connect.get(client)
-	}
+	end	
 
 	context '#get' do
 
-		it 'should take at least a config parameter that is an instance of an OSCRuby::Client' do
+		it 'should take at least a config parameter that is an instance of an OSCRuby::Client', :vcr do
 
 			expect(client).to be_an(OSCRuby::Client)
 
@@ -245,19 +241,25 @@ describe OSCRuby::Connect do
 
 		end
 
-		it 'should produce a Net::HTTPResponse' do
+		it 'should produce a Net::HTTPResponse', :vcr do
+
+			test = OSCRuby::Connect.get(client)
 
 			expect(test).to be_an(Net::HTTPResponse)
 				
 		end
 
-		it 'should produce a 200 response code' do
+		it 'should produce a 200 response code', :vcr do
+
+			test = OSCRuby::Connect.get(client)
 
 			expect(test.code).to eq("200")
 				
 		end
 
-		it 'should produce a JSON Response from the response body' do
+		it 'should produce a JSON Response from the response body', :vcr do
+
+			test = OSCRuby::Connect.get(client)
 			
 			expect(test.body).to be_an(String)
 
@@ -266,21 +268,18 @@ describe OSCRuby::Connect do
 
 	end
 
-	let(:product_test_id){
-
-		resource = URI.escape("queryResults/?query=select id from serviceproducts where lookupname = 'PRODUCT-TEST';")
 
-		product_test = OSCRuby::Connect.get(client,resource)
+	context '#post_or_patch' do
 
-		prod_json = JSON.parse(product_test.body).to_hash
+		it 'should take an optional parameter to allow PATCH request; it should produce a Net::HTTPResponse, should produce a 200 code', :vcr do
 
-		prod_json['items'][0]['rows'][0][0].to_i
+			resource = URI.escape("queryResults/?query=select id from serviceproducts where lookupname = 'PRODUCT-TEST';")
 
-	}
+			product_test = OSCRuby::Connect.get(client,resource)
 
-	context '#post_or_patch' do
+			prod_json = JSON.parse(product_test.body).to_hash
 
-		it 'should take an optional parameter to allow PATCH request; it should produce a Net::HTTPResponse, should produce a 200 code' do
+			product_test_id = prod_json['items'][0]['rows'][0][0].to_i
 
 			names = []
 
@@ -315,18 +314,6 @@ describe OSCRuby::Connect do
 
 	end
 
-	let(:product_test_updated_id){
-
-		resource = URI.escape("queryResults/?query=select id from serviceproducts where lookupname = 'PRODUCT-TEST-updated';")
-
-		product_test_updated = OSCRuby::Connect.get(client,resource)
-
-		prod_json = JSON.parse(product_test_updated.body).to_hash
-
-		prod_json['items'][0]['rows'][0][0].to_i
-
-	}
-
 	context '#delete' do
 
 		it 'should raise an error if client is nil' do
@@ -351,7 +338,15 @@ describe OSCRuby::Connect do
 
 		end
 
-		it 'it should produce a Net::HTTPResponse, should produce a 200 code' do
+		it 'it should produce a Net::HTTPResponse, should produce a 200 code', :vcr do
+
+			resource = URI.escape("queryResults/?query=select id from serviceproducts where lookupname = 'PRODUCT-TEST-updated';")
+
+			product_test_updated = OSCRuby::Connect.get(client,resource)
+
+			prod_json = JSON.parse(product_test_updated.body).to_hash
+
+			product_test_updated_id = prod_json['items'][0]['rows'][0][0].to_i
 
 		    test = OSCRuby::Connect.delete(client,"serviceProducts/#{product_test_updated_id}")
 

data/spec/core/service_product_spec.rb

@@ -35,60 +35,60 @@ describe OSCRuby::ServiceProduct do
 
 	end
 
-	let(:attributes){
-		{'id' => 1, 
-		 'lookupName' => 'Test Product Lookup Name',
-		 'createdTime'=>nil,
-		 'updatedTime'=>nil,
-		 'displayOrder'=>1,
-		 'name'=>'Test Product Lookup Name',
-		 'parent' => nil
-		}
-	}
+	# let(:attributes){
+	# 	{'id' => 1, 
+	# 	 'lookupName' => 'Test Product Lookup Name',
+	# 	 'createdTime'=>nil,
+	# 	 'updatedTime'=>nil,
+	# 	 'displayOrder'=>1,
+	# 	 'name'=>'Test Product Lookup Name',
+	# 	 'parent' => nil
+	# 	}
+	# }
 
-	context '#new_from_fetch' do
+	# context '#new_from_fetch' do
 
-		it 'should accept an attributes as a hash' do
+	# 	it 'should accept an attributes as a hash' do
 
-			expect do
+	# 		expect do
 
-				attributes = []
+	# 			attributes = []
 
-				OSCRuby::ServiceProduct.new_from_fetch(attributes)
+	# 			OSCRuby::ServiceProduct.new_from_fetch(attributes)
 
-			end.to raise_error("Attributes must be a hash; please use the appropriate data structure")
+	# 		end.to raise_error("Attributes must be a hash; please use the appropriate data structure")
 
-			expect do
+	# 		expect do
 
-				OSCRuby::ServiceProduct.new_from_fetch(attributes)
+	# 			OSCRuby::ServiceProduct.new_from_fetch(attributes)
 
-			end.not_to raise_error
+	# 		end.not_to raise_error
 
-		end
+	# 	end
 
-		it 'should instantiate an id, lookupName, createdTime, updatedTime, displayOrder, name, and parent with the correct values' do
+	# 	it 'should instantiate an id, lookupName, createdTime, updatedTime, displayOrder, name, and parent with the correct values' do
 
-			test = OSCRuby::ServiceProduct.new_from_fetch(attributes)
+	# 		test = OSCRuby::ServiceProduct.new_from_fetch(attributes)
 
-			expect(test.id).to eq(1)
+	# 		expect(test.id).to eq(1)
 
-			expect(test.lookupName).to eq('Test Product Lookup Name')
+	# 		expect(test.lookupName).to eq('Test Product Lookup Name')
 
-			expect(test.createdTime).to eq(nil)
+	# 		expect(test.createdTime).to eq(nil)
 
-			expect(test.updatedTime).to eq(nil)
+	# 		expect(test.updatedTime).to eq(nil)
 
-			expect(test.displayOrder).to eq(1)
+	# 		expect(test.displayOrder).to eq(1)
 
-			expect(test.name).to eq('Test Product Lookup Name')
+	# 		expect(test.name).to eq('Test Product Lookup Name')
 
-			expect(test.name).to eq(test.lookupName)
+	# 		expect(test.name).to eq(test.lookupName)
 
-			expect(test.parent).to eq(nil)
+	# 		expect(test.parent).to eq(nil)
 
-		end
+	# 	end
 
-	end
+	# end
 
 	let(:client) { 
 
@@ -141,7 +141,7 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should return an instance of an OSCRuby::ServiceProduct if the json_response param is set to false (which it is by default)' do
+		it 'should return an instance of an OSCRuby::ServiceProduct if the json_response param is set to false (which it is by default)', :vcr do
 
 			new_service_product.names[0] = {"labelText" => "TEST-PRODUCT", "language" => {"id" => 1}}
 			new_service_product.names[1] = {"labelText" => "TEST-PRODUCT", "language" => {"id" => 11}} 		
@@ -165,7 +165,7 @@ describe OSCRuby::ServiceProduct do
 		end
 
 
-		it 'should return the body object if the json_response param is set to true' do
+		it 'should return the body object if the json_response param is set to true', :vcr do
 
 			new_service_product.names[0] = {"labelText" => "TEST-PRODUCT", "language" => {"id" => 1}}
 			new_service_product.names[1] = {'labelText' => 'TEST-PRODUCT', 'language' => {'id' => 11}} 	
@@ -200,19 +200,16 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should return a warning if empty/no instances of the object can be found' do
+		it 'should return a warning if empty/no instances of the object can be found', :vcr do
 
 			expect{OSCRuby::ServiceProduct.find(client, 1)}.to raise_error('There were no objects matching your query; please try again.')
 
 		end
 
 
-		let(:known_working_product){
-			OSCRuby::ServiceProduct.find(client, 100)
-		}
-
-
-		it 'should return an instance of a new OSCRuby::ServiceProduct object with at least a name and displayOrder' do
+		it 'should return an instance of a new OSCRuby::ServiceProduct object with at least a name and displayOrder', :vcr do
+		
+			known_working_product = OSCRuby::ServiceProduct.find(client, 100)
 
 			expect(known_working_product).to be_an(OSCRuby::ServiceProduct)
 
@@ -222,7 +219,7 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should return the raw json response if the return_json parameter is set to true' do
+		it 'should return the raw json response if the return_json parameter is set to true', :vcr do
 
 			known_working_product_in_json = OSCRuby::ServiceProduct.find(client, 100, true)
 
@@ -244,7 +241,7 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should return multiple instances of OSCRuby::ServiceProduct' do
+		it 'should return multiple instances of OSCRuby::ServiceProduct', :vcr do
 
 			products = OSCRuby::ServiceProduct.all(client)
 
@@ -266,7 +263,7 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should just return JSON if the return_json parameter is set to true' do
+		it 'should just return JSON if the return_json parameter is set to true', :vcr do
 
 			expect(OSCRuby::ServiceProduct.all(client,true)).to be_a(String)
 
@@ -292,7 +289,7 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should take a query and return results' do
+		it 'should take a query and return results', :vcr do
 
 			products_lvl_1 = OSCRuby::ServiceProduct.where(client,"parent is null and lookupname not like 'Unsure'")
 
@@ -312,13 +309,13 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should raise an error if the query returns 0 results' do
+		it 'should raise an error if the query returns 0 results', :vcr do
 
 			expect{OSCRuby::ServiceProduct.where(client,"parent = 6546546546546")}.to raise_error('There were no objects matching your query; please try again.')
 
 		end
 
-		it 'should just return JSON if the return_json parameter is set to true' do
+		it 'should just return JSON if the return_json parameter is set to true', :vcr do
 
 			parents = OSCRuby::ServiceProduct.where(client,"parent is null and lookupname not like 'Unsure'",true)
 
@@ -330,13 +327,13 @@ describe OSCRuby::ServiceProduct do
 
 	end
 
-	let(:known_working_product){
-		OSCRuby::ServiceProduct.find(client, 100)
-	}
+		
 
 	context '#update' do
 
-		it 'should expect client is an instance of OSCRuby::Client class and raise an error if does not' do
+		it 'should expect client is an instance of OSCRuby::Client class and raise an error if does not', :vcr do
+
+			known_working_product = OSCRuby::ServiceProduct.find(client, 100)
 
 			expect(client).to be_an(OSCRuby::Client)
 
@@ -346,13 +343,17 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should expect that the Service Product is an instance of a OSCRuby::ServiceProduct' do
+		it 'should expect that the Service Product is an instance of a OSCRuby::ServiceProduct', :vcr do
+
+			known_working_product = OSCRuby::ServiceProduct.find(client, 100)
 
 			expect(known_working_product).to be_an(OSCRuby::ServiceProduct)
 
 		end
 
-		it 'should expect that the product has an ID and spit out an error if it does not' do
+		it 'should expect that the product has an ID and spit out an error if it does not', :vcr do
+
+			known_working_product = OSCRuby::ServiceProduct.find(client, 100)
 
 			known_working_product.id = nil
 
@@ -360,20 +361,22 @@ describe OSCRuby::ServiceProduct do
 		
 		end
 
-		it 'should update name when the names is updated' do
+		it 'should update name when the names is updated', :vcr do
 
-			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'QTH45-test'")
+			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT'")
 			first_prod = test_prods[0]
 
-			first_prod.names[0] = {"labelText" => "QTH45-test-UPDATED", "language" => {"id" => 1}}
+			first_prod.names[0] = {"labelText" => "TEST-PRODUCT-UPDATED", "language" => {"id" => 1}}
 
 			first_prod.update(client)
 
-			expect(first_prod.name).to eq('QTH45-test-UPDATED')
+			expect(first_prod.name).to eq('TEST-PRODUCT-UPDATED')
 
 		end
 
-		it 'should just return JSON if the return_json parameter is set to true' do
+		it 'should just return JSON if the return_json parameter is set to true', :vcr do
+
+			known_working_product = OSCRuby::ServiceProduct.find(client, 100)
 
 			test = known_working_product.update(client,true)
 
@@ -383,16 +386,12 @@ describe OSCRuby::ServiceProduct do
 
 	end
 
-	let(:product_to_delete){
-
-		test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT'")
-		test_prods[0]
-
-	}
-
 	context '#destroy' do
 
-		it 'should expect client is an instance of OSCRuby::Client class and raise an error if does not' do
+		it 'should expect client is an instance of OSCRuby::Client class and raise an error if does not', :vcr do
+
+			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT-UPDATED'")
+			product_to_delete = test_prods[0]
 
 			expect(client).to be_an(OSCRuby::Client)
 
@@ -402,13 +401,19 @@ describe OSCRuby::ServiceProduct do
 
 		end
 
-		it 'should expect that the Service Product is an instance of a OSCRuby::ServiceProduct' do
+		it 'should expect that the Service Product is an instance of a OSCRuby::ServiceProduct', :vcr do
+
+			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT-UPDATED'")
+			product_to_delete = test_prods[0]
 
 			expect(product_to_delete).to be_an(OSCRuby::ServiceProduct)
 
 		end
 
-		it 'should expect that the product has an ID and spit out an error if it does not' do
+		it 'should expect that the product has an ID and spit out an error if it does not', :vcr do
+
+			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT-UPDATED'")
+			product_to_delete = test_prods[0]
 
 			product_to_delete.id = nil
 
@@ -416,7 +421,10 @@ describe OSCRuby::ServiceProduct do
 		
 		end
 
-		it 'should delete the product' do
+		it 'should delete the product', :vcr do
+
+			test_prods = OSCRuby::ServiceProduct.where(client,"name like 'TEST-PRODUCT-UPDATED'")
+			product_to_delete = test_prods[0]
 
 			id_to_find = product_to_delete.id