osc_ruby 0.0.9 → 0.0.10

data/.travis.yml

@@ -1,7 +1,11 @@
 language: ruby
 rvm:
-  - 2.1.2p95
-  - jruby
-  - rbx-2
-script:
-  bundle exec rake spec
+- 2.2.0
+- jruby
+addons:
+  code_climate:
+    repo_token:
+      secure: jhiFV5qK92z9GNZNgifvOmzoYmghcTFcuHYn21B5pkcIFmUJRYL03FK4QHqinFQ4BvjHnKlGTEgRPvglivvPBtIwpGMwuDF0oX0JHeTNLXuAXk8Dd6SAap+udSc2fOZYBg7H8PNmhSVpP97fYu23JsLmhRN8lnoO/yYyFUn/xUZIufOhpPj5RBMtR/XmxXiqS1tnsuHpSs7P+Kp/h6sr8QUOw1pJALEAqHGw2WmdxGrI76GQc0bylLFGMITkCbAiTxVQA3QnjLKFYCHq8zo1U0QZiW78+ubbV22oZS1EVATAb4SyqlqFd2bJA9wYjL2J4tYl1I+RvgVSspMsksHs72uIYHDTNSsEuQTnMCxtkq7WJLbYjRW3Tzbqn124ize/NmJqHcJ70Bc8Tzc3CkgEuJNF/cK266r0UkNTu+m65OTElyic14y+wCzeU8r/aDfX9vQKPBpOFpvHuoWMC54iiGIPjLVZb0AYvI2i3weK2dcCh7ZFD+FsFoMAzyaFFFJP4ANH7R08ewVpTjdud4O8WiQBJOW08dXE9inOF+4hqUho2FdrTWQLvMbanVXOmQXsODeEy7zxFUi1I1wVcX1AktEACmcX2ruose8UiScRu7Tr2R6mhgPa4UAf1YhhBClYafeqtCBi1rRrHkgOkaofhKbU3hHHF5cQwDP2v2jUYEI=
+script: bundle exec rake spec
+after_success:
+- bundle exec codeclimate-test-reporter

data/Gemfile

@@ -5,4 +5,6 @@ gemspec
 
 group :test do
 	gem 'rspec'
+	gem "simplecov"
+  	gem "codeclimate-test-reporter", "~> 1.0.0"
 end

data/README.md

@@ -1,14 +1,18 @@
 # OSCRuby
 
+[![Code Climate](https://codeclimate.com/github/rajangdavis/osc_ruby/badges/gpa.svg)](https://codeclimate.com/github/rajangdavis/osc_ruby)
+
+[![Test Coverage](https://codeclimate.com/github/rajangdavis/osc_ruby/badges/coverage.svg)](https://codeclimate.com/github/rajangdavis/osc_ruby/coverage)
+
 Still developing this; will let ya know when this happens.
 
 The basic idea is to be able to do something simple like import a csv of information and post it into an Oracle Service Cloud site.
 
 The ultimate goal is to use this gem to make a Rails app for advanced administration/development that cannot be done with Oracle Service Cloud alone
 
-# Example (still coding this out, but trying to get this pretty simple)
+## Example (still coding this out, but trying to get this pretty simple)
 
-	# // Product Fetch example
+	# Product Fetch example
 
 	client = OSCRuby::Client.new do |config|	
 		config.interface = ENV['OSC_TEST_SITE']
@@ -20,9 +24,9 @@ The ultimate goal is to use this gem to make a Rails app for advanced administra
 
 	puts product.name
 
-	// puts 'Product Lookup Name'
+	# puts 'Product Lookup Name'
 
-	# // Product Creation example
+	# Product Creation example
 
 	names = []
 
@@ -47,54 +51,57 @@ The ultimate goal is to use this gem to make a Rails app for advanced administra
 
 	OSCRuby::ServiceProduct.save(client, new_prod)
 
-	// callback with JSON details
+	# callback with JSON details
+
+## TODO
+
+- [x] Create a URL generator method into the Connect Class
 
-# TODO
+- [x] Move tests for the get method into the URL generator method
 
-<!-- Create a URL generator method into the Connect Class -->
-<!-- Move tests for the get method into the URL generator method -->
+- [x] Move check_config method into the URL generator method so that tests pass
 
-<!-- Move check_config method into the URL generator method so that tests pass -->
+- [x] Create more tests to validate the generated URL
 
-<!-- Create more tests to validate the generated URL -->
+- [x] Add in TravisCI into workflow to run tests and push and publish gem
 
-Put the URL generator method into the get class
+- [x] Add in Code Climate or something to show the percentage of covered methods for testing
 
-Have the get method make a get request using the Net::HTTP class
+- [ ] Put the URL generator method into the get class
 
-Need to add tests for passing resources, query/id/other param into the URL generator class
+- [ ] Have the get method make a get request using the Net::HTTP class
 
-Need to figure out how to pass resources and some sort of query/id/other param into the URL generator class
+- [ ] Need to add tests for passing resources, query/id/other param into the URL generator class
 
-Add in tests for Post requests
+- [ ] Need to figure out how to pass resources and some sort of query/id/other param into the URL generator class
 
-Make a Post method
+- [ ] Add in tests for Post requests
 
-Add in tests for update requests
+- [ ] Make a Post method
 
-Make a update method
+- [ ] Add in tests for update requests
 
-Add in tests for delete requests
+- [ ] Make a update method
 
-Make a delete method
+- [ ] Add in tests for delete requests
 
-Create a OSCRuby::ServiceProduct class
+- [ ] Make a delete method
 
-Figure out how to do RDoc/Yardoc documentation or best in class documentation for using this Ruby Wrapper
+- [ ] I might need to do a transformation class that converts JSON response into a Ruby Hash
 
-Add in VCR and WebMock as dependencies
+- [ ] Create a OSCRuby::ServiceProduct class
 
-Figure out how to record and stub responses for a good response and bad response
+- [ ] Figure out how to do RDoc/Yardoc documentation or best in class documentation for using this Ruby Wrapper
 
-Simulate these responses
+- [ ] Add in VCR and WebMock as dependencies
 
-Add in TravisCI into workflow to run tests and push and publish gem
+- [ ] Figure out how to record and stub responses for a good response and bad response
 
-Add in Code Climate? or something to show the percentage of covered methods for testing
+- [ ] Simulate these responses
 
-Follow with next Classes (ServiceCategories, Answers, Interfaces)
+- [ ] Follow with next Classes (ServiceCategories, Answers, Interfaces)
 
-Release MVP
+- [ ] Release MVP
 
 ## Installation
 

data/lib/osc_ruby/connect.rb

@@ -10,17 +10,31 @@ module OSCRuby
 	class Connect
 
 		def self.get(client,resource_url = nil)
-			# Net::HTTP.start(uri.host, uri.port,
-			# 	:use_ssl => true,
-			# 	:verify_mode => OpenSSL::SSL::VERIFY_NONE) do |http|
 
-			# 	request = Net::HTTP::Get.new uri.request_uri
-			# 	request.basic_auth config.username, config.password
+			if client.nil?
+				raise ArgumentError, "Client must have some configuration set; please create an instance of OSCRuby::Client with configuration settings"
+			else
+				@final_config = generate_url_and_config(client)
+			end
+
+			@uri = @final_config['site_url']
+			@username = @final_config['username']
+			@password = @final_config['password']
 
-			# 	response = http.request request # Net::HTTPResponse object
+			Net::HTTP.start(@uri.host, @uri.port,
+				:use_ssl => true,
+				:verify_mode => OpenSSL::SSL::VERIFY_NONE) do |http|
 
-			# 	json_response = JSON.parse(response.body)
-			# end
+				request = Net::HTTP::Get.new @uri.request_uri
+				request.basic_auth @username, @password
+
+				response = http.request request # Net::HTTPResponse object
+
+				json_response = JSON.parse(response.body)
+
+				puts json_response
+			end
+			
 		end
 
 		private
@@ -32,6 +46,7 @@ module OSCRuby
 			@config = client.config
 
 		  	@url = "https://" + @config.interface + ".custhelp.com/services/rest/connect/v1.3/#{resource_url}"
+		  	
 		  	@final_uri = URI(@url)
 		  	
 		  	@final_config = {'site_url' => @final_uri, 'username' => @config.username, 'password' => @config.password}

data/lib/osc_ruby/version.rb

@@ -1,3 +1,3 @@
 module OSCRuby
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/core/connect_spec.rb

@@ -109,6 +109,29 @@ describe OSCRuby::Connect do
 
 	context '#get' do
 
+		it 'should take at least a config parameter that is an instance of an OSCRuby::Client' do
+
+			expect(client).to be_an(OSCRuby::Client)
+
+			expect do
+
+				OSCRuby::Connect.get(client)
+
+			end.not_to raise_error
+		end
+
+		it 'should raise an error if client is nil' do
+
+			expect do
+				
+				client = nil
+
+				OSCRuby::Connect.get(client)
+
+			end.to raise_error("Client must have some configuration set; please create an instance of OSCRuby::Client with configuration settings")
+
+		end
+
 		# it 'should produce a JSON Response' do
 		# 	expect do
 		

data/spec/core/spec_helper.rb

@@ -1 +1,3 @@
-require 'osc_ruby'
+require 'osc_ruby'
+require "simplecov"
+SimpleCov.start

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: osc_ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Rajan Davis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-15 00:00:00.000000000 Z
+date: 2016-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -60,8 +60,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt