organizations 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93641d7c8f80e347c31ffb9ad1c1f0f489078218f65c8204a4f3f48ad1d3c070
-  data.tar.gz: 79f97cdfe624459b128075e7800d1452b35be970109cb7b1e2c040fcc69694b0
+  metadata.gz: 3489dee0ace79d490d899aa756462b26d367d2f609ca58b2ff96b41326a58ab1
+  data.tar.gz: 6764004c3e0fc2524eee6b457f8384de50ce9d4117b414eca9ba4519316e202b
 SHA512:
-  metadata.gz: b60315a1184fe81064acb974a95dd80a82c99abf9fbedb117a231e43a44ec11b99218b25f38efeae6ad88015b7445e66354a2351c28ad3572f75dd7323e60601
-  data.tar.gz: 5d0618750b4a4e59757538a99e1ca3e8ae6817f7cf6a395e194e7754eabc1f43dd747ea37e3aacf6979b0b5c945336b226c6e18e915a3dae58b14bbe13c3c1a5
+  metadata.gz: 88518342c7bcc6cc8c75eb83a036ac08348fc83962ba5f78e536deb22eedf1a1bfcc44c72255afe4e9b3080d6e8657133125ece9c87da21db583e1888eae09f5
+  data.tar.gz: d1f4aafce6fd17500d9f287b7907b165b4faee6a9fc219472f22a68fc06cabfb9cb82907184f6bf8530660fb89f3df7c449651cbc32217a168e0ddb7eb0c6d67

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.4.0] - 2026-03-17
+
+**Breaking:** `memberships_count` column is now required on the organizations table.
+
+- Added `memberships_count` to the install migration template (fresh installs get it automatically)
+- Switched to Rails' native `counter_cache` so in-memory organization instances stay accurate after member changes
+- `member_count` now reads directly from the counter cache (no fallback to COUNT query)
+- Marked `memberships_count` as readonly on organizations
+
 ## [0.3.1] - 2026-02-28
 
 - Fixed `organization_switcher_data[:switch_path]` generating broken URLs when engine mounted with custom name (e.g., `as: 'organizations_engine'`)

data/README.md

@@ -1387,24 +1387,11 @@ organization_switcher_data
 
 ### Counter caches for member counts
 
-If you display member counts frequently (pricing pages, org listings), consider adding a counter cache:
-
-```ruby
-# In a migration
-add_column :organizations_organizations, :memberships_count, :integer, default: 0, null: false
-
-# Reset existing counts
-Organization.find_each do |org|
-  Organization.reset_counters(org.id, :memberships)
-end
-```
-
-The gem automatically uses the counter cache if present:
+The install migration includes a `memberships_count` counter cache on organizations, and `member_count` reads from it directly:
 
 ```ruby
 org.member_count
-# Uses memberships_count column if it exists
-# Falls back to COUNT(*) query otherwise
+# Uses the memberships_count counter cache
 ```
 
 ### Existence checks use SQL

data/lib/generators/organizations/install/templates/create_organizations_tables.rb.erb

@@ -8,6 +8,7 @@ class CreateOrganizationsTables < ActiveRecord::Migration<%= migration_version %
     # Organizations table
     create_table :organizations_organizations, id: primary_key_type do |t|
       t.string :name, null: false
+      t.integer :memberships_count, default: 0, null: false
       t.send(json_column_type, :metadata, null: json_column_null, default: json_column_default)
 
       t.timestamps

data/lib/organizations/models/membership.rb

@@ -28,7 +28,8 @@ module Organizations
     belongs_to :user
     belongs_to :organization,
                class_name: "Organizations::Organization",
-               inverse_of: :memberships
+               inverse_of: :memberships,
+               counter_cache: :memberships_count
 
     belongs_to :invited_by,
                class_name: "User",
@@ -40,11 +41,6 @@ module Organizations
     validates :user_id, uniqueness: { scope: :organization_id, message: "is already a member of this organization" }
     validate :single_owner_per_organization, if: :owner?
 
-    # Keep memberships_count accurate when the optional counter cache column exists.
-    after_create_commit :increment_memberships_counter_cache
-    after_destroy_commit :decrement_memberships_counter_cache
-    after_update_commit :sync_memberships_counter_cache_for_org_change, if: :saved_change_to_organization_id?
-
     # === Scopes ===
 
     # Memberships with owner role
@@ -200,34 +196,6 @@ module Organizations
       errors.add(:role, "owner already exists for this organization")
     end
 
-    def increment_memberships_counter_cache
-      return unless memberships_counter_cache_enabled?
-      return unless organization_id
-
-      Organizations::Organization.increment_counter(:memberships_count, organization_id)
-    end
-
-    def decrement_memberships_counter_cache
-      return unless memberships_counter_cache_enabled?
-      return unless organization_id
-
-      Organizations::Organization.decrement_counter(:memberships_count, organization_id)
-    end
-
-    def sync_memberships_counter_cache_for_org_change
-      return unless memberships_counter_cache_enabled?
-
-      old_org_id, new_org_id = saved_change_to_organization_id
-      Organizations::Organization.decrement_counter(:memberships_count, old_org_id) if old_org_id
-      Organizations::Organization.increment_counter(:memberships_count, new_org_id) if new_org_id
-    end
-
-    def memberships_counter_cache_enabled?
-      Organizations::Organization.column_names.include?("memberships_count")
-    rescue StandardError
-      false
-    end
-
     def validate_role!(role)
       unless Roles.valid_role?(role)
         raise ArgumentError, "Invalid role: #{role}. Must be one of: #{Roles.valid_roles.join(', ')}"

data/lib/organizations/models/organization.rb

@@ -46,6 +46,7 @@ module Organizations
     # === Validations ===
 
     validates :name, presence: true
+    attr_readonly :memberships_count
 
     # === Scopes ===
 
@@ -101,14 +102,10 @@ module Organizations
       memberships.exists?
     end
 
-    # Get member count (uses counter cache if available, otherwise COUNT)
+    # Get member count from the organizations counter cache.
     # @return [Integer]
     def member_count
-      if has_attribute?(:memberships_count)
-        self[:memberships_count] || memberships.count
-      else
-        memberships.count
-      end
+      memberships_count || 0
     end
 
     # Get pending invitations

data/lib/organizations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Organizations
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: organizations
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - rameerez
 bindir: exe
 cert_chain: []
-date: 2026-02-28 00:00:00.000000000 Z
+date: 2026-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties