order_cop 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83506d77c88c7d0fb5f3b5b0b779bdb33262adb7645951127fd2feb1668db52f
-  data.tar.gz: ee2e8013a24a8078e87455a2aa88e98aae921137a870d9c3d29bdb1dbc067a76
+  metadata.gz: 9844113f7fde924bc0804ffd7a8a3e81b034e1009e2b8e399538e791756f1ba6
+  data.tar.gz: 71231522bb6415cb282945f68efcf58acc66d8f5400a70cbc039a076c49877ce
 SHA512:
-  metadata.gz: 40dc1ee7a51ded6c68b4c44e68d0ce96c5a97f53ce95de5f68fb8651aab44c357f72564de56b623b853bba01867a8faf9dc7221c830a70ed5f961a1e61865a28
-  data.tar.gz: 11eb778fdc25c1bbc1e164ec27a1c2738a2d3541d49b7c53a0a5e5ca8a13f06e07a298332a859080787eb0351281b2bb999b756532dde3aa4ac330bccf4a48b1
+  metadata.gz: 874cf90c0aefe66aa65a936bf2f48ee2fb2b383c41d5b137af448a5fafbabd5c138940254481ae27a36ea59c004692ca5d75cdc6e61104a6cebd81dfa676226f
+  data.tar.gz: ca59878e2544b486200256d224b5fc99ec0433ee134ea2617f46db658880f3860c42e316391b77afd332b7077fe073d51cd95db2758aaccaf2e5ba813c944cf7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    order_cop (0.1.0)
+    order_cop (0.1.2)
       binding_of_caller (~> 1.0)
       rails (~> 7.0)
 

data/lib/order_cop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OrderCop
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

data/lib/order_cop.rb

@@ -54,16 +54,29 @@ module OrderCop
 
     private
 
-    def detect_missing_order(method)
-      return if OrderCop.disabled?
-      level = 1.upto(binding.frame_count).find do |i|
+    def stack_is_whitelisted?
+      1.upto(binding.frame_count).each do |i|
         lbinding = binding.of_caller(i)
         lmethod = lbinding.eval("__method__")
         next if lmethod.nil?
+        puts "lmethod: #{lmethod}" if OrderCop.debug?
         if OrderCop::WHITELIST.include?(lmethod)
-          puts "whitelisted #{lmethod}"
-          return nil
+          puts "#{lmethod} is whitelisted, ignoring" if OrderCop.debug?
+          return true
         end
+      end
+      false
+    end
+
+    def detect_missing_order(method)
+      return if OrderCop.disabled?
+      puts "missing order, detect if allowed" if OrderCop.debug?
+      puts "stack size: #{binding.frame_count}" if OrderCop.debug?
+
+      return if stack_is_whitelisted?
+
+      level = 1.upto(binding.frame_count).find do |i|
+        lbinding = binding.of_caller(i)
         location = lbinding.source_location[0]
         location.include?(Rails.root.to_s) && !location.include?(Rails.root.join("config").to_s)
       end
@@ -135,8 +148,12 @@ module OrderCop
     config.raise
   end
 
+  def self.debug?
+    config.debug
+  end
+
   def self.config(**options)
-    @config ||= OpenStruct.new(rails_logger: false, raise: true, enabled: true)
+    @config ||= OpenStruct.new(rails_logger: false, raise: true, enabled: true, debug: false)
     options.each do |k, v|
       @config[k] = v
     end
@@ -170,4 +187,3 @@ end
 ActiveSupport::Reloader.to_prepare do
   OrderCop.apply(Rails.application)
 end
-# OrderCop.setup(rails_logger: true) unless Rails.env.production?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: order_cop
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Gauthier Monserand