order_as_specified 1.3 → 1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 450073ab184ee65a4ca822e1357d3b83ef9f77c8
-  data.tar.gz: 2b82f44edfb67e15ebd24226a1222eabf18bb008
+SHA256:
+  metadata.gz: 810fb1d84c1606e6a005b15d822d6758a93caf1ae53b9df6a695ff8d2e024582
+  data.tar.gz: ce7d3be0ef5a951a65bb1e5ceae0aa07ec3e0957fc844a6ecd2d0ca02af9170d
 SHA512:
-  metadata.gz: f8719ccfaf980a2f5bd52535700a3093d96a41f2c5194f9edc1f5862a6c37cf801d0ceeda90a7a3c8e883532ca47e3595bc0657e07cf8e9864c66044f6d6bda7
-  data.tar.gz: 26fe666d64943d02e93a78fd6edb506480c4deaa8c3a1b6a5e675c98a81fd28082008209c578313dd8acb801a9b21fbe946b7e26c7d3d3cbcc71420abbd084c1
+  metadata.gz: 7e8e491197afaf309031af8d7eb7869d1acdd2884ef776e6440a137a5288601993164ddc31815a42703407d18d51f73c917577cc80dbde2c742f7b6b7e06ab10
+  data.tar.gz: d8437b518f99ae3a9d6f75069e927b1a677772957d6868c9d3a24f49dd956c3a66f62f31174ae5796447a0b6806b1c15294ad94591ddddf415ca0a6c24ba190e

data/.rubocop.yml

@@ -1,260 +1,17 @@
-# This (http://c2.com/cgi/wiki?AbcMetric) is super obnoxious
-AbcSize:
-  Enabled: false
-
-AccessorMethodName:
-  Enabled: false
-
-Alias:
-  Enabled: false
+require:
+  - rubocop/rspec/focused
 
 AllCops:
-  RunRailsCops: true
-
-AmbiguousOperator:
-  Enabled: false
-
-AmbiguousRegexpLiteral:
-  Enabled: false
-
-ArrayJoin:
-  Enabled: false
-
-AsciiComments:
-  Enabled: false
-
-AsciiIdentifiers:
-  Enabled: false
-
-AssignmentInCondition:
-  Enabled: true
-
-Attr:
-  Enabled: false
-
-BlockNesting:
-  Enabled: false
-
-BracesAroundHashParameters:
-  Enabled: false
-
-CaseEquality:
-  Enabled: false
-
-CharacterLiteral:
-  Enabled: false
-
-ClassLength:
-  Enabled: false
-
-ClassVars:
-  Enabled: false
-
-CollectionMethods:
-  PreferredMethods:
-    find: detect
-    reduce: inject
-    collect: map
-    find_all: select
-
-ColonMethodCall:
-  Enabled: false
-
-CommentAnnotation:
-  Enabled: false
-
-ConditionPosition:
-  Enabled: false
-
-CyclomaticComplexity:
-  Enabled: false
-
-Delegate:
-  Enabled: false
-
-DeprecatedClassMethods:
-  Enabled: false
+  TargetRubyVersion: 2.3
 
-DeprecatedHashMethods:
-  Enabled: false
-
-Documentation:
+AbcSize:
   Enabled: false
 
 DotPosition:
   EnforcedStyle: trailing
 
-DoubleNegation:
-  Enabled: false
-
-ElseLayout:
-  Enabled: false
-
-EmptyLiteral:
-  Enabled: false
-
-Encoding:
-  Enabled: false
-
-EvenOdd:
-  Enabled: false
-
-FileName:
-  Enabled: false
-
-FlipFlop:
-  Enabled: false
-
-FormatString:
-  Enabled: false
-
-GlobalVars:
-  Enabled: false
-
-GuardClause:
-  Enabled: false
-
-HandleExceptions:
-  Enabled: false
-
-IfUnlessModifier:
-  Enabled: false
-
-IfWithSemicolon:
-  Enabled: false
-
-InvalidCharacterLiteral:
-  Enabled: false
-
-Lambda:
-  Enabled: false
-
-LambdaCall:
-  Enabled: false
-
-LineEndConcatenation:
-  Enabled: false
-
-LineLength:
-  Max: 80
-
-LiteralInCondition:
-  Enabled: false
-
-LiteralInInterpolation:
-  Enabled: false
-
-Loop:
-  Enabled: false
-
 MethodLength:
   Enabled: false
 
-ModuleFunction:
-  Enabled: false
-
-NegatedIf:
-  Enabled: false
-
-NegatedWhile:
-  Enabled: false
-
-Next:
-  Enabled: false
-
-NilComparison:
-  Enabled: false
-
-Not:
-  Enabled: false
-
-NumericLiterals:
-  Enabled: false
-
-OneLineConditional:
-  Enabled: false
-
-OpMethod:
-  Enabled: false
-
-ParameterLists:
-  Enabled: false
-
-ParenthesesAsGroupedExpression:
-  Enabled: false
-
-PercentLiteralDelimiters:
-  PreferredDelimiters:
-    '%': '{}'
-
-PerceivedComplexity:
-  Enabled: false
-
-PerlBackrefs:
-  Enabled: false
-
-PredicateName:
-  Enabled: false
-
-Proc:
-  Enabled: false
-
-RaiseArgs:
-  Enabled: false
-
-RedundantReturn:
-  AllowMultipleReturnValues: true
-
-RegexpLiteral:
-  Enabled: false
-
-RequireParentheses:
-  Enabled: false
-
-SelfAssignment:
-  Enabled: false
-
-SignalException:
-  EnforcedStyle: only_raise
-
-SingleLineBlockParams:
-  Enabled: false
-
-SingleLineMethods:
-  Enabled: false
-
-SpecialGlobalVars:
-  Enabled: false
-
 StringLiterals:
   EnforcedStyle: double_quotes
-
-Style/MultilineBlockChain:
-  Enabled: false
-
-VariableInterpolation:
-  Enabled: false
-
-TrailingComma:
-  Enabled: false
-
-TrivialAccessors:
-  Enabled: false
-
-UnderscorePrefixedVariableName:
-  Enabled: false
-
-VariableInterpolation:
-  Enabled: false
-
-Void:
-  Enabled: false
-
-WhenThen:
-  Enabled: false
-
-WhileUntilModifier:
-  Enabled: false
-
-WordArray:
-  Enabled: false

data/.travis.yml

@@ -1,19 +1,26 @@
 language: ruby
 rvm:
 - 2.2.5
-- 2.3.1
+- 2.5.1
 before_script:
   - psql -c 'create database order_as_specified_test;' -U postgres
-script: bundle exec rspec
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rspec
+  - bundle exec rubocop
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
 addons:
   postgresql: "9.3"
   code_climate:
     repo_token: 781c439d68cbb928316deaec1c7136f98423e1db87238f99cbc95183de94df9e
 env:
   matrix:
-    - AR_VERSION="~> 4.2.0"
     - AR_VERSION="~> 5.0.0"
     - AR_VERSION="~> 5.1.0"
+    - AR_VERSION="~> 5.2.0"
 notifications:
   email: false
   hipchat:

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.4
+
+This release removes deprecation warnings for ActiveRecord 5.2 users, and drops
+support for ActiveRecord 4.x. Many thanks to
+[George Protacio-Karaszi](https://github.com/GeorgeKaraszi) for pointing out
+this issue!
+
 # 1.3
 
 This release adds support for ActiveRecord 5.1. Many thanks to

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in order_as_specified.gemspec

data/README.md

@@ -156,6 +156,18 @@ databases do not have good or consistent support for ordering with `NULL` values
 in an arbitrary order, so we don't permit this behavior instead of allowing an
 unexpected result.
 
+## Limitations
+
+Databases may have limitations on the underlying number of fields you can have
+in an `ORDER BY` clause. For example, in PostgreSQL if you pass in more than
+1664 list elements you'll [receive this error](https://github.com/panorama-ed/order_as_specified/issues/34):
+
+```ruby
+PG::ProgramLimitExceeded: ERROR: target lists can have at most 1664 entries
+```
+
+That's a database limitation that this gem cannot avoid, unfortunately.
+
 ## Documentation
 
 We have documentation on [RubyDoc](http://www.rubydoc.info/github/panorama-ed/order_as_specified/master).
@@ -169,8 +181,7 @@ We have documentation on [RubyDoc](http://www.rubydoc.info/github/panorama-ed/or
 5. Create a new Pull Request
 
 **Make sure your changes have appropriate tests (`bundle exec rspec`)
-and conform to the Rubocop style specified.** We use
-[overcommit](https://github.com/causes/overcommit) to enforce good code.
+and conform to the Rubocop style specified.**
 
 ## License
 

data/lib/order_as_specified.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "order_as_specified/version"
 require "order_as_specified/error"
 
@@ -5,7 +7,6 @@ require "order_as_specified/error"
 # the database in an arbitrary order, without having to store anything extra
 # in the database. Simply `extend` it into your class and then you can use the
 # `order_as_specified` class method.
-
 module OrderAsSpecified
   # @param hash [Hash] the ActiveRecord arguments hash
   # @return [ActiveRecord::Relation] the objects, ordered as specified
@@ -27,10 +28,12 @@ module OrderAsSpecified
       "#{table}.#{attribute}=#{db_connection.quote(value)}"
     end
 
-    scope = order(conditions.map { |cond| "#{cond} DESC" }.join(", "))
+    scope = order(Arel.sql(conditions.map { |cond| "#{cond} DESC" }.join(", ")))
 
     if distinct_on
-      scope = scope.select("DISTINCT ON (#{conditions.join(', ')}) #{table}.*")
+      scope = scope.select(
+        Arel.sql("DISTINCT ON (#{conditions.join(', ')}) #{table}.*")
+      )
     end
 
     scope
@@ -44,13 +47,13 @@ module OrderAsSpecified
   # @param table [String/Symbol] the name of the table, default: the class table
   # @param hash [Hash] the ActiveRecord-style arguments, such as:
   #   { other_objects: { id: [1, 5, 3] } }
-  def extract_params(table = table_name, hash)
+  def extract_params(hash, table = table_name)
     raise "Could not parse params" unless hash.size == 1
 
     key, val = hash.first
 
     if val.is_a? Hash
-      extract_params(key, hash[key])
+      extract_params(hash[key], key)
     else
       {
         table: table,

data/lib/order_as_specified/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OrderAsSpecified
   class Error < StandardError
   end

data/lib/order_as_specified/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OrderAsSpecified
-  VERSION = "1.3"
+  VERSION = "1.4"
 end

data/order_as_specified.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "order_as_specified/version"
 
@@ -19,14 +20,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", ">= 4.0.1"
+  spec.add_dependency "activerecord", ">= 5.0.0"
 
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 0.4"
-  spec.add_development_dependency "overcommit", "~> 0.23"
-  spec.add_development_dependency "pg", ">= 0.18"
-  spec.add_development_dependency "rspec", "~> 3.2"
-  spec.add_development_dependency "rspec-rails", "~> 3.2"
-  spec.add_development_dependency "rubocop", "~> 0.29"
-  spec.add_development_dependency "sqlite3", ">= 1.3"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "pg"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec-rails"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "rubocop-rspec-focused"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "sqlite3"
 end

data/spec/config/test_setup_migration.rb

@@ -1,10 +1,11 @@
-VersionedMigration = ActiveRecord::Migration.try(:[], 5.0) || ActiveRecord::Migration
+# frozen_string_literal: true
+
+VersionedMigration = ActiveRecord::Migration[ActiveRecord::Migration.current_version] # rubocop:disable Metrics/LineLength
 
 class TestSetupMigration < VersionedMigration
   def up
     db_connection = ActiveRecord::Base.connection
-    return if db_connection.try(:table_exists?,:test_classes) || # AR 4.2
-              db_connection.try(:data_source_exists?,:test_classes) # AR > 5.0
+    return if db_connection.try(:data_source_exists?, :test_classes)
 
     create_table :test_classes do |t|
       t.string :field

data/spec/order_as_specified_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Instead of defining specs here, we define them in
 # shared/order_as_specified_examples.rb. We then have a different spec file for
 # each supported database adapter, whch runs the shared RSpec tests found in

data/spec/postgresql_spec.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require "shared/order_as_specified_examples"
 require "config/test_setup_migration"
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe "PostgreSQL" do
   before :all do
     ActiveRecord::Base.establish_connection(:postgresql_test)
@@ -21,8 +24,8 @@ RSpec.describe "PostgreSQL" do
     end
 
     let(:shuffled_objects) do
-      fields = 3.times.map { |i| "Field #{i}" } * 2
-      5.times.map { |i| TestClass.create(field: fields[i]) }.shuffle
+      fields = Array.new(3) { |i| "Field #{i}" } * 2
+      Array.new(5) { |i| TestClass.create(field: fields[i]) }.shuffle
     end
 
     it "returns distinct objects" do
@@ -33,13 +36,16 @@ RSpec.describe "PostgreSQL" do
       before(:each) { TestClass.create(field: "foo") }
 
       it "sanitizes column values" do
-        # Attempt to inject code to add a 'hi' field to each record. If the SQL inputs
-        # are properly sanitized, the code will be ignored and the returned model
-        # instances will not respond to #hi. If not, the code will execute and
-        # each of the returned model instances will have a #hi method to access the
-        # new field.
+        # Attempt to inject code to add a 'hi' field to each record. If the SQL
+        # inputs are properly sanitized, the code will be ignored and the
+        # returned model instances will not respond to #hi. If not, the code
+        # will execute and each of the returned model instances will have a #hi
+        #  method to access the new field.
         bad_value = "foo') field, 'hi'::varchar AS hi FROM test_classes --"
-        record = TestClass.order_as_specified(distinct_on: true, field: [bad_value]).to_a.first
+        record = TestClass.order_as_specified(
+          distinct_on: true,
+          field: [bad_value]
+        ).to_a.first
         expect(record).to_not respond_to(:hi)
       end
 
@@ -48,11 +54,17 @@ RSpec.describe "PostgreSQL" do
         quoted_table = AssociationTestClass.connection.quote_table_name(table)
 
         column = "id"
-        quoted_column = AssociationTestClass.connection.quote_column_name(column)
+        quoted_column = AssociationTestClass.
+                        connection.
+                        quote_column_name(column)
 
-        sql = TestClass.order_as_specified(distinct_on: true, table => { column => ["foo"] }).to_sql
+        sql = TestClass.order_as_specified(
+          distinct_on: true,
+          table => { column => ["foo"] }
+        ).to_sql
         expect(sql).to include("DISTINCT ON (#{quoted_table}.#{quoted_column}")
       end
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/shared/order_as_specified_examples.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
+require "support/application_record"
 require "support/test_class"
 require "support/association_test_class"
 
+# rubocop:disable Metrics/BlockLength
 RSpec.shared_examples ".order_as_specified" do
   # Clean up after each test. This is a lot lighter for these few tests than
   # trying to wrangle with RSpec-Rails to get transactional tests to work.
@@ -10,7 +14,7 @@ RSpec.shared_examples ".order_as_specified" do
   end
 
   let(:shuffled_objects) do
-    5.times.map { |i| TestClass.create(field: "Field #{i}") }.shuffle
+    Array.new(5) { |i| TestClass.create(field: "Field #{i}") }.shuffle
   end
   let(:shuffled_object_fields) { shuffled_objects.map(&:field) }
   let(:shuffled_object_ids) { shuffled_objects.map(&:id) }
@@ -50,7 +54,7 @@ RSpec.shared_examples ".order_as_specified" do
 
     context "when the order includes nil" do
       let(:shuffled_objects) do
-        5.times.map do |i|
+        Array.new(5) do |i|
           TestClass.create(field: (i == 0 ? nil : "Field #{i}"))
         end.shuffle
       end
@@ -102,15 +106,16 @@ RSpec.shared_examples ".order_as_specified" do
     end
 
     it "sanitizes column values" do
-      # Verify that the result set includes two records when using good column value.
+      # Verify that the result set includes two records when using good column
+      # value.
       good_value = "foo"
       records = TestClass.order_as_specified(field: [good_value]).to_a
       expect(records.count).to eq(2)
 
       # Attempt to inject a LIMIT clause into the query. If the SQL inputs are
       # properly sanitized, it will be ignored and the returned result set will
-      # include two records. If not, the LIMIT clause will execute and the result
-      # set will include just one record.
+      # include two records. If not, the LIMIT clause will execute and the
+      # result set will include just one record.
       bad_value = "' LIMIT 1 --"
       records = TestClass.order_as_specified(field: [bad_value]).to_a
       expect(records.count).to eq(2)
@@ -128,3 +133,4 @@ RSpec.shared_examples ".order_as_specified" do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -1,5 +1,13 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
+# frozen_string_literal: true
+
+if ENV["TRAVIS"] == "true"
+  require "simplecov"
+  SimpleCov.start
+  SimpleCov.start do
+    # Omit the spec directory from being counted in code coverage calculations.
+    add_filter "/spec/"
+  end
+end
 
 require "active_record"
 

data/spec/sqlite3_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require "shared/order_as_specified_examples"
 require "config/test_setup_migration"

data/spec/support/application_record.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/spec/support/association_test_class.rb

@@ -1,4 +1,6 @@
-class AssociationTestClass < ActiveRecord::Base
+# frozen_string_literal: true
+
+class AssociationTestClass < ApplicationRecord
   extend OrderAsSpecified
 
   belongs_to :test_class

data/spec/support/test_class.rb

@@ -1,4 +1,6 @@
-class TestClass < ActiveRecord::Base
+# frozen_string_literal: true
+
+class TestClass < ApplicationRecord
   extend OrderAsSpecified
 
   has_one :association_test_class

metadata

@@ -1,141 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: order_as_specified
 version: !ruby/object:Gem::Version
-  version: '1.3'
+  version: '1.4'
 platform: ruby
 authors:
 - Jacob Evelyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2018-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.1
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.1
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: overcommit
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.23'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.23'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: pg
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rubocop-rspec-focused
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.29'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.29'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 description: Obtain ActiveRecord results with a custom ordering with no need to store
   anything in the database.
 email:
@@ -144,10 +144,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .overcommit.yml
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -163,6 +162,7 @@ files:
 - spec/shared/order_as_specified_examples.rb
 - spec/spec_helper.rb
 - spec/sqlite3_spec.rb
+- spec/support/application_record.rb
 - spec/support/association_test_class.rb
 - spec/support/test_class.rb
 homepage: https://github.com/panorama-ed/order_as_specified
@@ -175,17 +175,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Add arbitrary ordering to ActiveRecord queries.
@@ -197,6 +197,6 @@ test_files:
 - spec/shared/order_as_specified_examples.rb
 - spec/spec_helper.rb
 - spec/sqlite3_spec.rb
+- spec/support/application_record.rb
 - spec/support/association_test_class.rb
 - spec/support/test_class.rb
-has_rdoc: 

data/.overcommit.yml

@@ -1,8 +0,0 @@
-PreCommit:
-  # Disable Brakeman since this is not an app.
-  Brakeman:
-    enabled: false
-  RailsSchemaUpToDate:
-    enabled: false
-  Reek:
-    enabled: false