orcid_client 0.2 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b8c346014625fd0c0f489d0dccbc251b9564a29
-  data.tar.gz: 9f8d24234b8728fea8188ac8269093ebb6d42ed9
+  metadata.gz: 12b2fc21cb92147d5a8e1de1b1e01477a87249f7
+  data.tar.gz: 6ccd0ca2d3ee093c69281dabb61a42c50ac4ff59
 SHA512:
-  metadata.gz: 67fedbdd23664f78bbad586218d497d6c724c9af9ffd33cb88cfc963b9b4afd8d2a17d20fab4c7e35898ff995ee8838eab299cd3977340c3ca228a7f5e5423fa
-  data.tar.gz: e4faa5a081cbcb9766f7fc0b6a220bacb5c85e5dabea44ba6ecfaf7e1a084bfe7b323b0812cc15f57b9e0e61825f4b1174dbaf47f9ced8b29ecf649ba8cf1d1b
+  metadata.gz: 9092ec06f1d44f46393a0e34e1137c4217d99c448604f91fb73957728fbd2fb349e1faec163c05c7f6959d87ccc8522660499aff0fefd52c108fe2e8375b0f69
+  data.tar.gz: f6012a2d508cbf3b9531247458a71192edc17ed93a0364156728c08ca8b076ea7f9cdc27694b586f66ef00b3b84e1023581655d9c6a7e174fad32f209a63e448

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    orcid_client (0.2)
+    orcid_client (0.2.1)
       activesupport (~> 4.2, >= 4.2.5)
       builder (~> 3.2, >= 3.2.2)
       dotenv (~> 2.1, >= 2.1.1)

data/lib/orcid_client/api.rb

@@ -60,6 +60,16 @@ module OrcidClient
       response
     end
 
+    def delete_external_identifier(options={})
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Access token missing" }] }) unless access_token.present?
+      return OpenStruct.new(body: { "errors" => [{ "title" => "Put code missing" }] }) unless put_code.present?
+
+      orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
+
+      url = "#{orcid_api_url}/v#{API_VERSION}/#{orcid}/external-identifiers/#{put_code}"
+      response = Maremma.delete(url, content_type: 'application/vnd.orcid+xml', bearer: access_token)
+    end
+
     def get_notification_access_token(client_id:, client_secret:, **options)
       orcid_api_url = options[:sandbox] ? 'https://api.sandbox.orcid.org' : 'https://api.orcid.org'
 

data/lib/orcid_client/version.rb

@@ -1,3 +1,3 @@
 module OrcidClient
-  VERSION = "0.2"
+  VERSION = "0.2.1"
 end

data/spec/api_spec.rb

@@ -74,6 +74,8 @@ describe OrcidClient, vcr: true do
   end
 
   describe "external_identifier", :order => :defined do
+    subject { OrcidClient::ExternalIdentifier.new(type: "GitHub", value: "mfenner", url: "https://github.com/mfenner", orcid: orcid, access_token: access_token, put_code: "3316") }
+
     describe 'post' do
       subject { OrcidClient::ExternalIdentifier.new(type: "GitHub", value: "mfenner", url: "https://github.com/mfenner", orcid: orcid, access_token: access_token) }
 
@@ -89,6 +91,21 @@ describe OrcidClient, vcr: true do
         expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
       end
     end
+
+    describe 'delete' do
+      it 'should delete external_identifier' do
+        response = subject.delete_external_identifier(sandbox: true)
+        expect(response.body["data"]).to be_blank
+        expect(response.body["errors"]).to be_nil
+        expect(response.status).to eq(204)
+      end
+
+      it 'access_token missing' do
+        subject = OrcidClient::ExternalIdentifier.new(type: "GitHub", value: "mfenner", url: "https://github.com/mfenner", orcid: orcid, access_token: nil)
+        response = subject.delete_external_identifier(sandbox: true)
+        expect(response.body).to eq("errors"=>[{"title"=>"Access token missing"}])
+      end
+    end
   end
 
   describe "notifications", :order => :defined do

data/spec/fixtures/vcr_cassettes/OrcidClient/external_identifier/delete/should_delete_external_identifier.yml

@@ -0,0 +1,38 @@
+---
+http_interactions:
+- request:
+    method: delete
+    uri: https://api.sandbox.orcid.org/v2.0_rc3/0000-0001-6528-2027/external-identifiers/3316
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Maremma - https://github.com/datacite/maremma
+      Content-Type:
+      - application/vnd.orcid+xml
+      Accept:
+      - text/html,application/json,application/xml;q=0.9, text/plain;q=0.8,image/png,*/*;q=0.5
+      Authorization:
+      - Bearer <ACCESS_TOKEN>
+  response:
+    status:
+      code: 204
+      message: ''
+    headers:
+      Server:
+      - nginx/1.4.6 (Ubuntu)
+      Date:
+      - Sun, 27 Nov 2016 09:57:07 GMT
+      Content-Type:
+      - application/vnd.orcid+xml; qs=5;charset=UTF-8
+      Connection:
+      - keep-alive
+      Access-Control-Allow-Origin:
+      - "*"
+    body:
+      encoding: UTF-8
+      string: ''
+    http_version: 
+  recorded_at: Sun, 27 Nov 2016 09:57:07 GMT
+recorded_with: VCR 3.0.3

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: orcid_client
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: 0.2.1
 platform: ruby
 authors:
 - Martin Fenner
@@ -345,6 +345,7 @@ files:
 - spec/api_spec.rb
 - spec/external_identifier_spec.rb
 - spec/fixtures/external_identifier.xml
+- spec/fixtures/vcr_cassettes/OrcidClient/external_identifier/delete/should_delete_external_identifier.yml
 - spec/fixtures/vcr_cassettes/OrcidClient/external_identifier/post/should_create_external_identifier.yml
 - spec/fixtures/vcr_cassettes/OrcidClient/notifications/delete/should_delete_notification.yml
 - spec/fixtures/vcr_cassettes/OrcidClient/notifications/get/should_get_notification.yml