orc 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ae6474446adf8b9202cda734de4082253a86b10
-  data.tar.gz: 0bf59dd848ed82e0c162911b320cc78b6dbfd1f5
+  metadata.gz: 130f07b4b6a1684b92f3e5ec8e699e77a852e339
+  data.tar.gz: 32ec85549a38e20d8636e4822bfc1354da881ee5
 SHA512:
-  metadata.gz: 78a3c8c3e9eb39cfd2576be8c7abe5bb5ba82b76a123cb227af6edeaf7c5d7300584ed3972184056308862e0ed0421961ab478ffa300bae04ee45d15a85d39b0
-  data.tar.gz: 311fe4fc30114d43a804d9241351981a4ff8eb3d98ed5d3586fceccfa081843dfa8c315cb6d1259bd71382de6b634bdf35651d44d87676baae906e5dfb9137a1
+  metadata.gz: eaf9060d1c4e79d2db2392cafe0812d3e8f5a44469652f78b5f98d0dc6b22ac7d60c0f6395d3f78d37549e4f65a115b37debbaf11711672b6f23b53aa948fa3e
+  data.tar.gz: 73c50733010f8e60939e8fa69acdc38ee20f194a879f80c30c5f527d3b423488d290128283232c86d1cd9cc1c6d7e5c910d53388276ad8b752eea41e4879b9b9

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
-threshold: 4
-total_score: 11
+threshold: 9
+total_score: 14

data/config/flog.yml

@@ -1,2 +1,2 @@
 ---
-threshold: 1.6
+threshold: 6.3

data/lib/orc.rb

@@ -15,8 +15,8 @@ module Orc
     #   arbitrary data associated with the result
     #
     # @return [Success]
-    def self.success(object)
-      Success.new(object)
+    def self.success(object, status = :success)
+      Success.new(object, status)
     end
 
     # Create a result indicating failure
@@ -32,19 +32,24 @@ module Orc
       Failure.new(object, status)
     end
 
+    include Concord::Public.new(:object, :status)
     include AbstractType
 
     abstract_method :success?
-    abstract_method :status
-
-    attr_reader :object
 
     alias_method :output, :object
     alias_method :data,   :object
 
+    def failure?
+      !success?
+    end
+
+    def update
+      self.class.new(yield(object), status)
+    end
+
     # Result object indicating success along with associated data
     class Success < self
-      include Concord::Public.new(:object)
 
       # Indicate success
       #
@@ -52,18 +57,10 @@ module Orc
       def success?
         true
       end
-
-      # Status description
-      #
-      # @return [:success]
-      def status
-        :success
-      end
     end # Success
 
     # Result object indicating failure along with status and context
     class Failure < self
-      include Concord::Public.new(:object, :status)
 
       # Indicate success
       #

data/lib/orc/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Orc
-  VERSION = '0.0.3'.freeze
+  VERSION = '0.0.4'.freeze
 end # Orc

data/spec/unit/orc/result_spec.rb

@@ -4,20 +4,38 @@ require 'spec_helper'
 
 describe Orc::Result do
   describe '.success' do
-    subject { Orc::Result.success(object) }
+    shared_context 'a success result' do
+      let(:status) { :alright }
+      let(:object) { :context }
 
-    let(:object) { :object }
+      it 'signals success' do
+        expect(subject.success?).to be(true)
+        expect(subject.failure?).to be(false)
+      end
 
-    it 'signals success' do
-      expect(subject.success?).to be(true)
+      it 'exposes the associated #object' do
+        expect(subject.object).to be(object)
+      end
     end
 
-    it 'returns :success status' do
-      expect(subject.status).to be(:success)
+    context 'when no status is given' do
+      subject { Orc::Result.success(object) }
+
+      include_context 'a success result'
+
+      it 'exposes a :success status' do
+        expect(subject.status).to be(:success)
+      end
     end
 
-    it 'exposes the associated object' do
-      expect(subject.object).to be(object)
+    context 'when status is given' do
+      subject { Orc::Result.success(object, status) }
+
+      include_context 'a success result'
+
+      it 'exposes the given #status' do
+        expect(subject.status).to be(status)
+      end
     end
   end
 
@@ -28,6 +46,7 @@ describe Orc::Result do
 
       it 'signals failure' do
         expect(subject.success?).to be(false)
+        expect(subject.failure?).to be(true)
       end
 
       it 'exposes the associated #object' do
@@ -55,4 +74,24 @@ describe Orc::Result do
       end
     end
   end
+
+  describe '#update' do
+    subject { result.update { |o| o + 1 } }
+
+    let(:result) { Orc::Result.success(object, status) }
+    let(:status) { :alright }
+    let(:object) { 1 }
+
+    it 'updates #object' do
+      expect(subject.object).to be(2)
+    end
+
+    it 'does not change #status' do
+      expect(subject.status).to be(status)
+    end
+
+    it 'does not change #class' do
+      expect(subject.class).to equal(result.class)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: orc
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Martin Gamsjaeger (snusnu)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-26 00:00:00.000000000 Z
+date: 2014-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concord