optimum-energy-rubocop 0.7.3 → 0.7.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d622e5f383926c912f9d6ec1bc33f81e5dcd42ce745b3d50817b3f0f2e988595
-  data.tar.gz: c2e6d058370184b0b597307fc1e101cd3f5ae0dd02cd2c8af7a935a982528113
+  metadata.gz: d8a48fe93810295e73baba85384c88d9f8c65577793e958cf90d1c4a01a04378
+  data.tar.gz: 005de9b95f4c3b966cf57140e1df36c6b842821d147721bed594fe999aaf2410
 SHA512:
-  metadata.gz: 0e11a55e98de89ceba27d9b54d36941937848830a6a2f05a679643c508258c34851261aad3dd79fe59b44e4dba6e12beba319fbde3cf8d280f7f943a45a33456
-  data.tar.gz: c976b22785d4c3a4f435158312fbf3d1d773e9cb2acee9fccb73d23b4e0e8e3f182b77c19c7f317a03ae3bd366b7f9692891cd8cebaeecbc71411a16c7f139b6
+  metadata.gz: 2d9055756cdc55b425d6461b1768396a7030751bb696d4264e98c52475e1e5e82d6123f4ac493e415dc58c506abf704fddf1e229de4138cc3f593c01b8a0c322
+  data.tar.gz: 9756e319ec2db19a33a5021fcdaaadefb1183cbf811b104e077331c313c14ce0cf69787cc69bcbf4dcd1c449c13230fb86bb24f58add8598ff31df865a6a02b5

data/.ruby-version

@@ -1 +1 @@
-2.7.0
+2.7.1

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:2.7.0
+FROM ruby:2.7.1
 
 # Install the dependencies
 ADD Gemfile Gemfile.lock .ruby-version optimum-energy-rubocop.gemspec VERSION.txt /app/

data/Gemfile.lock

@@ -1,34 +1,52 @@
 PATH
   remote: .
   specs:
-    optimum-energy-rubocop (0.7.3)
+    optimum-energy-rubocop (0.7.5)
       rubocop (~> 0.80)
-      rubocop-rails (~> 2.4.2)
+      rubocop-rails (~> 2.7.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    jaro_winkler (1.5.4)
-    parallel (1.19.1)
-    parser (2.7.0.4)
-      ast (~> 2.4.0)
-    rack (2.2.2)
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
+    concurrent-ruby (1.1.6)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.1)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
+    regexp_parser (1.7.1)
     rexml (3.2.4)
-    rubocop (0.80.1)
-      jaro_winkler (~> 1.5.1)
+    rubocop (0.88.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
       rexml
+      rubocop-ast (>= 0.1.0, < 1.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-rails (2.4.2)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.2.0)
+      parser (>= 2.7.0.1)
+    rubocop-rails (2.7.1)
+      activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.72.0)
+      rubocop (>= 0.87.0)
     ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -37,7 +55,7 @@ DEPENDENCIES
   optimum-energy-rubocop!
 
 RUBY VERSION
-   ruby 2.7.0p0
+   ruby 2.7.1p83
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -24,9 +24,10 @@ inherit_from:
 
 ## Updating This Gem
 
-After making changes to the rules in the [default.yml](default.yml) file, be sure that the version
-is bumped in both the [VERSION.txt](VERSION.txt) and [Gemfile.lock](Gemfile.lock) files. If the
-version is not changed, repos consuming this gem will not get the updates.
+After making changes to the rules in the [optimum_energy_rubocop.yml](optimum_energy_rubocop.yml)
+file, be sure that the version is bumped in both the [VERSION.txt](VERSION.txt) and
+[Gemfile.lock](Gemfile.lock) files. If the version is not changed, repos consuming this gem will not
+get the updates.
 
 ## Running Rubocop
 

data/VERSION.txt

@@ -1 +1 @@
-0.7.3
+0.7.8

data/deployment.env.encrypted

@@ -1,2 +1,2 @@
 codeship:v2
-JjzJa5IPPlslZNYdlQaBuQwNLu1cNBVcIFyCqOQ1Bz9Rfmo/b673eak7fgsGFNs1cMIvp28L61IfIBKwRsy0x1lrGGIfdjo8lwIGA/JCyM5IpHrpsBazaVjaL0cHzOulATzlwQ==
+IKBJYRm4ObjGLsvovpL6Ov+IwE3JgQtN2ckNn2AbftoBWh9gEKXDRD9LPhZfKPiaDTNrUWIvNFKNqGI6eMNm6r5Uu/1iHZdnmwoP5t9pv+4t8S+dYsSfzNhvJ9psisoN1hTT/8+CtxyZ13BEhS4ejF2aUZ+8IePxKLr+NTk=

data/example/example.rb

@@ -0,0 +1,5 @@
+# Rubocop ignores some rules when it only lints the Gemfile and gemspec files. This file serves as
+# an example of a Ruby file so we can ensure all of the linter rules run without warnings or errors.
+module Example
+  def example; end
+end

data/optimum-energy-rubocop.gemspec

@@ -1,6 +1,7 @@
 Gem::Specification.new do |spec|
   spec.name = "optimum-energy-rubocop"
   spec.version = File.read("VERSION.txt")
+  spec.required_ruby_version = "~> 2.7"
   spec.authors = [ "Optimum Energy" ]
 
   spec.summary = "The shared Rubocop configuration for Optimum Energy"
@@ -10,5 +11,5 @@ Gem::Specification.new do |spec|
   spec.files = `git ls-files -z`.split("\x0")
 
   spec.add_dependency "rubocop", "~> 0.80"
-  spec.add_dependency "rubocop-rails", "~> 2.4.2"
+  spec.add_dependency "rubocop-rails", "~> 2.7.1"
 end

data/optimum_energy_rubocop.yml

@@ -4,6 +4,12 @@
 require: rubocop-rails
 
 AllCops:
+
+  # By default, Rubocop now displays warnings for all cops that are going to be enabled in the next
+  # minor version. This disables those cops. We'll pick them up when Rubocop decided they're good
+  # enough to enable by default for everyone.
+  NewCops: disable
+
   Exclude:
     - 'db/schema.rb'
     - 'bin/*'
@@ -21,6 +27,9 @@ Layout/BlockAlignment:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
 # Unfortuantely, this rule can't be refined to the point of being useful.
 Layout/EmptyLinesAroundMethodBody:
   Enabled: false
@@ -76,9 +85,19 @@ Layout/MultilineMethodCallIndentation:
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
+# Ideally we'd be able to configure begin/rescue blocks to align how our other blocks do, but for
+# now there doesn't seem to be an option for it.
+#
+# TODO: Move this rule change to optimum-energy-rubocop-config.
+Layout/RescueEnsureAlignment:
+  Enabled: false
+
 Layout/SpaceInsideArrayLiteralBrackets:
   EnforcedStyle: space
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/SpaceAroundOperators:
   AllowForAlignment: false
 
@@ -92,11 +111,17 @@ Layout/SpaceInsideStringInterpolation:
 # LINT #
 ########
 
+Lint/RaiseException:
+  Enabled: true
+
 # Rubocop has a nasty habit of removing inline rule declarations, even when they're necessary. This
 # disables that behavior.
 Lint/RedundantCopEnableDirective:
   AutoCorrect: false
 
+Lint/StructNewOverride:
+    Enabled: true
+
 Lint/UnusedBlockArgument:
   AutoCorrect: false
 
@@ -165,6 +190,11 @@ Rails/Date:
 Rails/FilePath:
   Enabled: false
 
+# By default, the Rubocop Rails rules warn against using has_and_belongs_to_many. This disables that
+# behavior. Don't you tell me what to do Rubocop.
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
 Rails/NotNullColumn:
   Enabled: false
 
@@ -199,9 +229,17 @@ Style/EachWithObject:
 Style/EmptyMethod:
   AutoCorrect: false
 
+Style/ExponentialNotation:
+  Enabled: true
+  AutoCorrect: true
+
 Style/FormatString:
   EnforcedStyle: percent
 
+# This rule is wrong for Rails validation messages.
+Style/FormatStringToken:
+  Enabled: false
+
 # TODO: This won't be necessary when we upgrade to Ruby 3.0. Until then, rather than adding a
 # comment to every file, we should only add it to the files where it's necessary.
 Style/FrozenStringLiteralComment:
@@ -231,6 +269,9 @@ Style/RegexpLiteral:
 Style/ReturnNil:
   Enabled: true
 
+Style/SlicingWithRange:
+  Enabled: true
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optimum-energy-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.7.8
 platform: ruby
 authors:
 - Optimum Energy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-14 00:00:00.000000000 Z
+date: 2020-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.7.1
 description: 
 email: 
 executables: []
@@ -57,6 +57,7 @@ files:
 - codeship-services.yml
 - codeship-steps.yml
 - deployment.env.encrypted
+- example/example.rb
 - optimum-energy-rubocop.gemspec
 - optimum_energy_rubocop.yml
 homepage: https://github.com/optimiumenergyco/optimum-energy-rubocop
@@ -69,9 +70,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="