optimum-energy-rubocop 0.7.2 → 0.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f0cd9f0166ac4ace7b49f917a78c87538580cf14af2bf62b72502b92378ca33
-  data.tar.gz: 2d7667bd018bc5ef9eebb4e8b1ae9b36e75a0151b9e788ca8692a91540f96595
+  metadata.gz: 20c776d18b6b987d6b62b70e4059353cfc33a93369c3bf054b0536b3bda9df69
+  data.tar.gz: 63d893948684ae9a30e5ef249fa20aa94e2e8f45997dba8c645db34b6bb9f86f
 SHA512:
-  metadata.gz: 7889df2b5efca3031974f35aa70d4b326cab878336806396ebaace3a6223f05698637fffcc98e533acdf25399af77da5fe51d79fe83d827cb23000436ecd50e2
-  data.tar.gz: 7bbb608c029580ed08abb6bd2707d910ab444511c5545ba57d198582e97310dab43a7911463d763abc354f6696e6c1db18eaa68d7c5dcc197d05aa38ce444190
+  metadata.gz: 78582677dd14837e8b301ac1d435ac74d655db94a62dd08aa0d132958904ff9aa893179eb86e4ee18931a626ad3ebbac864fb4dbbf630d2eb8e63f5091891126
+  data.tar.gz: cfcabe6d8169de650e13c6cb2633494f8c383b14c1e5fb16d6cf4b3eb0a0d2a85ff37aae59cd67c90bf0955d96bb8bb32d7f341d6d49b7bd5ef68e9aaf7fc443

data/.ruby-version

@@ -1 +1 @@
-2.7.0
+2.7.1

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:2.7.0
+FROM ruby:2.7.1
 
 # Install the dependencies
 ADD Gemfile Gemfile.lock .ruby-version optimum-energy-rubocop.gemspec VERSION.txt /app/

data/Gemfile.lock

@@ -1,34 +1,52 @@
 PATH
   remote: .
   specs:
-    optimum-energy-rubocop (0.7.2)
+    optimum-energy-rubocop (0.7.5)
       rubocop (~> 0.80)
-      rubocop-rails (~> 2.4.2)
+      rubocop-rails (~> 2.7.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    jaro_winkler (1.5.4)
-    parallel (1.19.1)
-    parser (2.7.0.2)
-      ast (~> 2.4.0)
-    rack (2.2.2)
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
+    concurrent-ruby (1.1.6)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.14.1)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
+    regexp_parser (1.7.1)
     rexml (3.2.4)
-    rubocop (0.80.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (0.88.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
       rexml
+      rubocop-ast (>= 0.1.0, < 1.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-rails (2.4.2)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.2.0)
+      parser (>= 2.7.0.1)
+    rubocop-rails (2.7.1)
+      activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.72.0)
+      rubocop (>= 0.87.0)
     ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -37,7 +55,7 @@ DEPENDENCIES
   optimum-energy-rubocop!
 
 RUBY VERSION
-   ruby 2.7.0p0
+   ruby 2.7.1p83
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -24,9 +24,10 @@ inherit_from:
 
 ## Updating This Gem
 
-After making changes to the rules in the [default.yml](default.yml) file, be sure that the version
-is bumped in both the [VERSION.txt](VERSION.txt) and [Gemfile.lock](Gemfile.lock) files. If the
-version is not changed, repos consuming this gem will not get the updates.
+After making changes to the rules in the [optimum_energy_rubocop.yml](optimum_energy_rubocop.yml)
+file, be sure that the version is bumped in both the [VERSION.txt](VERSION.txt) and
+[Gemfile.lock](Gemfile.lock) files. If the version is not changed, repos consuming this gem will not
+get the updates.
 
 ## Running Rubocop
 

data/VERSION.txt

@@ -1 +1 @@
-0.7.2
+0.7.7

data/example/example.rb

@@ -0,0 +1,5 @@
+# Rubocop ignores some rules when it only lints the Gemfile and gemspec files. This file serves as
+# an example of a Ruby file so we can ensure all of the linter rules run without warnings or errors.
+module Example
+  def example; end
+end

data/optimum-energy-rubocop.gemspec

@@ -10,5 +10,5 @@ Gem::Specification.new do |spec|
   spec.files = `git ls-files -z`.split("\x0")
 
   spec.add_dependency "rubocop", "~> 0.80"
-  spec.add_dependency "rubocop-rails", "~> 2.4.2"
+  spec.add_dependency "rubocop-rails", "~> 2.7.1"
 end

data/optimum_energy_rubocop.yml

@@ -4,6 +4,12 @@
 require: rubocop-rails
 
 AllCops:
+
+  # By default, Rubocop now displays warnings for all cops that are going to be enabled in the next
+  # minor version. This disables those cops. We'll pick them up when Rubocop decided they're good
+  # enough to enable by default for everyone.
+  NewCops: disable
+
   Exclude:
     - 'db/schema.rb'
     - 'bin/*'
@@ -21,6 +27,9 @@ Layout/BlockAlignment:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
 # Unfortuantely, this rule can't be refined to the point of being useful.
 Layout/EmptyLinesAroundMethodBody:
   Enabled: false
@@ -76,9 +85,19 @@ Layout/MultilineMethodCallIndentation:
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
+# Ideally we'd be able to configure begin/rescue blocks to align how our other blocks do, but for
+# now there doesn't seem to be an option for it.
+#
+# TODO: Move this rule change to optimum-energy-rubocop-config.
+Layout/RescueEnsureAlignment:
+  Enabled: false
+
 Layout/SpaceInsideArrayLiteralBrackets:
   EnforcedStyle: space
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/SpaceAroundOperators:
   AllowForAlignment: false
 
@@ -92,11 +111,17 @@ Layout/SpaceInsideStringInterpolation:
 # LINT #
 ########
 
+Lint/RaiseException:
+  Enabled: true
+
 # Rubocop has a nasty habit of removing inline rule declarations, even when they're necessary. This
 # disables that behavior.
 Lint/RedundantCopEnableDirective:
   AutoCorrect: false
 
+Lint/StructNewOverride:
+    Enabled: true
+
 Lint/UnusedBlockArgument:
   AutoCorrect: false
 
@@ -165,6 +190,11 @@ Rails/Date:
 Rails/FilePath:
   Enabled: false
 
+# By default, the Rubocop Rails rules warn against using has_and_belongs_to_many. This disables that
+# behavior. Don't you tell me what to do Rubocop.
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
 Rails/NotNullColumn:
   Enabled: false
 
@@ -193,12 +223,23 @@ Style/Documentation:
 Style/DoubleNegation:
   Enabled: false
 
+Style/EachWithObject:
+  Enabled: false
+
 Style/EmptyMethod:
   AutoCorrect: false
 
+Style/ExponentialNotation:
+  Enabled: true
+  AutoCorrect: true
+
 Style/FormatString:
   EnforcedStyle: percent
 
+# This rule is wrong for Rails validation messages.
+Style/FormatStringToken:
+  Enabled: false
+
 # TODO: This won't be necessary when we upgrade to Ruby 3.0. Until then, rather than adding a
 # comment to every file, we should only add it to the files where it's necessary.
 Style/FrozenStringLiteralComment:
@@ -228,6 +269,9 @@ Style/RegexpLiteral:
 Style/ReturnNil:
   Enabled: true
 
+Style/SlicingWithRange:
+  Enabled: true
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optimum-energy-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.7
 platform: ruby
 authors:
 - Optimum Energy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-25 00:00:00.000000000 Z
+date: 2020-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.7.1
 description: 
 email: 
 executables: []
@@ -57,6 +57,7 @@ files:
 - codeship-services.yml
 - codeship-steps.yml
 - deployment.env.encrypted
+- example/example.rb
 - optimum-energy-rubocop.gemspec
 - optimum_energy_rubocop.yml
 homepage: https://github.com/optimiumenergyco/optimum-energy-rubocop