optimizely_server_side 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52a8ee884cb6db767b45acb026984cb413f77dca
-  data.tar.gz: f674f904ce523f6003db14456367a47df57b48d2
+  metadata.gz: 4a8b2715ff8f9919582b449925b0838d4f1590b2
+  data.tar.gz: c3f89f698fed6d3590fcd342fe8efcff51370377
 SHA512:
-  metadata.gz: 42058be44f0bd1cc8ce1a16b6aae1e7aba342d558a4cc5f8dacf13a97a03f5c3751126cf4ba10839cc89a0701026f32213af3e777345051aa3650c22dc851068
-  data.tar.gz: 115f4e2b2ee276c8eb29b5160fd83074fc12b25aa01f5fcdaab5eb3400c7fcafad738f7fce52781095a96855f218aa6207dc0c7aa63c22567ee0aed0e5614b2a
+  metadata.gz: 47125338faa0d15515e4e0586384b9972ca66703e1c912eaaafb535c1f183f1863d4500d6770703e3359d616c959ccdfe4c8f6224abae16455672b1ae6fbcff1
+  data.tar.gz: 146fea8cb394cf5cb687c66534fe6deb9c3b7e0ad902cef1f2a3761f8202206c432edd1af2cb3e418ed9add5f8e60ce30307ad06b86dbcd0e382b58ff21e0314

data/.rspec

@@ -1,2 +1,2 @@
---format progress
+--format documentation
 --color

data/Gemfile.lock

@@ -40,8 +40,6 @@ GEM
       rspec-core (~> 3.5.0)
       rspec-expectations (~> 3.5.0)
       rspec-mocks (~> 3.5.0)
-    rspec-collection_matchers (1.1.2)
-      rspec-expectations (>= 2.99.0.beta1)
     rspec-core (3.5.2)
       rspec-support (~> 3.5.0)
     rspec-expectations (3.5.0)
@@ -72,7 +70,6 @@ DEPENDENCIES
   codeclimate-test-reporter
   optimizely_server_side!
   rspec (~> 3.5)
-  rspec-collection_matchers (~> 1.1, >= 1.1.2)
   webmock (~> 2.1)
 
 BUNDLED WITH

data/Readme.md

@@ -29,7 +29,7 @@ This gem solves few things:
 
 ### Architecture
 
-![alt text](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/general_architecture.png
+![alt Architecture](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/general_architecture.png
  "Architecture")
 
 ### Getting Started
@@ -125,7 +125,24 @@ class Foo
   end
 end
 ```
+#### Don't want to stick with variation_one, variation_two ?
 
+You can call you own method names with `variation_` . Below i have `config.variation_best_experience` and `config.variation_pathetic_experience`.
+
+
+```ruby
+# in any app/view/foo.html.erb
+<% experiment(EXPERIMENT_KEY) do |config| %>
+  <% config.variation_best_experience(VARIATION_ONE_KEY) do %>
+    <%= render partial: 'variation_one_experience'    
+  <% end %>
+
+  <% config.variation_pathetic_experience(VARIATION_DEFAULT_KEY, primary: true) do %>
+    <%= render partial: 'variation_default_experience'    
+  <% end %>
+<% end %>
+
+```
 In the above examples:
 
 `EXPERIMENT_KEY`: When you will set your experiment this key will be set up that time at https://app.optimizely.com.
@@ -138,7 +155,7 @@ In the above examples:
 
 `primary: true` : If you see above some variations are marked with `primary: true`. This enables handling the fallback capabilities of optimizely_server_side. If there is any error pulling datafile or experiment is paused the `primary` experience is served.  Not setting primary won't give any experience during fallback times.  We encourage setting it up.
 
-![alt text](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/screenshot.png "Logo Title Text 1")
+![alt Optimizely dashboard](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/screenshot.png "Optimizely dashboard")
 
 
 ### Instrumentation

data/lib/optimizely_server_side.rb

@@ -15,13 +15,14 @@ module OptimizelyServerSide
 
   class << self
     attr_writer :configuration
-  end
 
-  def self.configuration
-    @configuration ||= Configuration.new
-  end
+    def configuration
+      @configuration ||= Configuration.new
+    end
 
-  def self.configure
-    yield(configuration)
+    def configure
+      yield(configuration)
+    end
   end
+
 end

data/lib/optimizely_server_side/experiment.rb

@@ -12,15 +12,25 @@ module OptimizelyServerSide
       self.applicable_variation
     end
 
-    [
-      :variation_one,
-      :variation_two,
-      :variation_three,
-      :variation_default,
-    ].each do |variation|
-      define_method(variation) do |key, opts={}, &blk|  # def variation_one(key, opts = {}, &blk)
-        add_variation(key, opts, &blk)                  #   add_variation(key, opts, &blk)
-      end                                               # end
+    def variation_one(key, opts = {}, &blk)
+      add_variation(key, opts, &blk)
+    end
+
+    def variation_two(key, opts = {}, &blk)
+      add_variation(key, opts, &blk)
+    end
+
+    def variation_default(key, opts = {}, &blk)
+      add_variation(key, opts, &blk)
+    end
+
+    # Support for variation_three, variation_four till variation_n
+    def method_missing(key, *args, &blk)
+      if key.to_s.match('variation_')
+        add_variation(args[0], args[1] || {}, &blk)
+      else
+        super
+      end
     end
 
     # Selects and calls the variation which is applicable

data/optimizely_server_side.gemspec

@@ -2,8 +2,8 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = 'optimizely_server_side'
-  s.version     = '0.0.6'
-  s.date        = '2016-08-14'
+  s.version     = '0.0.7'
+  s.date        = '2016-08-15'
   s.summary     = "Optimizely server side. A wrapper on top of optimizely's ruby sdk for easy caching of server side config "
   s.description = "Optimizely server side. A A/B test wrapper on top of optimizely's ruby sdk for easy caching of server side config and exposing few more utility helpers. Handling of fallbacks and marking primary experiments. "
   s.authors     = ["Ankit Gupta"]
@@ -16,7 +16,6 @@ Gem::Specification.new do |s|
     'https://github.com/ankit8898/optimizely_server_side'
   s.license       = 'MIT'
   s.add_development_dependency 'rspec', '~> 3.5'
-  s.add_development_dependency 'rspec-collection_matchers', '~> 1.1', '>= 1.1.2'
   s.add_development_dependency 'webmock', '~> 2.1'
   s.add_runtime_dependency 'optimizely-sdk' , '~> 0.1.1'
   s.add_runtime_dependency 'activesupport', '~> 4.2', '>= 4.2.6'

data/spec/optimizely_server_side/experiment_spec.rb

@@ -37,6 +37,31 @@ RSpec.describe OptimizelyServerSide::Experiment do
     end
 
 
+    context 'when the variation are named anything else' do
+
+      subject { OptimizelyServerSide::Experiment.new(variation_key = 'foobar') }
+
+      let(:some_method) { Proc.new {|n| n*2 } }
+
+      let(:some_html_block) do
+        -> { '<h1>Foo</h1>' }
+      end
+
+      let(:string_blk) { -> { 'Hello!'} }
+
+
+      before do
+        subject.variation_bottom_lead_form('foo', &some_method)
+
+        subject.variation_middle_lead_form('foo_two', primary: true, &some_html_block)
+
+        subject.variation_pathetic_form('foobar', &string_blk)
+      end
+
+      it { expect(subject.applicable_variation).to eq('Hello!') }
+    end
+
+
   end
 
   describe '#variation_one' do
@@ -141,6 +166,32 @@ RSpec.describe OptimizelyServerSide::Experiment do
     end
   end
 
+
+  describe '#variation_bottom_lead_form' do
+
+    let(:blk) { -> {'<div><h1>Hello</h1></div>'} }
+
+    before do
+      @variation_instance = subject.variation_bottom_lead_form('foo', primary: true, &blk)
+    end
+
+    it 'returns a variation instance passed' do
+      expect(@variation_instance).to be_kind_of(OptimizelyServerSide::Variation)
+    end
+
+    it 'returns a key of foo' do
+      expect(@variation_instance.key).to eq('foo')
+    end
+
+    it 'returns a content with blk ' do
+      expect(@variation_instance.instance_variable_get(:@content)).to eq(blk)
+    end
+
+    it 'is primary' do
+      expect(@variation_instance.primary).to be(true)
+    end
+  end
+
   describe '#variations' do
 
     context 'key accepts regular strings' do
@@ -152,7 +203,7 @@ RSpec.describe OptimizelyServerSide::Experiment do
       end
 
       it 'holds collection of variations' do
-        expect(subject.instance_variable_get(:@variations)).to have(1).items
+        expect(subject.instance_variable_get(:@variations).count).to eq(1)
       end
 
       it 'is a type of Variation' do
@@ -216,7 +267,7 @@ RSpec.describe OptimizelyServerSide::Experiment do
       end
 
       it 'has all variations' do
-        expect(subject.instance_variable_get(:@variations)).to have(3).items
+        expect(subject.instance_variable_get(:@variations).count).to eq(3)
       end
 
       it 'has all variations of class Variation' do
@@ -282,5 +333,21 @@ RSpec.describe OptimizelyServerSide::Experiment do
       it { expect(subject.primary_variation.call).to eq('<h1>Foo</h1>') }
     end
 
+
+    context 'when test are having own variation names' do
+
+      before do
+        subject.variation_bottom_lead_form('foo', &some_method)
+
+        subject.variation_middle_lead_form('foo_two', primary: true, &some_html_block)
+
+        subject.variation_pathetic_form('foo_three',&string_blk)
+      end
+
+      it { expect(subject.primary_variation).not_to be_nil }
+
+      it { expect(subject.primary_variation.call).to eq('<h1>Foo</h1>') }
+    end
+
   end
 end

data/spec/spec_helper.rb

@@ -3,7 +3,6 @@ CodeClimate::TestReporter.start
 
 require 'bundler/setup'
 require 'webmock/rspec'
-require 'rspec/collection_matchers'
 
 Bundler.setup
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optimizely_server_side
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Ankit Gupta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-14 00:00:00.000000000 Z
+date: 2016-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -24,26 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -106,7 +86,6 @@ files:
 - Gemfile
 - Gemfile.lock
 - Readme.md
-- blocky.rb
 - docs/general_architecture.png
 - docs/screenshot.png
 - lib/optimizely_server_side.rb