optimizely_server_side 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6398f138ed81929b7eb9057466e0bb501f21cae3
-  data.tar.gz: abc2f4c80d0fa6dc094ed80dfc1395eb66e4685d
+  metadata.gz: e32298f15f7388b74f47abe8f85550d0b590d96d
+  data.tar.gz: babcf58d56c9adc0a8cc13458ff14b0921eed38d
 SHA512:
-  metadata.gz: 6591c7c1872081c2748074891cb9c1f4084fae529a752d2c78ae239b78790709b9fab4bd1ded08d1195116ffffcedc5fc452d68409620b6e9a98afc595a683b8
-  data.tar.gz: 75dd78eac9285bfd4bd988552e9fae740572af4916981ee0308e5e39abd6fcbed84b929ec355d0c752a2ca6a3ca7329b8966cc5abba42e0597899a293f118c02
+  metadata.gz: a948ea8f67705f498e8b9783eb6834140227a5a87944e4f3f67c499becfd774ba04a333ab9bbff82a687e285c31996232bbeb6e4ee3fe6ea70644b2a1db59ab2
+  data.tar.gz: c44efd2ba68bdf260569b254c88b9b69beddc90c3d90d93be507d12bc5d55fbe122ff29f0ad9fac8c7ffdea8408b5e27e56990cb511949bd9f861fe06e54a1b6

data/.gitignore

@@ -1 +1,4 @@
 .DS_Store
+optimizely_server_side-*.gem
+coverage
+blocky.rb

data/.travis.yml

@@ -2,4 +2,7 @@ language: ruby
 rvm:
   - 2.2
   - 2.3.0
-script: bundle exec rspec spec
+script: bundle exec rspec spec
+addons:
+  code_climate:
+    repo_token: 3dab4dd3ef8f9baf5bf35b781aff78b4be16700dcc1db13805f34e25849d898f

data/Gemfile

@@ -1,3 +1,5 @@
 source "https://rubygems.org"
 
 gemspec
+
+gem "codeclimate-test-reporter", group: :test, require: nil

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    optimizely_server_side (0.0.1)
+    optimizely_server_side (0.0.3)
       activesupport (~> 4.2, >= 4.2.6)
       optimizely-sdk (~> 0.1.1)
 
@@ -15,9 +15,12 @@ GEM
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     addressable (2.3.8)
+    codeclimate-test-reporter (0.5.0)
+      simplecov (>= 0.7.1, < 1.0.0)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.2.5)
+    docile (1.1.5)
     hashdiff (0.3.0)
     httparty (0.13.7)
       json (~> 1.8)
@@ -47,6 +50,11 @@ GEM
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
     safe_yaml (1.0.4)
+    simplecov (0.11.2)
+      docile (~> 1.1.0)
+      json (~> 1.8)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
@@ -59,6 +67,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  codeclimate-test-reporter
   optimizely_server_side!
   rspec (~> 3.5)
   webmock (~> 2.1)

data/Readme.md

@@ -1,6 +1,8 @@
 ## Optimizely Server Side
 
 [![Code Climate](https://codeclimate.com/github/ankit8898/optimizely_config_provider/badges/gpa.svg)](https://codeclimate.com/github/ankit8898/optimizely_config_provider) [![Build Status](https://travis-ci.org/ankit8898/optimizely_server_side.svg?branch=master)](https://travis-ci.org/ankit8898/optimizely_server_side)
+[![Gem Version](https://badge.fury.io/rb/optimizely_server_side.svg)](https://badge.fury.io/rb/optimizely_server_side)
+[![Test Coverage](https://codeclimate.com/github/ankit8898/optimizely_config_provider/badges/coverage.svg)](https://codeclimate.com/github/ankit8898/optimizely_config_provider/coverage)
 
 ### What is Optimizely Server Side ?
 
@@ -12,19 +14,26 @@ This gem solves few things:
 
  - **Syncing AB test config across different servers when you don't want to fetch config via REST endpoint or redis/memcache store**
 
+  Yes, it's designed keeping performance in mind as we want to save a network overhead and a extra dependency.
+
   If you are using Optimizely you will be aware about the [datafile](http://developers.optimizely.com/server/reference/index.html#datafile). Once we make changes to the A/B test like change in percent distribution, start / pause a experiment this file get's updated.
 
-  If you have 50 servers with 40 passenger / puma process these process needs to be updated.  The Gem polls the config at regular interval and keeps the file cached across different process.
+  If you have 50 servers with 40 passenger / puma process these process needs to be updated.  The Gem polls the config at regular interval and keeps the datafile cached across different process.
 
-  The config is stored in **Memory Store** .
+  The config is stored in **Memory Store** . We use [Activesupport memory store](http://api.rubyonrails.org/classes/ActiveSupport/Cache/MemoryStore.html) for same.
 
 * **Some additional helpers**
 
   Some more helpers exposed that can be exposed in views (.erbs) or PORO's.  It avoids duplication of few activation settings.
 
+### Architecture
+
+![alt text](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/general_architecture.png
+ "Architecture")
+
 ### Getting Started
 
-Add the gem in you Gemfile
+Add the gem in your Gemfile
 
 ```ruby
  gem 'optimizely_server_side'
@@ -71,7 +80,6 @@ class ApplicationController < ActionController::Base
 
 ```
 
-
 Now in your views or models
 
 
@@ -93,12 +101,29 @@ experiment(EXPERIMENT_KEY) do |config|
 end
 ```
 
-EXPERIMENT_KEY: The experiment key that you will be getting while setting up your experiment from https://app.optimizely.com.
+`EXPERIMENT_KEY`: The experiment key that you will be getting while setting up your experiment from https://app.optimizely.com.
 
-VARIATION_ONE_KEY: Key for Variation one. This will be also set when setting up experiment
+`VARIATION_ONE_KEY`: Key for Variation one. This will be also set when setting up experiment
 
-VARIATION_TWO_KEY: Key for Variation two. This will be also set when setting up experiment
+`VARIATION_TWO_KEY`: Key for Variation two. This will be also set when setting up experiment
 
-VARIATION_DEFAULT_KEY: Key for default experience. This will be also set when setting up experiment
+`VARIATION_DEFAULT_KEY`: Key for default experience. This will be also set when setting up experiment
 
 ![alt text](https://github.com/ankit8898/optimizely_server_side/blob/master/docs/screenshot.png "Logo Title Text 1")
+
+### Testing
+
+Gem uses rspec for unit testing
+
+```ruby
+bundle exec rspec .
+```
+
+```
+Finished in 0.28287 seconds (files took 1.3 seconds to load)
+36 examples, 0 failures
+```
+
+### License
+
+The MIT License

data/lib/optimizely_server_side.rb

@@ -6,7 +6,7 @@ require 'optimizely'
 require 'optimizely_server_side/cache'
 require 'optimizely_server_side/configuration'
 require 'optimizely_server_side/datafile_fetcher'
-require 'optimizely_server_side/variation'
+require 'optimizely_server_side/experiment'
 require 'optimizely_server_side/optimizely_sdk'
 require 'optimizely_server_side/helpers/support'
 

data/lib/optimizely_server_side/cache.rb

@@ -11,7 +11,9 @@ module OptimizelyServerSide
     # We are sticking with Activesupprt memory store as gem is to be used with
     # Rails app for now.
     def initialize
-      @cache_store_instance = ActiveSupport::Cache::MemoryStore.new(expires_in: OptimizelyServerSide.configuration.cache_expiry.send(:minutes))
+      @cache_store_instance = ActiveSupport::Cache::MemoryStore.new(
+        expires_in: OptimizelyServerSide.configuration.cache_expiry.send(:minutes)
+      )
     end
 
     class << self

data/lib/optimizely_server_side/configuration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module OptimizelyServerSide
 
   class Configuration

data/lib/optimizely_server_side/datafile_fetcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module OptimizelyServerSide
 
   class DatafileFetcher
@@ -5,14 +6,44 @@ module OptimizelyServerSide
     # the API source. The API can be optimizely cdn itself or
     # any other source.
 
+    attr_reader :content, :success
+
+    def initialize(content:, success:)
+      @content = content
+      @success = success
+    end
+
     class << self
 
       # Fetch the Config from the specified source.
       def fetch
-        Net::HTTP.get(URI(OptimizelyServerSide.configuration.config_endpoint))
+        begin
+          response = call_optimizely_cdn
+          if response.is_a?(Net::HTTPSuccess)
+            new(content: response.body, success: true)
+          else
+            fallback
+          end
+        rescue Exception => e
+          fallback
+        end
       end
       alias_method :datafile, :fetch
 
+      # Gets data from Optimizely cdn
+      def call_optimizely_cdn
+        Net::HTTP.get_response(
+          URI(OptimizelyServerSide.configuration.config_endpoint)
+        )
+      end
+
+      def fallback
+        new(
+          content: '{"experiments": [],"version": "1","audiences": [],"dimensions": [],"groups": [],"projectId": "5960232316","accountId": "5955320306","events": [],"revision": "30"}',
+          success: false
+        )
+
+      end
     end
 
   end

data/lib/optimizely_server_side/experiment.rb

@@ -0,0 +1,52 @@
+module OptimizelyServerSide
+  class Experiment
+
+    def initialize(key)
+      @another_key = key
+      @store = {}
+    end
+
+    def start
+      yield(self)
+      self.compute
+    end
+
+
+    def variation_one(key, &blk)
+      @store[key] = blk
+    end
+
+    def variation_two(key, &blk)
+      @store[key] = blk
+    end
+
+    def variation_three(key, &blk)
+      @store[key] = blk
+    end
+
+    def variation_default(key, &blk)
+      @store[key] = blk
+    end
+
+    def compute
+      puts "---Experience selected----- #{@another_key}"
+      if @store[@another_key]
+        @store[@another_key].call
+      end
+    end
+
+  end
+end
+#
+# a = Foo.new.start do |config|
+#
+#   config.game_one('aa') do
+#     '<div>       \n   </div>'
+#   end
+#
+#   config.game_two('bb') do
+#     '<div>       \n kjsdkaskfsajkfjk   </div>'
+#   end
+# end
+#
+# p a

data/lib/optimizely_server_side/helpers/support.rb

@@ -21,14 +21,14 @@ module OptimizelyServerSide
     # end
 
     def experiment(experiment_key, &blk)
-      result_variation_key = optimizely_sdk_project_instance(experiment_key)
-      variation_instance   = OptimizelyServerSide::Variation.new(result_variation_key)
-      blk.call(variation_instance)
-      variation_instance.compute
+      variation_key = optimizely_sdk_project_instance(experiment_key)
+      OptimizelyServerSide::Experiment.new(variation_key).start(&blk)
     end
 
     def optimizely_sdk_project_instance(experiment_key)
-      OptimizelyServerSide::OptimizelySdk.project_instance(event_dispather: MyEventDispatcher.new).activate(experiment_key, OptimizelyServerSide.configuration.visitor_id)
+      OptimizelyServerSide::OptimizelySdk
+      .project_instance(event_dispatcher: MyEventDispatcher.new)
+      .activate(experiment_key, OptimizelyServerSide.configuration.visitor_id)
     end
 
   end

data/lib/optimizely_server_side/optimizely_sdk.rb

@@ -1,16 +1,26 @@
+# frozen_string_literal: true
 module OptimizelyServerSide
 
   class OptimizelySdk
 
-    # Public method to be accessed in the application
-    # This is the project instance and is giving
-    # access to all the optimizely sdk methods.
-    # Datafile
-    def self.project_instance(options = {})
-      Cache.fetch('optimizely_sdk_config'.freeze) do
-        puts "Getting the configg"
-        Optimizely::Project.new(DatafileFetcher.datafile, options[:event_dispather])
+    class << self
+
+      # Public method to be accessed in the application
+      # This is the project instance and is giving
+      # access to all the optimizely sdk methods.
+      # Datafile
+      def project_instance(options = {})
+        Optimizely::Project.new(cached_datafile,
+                                options[:event_dispatcher])
+      end
+
+      def cached_datafile
+        Cache.fetch('optimizely_sdk_config') do
+          puts "*********** Getting the config ***********"
+          DatafileFetcher.datafile.content
+        end
       end
+
     end
 
   end

data/optimizely_server_side.gemspec

@@ -2,10 +2,10 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = 'optimizely_server_side'
-  s.version     = '0.0.3'
-  s.date        = '2016-08-10'
+  s.version     = '0.0.4'
+  s.date        = '2016-08-13'
   s.summary     = "Optimizely server side. A wrapper on top of optimizely's ruby sdk for easy caching of server side config "
-  s.description = "Optimizely server side. A wrapper on top of optimizely's ruby sdk for easy caching of server side config and exposing few more utility helpers "
+  s.description = "Optimizely server side. A AB test wrapper on top of optimizely's ruby sdk for easy caching of server side config and exposing few more utility helpers.  Handling of fallbacks and marking primary experiments. "
   s.authors     = ["Ankit Gupta"]
   s.email       = 'ankit.gupta8898@gmail.com'
   s.files       = `git ls-files`.split("\n")

data/spec/optimizely_server_side/cache_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe OptimizelyServerSide::Cache do
     it 'should return the config from API and cache it' do
       expect(
         described_class.fetch('key') do
-          JSON.parse(OptimizelyServerSide::DatafileFetcher.datafile, symbolize_names: true)
+          JSON.parse(OptimizelyServerSide::DatafileFetcher.datafile.content, symbolize_names: true)
         end
       ).to eq(
         {

data/spec/optimizely_server_side/datafile_fetcher_spec.rb

@@ -4,18 +4,39 @@ RSpec.describe OptimizelyServerSide::DatafileFetcher do
 
   describe '#fetch' do
 
-    before do
-      stub_request(:get, "https://cdn.optimizely.com/json/5960232316.json")
-      .to_return(body: '{"experiments": [{"status": "running"}]}',status: 200)
-    end
+    context 'when 200 response' do
+      before do
+        stub_request(:get, "https://cdn.optimizely.com/json/5960232316.json")
+        .to_return(body: '{"experiments": [{"status": "running"}]}',status: 200)
+      end
+
+      it 'should fetch the config' do
+        expect(described_class.fetch.content).to eq('{"experiments": [{"status": "running"}]}')
+      end
+
+
+      it 'should return stringified datafile' do
+        expect(described_class.datafile.content).to eq('{"experiments": [{"status": "running"}]}')
+      end
 
-    it 'should fetch the config' do
-      expect(described_class.fetch).to eq('{"experiments": [{"status": "running"}]}')
     end
 
 
-    it 'should return stringified datafile' do
-      expect(described_class.datafile).to eq('{"experiments": [{"status": "running"}]}')
+    context 'when 500 response' do
+      before do
+        stub_request(:get, "https://cdn.optimizely.com/json/5960232316.json")
+        .to_return(body: '{"experiments": [{"status": "running"}]}',status: 500)
+      end
+
+      it 'should fetch the config' do
+        expect(described_class.fetch.content).to eq('{"experiments": [],"version": "1","audiences": [],"dimensions": [],"groups": [],"projectId": "5960232316","accountId": "5955320306","events": [],"revision": "30"}')
+      end
+
+
+      it 'should return stringified datafile' do
+        expect(described_class.datafile.content).to eq('{"experiments": [],"version": "1","audiences": [],"dimensions": [],"groups": [],"projectId": "5960232316","accountId": "5955320306","events": [],"revision": "30"}')
+      end
+
     end
 
   end

data/spec/optimizely_server_side/experiment_spec.rb

@@ -0,0 +1,138 @@
+require 'spec_helper'
+
+RSpec.describe OptimizelyServerSide::Experiment do
+
+  subject { OptimizelyServerSide::Experiment.new(variation_key = 'variation_key_a') }
+
+
+  describe '#compute' do
+
+    before do
+
+      subject.variation_one('variation_key_a') do
+        'experience a'
+      end
+
+      subject.variation_two('variation_key_b') do
+        'experience b'
+      end
+
+    end
+
+    context 'when variation_key is present' do
+
+      it 'should result variation b' do
+        expect(subject.compute).to eq('experience a')
+      end
+
+    end
+
+
+    context 'when variation_key is not present' do
+      subject { OptimizelyServerSide::Experiment.new(variation_key = '') }
+
+      it 'should be nil' do
+        expect(subject.compute).to be_nil
+      end
+    end
+
+
+  end
+
+  describe '#variation_one' do
+
+    let(:blk) { Proc.new { 'Hello!'} }
+
+    it 'returns a block passed' do
+      expect(subject.variation_one('foo', &blk)).to eq(blk)
+    end
+  end
+
+
+  describe '#variation_two' do
+
+    let(:blk) { -> {OpenStruct.new } }
+
+    it 'returns a block passed' do
+      expect(subject.variation_two('foo', &blk)).to eq(blk)
+    end
+  end
+
+  describe '#variation_three' do
+
+    let(:blk) { Proc.new { 'Hello!'} }
+
+    it 'returns a block passed' do
+      expect(subject.variation_three('foo', &blk)).to eq(blk)
+    end
+  end
+
+  describe '#store' do
+
+    context 'key accepts regular strings' do
+
+      let(:string_lambda) { -> {'I am a variation' } }
+
+      before do
+        subject.variation_one('foo', &string_lambda)
+      end
+
+      it 'has value as string' do
+        expect(subject.instance_variable_get(:@store)).to eq({'foo' => string_lambda})
+      end
+
+    end
+
+
+    context 'key accepts blocks / proc' do
+
+      let(:some_method) { Proc.new {|n| n*2 } }
+
+      before do
+        subject.variation_one('foo', &some_method)
+      end
+
+      it 'has value as proc' do
+        expect(subject.instance_variable_get(:@store)).to eq({'foo' => some_method})
+      end
+
+    end
+
+    context 'key accepts string, html or blocks / proc' do
+
+      let(:some_method) { Proc.new {|n| n*2 } }
+
+      let(:some_html_block) do
+        -> {'<!DOCTYPE html>
+            <html>
+            <head>
+            <title>Page Title</title>
+            </head>
+            <body>
+
+            <h1>This is a Heading</h1>
+            <p>This is a paragraph.</p>
+
+            </body>
+            </html>
+          '
+            }
+      end
+
+      let(:string_blk) { -> { 'Hello!'} }
+
+      before do
+        subject.variation_one('foo', &some_method)
+
+        subject.variation_two('foo_two', &some_html_block)
+
+        subject.variation_three('foo_three', &string_blk)
+      end
+
+      it 'has value as proc' do
+        expect(subject.instance_variable_get(:@store)).to eq({'foo' => some_method, 'foo_two' => some_html_block, 'foo_three' => string_blk})
+      end
+
+    end
+  end
+end

data/spec/optimizely_server_side/helpers/support_spec.rb

@@ -2,6 +2,12 @@ require 'spec_helper'
 
 RSpec.describe OptimizelyServerSide::Support do
 
+  class MyEventDispatcher
+
+    def dispatch_event(url,params)
+      puts "Do nothing with #{url} and #{params}"
+    end
+  end
   class FakeKlass
 
     include OptimizelyServerSide::Support
@@ -24,14 +30,44 @@ RSpec.describe OptimizelyServerSide::Support do
   end
 
 
-  context '#experiment' do
+  describe '#experiment' do
 
     subject { FakeKlass.new }
 
-    before do
-      allow(subject).to receive(:optimizely_sdk_project_instance).and_return('variation_one')
+    context 'everything is good' do
+
+
+      before do
+        allow(subject).to receive(:optimizely_sdk_project_instance).and_return('variation_one')
+      end
+
+      it { expect(subject.some_klass_method).to eq('Experience one')}
     end
 
-    it { expect(subject.some_klass_method).to eq('Experience one')}
+
+    context 'when a fatal error has happened' do
+
+      let(:response) do
+        '{
+            "experiments": [],
+            "version": "1",
+            "audiences": [],
+            "dimensions": [],
+            "groups": [],
+            "projectId": "5960232316",
+            "accountId": "5955320306",
+            "events": [],
+            "revision": "30"
+          }'
+      end
+
+      before do
+        stub_request(:get, "https://cdn.optimizely.com/json/5960232316.json")
+        .to_return(body: response, status: 500)
+      end
+
+
+      it { expect(subject.some_klass_method).to be_nil }
+    end
   end
 end

data/spec/optimizely_server_side_spec.rb

@@ -55,21 +55,3 @@ RSpec.describe OptimizelyServerSide do
 
   end
 end
-
-def foo
-  experiment(EXPERIMENT_KEY) do |config|
-
-    config.variation_one(VARIATION_ONE_KEY) do
-      # Code for experience one. it can be html or a ruby code
-    end
-
-    config.variation_two(VARIATION_TWO_KEY) do
-      # Code for experience two. it can be html or a ruby code
-    end
-
-    config.variation_default(variation_default_KEY) do
-      # Code for experience default. it can be html or a ruby code
-    end
-
-  end
-end

data/spec/spec_helper.rb

@@ -1,9 +1,12 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 require 'bundler/setup'
 require 'webmock/rspec'
 Bundler.setup
 
 require 'optimizely_server_side'
-
+WebMock.disable_net_connect!(allow: 'codeclimate.com')
 RSpec.configure do |config|
   # some (optional) config here
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optimizely_server_side
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ankit Gupta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-10 00:00:00.000000000 Z
+date: 2016-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -72,8 +72,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.6
-description: 'Optimizely server side. A wrapper on top of optimizely''s ruby sdk for
-  easy caching of server side config and exposing few more utility helpers '
+description: 'Optimizely server side. A AB test wrapper on top of optimizely''s ruby
+  sdk for easy caching of server side config and exposing few more utility helpers.  Handling
+  of fallbacks and marking primary experiments. '
 email: ankit.gupta8898@gmail.com
 executables: []
 extensions: []
@@ -85,21 +86,23 @@ files:
 - Gemfile
 - Gemfile.lock
 - Readme.md
+- blocky.rb
+- docs/general_architecture.png
 - docs/screenshot.png
 - lib/optimizely_server_side.rb
 - lib/optimizely_server_side/cache.rb
 - lib/optimizely_server_side/configuration.rb
 - lib/optimizely_server_side/datafile_fetcher.rb
+- lib/optimizely_server_side/experiment.rb
 - lib/optimizely_server_side/helpers/support.rb
 - lib/optimizely_server_side/optimizely_sdk.rb
-- lib/optimizely_server_side/variation.rb
 - optimizely_server_side.gemspec
 - spec/optimizely_server_side/cache_spec.rb
 - spec/optimizely_server_side/configuration_spec.rb
 - spec/optimizely_server_side/datafile_fetcher_spec.rb
+- spec/optimizely_server_side/experiment_spec.rb
 - spec/optimizely_server_side/helpers/support_spec.rb
 - spec/optimizely_server_side/optimizely_sdk_spec.rb
-- spec/optimizely_server_side/variation_spec.rb
 - spec/optimizely_server_side_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/ankit8898/optimizely_server_side
@@ -131,8 +134,8 @@ test_files:
 - spec/optimizely_server_side/cache_spec.rb
 - spec/optimizely_server_side/configuration_spec.rb
 - spec/optimizely_server_side/datafile_fetcher_spec.rb
+- spec/optimizely_server_side/experiment_spec.rb
 - spec/optimizely_server_side/helpers/support_spec.rb
 - spec/optimizely_server_side/optimizely_sdk_spec.rb
-- spec/optimizely_server_side/variation_spec.rb
 - spec/optimizely_server_side_spec.rb
 - spec/spec_helper.rb

data/lib/optimizely_server_side/variation.rb

@@ -1,38 +0,0 @@
-module OptimizelyServerSide
-
-  class Variation
-
-    attr_reader :hsh
-
-    def initialize(variation_key)
-      @variation_key = variation_key
-      @hsh = {}
-    end
-
-    # Variation one of experiment
-    def variation_one(key)
-      @hsh[key] = yield
-    end
-
-    # Variation two of experiment
-    def variation_two(key)
-      @hsh[key] = yield
-    end
-
-    def variation_default(key)
-      @hsh[key] = yield
-    end
-
-    # Variation three of experiment
-    def variation_three(key)
-      @hsh[key] = yield
-    end
-
-    # Select which variation to be picked up
-    def compute
-      @hsh.select do |key,value|
-        key == @variation_key
-      end.values[0]
-    end
-  end
-end

data/spec/optimizely_server_side/variation_spec.rb

@@ -1,137 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe OptimizelyServerSide::Variation do
-
-  subject { OptimizelyServerSide::Variation.new(variation_key = 'variation_key_a') }
-
-
-  describe '#compute' do
-
-
-    before do
-
-      subject.variation_one('variation_key_a') do
-        'experience a'
-      end
-
-      subject.variation_two('variation_key_b') do
-        'experience b'
-      end
-
-    end
-
-    it 'should result variation b' do
-      expect(subject.compute).to eq('experience a')
-    end
-  end
-
-
-  ['variation_one','variation_two','variation_three','variation_default'].each do |variation|
-
-    describe "#{variation}" do
-
-      context 'it accepts regular strings' do
-
-        it do
-          expect(subject.send(variation,'foo') do
-                   'Hello!'
-          end).to eq('Hello!')
-        end
-
-      end
-
-
-      context 'it accepts a block' do
-
-        let(:some_block) do
-          -> { 'something'}
-        end
-
-        it do
-          expect(subject.send(variation,'foo') do
-                   some_block
-          end).to eq(some_block)
-        end
-
-      end
-
-    end
-
-
-    describe '#hsh' do
-
-      context 'key accepts regular strings' do
-
-        let(:string) { 'I am a variation' }
-
-        before do
-          subject.variation_one('foo') do
-            string
-          end
-        end
-
-        it 'has value as string' do
-          expect(subject.hsh).to eq({'foo' => string})
-        end
-
-      end
-
-
-      context 'key accepts blocks / proc' do
-
-        let(:proc) { Proc.new {|n| n*2 } }
-
-        before do
-          subject.variation_one('foo') do
-            proc
-          end
-        end
-
-        it 'has value as proc' do
-          expect(subject.hsh).to eq({'foo' => proc})
-        end
-
-      end
-
-      context 'key accepts string, html or blocks / proc' do
-
-        let(:proc) { Proc.new {|n| n*2 } }
-        let(:html) do
-          '<!DOCTYPE html>
-      <html>
-      <head>
-      <title>Page Title</title>
-      </head>
-      <body>
-
-      <h1>This is a Heading</h1>
-      <p>This is a paragraph.</p>
-
-      </body>
-      </html>
-      '
-        end
-        let(:string) { 'Hello!'}
-
-        before do
-          subject.variation_one('foo') do
-            proc
-          end
-
-          subject.variation_two('foo_two') do
-            html
-          end
-
-          subject.variation_three('foo_three') do
-            string
-          end
-        end
-
-        it 'has value as proc' do
-          expect(subject.hsh).to eq({'foo' => proc, 'foo_two' => html, 'foo_three' => string})
-        end
-
-      end
-    end
-  end
-end