optify-config 1.4.0-x86_64-linux → 1.4.1-x86_64-linux

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34d4942fdd16516b838755a6588d185813b39895287972000ea72919249c8349
-  data.tar.gz: aa1a4f179fe266262a52d60b5805d825b377b512bfd74d9f0647601bcff1049b
+  metadata.gz: 4e8f2ea00313d025e288dafa0a021ddcb0953d41c89261828e84a7f8952a229e
+  data.tar.gz: 8fc98d221e05d2ce9ed08a0bfc8de716cc19301a7d09d627e87283eb53f5c015
 SHA512:
-  metadata.gz: 01ee18fceeaff83882ceb2d14eb77da5e2804355cd47c4c138789806cc34e707472d03ff5c594b29d063f0509f3ed4fdab684b270be30733f7d9e1691917e777
-  data.tar.gz: d5546a15c032e7149646aedbc52449c73858e253c6c7d754b1df96ea2489ea18fb4253ba1e4880c3fb0da5dc5fc7b2080ccd14df42a8a0d61119491089ab8656
+  metadata.gz: 0fc8dada15e7f8efef6e78063cf1a02c8539180efa594c0d79ffd1105e0c964910c3ab25158be542b761f1cf363ebf209b967da59926d81d8c44766f89227431
+  data.tar.gz: 2ffbcc06e1158d8b6584f1bd850c3af16a0cfe0f0ec34c804ede6d31cf11651f72560bc207f2188063aa6d309364a44cdea9265b069f6d1d9a5d33fd277816f0

data/lib/optify_ruby/provider_module.rb

@@ -11,7 +11,7 @@ module Optify
     #: (Array[String] feature_names) -> Array[String]
     def get_canonical_feature_names(feature_names)
       # Try to optimize a typical case where there are just a few features.
-      # Ideally in production, a single feature that imports many other features is used for the most common scenario.
+      # Ideally in production, a single feature that imports many other features is used for the most common scenarios.
       # Benchmarks show that it is faster to use a loop than to call the Rust implementation which involves making a `Vec<String>` and returning a `Vec<String>`.
       if feature_names.length < 4
         feature_names.map { |feature_name| get_canonical_feature_name(feature_name) }
@@ -93,19 +93,25 @@ module Optify
       end
 
       init unless @cache
-      unless preferences&.skip_feature_name_conversion
-        # When there are just a few names, then it can be faster to convert them one by one in a loop to avoid working with an array in Rust.
-        # When there are over 7 names, then it is faster to convert them with one call to Rust.
-        feature_names = get_canonical_feature_names(feature_names)
-      end
+      feature_names = get_canonical_feature_names(feature_names) unless preferences&.skip_feature_name_conversion
 
       cache_key = [key, feature_names, config_class]
       result = @cache&.fetch(cache_key, NOT_FOUND_IN_CACHE_SENTINEL)
       return result unless result.equal?(NOT_FOUND_IN_CACHE_SENTINEL)
 
-      # TODO: Copy the preferences to avoid mutating the original object.
-      preferences ||= GetOptionsPreferences.new
-      preferences.skip_feature_name_conversion = true
+      # Handle a cache miss.
+
+      # We can avoid converting the features names because they're already converted, if that was desired.
+      if preferences.nil?
+        preferences = GetOptionsPreferences.new
+        preferences.skip_feature_name_conversion = true
+      else
+        # Indeed the copying of preferences could be wasteful, but this only happens on a cache miss
+        # and when no custom preferences are provided.
+        preferences = preferences.dup
+        preferences.skip_feature_name_conversion = true
+      end
+
       result = get_options(key, feature_names, config_class, nil, preferences)
 
       T.must(@cache)[cache_key] = result

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: optify-config
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: x86_64-linux
 authors:
 - Justin D. Harris
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-05-09 00:00:00.000000000 Z
+date: 2025-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
 - !ruby/object:Gem::Dependency
   name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.9
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.9
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: rbs
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.9.2
+        version: 3.9.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.9.2
+        version: 3.9.3
 - !ruby/object:Gem::Dependency
   name: sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.11911
+        version: 0.5.12083
 - !ruby/object:Gem::Dependency
   name: tapioca
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 3.6.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 3.6.8
 description: |-
   Simplifies getting the right configuration options for a process using pre-loaded configurations
     from files to manage options for experiments or flights.