opinionated_http 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0b33ff41de4de2487017dcb16c8af1bd049d8f59b99af148c2782f5aadbf90f
-  data.tar.gz: fbb4ddce12a6aabb67827d124fd579e91d4a2b4def78d74c893dc82687519c96
+  metadata.gz: 70883413762ba2277b74061e20f9fd5faa73fccee8a762595a40793a93ed2689
+  data.tar.gz: 45bf3291006a3577a29f5fd603ad27c34b1d6948c54e67f71efb20862c0af613
 SHA512:
-  metadata.gz: a3b31d0083666203057f05a38bdc0e7a5519af9757df935c9c772ca514bb7f8777c9b52a24edb960b201e5816bca356508d9470bfcd42fdcf83ee3bd622ec51b
-  data.tar.gz: b6b9ba368403e795fc19b81a759e30cd03de38fd436c52222db7f7e73f79d4ad38fb1054c7ad6a23a2cddf5c6f55654127e334c76b0f5fd5f0ab3deab606163d
+  metadata.gz: eec7f0a191186d29a970284e04dc571a2c8329587a414fa41576852e59d08503928594e14fc8e65f9ebea1570f90e15ad5e878a7b26259eae4adc605e7e9063f
+  data.tar.gz: ac1ce6b6f65d720cf7ddac4d93621c608f609ad1e113ead056e710e0cfe37df70792459940cdd3ca9effe0d8a123e60df11e89cf2a713ab7855c1148ea29e86d

data/lib/opinionated_http/client.rb

@@ -39,9 +39,10 @@ module OpinionatedHTTP
       force_retry: true,
       max_redirects: 10,
       after_connect: nil,
-      verify_peer: false,  # TODO: PersistentHTTP keeps returning cert expired even when it is valid.
+      verify_peer: false, # TODO: PersistentHTTP keeps returning cert expired even when it is valid.
       certificate: nil,
-      private_key: nil
+      private_key: nil,
+      header: nil
     )
       @metric_prefix = metric_prefix
       @logger        = logger || SemanticLogger[self]
@@ -90,7 +91,8 @@ module OpinionatedHTTP
         after_connect: @after_connect,
         certificate:   @certificate,
         private_key:   @private_key,
-        verify_mode:   @verify_peer ? OpenSSL::SSL::VERIFY_PEER | OpenSSL::SSL::VERIFY_FAIL_IF_NO_PEER_CERT : OpenSSL::SSL::VERIFY_NONE
+        verify_mode:   @verify_peer ? OpenSSL::SSL::VERIFY_PEER | OpenSSL::SSL::VERIFY_FAIL_IF_NO_PEER_CERT : OpenSSL::SSL::VERIFY_NONE,
+        header:        header
       )
     end
 
@@ -101,13 +103,35 @@ module OpinionatedHTTP
       Response.new(http_response, request)
     end
 
-    def post(request: nil, **args)
+    def post(request: nil, json: nil, body: nil, **args)
+      raise(ArgumentError, "Either set :json or :body") if json && body
+
       request       ||= Request.new(**args)
+      if json
+        request.format = :json
+        request.body   = json
+      else
+        request.body = body
+      end
       request.verb  = "Post"
       http_response = request(request)
       Response.new(http_response, request)
     end
 
+    def delete(request: nil, **args)
+      request       ||= Request.new(**args)
+      request.verb  = "Delete"
+      http_response = request(request)
+      Response.new(http_response, request)
+    end
+
+    def patch(request: nil, **args)
+      request       ||= Request.new(**args)
+      request.verb  = "Patch"
+      http_response = request(request)
+      Response.new(http_response, request)
+    end
+
     # Returns [Response] after submitting the [Request]
     def request(request)
       request.metric_prefix ||= metric_prefix

data/lib/opinionated_http/request.rb

@@ -56,7 +56,7 @@ module OpinionatedHTTP
       case format
       when :json
         headers["Content-Type"] = "application/json"
-        body.to_json #unless body.is_a?(String) || body.nil?
+        body.to_json unless body.is_a?(String) || body.nil?
       when nil
         body
       else

data/lib/opinionated_http/response.rb

@@ -26,7 +26,7 @@ module OpinionatedHTTP
       return body if success?
 
       error_message = "HTTP #{verb.upcase}: #{action} Failure: (#{code}) #{message}"
-      logger.error(message: error_message, metric: "#{metric_prefix}/exception")
+      logger.error(message: error_message, metric: "#{metric_prefix}/exception", payload: {body: body})
       raise(error_class, error_message)
     end
 

data/lib/opinionated_http/version.rb

@@ -1,3 +1,3 @@
 module OpinionatedHTTP
-  VERSION = "0.1.0".freeze
+  VERSION = "0.1.1".freeze
 end

data/test/client_test.rb

@@ -12,8 +12,7 @@ class ClientTest < Minitest::Test
         secret_config_prefix: "fake_service",
         metric_prefix:        "FakeService",
         logger:               SemanticLogger["FakeService"],
-        error_class:          ServiceError,
-        header:               {"Content-Type" => "application/json"}
+        error_class:          ServiceError
       )
     end
 
@@ -58,6 +57,15 @@ class ClientTest < Minitest::Test
         end
       end
 
+      it "with JSON data" do
+        request = {zip: "12345", population: 54_321}
+        body   = request.to_json
+        stub_request(Net::HTTPSuccess, 200, "OK", body) do
+          response = http.post(action: "lookup", json: request)
+          assert_equal request, response.body!.transform_keys!(&:to_sym)
+        end
+      end
+
       it "fails with body" do
         message = "HTTP POST: lookup Failure: (403) Forbidden"
         output  = {zip: "12345", population: 54_321}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opinionated_http
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Reid Morrison
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-11 00:00:00.000000000 Z
+date: 2022-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: persistent_http