opinionated-xml 0.0.1 → 0.1.0

data/spec/unit/container_spec.rb

@@ -0,0 +1,60 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require "nokogiri"
+require "om"
+
+describe "OM::XML::Container" do
+  
+  before(:all) do
+    class ContainerTest
+      include OM::XML::Container
+    end
+  end
+  
+  before(:each) do
+    @container = ContainerTest.from_xml("<foo><bar>1</bar></foo>")
+  end
+  
+  it "should automatically include the other modules" do
+    pending
+    ContainerTest.included_modules.should include(OM::XML::Accessor)
+    ContainerTest.included_modules.should include(OM::XML::Schema)
+  end
+  
+  it "should add .ng_xml accessor" do
+    @container.should respond_to(:ng_xml)
+    @container.should respond_to(:ng_xml=)    
+  end
+  
+  describe "new" do
+    it "should populate ng_xml with an instance of Nokogiri::XML::Document" do
+      @container.ng_xml.class.should == Nokogiri::XML::Document
+    end
+  end
+  
+  describe "#from_xml" do
+    it "should accept a String, parse it and store it in .ng_xml" do
+      Nokogiri::XML::Document.expects(:parse).returns("parsed xml")
+      container1 = ContainerTest.from_xml("<foo><bar>1</bar></foo>")
+      container1.ng_xml.should == "parsed xml"
+    end
+    it "should accept a File, parse it and store it in .ng_xml" do
+      file = fixture(File.join("mods_articles", "hydrangea_article1.xml"))
+      Nokogiri::XML::Document.expects(:parse).returns("parsed xml")
+      container1 = ContainerTest.from_xml(file)
+      container1.ng_xml.should == "parsed xml"
+    end
+    it "should accept Nokogiri nodes as input and leave them as-is" do
+      parsed_xml = Nokogiri::XML::Document.parse("<foo><bar>1</bar></foo>")
+      container1 = ContainerTest.from_xml(parsed_xml)
+      container1.ng_xml.should == parsed_xml
+    end
+  end
+  
+  describe ".to_xml" do
+    it  "should call .ng_xml.to_xml" do
+      @container.ng_xml.expects(:to_xml).returns("ng xml")
+      @container.to_xml.should == "ng xml"
+    end
+  end
+  
+end

data/spec/unit/{opinionated-xml_spec.rb → properties_spec.rb}

@@ -1,12 +1,14 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require "om"
 
-describe "OpinionatedXml" do
+describe "OM::XML::Properties" do
   
   before(:all) do
     #ModsHelpers.name_("Beethoven, Ludwig van", :date=>"1770-1827", :role=>"creator")
-    class FakeOxMods < Nokogiri::XML::Document
-      
-      include OX      
+    class FakeOxMods 
+
+      include OM::XML::Container            
+      include OM::XML::Properties      
       
       # Could add support for multiple root declarations.  
       #  For now, assume that any modsCollections have already been broken up and fed in as individual mods documents
@@ -40,8 +42,8 @@ describe "OpinionatedXml" do
     
     class FakeOtherOx < Nokogiri::XML::Document
       
-      include OX
-      extend OX::ClassMethods
+      include OM::XML::Properties
+      # extend OX::ClassMethods
       
       root_property :other, "other", "http://www.foo.com"        
       
@@ -50,7 +52,7 @@ describe "OpinionatedXml" do
   end
   
   before(:each) do
-    @fixturemods = FakeOxMods.parse( fixture( File.join("CBF_MODS", "ARS0025_016.xml") ) )
+    @fixturemods = FakeOxMods.from_xml( fixture( File.join("CBF_MODS", "ARS0025_016.xml") ) )
   end
   
   after(:all) do
@@ -68,7 +70,6 @@ describe "OpinionatedXml" do
       FakeOxMods.root_property_ref.should == :mods
       FakeOxMods.root_config.should == {:ref=>:mods, :path=>"mods", :namespace=>"http://www.loc.gov/mods/v3", :attributes=>["id", "version"], :schema=>"http://www.loc.gov/standards/mods/v3/mods-3-2.xsd"}
       FakeOxMods.ox_namespaces.should == {"oxns"=>"http://www.loc.gov/mods/v3"}
-      FakeOxMods.schema_url.should == "http://www.loc.gov/standards/mods/v3/mods-3-2.xsd"
       
       FakeOtherOx.root_property_ref.should == :other
       FakeOtherOx.root_config.should == {:namespace=>"http://www.foo.com", :path=>"other", :ref=>:other}
@@ -135,16 +136,16 @@ describe "OpinionatedXml" do
   describe ".lookup"  do
     
     it "uses the generated xpath queries" do
-      @fixturemods.expects(:xpath).with('//oxns:name[@type="personal"]', @fixturemods.ox_namespaces)
+      @fixturemods.ng_xml.expects(:xpath).with('//oxns:name[@type="personal"]', @fixturemods.ox_namespaces)
       @fixturemods.lookup(:person)
       
-      @fixturemods.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:namePart, "Beethoven, Ludwig van")]', @fixturemods.ox_namespaces)
+      @fixturemods.ng_xml.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:namePart, "Beethoven, Ludwig van")]', @fixturemods.ox_namespaces)
       @fixturemods.lookup(:person, "Beethoven, Ludwig van")
       
-      @fixturemods.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:namePart[@type="date"], "2010")]', @fixturemods.ox_namespaces)
+      @fixturemods.ng_xml.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:namePart[@type="date"], "2010")]', @fixturemods.ox_namespaces)
       @fixturemods.lookup(:person, :date=>"2010")
       
-      @fixturemods.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:role/oxns:roleTerm, "donor")]', @fixturemods.ox_namespaces)
+      @fixturemods.ng_xml.expects(:xpath).with('//oxns:name[@type="personal" and contains(oxns:role/oxns:roleTerm, "donor")]', @fixturemods.ox_namespaces)
       @fixturemods.lookup(:person, :role=>"donor")
       
       # @fixturemods.expects(:xpath).with('//oxns:name[@type="personal"]/oxns:namePart[@type="date"]', @fixturemods.ox_namespaces)
@@ -242,59 +243,5 @@ describe "OpinionatedXml" do
       FakeOxMods.send(:applicable_attributes, ["authority", {:type=>["text","code"]}] ).should == {:type=>"text"} 
     end
   end
-  
-  ## Validation Support 
-  # Some of these tests fail when you don't have an internet connection because the mods schema includes other xsd schemas by URL reference.
-  
-  describe "#schema" do
-    it "should return an instance of Nokogiri::XML::Schema loaded from the schema url -- fails if no internet connection" do
-      FakeOxMods.schema.should be_kind_of Nokogiri::XML::Schema
-    end
-  end
-  
-  describe "#validate" do
-    it "should validate the provided document against the schema provided in class definition  -- fails if no internet connection" do
-      FakeOxMods.schema.expects(:validate).with(@fixturemods).returns([])
-      FakeOxMods.validate(@fixturemods)
-    end
-  end
-  
-  describe ".validate" do
-    it "should rely on class validate method" do
-      FakeOxMods.expects(:validate).with(@fixturemods)
-      @fixturemods.validate
-    end
-  end
-  
-  describe "#schema_file" do
-    before(:all) do
-      FakeOxMods.schema_file = nil
-    end
-    
-    after(:all) do
-      FakeOxMods.schema_file = fixture("mods-3-2.xsd")
-    end
-    
-    it "should lazy load the schema file from the @schema_url" do
-      FakeOxMods.instance_variable_get(:@schema_file).should be_nil
-      FakeOxMods.expects(:file_from_url).with(FakeOxMods.schema_url).returns("fake file").once
-      FakeOxMods.schema_file
-      FakeOxMods.instance_variable_get(:@schema_file).should == "fake file"
-      FakeOxMods.schema_file.should == "fake file"
-    end
-  end
-  
-  describe "#file_from_url" do
-    it "should retrieve a file from the provided url over HTTP" do
-      FakeOxMods.send(:file_from_url, "http://google.com")
-    end
-    it "should raise an error if the url is invalid" do
-      lambda {FakeOxMods.send(:file_from_url, "")}.should raise_error(RuntimeError, "Could not retrieve file from . Error: No such file or directory - ")
-      lambda {FakeOxMods.send(:file_from_url, "foo")}.should raise_error(RuntimeError, "Could not retrieve file from foo. Error: No such file or directory - foo")
-    end
-    it "should raise an error if file retrieval fails" do
-      lambda {FakeOxMods.send(:file_from_url, "http://fedora-commons.org/nonexistent_file")}.should raise_error(RuntimeError, "Could not retrieve file from http://fedora-commons.org/nonexistent_file. Error: 404 Not Found")  
-    end
-  end
    
 end

data/spec/unit/property_value_operators_spec.rb

@@ -0,0 +1,245 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require "om"
+
+describe "OM::XML::PropertyValueOperators" do
+  
+  before(:all) do
+    #ModsHelpers.name_("Beethoven, Ludwig van", :date=>"1770-1827", :role=>"creator")
+    class PropertiesValueOperatorsTest 
+      
+      include OM::XML::Container     
+      include OM::XML::Properties
+      include OM::XML::PropertyValueOperators      
+      
+      # Could add support for multiple root declarations.  
+      #  For now, assume that any modsCollections have already been broken up and fed in as individual mods documents
+      # root :mods_collection, :path=>"modsCollection", 
+      #           :attributes=>[],
+      #           :subelements => :mods
+                     
+      root_property :mods, "mods", "http://www.loc.gov/mods/v3", :attributes=>["id", "version"], :schema=>"http://www.loc.gov/standards/mods/v3/mods-3-2.xsd"          
+                
+                
+      property :name_, :path=>"name", 
+                  :attributes=>[:xlink, :lang, "xml:lang", :script, :transliteration, {:type=>["personal", "enumerated", "corporate"]} ],
+                  :subelements=>["namePart", "displayForm", "affiliation", :role, "description"],
+                  :default_content_path => "namePart",
+                  :convenience_methods => {
+                    :date => {:path=>"namePart", :attributes=>{:type=>"date"}},
+                    :family_name => {:path=>"namePart", :attributes=>{:type=>"family"}},
+                    :given_name => {:path=>"namePart", :attributes=>{:type=>"given"}},
+                    :terms_of_address => {:path=>"namePart", :attributes=>{:type=>"termsOfAddress"}}
+                  }
+                  
+      property :person, :variant_of=>:name_, :attributes=>{:type=>"personal"}
+      
+      property :role, :path=>"role",
+                  :parents=>[:name_],
+                  :attributes=>[ { "type"=>["text", "code"] } , "authority"],
+                  :default_content_path => "roleTerm"
+                  
+                  
+    end
+        
+  end
+  
+  before(:each) do
+    @sample = PropertiesValueOperatorsTest.from_xml( fixture( File.join("test_dummy_mods.xml") ) )
+  end
+  
+  after(:all) do
+    Object.send(:remove_const, :PropertiesValueOperatorsTest)
+  end
+  
+  describe ".property_values" do
+
+    it "should call .lookup and then build an array of values from the returned nodeset (using default_node, etc as nessesary)" do
+      lookup_opts = "insert args here"
+      mock_node = mock("node")
+      mock_node.expects(:text).returns("sample value").times(3)
+      mock_nodeset = [mock_node, mock_node, mock_node]
+      @sample.expects(:lookup).with(lookup_opts).returns(mock_nodeset)
+      
+      @sample.property_values(lookup_opts).should == ["sample value","sample value","sample value"]
+    end
+  
+  end
+  
+  describe ".property_values_append" do
+	
+  	it "looks up the parent using :parent_select, uses :child_index to choose the parent node from the result set, uses :template to build the node(s) to be inserted, inserts the :values(s) into the node(s) and adds the node(s) to the parent" do      
+	    @sample.property_values_append(
+        :parent_select => [:person, {:given_name=>"Tim", :family_name=>"Berners-Lee"}] ,
+        :child_index => :first,
+        :template => [:person, :affiliation],
+        :values => ["my new value", "another new value"] 
+      )
+    end
+    
+    it "should accept parent_select and template [property_reference, lookup_opts] as argument arrays for generators/lookups" do
+      # this appends two affiliation nodes into the first person node whose name is Tim Berners-Lee
+      expected_result = '<ns3:name type="personal">
+      <ns3:namePart type="family">Berners-Lee</ns3:namePart>
+      <ns3:namePart type="given">Tim</ns3:namePart>
+      <ns3:role>
+          <ns3:roleTerm type="text" authority="marcrelator">creator</ns3:roleTerm>
+          <ns3:roleTerm type="code" authority="marcrelator">cre</ns3:roleTerm>
+      </ns3:role>
+  <ns3:affiliation>my new value</ns3:affiliation><ns3:affiliation>another new value</ns3:affiliation></ns3:name>'
+      
+	    @sample.property_values_append(
+        :parent_select => [:person, {:given_name=>"Tim", :family_name=>"Berners-Lee"}] ,
+        :child_index => :first,
+        :template => [:person, :affiliation],
+        :values => ["my new value", "another new value"] 
+      ).to_xml.should == expected_result
+      
+      @sample.lookup(:person, {:given_name=>"Tim", :family_name=>"Berners-Lee"}).first.to_xml.should == expected_result
+    end
+    
+    it "should accept symbols as arguments for generators/lookups" do
+      # this appends a role of "my role" into the third "person" node in the document
+      expected_result = "<ns3:name type=\"personal\">\n      <ns3:namePart type=\"family\">Klimt</ns3:namePart>\n      <ns3:namePart type=\"given\">Gustav</ns3:namePart>\n      <ns3:role>\n          <ns3:roleTerm type=\"text\" authority=\"marcrelator\">creator</ns3:roleTerm>\n          <ns3:roleTerm type=\"code\" authority=\"marcrelator\">cre</ns3:roleTerm>\n      </ns3:role>\n      <ns3:role>\n          <ns3:roleTerm type=\"text\" authority=\"marcrelator\">visionary</ns3:roleTerm>\n          <ns3:roleTerm type=\"code\" authority=\"marcrelator\">vry</ns3:roleTerm>\n      </ns3:role>\n  <ns3:role type=\"text\"><ns3:roleTerm>my role</ns3:roleTerm></ns3:role></ns3:name>"
+      
+      @sample.property_values_append(
+        :parent_select => :person ,
+        :child_index => 3,
+        :template => :role,
+        :values => "my role" 
+      ).to_xml.should == expected_result
+
+      @sample.lookup(:person)[3].to_xml.should == expected_result
+    end
+    
+    it "should accept parent_select as an (xpath) string and template as a (template) string" do
+      # this uses the provided template to add a node into the first node resulting from the xpath '//oxns:name[@type="personal"]'
+      expected_result = "<ns3:name type=\"personal\">\n      <ns3:namePart type=\"family\">Berners-Lee</ns3:namePart>\n      <ns3:namePart type=\"given\">Tim</ns3:namePart>\n      <ns3:role>\n          <ns3:roleTerm type=\"text\" authority=\"marcrelator\">creator</ns3:roleTerm>\n          <ns3:roleTerm type=\"code\" authority=\"marcrelator\">cre</ns3:roleTerm>\n      </ns3:role>\n  <ns3:role type=\"code\" authority=\"marcrelator\"><ns3:roleTerm>creator</ns3:roleTerm></ns3:role></ns3:name>"
+      
+      @sample.ng_xml.xpath('//oxns:name[@type="personal" and position()=1]/oxns:role', @sample.ox_namespaces).length.should == 1
+      
+      @sample.property_values_append(
+        :parent_select =>'//oxns:name[@type="personal"]',
+        :child_index => 0,
+        :template => 'xml.role { xml.roleTerm( \'#{builder_new_value}\', :type=>\'code\', :authority=>\'marcrelator\') }',
+        :values => "founder" 
+      )
+
+      @sample.ng_xml.xpath('//oxns:name[@type="personal" and position()=1]/oxns:role', @sample.ox_namespaces).length.should == 2
+      @sample.ng_xml.xpath('//oxns:name[@type="personal" and position()=1]/oxns:role[last()]/oxns:roleTerm', @sample.ox_namespaces).first.text.should == "founder"
+
+      # @sample.lookup(:person).first.to_xml.should == expected_result
+    end
+	  
+	  it "should support more complex mixing & matching" do
+	    expected_result = "<ns3:name type=\"personal\">\n      <ns3:namePart type=\"family\">Jobs</ns3:namePart>\n      <ns3:namePart type=\"given\">Steve</ns3:namePart>\n      <ns3:namePart type=\"date\">2004</ns3:namePart>\n      <ns3:role>\n          <ns3:roleTerm type=\"text\" authority=\"marcrelator\">creator</ns3:roleTerm>\n          <ns3:roleTerm type=\"code\" authority=\"marcrelator\">cre</ns3:roleTerm>\n      </ns3:role>\n  <ns3:role type=\"code\" authority=\"marcrelator\"><ns3:roleTerm>foo</ns3:roleTerm></ns3:role></ns3:name>"
+
+      @sample.ng_xml.xpath('//oxns:name[@type="personal" and position()=2]/oxns:role', @sample.ox_namespaces).length.should == 1
+      
+	    @sample.property_values_append(
+        :parent_select =>'//oxns:name[@type="personal"]',
+        :child_index => 1,
+        :template => [ :person, :role, {:attributes=>{"type"=>"code", "authority"=>"marcrelator"}} ],
+        :values => "foo" 
+      )
+
+      @sample.ng_xml.xpath('//oxns:name[@type="personal" and position()=2]/oxns:role', @sample.ox_namespaces).length.should == 2
+      @sample.lookup(:person)[1].search("./oxns:role[last()]/oxns:roleTerm", @sample.ox_namespaces).first.text.should == "foo"
+	  end
+	  
+	  it "should raise exception if no node corresponds to the provided :parent_select and :child_index"
+  	
+  end
+  
+  describe ".property_value_update" do
+
+    it "should accept an xpath as :parent_select" do
+	    sample_xpath = '//oxns:name[@type="personal"]/oxns:role/oxns:roleTerm[@type="text"]'
+	    @sample.property_value_update(      
+        :parent_select =>sample_xpath,
+        :child_index => 1,
+        :value => "donor"
+      )
+      @sample.ng_xml.xpath(sample_xpath, @sample.ox_namespaces)[1].text.should == "donor"
+    end
+    
+    it "if :select is provided, should update the first node provided by that xpath statement" do
+      sample_xpath = '//oxns:name[@type="personal" and position()=1]/oxns:namePart[@type="given"]'
+      @sample.property_value_update(
+        :select =>sample_xpath,
+        :value => "Timmeh"
+      )
+      @sample.ng_xml.xpath(sample_xpath, @sample.ox_namespaces).first.text.should == "Timmeh"
+    end
+    
+    it "should replace the existing node if you pass a template and values" do
+      pending
+      @sample.property_value_update(
+        :parent_select =>'//oxns:name[@type="personal"]',
+        :child_index => 1,
+        :template => [ :person, :role, {:attributes=>{"type"=>"code", "authority"=>"marcrelator"}} ],
+        :value => "foo"
+      )
+      1.should == 2
+    end
+  end
+  
+  describe ".property_value_delete" do
+    it "should accept an xpath query as :select option" do
+      generic_xpath = '//oxns:name[@type="personal" and position()=4]/oxns:role'
+      specific_xpath = '//oxns:name[@type="personal" and position()=4]/oxns:role[oxns:roleTerm="visionary"]'
+      select_xpath = '//oxns:name[@type="personal" and position()=4]/oxns:role[last()]'
+      
+      # Check that we're starting with 2 roles
+      # Check that the specific node we want to delete exists
+      @sample.lookup(generic_xpath).length.should == 2
+      @sample.lookup(specific_xpath).length.should == 1
+
+      @sample.property_value_delete(
+        :select =>select_xpath
+      )
+      # Check that we're finishing with 1 role
+      @sample.lookup(generic_xpath).length.should == 1
+      # Check that the specific node we want to delete no longer exists
+      @sample.lookup(specific_xpath).length.should == 0
+    end 
+    it "should accept :parent_select, :parent_index and :child_index options instead of a :select" do
+            
+      generic_xpath = '//oxns:name[@type="personal" and position()=4]/oxns:role/oxns:roleTerm'
+      specific_xpath = '//oxns:name[@type="personal" and position()=4]/oxns:role[oxns:roleTerm="visionary"]'
+      
+      # Check that we're starting with 2 roles
+      # Check that the specific node we want to delete exists
+      @sample.lookup(generic_xpath).length.should == 4
+      @sample.lookup(specific_xpath).length.should == 1
+
+      # this is attempting to delete the last child (in this case roleTerm) from the 3rd role in the document. 
+      @sample.property_value_delete(
+        :parent_select => [:person, :role],
+        :parent_index => 3,
+        :child_index => :last
+      )
+      
+      # Check that we're finishing with 1 role
+      @sample.lookup(generic_xpath).length.should == 3
+      # Check that the specific node we want to delete no longer exists
+      @sample.lookup(specific_xpath).length.should == 1
+    end
+    it "should work if only :parent_select and :child_index are provided" do
+      generic_xpath = '//oxns:name[@type="personal"]/oxns:role'
+      # specific_xpath = '//oxns:name[@type="personal"]/oxns:role'
+      
+      # Check that we're starting with 2 roles
+      # Check that the specific node we want to delete exists
+      @sample.lookup(generic_xpath).length.should == 4
+      # @sample.lookup(specific_xpath).length.should == 1
+
+      @sample.property_value_delete(
+        :parent_select => [:person, :role],
+        :child_index => 3
+      )
+      # Check that we're finishing with 1 role
+      @sample.lookup(generic_xpath).length.should == 3
+    end
+  end
+  
+end

data/spec/unit/validation_spec.rb

@@ -0,0 +1,78 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require "nokogiri"
+require "om"
+
+describe "OM::XML::Validation" do
+  
+  before(:all) do
+    class ValidationTest
+      include OM::XML::Container
+      include OM::XML::Validation
+      self.schema_url = "http://www.loc.gov/standards/mods/v3/mods-3-2.xsd"
+    end
+  end
+  
+  before(:each) do
+    @sample = ValidationTest.from_xml("<foo><bar>1</bar></foo>")
+  end
+  
+  ## Validation Support 
+  # Some of these tests fail when you don't have an internet connection because the mods schema includes other xsd schemas by URL reference.
+
+  describe '#schema_url' do
+    it "should allow you to set the schema url" do
+      ValidationTest.schema_url.should == "http://www.loc.gov/standards/mods/v3/mods-3-2.xsd"
+    end
+  end
+  
+  describe "#schema" do
+    it "should return an instance of Nokogiri::XML::Schema loaded from the schema url -- fails if no internet connection" do
+      ValidationTest.schema.should be_kind_of Nokogiri::XML::Schema
+    end
+  end
+
+  describe "#validate" do
+    it "should validate the provided document against the schema provided in class definition  -- fails if no internet connection" do
+      ValidationTest.schema.expects(:validate).with(@sample).returns([])
+      ValidationTest.validate(@sample)
+    end
+  end
+
+  describe ".validate" do
+    it "should rely on class validate method" do
+      ValidationTest.expects(:validate).with(@sample)
+      @sample.validate
+    end
+  end
+
+  describe "#schema_file" do
+    before(:all) do
+      ValidationTest.schema_file = nil
+    end
+  
+    after(:all) do
+      ValidationTest.schema_file = fixture("mods-3-2.xsd")
+    end
+  
+    it "should lazy load the schema file from the @schema_url" do
+      ValidationTest.instance_variable_get(:@schema_file).should be_nil
+      ValidationTest.expects(:file_from_url).with(ValidationTest.schema_url).returns("fake file").once
+      ValidationTest.schema_file
+      ValidationTest.instance_variable_get(:@schema_file).should == "fake file"
+      ValidationTest.schema_file.should == "fake file"
+    end
+  end
+
+  describe "#file_from_url" do
+    it "should retrieve a file from the provided url over HTTP" do
+      ValidationTest.send(:file_from_url, "http://google.com")
+    end
+    it "should raise an error if the url is invalid" do
+      lambda {ValidationTest.send(:file_from_url, "")}.should raise_error(RuntimeError, "Could not retrieve file from . Error: No such file or directory - ")
+      lambda {ValidationTest.send(:file_from_url, "foo")}.should raise_error(RuntimeError, "Could not retrieve file from foo. Error: No such file or directory - foo")
+    end
+    it "should raise an error if file retrieval fails" do
+      lambda {ValidationTest.send(:file_from_url, "http://fedora-commons.org/nonexistent_file")}.should raise_error(RuntimeError, "Could not retrieve file from http://fedora-commons.org/nonexistent_file. Error: 404 Not Found")  
+    end
+  end
+end