operations 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc575adbf6fc2bf4be98c515a6339190ed29243ccccf2655a8927b0a8f95ac5a
-  data.tar.gz: 486800ebcbd4bc7cffff7aa9e272dba34500a568911a23bb5c7ce60accbb7cea
+  metadata.gz: dc7557987e49805062efa789a9ecc5b0344839b5f8217b9a59fbd6904246ec8f
+  data.tar.gz: 801b5edbde46dba2c005ef8bad826691ca00ce7adda5654d04f602406d15847f
 SHA512:
-  metadata.gz: 1998a83aa5e434c3431d43bf7036f674a2f5f1fd0859f0ea08fc24fe28c419c4a3ee42b07948d8d3faecb2b0b118d006119aa0818e03edd948292ff2e102222c
-  data.tar.gz: b8fab83bfa1f14e139ec3b946f01496e22ec4a57243e74bcee354389e7818847b7df7bd9cd4cf66178e2bf247db1bccd9bd9d6bca12db6fb33b15bbcfb42f572
+  metadata.gz: bcec088edb29345af8934525274ddf100a5d0276545c2153ef1eeef4e6a255040dd0eabfd287afc5d68c3b041a4ac335ef8a258d653598cbb449eb2a78b94c63
+  data.tar.gz: b660a95428e98a9e6839f2b154623dd5226532c646a486f606f4c318c71bef8dd7861859a5775a28be47098ffeecd7c54974baaf31195246084d2ace7daeac08

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-03-25 07:19:50 UTC using RuboCop version 1.44.1.
+# on 2023-12-20 10:30:23 UTC using RuboCop version 1.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,26 +9,20 @@
 # Offense count: 3
 # Configuration parameters: EnforcedStyle, AllowedGems, Include.
 # SupportedStyles: Gemfile, gems.rb, gemspec
-# AllowedGems: bundler
 # Include: **/*.gemspec, **/Gemfile, **/gems.rb
 Gemspec/DevelopmentDependencies:
   Exclude:
     - 'operations.gemspec'
 
 # Offense count: 5
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 28
 
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 160
-
-# Offense count: 7
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
-Metrics/MethodLength:
-  Max: 17
+  Max: 161
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.

data/CHANGELOG.md

@@ -1,10 +1,16 @@
 # Changelog
 
-## [0.6.2](https://github.com/BookingSync/operations/tree/main)
+## [0.6.3](https://github.com/BookingSync/operations/tree/main)
+
+### Fixes
+
+- In some cases, `Operation::Command#form_class` was evaluated before `form_base` was evaluated [\#41](https://github.com/BookingSync/operations/pull/41) ([pyromaniac](https://github.com/pyromaniac))
+
+## [0.6.2]
 
 ### Added
 
-- Support Rails 7.1 [\#40](https://github.com/BookingSync/operations/pull/40) ([ston1x](https://github.com/pyromaniac))
+- Support Rails 7.1 [\#40](https://github.com/BookingSync/operations/pull/40) ([pyromaniac](https://github.com/pyromaniac))
 - Include `Dry::Monads[:result]` in Policies, Preconditions and Callbacks [\#39](https://github.com/BookingSync/operations/pull/39) ([ston1x](https://github.com/ston1x))
 - Add `callback` method to `Operations::Convenience` [\#37](https://github.com/BookingSync/operations/pull/37) ([pyromaniac](https://github.com/pyromaniac))
 - Ability to access operation result in callbacks [\#36](https://github.com/BookingSync/operations/pull/36) ([pyromaniac](https://github.com/pyromaniac))

data/lib/operations/command.rb

@@ -165,7 +165,7 @@ class Operations::Command
     Operations::Types::String
   ), default: proc { {} }
   option :form_base, Operations::Types::Class, default: proc { ::Operations::Form }
-  option :form_class, Operations::Types::Class, default: proc { build_form }
+  option :form_class, Operations::Types::Class.optional, default: proc {}
   option :form_hydrator, Operations::Types.Interface(:call), default: proc { FORM_HYDRATOR }
   option :configuration, Operations::Configuration, default: proc { Operations.default_config }
 
@@ -203,6 +203,7 @@ class Operations::Command
 
     preconditions.push(precondition) if precondition.present?
     super(operation, preconditions: preconditions, on_success: after, **options)
+    @form_class ||= build_form_class
   end
 
   # Instantiates a new command with the given fields updated.
@@ -264,7 +265,7 @@ class Operations::Command
   # These 3 methods added for convenience. They return boolean result
   # instead of Operations::Result. True on success and false on failure.
   %i[callable allowed possible].each do |method|
-    define_method "#{method}?" do |**kwargs|
+    define_method :"#{method}?" do |**kwargs|
       public_send(method, **kwargs).success?
     end
   end
@@ -395,7 +396,7 @@ class Operations::Command
     end
   end
 
-  def build_form
+  def build_form_class
     ::Operations::Form::Builder
       .new(base_class: form_base)
       .build(

data/lib/operations/convenience.rb

@@ -80,7 +80,7 @@ module Operations::Convenience
     contract = Class.new(from)
     contract.config.messages.namespace = name.underscore
     contract.class_eval(&block)
-    const_set("#{prefix.to_s.camelize}Contract", contract)
+    const_set(:"#{prefix.to_s.camelize}Contract", contract)
   end
 
   %w[policy precondition callback].each do |kind|
@@ -96,7 +96,7 @@ module Operations::Convenience
 
       klass.define_method(:call, &block) if block
 
-      const_set("#{prefix.to_s.camelize}#{kind.camelize}", klass)
+      const_set(:"#{prefix.to_s.camelize}#{kind.camelize}", klass)
     end
   end
 end

data/lib/operations/form/builder.rb

@@ -52,7 +52,7 @@ class Operations::Form::Builder
       nested_attributes_suffix,
       nested_attributes_collection
     )
-    form.define_method "#{hash_key.name}=", proc { |attributes| attributes } if nested_attributes_suffix
+    form.define_method :"#{hash_key.name}=", proc { |attributes| attributes } if nested_attributes_suffix
 
     key_path = path + [name]
     nested_form = traverse(members, form, name.underscore.camelize, model_map, key_path)

data/lib/operations/form.rb

@@ -157,7 +157,7 @@ class Operations::Form
     name = name.to_sym
     return unless self.class.attributes.key?(name)
 
-    nested_name = "#{name}_attributes".to_sym
+    nested_name = :"#{name}_attributes"
     value = data.key?(nested_name) ? data[nested_name] : data[name]
 
     (@attributes_cache ||= {})[name] ||= yield(value, self.class.attributes[name])

data/lib/operations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Operations
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: operations
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Arkadiy Zabazhanov
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-11-05 00:00:00.000000000 Z
+date: 2023-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.7
 signing_key:
 specification_version: 4
 summary: Operations framework