opera 0.2.14 → 0.2.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89cd1d74b5ee4021f3adffec29eb4096cb0d71d64c9179ca7e7d8c970f49aac1
-  data.tar.gz: 29faa06fcb24291dc2e75762a12d8747050173dadb163f89af6b4f86013d9e37
+  metadata.gz: dc70b9316e79f9ca5de85afc65ea0ea0f667c8a99aa72d0828f267383b8e76c2
+  data.tar.gz: 8ae3e726adc06851d36fdfd1314f001f678b35b7840be2bb96f833065198497a
 SHA512:
-  metadata.gz: 2165af4193eba6127ff31ffcff445cbb84e883b26d35cf0fae0e1a726dee3e5a2d7285e234639529bb9d175c4a49b54b7ff800b34e535a7c94df89c4c6c20cfc
-  data.tar.gz: 742f6615a8f559bcf2f4a4b6a9efde378005609a5ba77711b25c38f69f9bf281e5a76a5f05e2b9b14bfbe07078b8d5cb409cd6b6c90ef1f976a2a058ee452ca4
+  metadata.gz: f9cf2f017c1ba44975e3968912d7859514ca6c900c824130922e9d1ab7a537cdc7e0d69b0a014d8d4ceb5eb9250be7246a7671af5ff00919764e734cce333f3f
+  data.tar.gz: 1ee6be5b16d95fd0d9174028e93784f6afa18a249553fcc2d5ef1725ac959733e4eba2598249a53c39314937299a7d55889d1919ea7e7bef670d48c712740331

data/.github/workflows/release.yml

@@ -9,15 +9,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [ '2.6', '2.7', '3.0', 'jruby' ]
+        ruby-version: [ '2.6', '2.7', '3.0', '3.2', 'jruby' ]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up Ruby
-        # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
-        # change this to (see https://github.com/ruby/setup-ruby#versioning):
-        # uses: ruby/setup-ruby@v1
-        uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: false # runs 'bundle install' and caches installed gems automatically
@@ -31,7 +28,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Tag automatically
         run: git tag v`cat lib/opera/version.rb | grep 'VERSION' | awk '{ print $3 $4 }' | sed "s/'//g"`
@@ -48,11 +45,11 @@ jobs:
       packages: write
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby 2.7
+      - uses: actions/checkout@v4
+      - name: Set up Ruby 3.2
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.2
 
       - name: Publish to RubyGems
         run: |

data/.github/workflows/specs.yml

@@ -16,15 +16,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.6', '2.7', '3.0', 'jruby']
+        ruby-version: ['2.6', '2.7', '3.0', '3.2', 'jruby']
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Ruby
-    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
-    # change this to (see https://github.com/ruby/setup-ruby#versioning):
-    # uses: ruby/setup-ruby@v1
-      uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: false # runs 'bundle install' and caches installed gems automatically

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Opera Changelog
 
+### 0.2.16 - June 8, 2024
+
+- add `mode` configuration option. When set to `:production` we optimize memory usage by skipping storing executions.
+
+### 0.2.15 - September 4, 2023
+
+- Make the Transaction executor work with the keyword arguments
+
 ### 0.2.14 - April 25, 2023
 
 - Added support for objects responding to `to_hash` method in error handling for easier integration with Rails.

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:3
+FROM ruby:3.2
 
 MAINTAINER ProFinda Developers <dev@profinda.com>
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    opera (0.2.14)
+    opera (0.2.16)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -36,6 +36,7 @@ Opera::Operation::Config.configure do |config|
   config.transaction_class = ActiveRecord::Base
   config.transaction_method = :transaction
   config.transaction_options = { requires_new: true }
+  config.mode = :development # Can be set to production too
   config.reporter = defined?(Rollbar) ? Rollbar : Rails.logger
 end
 ```
@@ -885,9 +886,147 @@ Opera::Operation::Result.new(output: 'success')
     - add_exceptions(Hash)     - Adds multiple exceptions
     - add_information(Hash)    - Adss new information - Useful informations for developers
 
+## Opera::Operation::Base - Instance Methods
+>
+    - context [Hash]          - used to pass information between steps - only for internal usage
+    - params [Hash]           - immutable and received in call method
+    - dependencies [Hash]     - immutable and received in call method
+    - finish!                 - this method interrupts the execution of steps after is invoked
+
 ## Opera::Operation::Base - Class Methods
+
+#### `context_reader`
+
+The `context_reader` helper method is designed to facilitate easy access to specified keys within a `context` hash. It dynamically defines a method that acts as a getter for the value associated with a specified key, simplifying data retrieval.
+
+#### Parameters
+**key (Symbol):** The key(s) for which the getter and setter methods are to be created. These symbols should correspond to keys in the context hash.
+
+**default (Proc, optional):** A lambda or proc that returns a default value for the key if it is not present in the context hash. This proc is lazily evaluated only when the getter is invoked and the key is not present in the hash.
+
+#### Usage
+
+**GOOD**
+
+```ruby
+# USE context_reader to read steps outputs from the context hash
+
+context_reader :schema_output
+
+validate :schema # context = { schema_output: { id: 1 } }
+step :do_something
+
+def do_something
+  puts schema_output  # outputs: { id: 1 }
+end
+```
+
+```ruby
+# USE context_reader with 'default' option to provide default value when key is missing in the context hash
+
+context_reader :profile, default: -> { Profile.new }
+
+step :fetch_profile
+step :do_something
+
+def fetch_profile
+  return if App.http_disabled?
+
+  context[:profile] = ProfileFetcher.call
+end
+
+def update_profile
+  profile.name = 'John'
+  profile.save!
+end
+```
+
+**BAD**
+
+```ruby
+# Using `context_reader` to create read-only methods that instantiate objects,
+# especially when these objects are not stored or updated in the `context` hash, is not recommended.
+# This approach can lead to confusion and misuse of the context hash,
+# as it suggests that the object might be part of the persistent state.
+context_reader :serializer, default: -> { ProfileSerializer.new }
+
+step :output
+
+def output
+  self.result = serializer.to_json({...})
+end
+
+
+# A better practice is to use private methods to define read-only access to resources
+# that are instantiated on the fly and not intended for storage in any state context.
+
+step :output
+
+def output
+  self.result = serializer.to_json({...})
+end
+
+private
+
+def serializer
+  ProfileSerializer.new
+end
+```
+**Conclusion**
+
+For creating instance methods that are meant to be read-only and not stored within a context hash, defining these methods as private is a more suitable and clear approach compared to using context_reader with a default. This method ensures that transient dependencies remain well-encapsulated and are not confused with persistent application state.
+
+#### `context_writer`
+
+The `context_writer` helper method is designed to enable setting of values for specified keys within a `context` hash. This method dynamically defines a method that acts as a setter, allowing for the direct modification of the value associated with a given key.
+
+#### Usage
+```ruby
+context_writer :profile
+
+step :fetch_profile
+
+def fetch_profile
+  self.profile = ProfileFetcher.call # sets context[:profile]
+end
+```
+
+#### `context_accessor`
+
+The `context_accessor` helper method is designed to enable easy access to and modification of values for specified keys within a `context` hash. This method dynamically defines both getter and setter methods for the designated keys, facilitating straightforward retrieval and update of values.
+
+#### Parameters
+
+**key (Symbol):** The key(s) for which the getter and setter methods are to be created. These symbols will correspond to keys in the context hash.
+
+**default (Proc, optional):** A lambda or proc that returns a default value for the key if it is not present in the context hash. This proc is lazily evaluated only when the getter is invoked and the key is not present in the hash.
+
+#### Usage
+```ruby
+context_accessor :profile
+
+step :fetch_profile
+step :update_profile
+
+def fetch_profile
+  self.profile = ProfileFetcher.call # sets context[:profile]
+end
+
+def update_profile
+  profile.update!(name: 'John') # reads profile from context[:profile]
+end
+```
+
+```ruby
+context_accessor :profile, default: -> { Profile.new }
+```
+
+```ruby
+context_accessor :profile, :account
+```
+
+#### Other methods
 >
-    - context_[reader|writer|accessor] - predefined methods for easy access
     - [params|dependencies]_reader     - predefined readers for immutable arguments
     - step(Symbol)             - single instruction
       - return [Truthly]       - continue operation execution
@@ -903,13 +1042,6 @@ Opera::Operation::Result.new(output: 'success')
     - call(params: Hash, dependencies: Hash?)
       - return [Opera::Operation::Result] - never raises an exception
 
-## Opera::Operation::Base - Instance Methods
->
-    - context [Hash]          - used to pass information between steps - only for internal usage
-    - params [Hash]           - immutable and received in call method
-    - dependencies [Hash]     - immutable and received in call method
-    - finish!                 - this method interrupts the execution of steps after is invoked
-
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/opera/operation/base.rb

@@ -14,6 +14,7 @@ module Opera
         @result = Result.new
         @params = params.freeze
         @dependencies = dependencies.freeze
+        config
       end
 
       def config

data/lib/opera/operation/config.rb

@@ -3,13 +3,19 @@
 module Opera
   module Operation
     class Config
-      attr_accessor :transaction_class, :transaction_method, :transaction_options, :reporter
+      DEVELOPMENT_MODE = :development
+      PRODUCTION_MODE = :production
+
+      attr_accessor :transaction_class, :transaction_method, :transaction_options, :reporter, :mode
 
       def initialize
         @transaction_class = self.class.transaction_class
         @transaction_method = self.class.transaction_method || :transaction
         @transaction_options = self.class.transaction_options
+        @mode = self.class.mode || DEVELOPMENT_MODE
         @reporter = custom_reporter || self.class.reporter
+
+        validate!
       end
 
       def configure
@@ -20,12 +26,28 @@ module Opera
         Rails.application.config.x.reporter.presence if defined?(Rails)
       end
 
+      private
+
+      def validate!
+        unless [DEVELOPMENT_MODE, PRODUCTION_MODE].include?(mode)
+          raise ArgumentError, 'Mode is incorrect. Can be either: development or production' 
+        end
+      end
+
       class << self
-        attr_accessor :transaction_class, :transaction_method, :transaction_options, :reporter
+        attr_accessor :transaction_class, :transaction_method, :transaction_options, :reporter, :mode
 
         def configure
           yield self
         end
+
+        def development_mode?
+          mode == DEFAULT_MODE
+        end
+
+        def production_mode?
+          mode == PRODUCTION_MODE
+        end
       end
     end
   end

data/lib/opera/operation/instructions/executors/operation.rb

@@ -18,7 +18,7 @@ module Opera
             end
 
             execution = result.executions.pop
-            result.executions << { execution => operation_result.executions }
+            result.add_execution(execution => operation_result.executions)
           end
 
           private

data/lib/opera/operation/instructions/executors/operations.rb

@@ -45,7 +45,7 @@ module Opera
           def add_results(instruction, results)
             add_instruction_output(instruction, results.map(&:output))
             execution = result.executions.pop
-            result.executions << { execution => results.map(&:executions) }
+            result.add_execution(execution => results.map(&:executions))
           end
 
           def raise_error

data/lib/opera/operation/instructions/executors/transaction.rb

@@ -8,8 +8,7 @@ module Opera
           class RollbackTransactionError < Opera::Error; end
 
           def call(instruction)
-            arguments = transaction_options ? [transaction_method, transaction_options] : [transaction_method]
-            transaction_class.send(*arguments) do
+            transaction_wrapper do
               super
 
               raise(transaction_error) if result.failure?
@@ -18,6 +17,12 @@ module Opera
             nil
           end
 
+          def transaction_wrapper
+            return transaction_class.send(transaction_method) { yield } unless transaction_options
+
+            transaction_class.send(transaction_method, **transaction_options) { yield }
+          end
+
           def transaction_class
             config.transaction_class
           end

data/lib/opera/operation/result.rb

@@ -71,8 +71,16 @@ module Opera
       end
 
       def add_execution(step)
+        return if config.production_mode?
+
         @executions << step
       end
+
+      private
+
+      def config
+        Config
+      end
     end
   end
 end

data/lib/opera/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Opera
-  VERSION = '0.2.14'
+  VERSION = '0.2.16'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opera
 version: !ruby/object:Gem::Version
-  version: 0.2.14
+  version: 0.2.16
 platform: ruby
 authors:
 - ProFinda Development Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-25 00:00:00.000000000 Z
+date: 2024-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-validation
@@ -115,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.19
 signing_key: 
 specification_version: 4
 summary: Use simple DSL language to keep your Operations clean and maintainable