openxml-docx 0.10.5 → 0.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83b80fb3e76c1777ecc53959807d74d79f384902
-  data.tar.gz: bf561fbe368a0d1533d5fd726065a1cf801f4ee1
+  metadata.gz: cb6fb253a34f3c7919c6dbc7adaf421c6ee3a72c
+  data.tar.gz: 1ff1d8ca864e3d95c9fce8d1259cd56234def356
 SHA512:
-  metadata.gz: bc95a3ec56c670a36de88de57b5e96a221e284c08d00c5eae3cc85eb45c78eeaa4b17f9cf4ac24b53f93f396cf1164754100a5e06a1cf96ee4a318e2ef0f4031
-  data.tar.gz: ff1cf70b3015775728f306f11283c44d21adea29e239c2118a1eecfd00e3dbcd7d1c471d1c812873d16302d7634e9470264942f62a77d3a59b501131ec831e15
+  metadata.gz: a3826c5a0da2891945597b88aaa0b195e1754217a8e292a14efc0e526dc24bc33ab48e4633da4a22ce191f78e919090984eaf554941962ef0207e554b4c8b097
+  data.tar.gz: 95673e5763a453c7b70dd1b8836382126400bc4f1816efe4e718ccaf6c6509143e2de14c750acfcd1f7c009e58d62806b6a9ff1cca29370dc184fd645b1e92c3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    openxml-docx (0.10.5)
+    openxml-docx (0.10.6)
       nokogiri
       openxml-package (>= 0.2.2)
 
@@ -13,14 +13,16 @@ GEM
     docile (1.1.5)
     json (1.8.3)
     method_source (0.8.2)
-    mini_portile2 (2.0.0)
-    nokogiri (1.6.7.2)
-      mini_portile2 (~> 2.0.0.rc2)
+    mini_portile2 (2.1.0)
+    nokogiri (1.6.8)
+      mini_portile2 (~> 2.1.0)
+      pkg-config (~> 1.1.7)
     openxml-package (0.2.4)
       nokogiri
       ox
       rubyzip (~> 1.1.0)
-    ox (2.3.0)
+    ox (2.4.3)
+    pkg-config (1.1.7)
     pry (0.10.3)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)

data/lib/openxml/docx/package.rb

@@ -69,23 +69,29 @@ module OpenXml
 
       def embed_image(path: nil, content_type: nil, into_part: nil)
         return if path.nil?
-        into_part = document unless into_part.respond_to?(:relationships)
 
         extension_match = path.match(/\.(?<extension>[^\.]+?)(?:\?.+)?$/)
         content_type ||= extension_match[:extension] if extension_match
         return if content_type.nil?
 
+        open(path, "rb") do |source_image|
+          embed_image_data(data: source_image.read, content_type: content_type, into_part: into_part)
+        end
+      end
+
+      def embed_image_data(data: nil, content_type: nil, into_part: nil)
+        return if data.nil? || content_type.nil?
+        into_part = document unless into_part.respond_to?(:relationships)
+
         content_type = "jpeg" if content_type == "jpg"
         content_type = content_type.to_sym
 
-        open(path, "rb") do |source_image|
-          destination_image_name = "image#{image_names.count + 1}.#{content_type}"
-          add_part "word/media/#{destination_image_name}", OpenXml::Parts::UnparsedPart.new(source_image.read)
-          image_names << destination_image_name
+        destination_image_name = "image#{image_names.count + 1}.#{content_type}"
+        add_part "word/media/#{destination_image_name}", OpenXml::Parts::UnparsedPart.new(data)
+        image_names << destination_image_name
 
-          image_relationship = into_part.relationships.add_relationship REL_IMAGE, "media/#{destination_image_name}"
-          image_relationship.id
-        end
+        image_relationship = into_part.relationships.add_relationship REL_IMAGE, "media/#{destination_image_name}"
+        image_relationship.id
       end
 
       def add_header(header)

data/lib/openxml/docx/properties/on_off_property.rb

@@ -4,11 +4,12 @@ module OpenXml
       class OnOffProperty < ValueProperty
 
         def ok_values
-          [nil, :on, :off]
+          [true, false, :on, :off] # :on and :off are from the Transitional Spec
         end
 
         def to_xml(xml)
-          xml["w"].public_send(tag, "w:val" => value) if value
+          return xml["w"].public_send(tag) if value == true
+          xml["w"].public_send(tag, "w:val" => value)
         end
 
       end

data/lib/openxml/docx/properties/toggle_property.rb

@@ -1,16 +1,12 @@
 module OpenXml
   module Docx
     module Properties
-      class ToggleProperty < ValueProperty
-
-        def ok_values
-          [nil, true, false]
-        end
-
-        def to_xml(xml)
-          xml["w"].public_send(tag) if value
-        end
-
+      class ToggleProperty < OnOffProperty
+        # Toggle properties are no different in representation than on/off properties;
+        # rather, the difference is in how they compose with one another (cf.
+        # Section 17.7.3). It's helpful, then, to retain the concept, but entirely
+        # unnecessary to duplicate implementation.
+        # cf. Section A.6.9 of the spec, and Section A.7.9 of the transitional spec.
       end
     end
   end

data/lib/openxml/docx/version.rb

@@ -1,5 +1,5 @@
 module OpenXml
   module Docx
-    VERSION = "0.10.5"
+    VERSION = "0.10.6"
   end
 end

data/spec/properties/bidi_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Bidi do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :bidi, name: "bidi"
+  it_should_use tag: :bidi, name: "bidi", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Bidi do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:bidi w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/bold_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Bold do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :b, name: "bold"
+  it_should_use tag: :b, name: "bold", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Bold do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:b w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/cant_split_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::CantSplit do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :cantSplit, name: "cant_split"
+  it_should_use tag: :cantSplit, name: "cant_split", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::CantSplit do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:cantSplit w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/caps_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Caps do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :caps, name: "caps"
+  it_should_use tag: :caps, name: "caps", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Caps do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:caps w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/complex_bold_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::ComplexBold do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :bCs, name: "complex_bold"
+  it_should_use tag: :bCs, name: "complex_bold", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::ComplexBold do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:bCs w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/complex_italics_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::ComplexItalics do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :iCs, name: "complex_italics"
+  it_should_use tag: :iCs, name: "complex_italics", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::ComplexItalics do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:iCs w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/complex_script_formatting_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::ComplexScriptFormatting do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :cs, name: "complex_script_formatting"
+  it_should_use tag: :cs, name: "complex_script_formatting", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::ComplexScriptFormatting do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:cs w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/compress_punctuation_spec.rb

@@ -3,7 +3,17 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::CompressPunctuation do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :topLinePunct, name: "compress_punctuation"
+  it_should_use tag: :topLinePunct, name: "compress_punctuation", value: true
+
+  with_value(true) do
+    it_should_work
+    it_should_output "<w:topLinePunct/>"
+  end
+
+  with_value(false) do
+    it_should_work
+    it_should_output "<w:topLinePunct w:val=\"false\"/>"
+  end
 
   with_value(:on) do
     it_should_work
@@ -16,8 +26,7 @@ describe OpenXml::Docx::Properties::CompressPunctuation do
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/contextual_spacing_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::ContextualSpacing do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :contextualSpacing, name: "contextual_spacing"
+  it_should_use tag: :contextualSpacing, name: "contextual_spacing", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::ContextualSpacing do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:contextualSpacing w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/emboss_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Emboss do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :emboss, name: "emboss"
+  it_should_use tag: :emboss, name: "emboss", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Emboss do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:emboss w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/even_and_odd_headers_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::EvenAndOddHeaders do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :evenAndOddHeaders, name: "even_and_odd_headers"
+  it_should_use tag: :evenAndOddHeaders, name: "even_and_odd_headers", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::EvenAndOddHeaders do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:evenAndOddHeaders w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/form_protection_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::FormProtection do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :formProt, name: "form_protection"
+  it_should_use tag: :formProt, name: "form_protection", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::FormProtection do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:formProt w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/hidden_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Hidden do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :hidden, name: "hidden"
+  it_should_use tag: :hidden, name: "hidden", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Hidden do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:hidden w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/hidden_style_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::HiddenStyle do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :hidden, name: "hidden_style"
+  it_should_use tag: :hidden, name: "hidden_style", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::HiddenStyle do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:hidden w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/hidden_text_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::HiddenText do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :vanish, name: "hidden_text"
+  it_should_use tag: :vanish, name: "hidden_text", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::HiddenText do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:vanish w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/hide_mark_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::HideMark do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :hideMark, name: "hide_mark"
+  it_should_use tag: :hideMark, name: "hide_mark", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::HideMark do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:hideMark w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/imprint_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Imprint do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :imprint, name: "imprint"
+  it_should_use tag: :imprint, name: "imprint", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Imprint do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:imprint w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/italics_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Italics do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :i, name: "italics"
+  it_should_use tag: :i, name: "italics", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Italics do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:i w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/keep_lines_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::KeepLines do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :keepLines, name: "keep_lines"
+  it_should_use tag: :keepLines, name: "keep_lines", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::KeepLines do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:keepLines w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/keep_next_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::KeepNext do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :keepNext, name: "keep_next"
+  it_should_use tag: :keepNext, name: "keep_next", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::KeepNext do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:keepNext w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/kinsoku_spec.rb

@@ -3,7 +3,17 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Kinsoku do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :kinsoku, name: "kinsoku"
+  it_should_use tag: :kinsoku, name: "kinsoku", value: true
+
+  with_value(true) do
+    it_should_work
+    it_should_output "<w:kinsoku/>"
+  end
+
+  with_value(false) do
+    it_should_work
+    it_should_output "<w:kinsoku w:val=\"false\"/>"
+  end
 
   with_value(:on) do
     it_should_work
@@ -16,8 +26,7 @@ describe OpenXml::Docx::Properties::Kinsoku do
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/math_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::Math do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :oMath, name: "math"
+  it_should_use tag: :oMath, name: "math", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::Math do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:oMath w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/mirror_indent_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::MirrorIndent do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :mirrorIndent, name: "mirror_indent"
+  it_should_use tag: :mirrorIndent, name: "mirror_indent", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::MirrorIndent do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:mirrorIndent w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/no_wrap_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::NoWrap do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :noWrap, name: "no_wrap"
+  it_should_use tag: :noWrap, name: "no_wrap", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::NoWrap do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:noWrap w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/page_break_before_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::PageBreakBefore do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :pageBreakBefore, name: "page_break_before"
+  it_should_use tag: :pageBreakBefore, name: "page_break_before", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::PageBreakBefore do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:pageBreakBefore w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/primary_style_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::PrimaryStyle do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :qFormat, name: "primary_style"
+  it_should_use tag: :qFormat, name: "primary_style", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::PrimaryStyle do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:qFormat w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/right_to_left_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::RightToLeft do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :rtl, name: "right_to_left"
+  it_should_use tag: :rtl, name: "right_to_left", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::RightToLeft do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:rtl w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/semi_hidden_spec.rb

@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::SemiHidden do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:semiHidden w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/snap_to_grid_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::SnapToGrid do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :snapToGrid, name: "snap_to_grid"
+  it_should_use tag: :snapToGrid, name: "snap_to_grid", value: true
 
   with_value(:on) do
     it_should_work
@@ -15,9 +15,18 @@ describe OpenXml::Docx::Properties::SnapToGrid do
     it_should_output "<w:snapToGrid w:val=\"off\"/>"
   end
 
-  with_value(nil) do
+  with_value(true) do
+    it_should_work
+    it_should_output "<w:snapToGrid/>"
+  end
+
+  with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:snapToGrid w:val=\"false\"/>"
+  end
+
+  with_value(nil) do
+    it_should_not_work
   end
 
 end

data/spec/properties/spec_vanish_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::SpecVanish do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :specVanish, name: "spec_vanish"
+  it_should_use tag: :specVanish, name: "spec_vanish", value: false
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::SpecVanish do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:specVanish w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/style_auto_redefinition_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::StyleAutoRedefinition do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :autoRedefine, name: "style_auto_redefinition"
+  it_should_use tag: :autoRedefine, name: "style_auto_redefinition", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::StyleAutoRedefinition do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:autoRedefine w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/style_lock_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::StyleLock do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :locked, name: "style_lock"
+  it_should_use tag: :locked, name: "style_lock", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::StyleLock do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:locked w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/supress_auto_hyphens_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::SupressAutoHyphens do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :supressAutoHyphens, name: "supress_auto_hyphens"
+  it_should_use tag: :supressAutoHyphens, name: "supress_auto_hyphens", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::SupressAutoHyphens do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:supressAutoHyphens w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/supress_line_numbers_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::SupressLineNumbers do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :supressLineNumbers, name: "supress_line_numbers"
+  it_should_use tag: :supressLineNumbers, name: "supress_line_numbers", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::SupressLineNumbers do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:supressLineNumbers w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/supress_overlap_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::SupressOverlap do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :supressOverlap, name: "supress_overlap"
+  it_should_use tag: :supressOverlap, name: "supress_overlap", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::SupressOverlap do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:supressOverlap w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/table_header_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::TableHeader do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :tblHeader, name: "table_header"
+  it_should_use tag: :tblHeader, name: "table_header", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::TableHeader do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:tblHeader w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/title_page_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::TitlePage do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :titlePg, name: "title_page"
+  it_should_use tag: :titlePg, name: "title_page", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::TitlePage do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:titlePg w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/unhide_when_used_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::UnhideWhenUsed do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :unhideWhenUsed, name: "unhide_when_used"
+  it_should_use tag: :unhideWhenUsed, name: "unhide_when_used", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::UnhideWhenUsed do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:unhideWhenUsed w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/web_hidden_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::WebHidden do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :webHidden, name: "web_hidden"
+  it_should_use tag: :webHidden, name: "web_hidden", value: true
 
   with_value(true) do
     it_should_work
@@ -12,12 +12,11 @@ describe OpenXml::Docx::Properties::WebHidden do
 
   with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:webHidden w:val=\"false\"/>"
   end
 
   with_value(nil) do
-    it_should_work
-    it_should_output ""
+    it_should_not_work
   end
 
 end

data/spec/properties/widow_control_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::WidowControl do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :widowControl, name: "widow_control"
+  it_should_use tag: :widowControl, name: "widow_control", value: true
 
   with_value(:on) do
     it_should_work
@@ -15,9 +15,19 @@ describe OpenXml::Docx::Properties::WidowControl do
     it_should_output "<w:widowControl w:val=\"off\"/>"
   end
 
-  with_value(nil) do
+  with_value(true) do
+    it_should_work
+    it_should_output "<w:widowControl/>"
+  end
+
+  with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:widowControl w:val=\"false\"/>"
+  end
+
+
+  with_value(nil) do
+    it_should_not_work
   end
 
 end

data/spec/properties/word_wrap_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe OpenXml::Docx::Properties::WordWrap do
   include ValuePropertyTestMacros
 
-  it_should_use tag: :wordWrap, name: "word_wrap"
+  it_should_use tag: :wordWrap, name: "word_wrap", value: true
 
   with_value(:on) do
     it_should_work
@@ -15,9 +15,19 @@ describe OpenXml::Docx::Properties::WordWrap do
     it_should_output "<w:wordWrap w:val=\"off\"/>"
   end
 
-  with_value(nil) do
+  with_value(true) do
+    it_should_work
+    it_should_output "<w:wordWrap/>"
+  end
+
+  with_value(false) do
     it_should_work
-    it_should_output ""
+    it_should_output "<w:wordWrap w:val=\"false\"/>"
+  end
+
+
+  with_value(nil) do
+    it_should_not_work
   end
 
 end

data/spec/section_spec.rb

@@ -14,14 +14,14 @@ describe OpenXml::Docx::Section do
   it_should_have_property :page_size
   it_should_have_property :paper_source
 
-  it_should_have_value_property :bidi
-  it_should_have_value_property :form_protection
+  it_should_have_value_property :bidi, with_value: true
+  it_should_have_value_property :form_protection, with_value: true
   it_should_have_value_property :rtl_gutter
   it_should_have_value_property :text_direction, with_value: :lr
   it_should_have_value_property :type, as_instance_of: :section_type, with_value: :oddPage
   it_should_have_value_property :vertical_alignment, as_instance_of: :vertical_text_alignment, with_value: :both
-  it_should_have_value_property :title_page
-  it_should_have_value_property :even_and_odd_headers
+  it_should_have_value_property :title_page, with_value: true
+  it_should_have_value_property :even_and_odd_headers, with_value: true
 
   context "if no attribute are set" do
     before(:each) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openxml-docx
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.10.6
 platform: ruby
 authors:
 - Gene Doyel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-26 00:00:00.000000000 Z
+date: 2017-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri