openvox 8.19.2 → 8.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aee9652d6d305f148340ca0549075b14115f8ae4fd72d26b08f4f6de52cfaf7f
-  data.tar.gz: cebf9cccc4374f6e8b71376e48604658ff79a6ba1f19aa899b945bec05d6f798
+  metadata.gz: 91c67366f80e0f90b53567de5eea991ba6d36d5fa59af42d65a6975c619f119e
+  data.tar.gz: 2c8b8e00d4f6d2d468888e6126ee9bcc5db0f18748164e1c7cf2545cdd27de51
 SHA512:
-  metadata.gz: ffa447bea4a9a6cc450b901f6b799a36769318621d7f554f301118388ae417673a08fb048808f01a61cc4d0fec23d7fc58cb2cd833230b8a5548070afe61492b
-  data.tar.gz: 7435e8c3fdce5f5ca1015f30e13239dadd6caa1c4508ebacbd98a956259dd953c5be6f3b9982ea5460dc806942b43abd602f414c6fd767650bb66cc48baf9ae8
+  metadata.gz: 315686060fd5c3fd1a3df8c7163c5cf737ddd16e2a922175b0dc2901e6bd4763fad7315cbccc06fff944485cfbab6f3d232160e04b72898cdec10076cfbe3474
+  data.tar.gz: 1a5eecd081bc2d6ed326620a01b128056d2336002e0015b0627b0c7789a07be0f25ccc57e03db9f3ffbb35a7ee9e7b55f777bf42acdd03c511211ca11b27ac57

data/CHANGELOG.md

@@ -2,36 +2,53 @@
 
 All notable changes to this project will be documented in this file.
 
-## [8.19.2](https://github.com/openvoxproject/puppet/tree/8.19.2) (2025-06-06)
+## [8.20.0](https://github.com/openvoxproject/openvox/tree/8.20.0) (2025-06-27)
 
-[Full Changelog](https://github.com/openvoxproject/puppet/compare/8.19.1...8.19.2)
+[Full Changelog](https://github.com/openvoxproject/openvox/compare/8.19.2...8.20.0)
+
+**Implemented enhancements:**
+
+- Switch from facter to openfact [\#142](https://github.com/OpenVoxProject/openvox/pull/142) ([smortex](https://github.com/smortex))
+- \(PUP-12083\) Update soft limit warning for fact value & name length [\#137](https://github.com/OpenVoxProject/openvox/pull/137) ([bastelfreak](https://github.com/bastelfreak))
+
+**Fixed bugs:**
+
+- Maintain consistent JSON formatting  [\#132](https://github.com/OpenVoxProject/openvox/pull/132) ([bastelfreak](https://github.com/bastelfreak))
+
+**Merged pull requests:**
+
+- cleanup gem metadata after Perforce-\>OpenVoxProject migration [\#140](https://github.com/OpenVoxProject/openvox/pull/140) ([smortex](https://github.com/smortex))
+
+## [8.19.2](https://github.com/openvoxproject/openvox/tree/8.19.2) (2025-06-06)
+
+[Full Changelog](https://github.com/openvoxproject/openvox/compare/8.19.1...8.19.2)
 
 **Fixed bugs:**
 
-- server\_facts: Switch implementation-\>serverimplementation [\#107](https://github.com/OpenVoxProject/puppet/pull/107) ([binford2k](https://github.com/binford2k))
-- Reflect Ruby 3.4 stack trace changes [\#100](https://github.com/OpenVoxProject/puppet/pull/100) ([ekohl](https://github.com/ekohl))
-- Add base64 as gem dependencies for Ruby 3.4 [\#98](https://github.com/OpenVoxProject/puppet/pull/98) ([ekohl](https://github.com/ekohl))
-- Add racc gem dependency [\#89](https://github.com/OpenVoxProject/puppet/pull/89) ([ekohl](https://github.com/ekohl))
+- server\_facts: Switch implementation-\>serverimplementation [\#107](https://github.com/OpenVoxProject/openvox/pull/107) ([binford2k](https://github.com/binford2k))
+- Reflect Ruby 3.4 stack trace changes [\#100](https://github.com/OpenVoxProject/openvox/pull/100) ([ekohl](https://github.com/ekohl))
+- Add base64 as gem dependencies for Ruby 3.4 [\#98](https://github.com/OpenVoxProject/openvox/pull/98) ([ekohl](https://github.com/ekohl))
+- Add racc gem dependency [\#89](https://github.com/OpenVoxProject/openvox/pull/89) ([ekohl](https://github.com/ekohl))
 
-## [8.19.1](https://github.com/openvoxproject/puppet/tree/8.19.1) (2025-06-03)
+## [8.19.1](https://github.com/openvoxproject/openvox/tree/8.19.1) (2025-06-03)
 
-[Full Changelog](https://github.com/openvoxproject/puppet/compare/8.19.0...8.19.1)
+[Full Changelog](https://github.com/openvoxproject/openvox/compare/8.19.0...8.19.1)
 
 **Fixed bugs:**
 
-- Fix invalid gemspec in AIO package [\#91](https://github.com/OpenVoxProject/puppet/pull/91) ([smortex](https://github.com/smortex))
+- Fix invalid gemspec in AIO package [\#91](https://github.com/OpenVoxProject/openvox/pull/91) ([smortex](https://github.com/smortex))
 
-## [8.19.0](https://github.com/openvoxproject/puppet/tree/8.19.0) (2025-05-30)
+## [8.19.0](https://github.com/openvoxproject/openvox/tree/8.19.0) (2025-05-30)
 
-[Full Changelog](https://github.com/openvoxproject/puppet/compare/8.18.1...8.19.0)
+[Full Changelog](https://github.com/openvoxproject/openvox/compare/8.18.1...8.19.0)
 
 **Implemented enhancements:**
 
-- Add `implementation` fact to agent and server. [\#63](https://github.com/OpenVoxProject/puppet/pull/63) ([ffrank](https://github.com/ffrank))
+- Add `implementation` fact to agent and server. [\#63](https://github.com/OpenVoxProject/openvox/pull/63) ([ffrank](https://github.com/ffrank))
 
 **Fixed bugs:**
 
-- Replace `erase` with `remove`, since it's no longer supported with DNF5 [\#68](https://github.com/OpenVoxProject/puppet/pull/68) ([Stricken1670](https://github.com/Stricken1670))
+- Replace `erase` with `remove`, since it's no longer supported with DNF5 [\#68](https://github.com/OpenVoxProject/openvox/pull/68) ([Stricken1670](https://github.com/Stricken1670))
 
 
 

data/Gemfile

@@ -13,10 +13,10 @@ def location_for(place, fake_version = nil)
 end
 
 # Make sure these gem requirements are in sync with the gempspec. Specifically,
-# the runtime_dependencies in puppet.gemspec match the runtime dependencies here
-# (like facter, semantic_puppet, and puppet-resource_api)
+# the runtime_dependencies in openvox.gemspec match the runtime dependencies here
+# (like openfact, semantic_puppet, and puppet-resource_api)
 
-gem "facter", *location_for(ENV['FACTER_LOCATION'] || ["~> 4.3"])
+gem "openfact", *location_for(ENV['OPENFACT_LOCATION'] || ["~> 5.0"])
 gem "semantic_puppet", *location_for(ENV['SEMANTIC_PUPPET_LOCATION'] || ["~> 1.0"])
 gem "puppet-resource_api", *location_for(ENV['RESOURCE_API_LOCATION'] || ["~> 1.5"])
 
@@ -47,6 +47,7 @@ group(:test) do
   gem "rspec", "~> 3.1", require: false
   gem "rspec-expectations", ["~> 3.9", "!= 3.9.3"]
   gem "rspec-its", "~> 1.1", require: false
+  gem 'rspec-mocks', '< 3.13.3', require: false # breaking change afterwards: https://github.com/rspec/rspec-mocks/pull/1596
   gem 'vcr', '~> 6.1', require: false
   gem 'webmock', '~> 3.0', require: false
   gem 'webrick', '~> 1.7', require: false

data/README.md

@@ -36,9 +36,9 @@ rest of the [developer documents](docs/index.md).
 
 ## Licensing
 
-See [LICENSE](LICENSE) file. OpenVox is licensed by Vox Pupuli as a community maintained
-implementation of Puppet. Vox Pupuli can be contacted at: voxpupuli@groups.io.
-Puppet itself is licensed by Puppet, Inc. under the Apache license. Puppet, Inc. can be contacted at: info@puppet.com
+See [LICENSE](LICENSE) file. OpenVox is licensed by the OpenVox Project as a community maintained
+implementation of Puppet. The OpenVox Project can be contacted at: openvox@voxpupuli.org.
+Puppet itself is licensed by Puppet, Inc. under the Apache license. Puppet, Inc. can be contacted at: info@puppet.com.
 
 ## Support
 

data/Rakefile

@@ -59,7 +59,7 @@ end
 namespace :pl_ci do
   desc 'Build puppet gems'
   task :gem_build, [:gemspec] do |t, args|
-    args.with_defaults(gemspec: 'puppet.gemspec')
+    args.with_defaults(gemspec: 'openvox.gemspec')
     stdout, stderr, status = Open3.capture3(<<~END)
       gem build #{args.gemspec} --platform x86-mingw32 && \
       gem build #{args.gemspec} --platform x64-mingw32 && \
@@ -79,11 +79,11 @@ namespace :pl_ci do
     # this is taken from `rake package:nightly_gem`
     extended_dot_version = %x{git describe --tags --dirty --abbrev=7}.chomp.tr('-', '.')
 
-    # we must create tempfile in the same directory as puppetg.gemspec, since
+    # we must create tempfile in the same directory as openvox.gemspec, since
     # it uses __dir__ to determine which files to include
     require 'tempfile'
     Tempfile.create('gemspec', __dir__) do |dst|
-      File.open('puppet.gemspec', 'r') do |src|
+      File.open('openvox.gemspec', 'r') do |src|
         src.readlines.each do |line|
           if line.match?(/version\s*=\s*['"][0-9.]+['"]/)
             line = "spec.version = '#{extended_dot_version}'"
@@ -158,7 +158,7 @@ begin
     All notable changes to this project will be documented in this file.
     HEADER
     config.user = "openvoxproject"
-    config.project = "puppet"
+    config.project = "openvox"
     config.exclude_labels = %w[dependencies duplicate question invalid wontfix wont-fix modulesync skip-changelog]
     config.since_tag = "8.18.1"
     config.future_release = Puppet::PUPPETVERSION
@@ -169,3 +169,6 @@ rescue LoadError
     abort("Run `bundle install --with release` to install the `github_changelog_generator` gem.")
   end
 end
+
+desc 'Prepare for a release'
+task 'release:prepare' => [:changelog]

data/lib/puppet/configurer.rb

@@ -135,36 +135,37 @@ class Puppet::Configurer
     Puppet.warning _("The current total number of fact values: %{size} exceeds the fact values limit: %{max_size}") % { size: size, max_size: max_number }
   end
 
-  def warn_fact_name_length(name, max_length)
-    Puppet.warning _("Fact %{name} with length: '%{length}' exceeds the length limit: %{limit}") % { name: name, length: name.to_s.bytesize, limit: max_length }
+  def warn_fact_name_length(name, max_length, fact_name_length)
+    Puppet.warning _("Fact %{name} with length: %{length} exceeds the fact name length limit: %{limit}") % { name: name, length: fact_name_length, limit: max_length }
   end
 
   def warn_number_of_top_level_facts(size, max_number)
     Puppet.warning _("The current number of top level facts: %{size} exceeds the top facts limit: %{max_size}") % { size: size, max_size: max_number }
   end
 
-  def warn_fact_value_length(value, max_length)
-    Puppet.warning _("Fact value '%{value}' with the value length: '%{length}' exceeds the value length limit: %{max_length}") % { value: value, length: value.to_s.bytesize, max_length: max_length }
+  def warn_fact_value_length(name, value, max_length)
+    Puppet.warning _("Fact %{name} with value %{value} with the value length: %{length} exceeds the value length limit: %{max_length}") % { name: name, value: value, length: value.to_s.bytesize, max_length: max_length }
   end
 
   def warn_fact_payload_size(payload, max_size)
-    Puppet.warning _("Payload with the current size of: '%{payload}' exceeds the payload size limit: %{max_size}") % { payload: payload, max_size: max_size }
+    Puppet.warning _("Payload with the current size of: %{payload} exceeds the payload size limit: %{max_size}") % { payload: payload, max_size: max_size }
   end
 
-  def check_fact_name_length(name, number_of_dots)
+  def check_fact_name_length(fact_path, number_of_dots)
     max_length = Puppet[:fact_name_length_soft_limit]
     return if max_length.zero?
 
+    name_without_dots = fact_path.join()
     # rough byte size estimations of fact path as a postgresql btree index
-    size_as_btree_index = 8 + (number_of_dots * 2) + name.to_s.bytesize
-    warn_fact_name_length(name, max_length) if size_as_btree_index > max_length
+    size_as_btree_index = 8 + (number_of_dots * 2) + name_without_dots.to_s.bytesize
+    warn_fact_name_length(fact_path.join('.'), max_length, size_as_btree_index) if size_as_btree_index > max_length
   end
 
-  def check_fact_values_length(values)
+  def check_fact_values_length(name, values)
     max_length = Puppet[:fact_value_length_soft_limit]
     return if max_length.zero?
 
-    warn_fact_value_length(values, max_length) if values.to_s.bytesize > max_length
+    warn_fact_value_length(name, values, max_length) if values.to_s.bytesize > max_length
   end
 
   def check_top_level_number_limit(size)
@@ -204,8 +205,8 @@ class Puppet::Configurer
         path.pop
       end
     else
-      check_fact_name_length(path.join(), path.size)
-      check_fact_values_length(object)
+      check_fact_name_length(path, path.size)
+      check_fact_values_length(path.join('.'), object)
       @number_of_facts += 1
     end
   end

data/lib/puppet/face/facts.rb

@@ -167,7 +167,15 @@ Puppet::Indirector::Face.define(:facts, '0.0.1') do
 
       case result
       when Array, Hash
-        Puppet::Util::Json.dump(result, :pretty => true)
+        # JSON < 2.8.0 would pretty print empty arrays and hashes with newlines
+        # Maintain that behavior for our users for now
+        if result.is_a?(Array) && result.empty?
+          "[\n\n]"
+        elsif result.is_a?(Hash) && result.empty?
+          "{\n}"
+        else
+          Puppet::Util::Json.dump(result, :pretty => true)
+        end
       else # one of VALID_TYPES above
         result
       end

data/lib/puppet/version.rb

@@ -8,7 +8,7 @@
 # Raketasks and such to set the version based on the output of `git describe`
 
 module Puppet
-  PUPPETVERSION = '8.19.2'
+  PUPPETVERSION = '8.20.0'
   IMPLEMENTATION = 'openvox'
 
   ##

data/tasks/vox.rake

@@ -0,0 +1,23 @@
+namespace :vox do
+  desc 'Update the version in preparation for a release'
+  task 'version:bump:full', [:version] do |_, args|
+    abort 'You must provide a tag.' if args[:version].nil? || args[:version].empty?
+    version = args[:version]
+    abort "#{version} does not appear to be a valid version string in x.y.z format" unless Gem::Version.correct?(version)
+
+    # Update lib/puppet/version.rb and openvox.gemspec
+    puts "Setting version to #{version}"
+
+    data = File.read('lib/puppet/version.rb')
+    new_data = data.sub(/PUPPETVERSION = '\d+\.\d+\.\d+(\.rc\d+)?'/, "PUPPETVERSION = '#{version}'")
+    warn 'Failed to update version in lib/puppet/version.rb' if data == new_data
+
+    File.write('lib/puppet/version.rb', new_data)
+
+    data = File.read('openvox.gemspec')
+    new_data = data.sub(/spec.version = "\d+\.\d+\.\d+(\.rc\d+)?"/, "spec.version = \"#{version}\"")
+    warn 'Failed to update version in openvox.gemspec' if data == new_data
+
+    File.write('openvox.gemspec', new_data)
+  end
+end

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: openvox
 version: !ruby/object:Gem::Version
-  version: 8.19.2
+  version: 8.20.0
 platform: ruby
 authors:
-- Vox Pupuli
+- OpenVox Project
 bindir: bin
 cert_chain: []
 date: 2012-08-17 00:00:00.000000000 Z
@@ -18,7 +18,7 @@ dependencies:
         version: '0.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -28,7 +28,7 @@ dependencies:
         version: '0.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: benchmark
   requirement: !ruby/object:Gem::Requirement
@@ -77,26 +77,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: facter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.3.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.3.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
 - !ruby/object:Gem::Dependency
   name: fast_gettext
   requirement: !ruby/object:Gem::Requirement
@@ -159,6 +139,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: openfact
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: ostruct
   requirement: !ruby/object:Gem::Requirement
@@ -232,7 +226,7 @@ dependencies:
 description: |
   OpenVox is a community implementation of Puppet, an automated administrative engine for your Linux, Unix, and Windows systems, performs administrative tasks
   (such as adding users, installing packages, and updating server configurations) based on a centralized specification.
-email: openvox@voxpupuli.org.
+email: openvox@voxpupuli.org
 executables:
 - puppet
 extensions: []
@@ -1339,7 +1333,7 @@ files:
 - man/man8/puppet-script.8
 - man/man8/puppet-ssl.8
 - man/man8/puppet.8
-- tasks/tag.rake
+- tasks/vox.rake
 homepage: https://github.com/OpenVoxProject/puppet
 licenses:
 - Apache-2.0

data/tasks/tag.rake

@@ -1,34 +0,0 @@
-namespace :vox do
-  desc 'Update version, create tag, and push to origin'
-  task :tag, [:tag] do |_, args|
-    abort 'You must provide a tag.' if args[:tag].nil? || args[:tag].empty?
-    version = args[:tag]
-    abort "#{version} does not appear to be a valid version string in x.y.z format" unless Gem::Version.correct?(version)
-
-    # Update lib/puppet/version.rb and puppet.gemspec
-    puts "Setting version to #{version}"
-    data = File.read('lib/puppet/version.rb')
-    data = data.sub(/PUPPETVERSION = '\d+\.\d+\.\d+'/, "PUPPETVERSION = '#{version}'")
-    File.write('lib/puppet/version.rb', data)
-    data = File.read('puppet.gemspec')
-    data = data.sub(/spec.version = "\d+\.\d+\.\d+"/, "spec.version = \"#{version}\"")
-    File.write('puppet.gemspec', data)
-    run_command("git add lib/puppet/version.rb && git add puppet.gemspec && git commit -m 'Set version to #{version}'")
-
-    # Run git command to get short SHA and one line description of the commit on HEAD
-    branch = run_command('git rev-parse --abbrev-ref HEAD')
-    sha = run_command('git rev-parse --short HEAD')
-    msg = run_command('git log -n 1 --pretty=%B')
-
-    puts "Branch: #{branch}"
-    puts "SHA: #{sha}"
-    puts "Commit: #{msg}"
-
-    run_command("git tag -a #{version} -m '#{version}'")
-
-    unless !ENV['NOPUSH'].nil?
-      puts "Pushing to origin"
-      run_command("git push origin && git push origin #{version}")
-    end
-  end
-end