openvox-lint 1.3.2 → 1.3.4

data/lib/openvox-lint/plugins/checks/trailing_comma.rb

@@ -2,7 +2,7 @@
 
 # Resource bodies and parameter lists should end with a trailing comma.
 #
-# Only fires inside resource bodies (NAME { ... }) — not inside
+# Only fires inside resource bodies (NAME or CLASSREF { ... }) — not inside
 # conditionals (if/unless/case), class bodies, or other brace contexts
 # where a trailing comma is not expected.
 OpenvoxLint.new_check(:trailing_comma) do

data/lib/openvox-lint/plugins/checks/variable_is_lowercase.rb

@@ -5,7 +5,7 @@ OpenvoxLint.new_check(:variable_is_lowercase) do
   def check
     tokens.each do |tok|
       next unless tok.type == :VARIABLE
-      name = tok.value.sub(/^\$/, '')
+      name = tok.value.sub(/^\$:*/, '')
       next if name =~ /\A[a-z_][a-z0-9_:]*\z/ || name.empty?
       notify :warning,
         message: "variable '#{tok.value}' contains uppercase characters",

data/lib/openvox-lint/report.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'json'
+require 'pathname'
 
 module OpenvoxLint
   # Formats and outputs lint problems in the requested format.
@@ -12,6 +13,7 @@ module OpenvoxLint
     end
 
     def format(problems, io: $stdout)
+      problems = with_display_paths(problems)
       case @config.log_format
       when 'json'        then format_json(problems, io)
       when 'csv'         then format_csv(problems, io)
@@ -42,15 +44,25 @@ module OpenvoxLint
     def format_csv(problems, io)
       io.puts 'path,line,column,kind,check,message'
       problems.each do |p|
-        io.puts [p[:path], p[:line], p[:column], p[:kind], p[:check],
-                 %("#{p[:message]}")].join(',')
+        io.puts [
+          csv_escape(p[:path]),
+          csv_escape(p[:line]),
+          csv_escape(p[:column]),
+          csv_escape(p[:kind]),
+          csv_escape(p[:check]),
+          csv_escape(p[:message]),
+        ].join(',')
       end
     end
 
     def format_github(problems, io)
       problems.each do |p|
         kind = p[:kind] == :error ? 'error' : 'warning'
-        io.puts "::#{kind} file=#{p[:path]},line=#{p[:line]},col=#{p[:column]}::#{p[:check]}: #{p[:message]}"
+        file = github_escape_property(p[:path])
+        line = github_escape_property(p[:line])
+        col = github_escape_property(p[:column])
+        message = github_escape_data("#{p[:check]}: #{p[:message]}")
+        io.puts "::#{kind} file=#{file},line=#{line},col=#{col}::#{message}"
       end
     end
 
@@ -82,5 +94,41 @@ module OpenvoxLint
       { path: p[:path], line: p[:line], column: p[:column],
         kind: p[:kind].to_s, check: p[:check].to_s, message: p[:message] }
     end
+
+    # GitHub workflow-command escaping:
+    # https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message
+    # Encode '%' first so attacker-supplied %0A/%0D cannot decode back to newlines.
+    def github_escape_data(value)
+      value.to_s.gsub('%', '%25').gsub("\r", '%0D').gsub("\n", '%0A').gsub('::', '%3A%3A')
+    end
+
+    def github_escape_property(value)
+      github_escape_data(value).gsub(':', '%3A').gsub(',', '%2C')
+    end
+
+    def csv_escape(value)
+      s = value.to_s
+      if s.match?(/[",\r\n]/)
+        %("#{s.gsub('"', '""')}")
+      else
+        s
+      end
+    end
+
+    # When --relative is set, emit paths relative to Dir.pwd.
+    # Problems hashes are not mutated.
+    def with_display_paths(problems)
+      return problems unless @config.relative
+      problems.map { |p| p.merge(path: display_path(p[:path])) }
+    end
+
+    def display_path(path)
+      return path if path.nil? || path.to_s.empty?
+      Pathname.new(File.expand_path(path.to_s)).relative_path_from(
+        Pathname.new(File.expand_path(Dir.pwd))
+      ).to_s
+    rescue ArgumentError
+      path
+    end
   end
 end

data/lib/openvox-lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenvoxLint
-  VERSION = '1.3.2'
+  VERSION = '1.3.4'
 end

data/lib/openvox-lint.rb

@@ -42,7 +42,7 @@ module OpenvoxLint
 
     def new_check(name, &block)
       if checks.key?(name)
-        $stderr.puts "openvox-lint: warning: check '#{name}' is already registered — overwriting" if ENV['OPENVOX_LINT_DEBUG']
+        $stderr.puts "openvox-lint: warning: check '#{name}' is already registered — overwriting"
       end
       klass = Class.new(CheckPlugin, &block)
       klass.instance_variable_set(:@check_name, name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openvox-lint
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.4
 platform: ruby
 authors:
 - Jerald Sheets
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-24 00:00:00.000000000 Z
+date: 2026-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -57,10 +57,12 @@ description: |
   It checks your .pp files against the OpenVox Language Style Guide (the
   current canonical reference) and catches common errors, deprecated patterns
   (legacy facts, Hiera 3, import, etc.), strict-mode issues, and Puppet 8+ /
-  OpenVox 8.x problems. Includes real --fix support for many checks.
+  OpenVox 8.x problems. Includes real --fix support for five checks:
+  trailing_whitespace, hard_tabs, quoted_booleans, double_quoted_strings,
+  and single_quote_string_with_variables.
 
   Fully compatible with OpenVox 8.x and Puppet 8.x. Drop-in replacement for
-  the archived puppet-lint with better Ruby 2.5+ support and OpenVox-specific
+  the archived puppet-lint with Ruby 2.6+ support and OpenVox-specific
   checks.
 email:
 - jsheets@xai.com
@@ -74,6 +76,7 @@ files:
 - LICENSE
 - README.md
 - bin/openvox-lint
+- docs/ARCHITECTURE_REVIEW.md
 - lib/openvox-lint.rb
 - lib/openvox-lint/check_plugin.rb
 - lib/openvox-lint/checks.rb
@@ -138,14 +141,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: Check OpenVox/Puppet manifests against the OpenVox Language Style Guide