openvox-lint 1.3.0 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92a172fe1a83c3d684aee5d33ab5d77562cc7f59f226187220b4afd8c491e5b2
-  data.tar.gz: be8d992d5f9ad8773718818bf9c576e50197ed4ca3d9d0ab0d5e568f2f4a2e3f
+  metadata.gz: 8c05d5ae29ef48e240815439ce845d046cc744174e1a8fab4af7750f945f152f
+  data.tar.gz: a7089f30cbc770df73833be2173b44fe8dbe579647c2e07b9243b76a49cca67b
 SHA512:
-  metadata.gz: b720a95e6dd55dea7fdef36831236fad7f586c4916fcec8e13d6e1f8668897f5261c806a525f3d46ccfbacc4291172531a40cb86f76ab2cedba51a15a7d78c85
-  data.tar.gz: 991d2849f7e848fcbd6eace4c09289ffde7509a6df96b1d447f6c4b68b83363ac5ab919627d4bde4cde0a974ca2170ae38e3150070c5d25a84ff48b367103d66
+  metadata.gz: 1d73364d4a91db8da06e6cef69f9f4eb10def5ff8ced91531c79d5f3d95f129368f81f4de1361d05d1418d35dd5d1e7edb9fecbac93cffabe3c446d5bb187f29
+  data.tar.gz: 6aab6a244ad2e8448a9eaf26b75bff0305edb0e91592b0b115310e38e1e5833c164ef5a20935cadbddb057c80b3f4d2918b61849b2c1ba73d4b40e7d33d8bc27

data/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 All notable changes to openvox-lint will be documented in this file.
 
+## [1.3.2] - 2026-05-24
+
+### Fixed
+- Strengthened resource detection logic in `compute_resource_indexes` to reliably exclude `class`/`define`/`node` bodies. This prevents multiple checks (especially `trailing_comma`) from incorrectly treating statements inside classes as resource attributes.
+
+## [1.3.1] - 2026-05-23
+
+### Fixed
+- Critical false positive in `unquoted_resource_title`: resource types (e.g. `file`) inside `class { ... }` or `define { ... }` bodies were incorrectly reported as unquoted titles.
+- `lint:ignore` parser now correctly handles multiple `lint:ignore:check` directives on a single comment line (space or comma separated) and bare `lint:ignore`.
+- Added comprehensive regression tests for the above fixes plus real `--fix` verification for the five supported checks.
+- Expanded unit test coverage across many previously untested checks and edge cases (legacy facts in lambdas/parameters, etc.).
+
 ## [1.3.0] - 2026-05-23
 
 ### Fixed / Production Readiness
@@ -15,7 +28,7 @@ All notable changes to openvox-lint will be documented in this file.
   - Linter now writes mutated `manifest_lines` back to disk on `--fix` (with final-NL normalization per style guide). Fixes are line-based and safe; complex structural fixes (arrow_alignment) remain future work. Tested on real manifests.
 - **`legacy_facts` crash fixed** (in active workspace): `require 'set'` present + exclusion logic for local class/define params and `|$var|` lambdas fully verified (no false positives, no NameError).
 - Removed committed stale `openvox-lint-1.0.8.gem` (violated `.gitignore`).
-- **Version/doc sync**: All references now 1.3.0 (source, docs header, comparison table, this changelog). Bumped for the --fix + hygiene milestone.
+- **Version/doc sync**: All references now 1.3.1 (source, docs header, comparison table, this changelog). Bumped for the --fix + hygiene milestone.
 - Updated README links and comparison to point to canonical OpenVox style guide and note real --fix status.
 - Architecture decision: retained OpenVox's lightweight `CheckPlugin` + depth-aware helpers (superior to puppet-lint Data for some cases); added minimal mutation support for fixes without porting heavy token-rewiring singleton.
 
@@ -23,7 +36,7 @@ All notable changes to openvox-lint will be documented in this file.
 - `--fix` now production-usable for the listed checks (edits in place like puppet-lint).
 - Style guide references prioritize OpenVox canonical docs.
 
-### Contributors (for 1.3.0)
+### Contributors (for 1.3.0 modernization)
 - Grok Build (lead modernization per full analysis reports)
 
 ## [1.2.0] - 2026-03-12

data/DOCUMENTATION.md

@@ -10,7 +10,7 @@ reported in multiple output formats suitable for humans, CI systems, and IDEs.
 This document covers the architecture, every public API, every built-in check,
 the lexer token types, the plugin system, and integration guidance.
 
-**Version:** 1.3.0  
+**Version:** 1.3.2  
 **Checks:** 37 built-in (with real --fix support for 5+ checks)  
 **License:** Apache 2.0  
 **Compatibility:** OpenVox 8.x, Puppet 8.x, Puppet 7.x (with deprecation warnings)
@@ -94,7 +94,7 @@ The top-level namespace for all openvox-lint classes.
 
 | Constant | Value | Description |
 |----------|-------|-------------|
-| `VERSION` | `'1.3.0'` | Gem version string |
+| `VERSION` | `'1.3.2'` | Gem version string |
 
 #### Class Methods
 

data/README.md

@@ -638,7 +638,7 @@ openvox-lint/
 
 ## Comparison with puppet-lint
 
-| Feature | puppet-lint 5.x | openvox-lint 1.3.0 |
+| Feature | puppet-lint 5.x | openvox-lint 1.3.2 |
 |---------|-----------------|------------------|
 | Ruby requirement | ≥ 3.1 | ≥ 2.5 (RHEL 8, macOS, all modern platforms) |
 | Runtime dependencies | None | None |

data/lib/openvox-lint/check_plugin.rb

@@ -92,6 +92,21 @@ module OpenvoxLint
       results = []; i = 0; sem = semantic_tokens
       while i < sem.length
         if sem[i].type == :NAME && i + 1 < sem.length && sem[i + 1].type == :LBRACE
+          # Skip NAME { that belong to class/define/node bodies rather than
+          # actual resources. This prevents inner statements (including other
+          # resources) from being treated as parameters of the class itself.
+          k = i - 1
+          while k >= 0
+            t = sem[k]
+            break if t.type == :CLASS || t.type == :DEFINE || t.type == :NODE
+            break unless t.formatting?
+            k -= 1
+          end
+          if k >= 0 && [:CLASS, :DEFINE, :NODE].include?(sem[k].type)
+            i += 1
+            next
+          end
+
           rtype = sem[i]; brace = i + 1; depth = 1; j = brace + 1; params = []
           while j < sem.length && depth > 0
             case sem[j].type
@@ -141,6 +156,12 @@ module OpenvoxLint
       results = []; sem = semantic_tokens
       sem.each_with_index do |tok, i|
         if tok.type == :LBRACE && i > 0 && sem[i - 1].type == :NAME
+          # Skip the opening brace of class/define/node bodies.
+          # Their name token before { is not a resource type; the next
+          # statement (often another resource) would otherwise be
+          # misinterpreted as an "unquoted resource title".
+          next if i >= 2 && [:CLASS, :DEFINE, :NODE].include?(sem[i-2]&.type)
+
           j = i + 1
           results << sem[j] if j < sem.length && %i[SSTRING STRING NAME VARIABLE].include?(sem[j].type)
         end

data/lib/openvox-lint/checks.rb

@@ -43,15 +43,34 @@ module OpenvoxLint
       @tokens.each do |tok|
         next unless tok.type == :COMMENT
 
-        if tok.value =~ /lint:endignore/
+        comment_text = tok.value.to_s
+
+        if comment_text =~ /lint:endignore/i
           # Close the most recent open block
           block = open_blocks.pop
           if block
             block[:end_line] = tok.line
             results << block
           end
-        elsif tok.value =~ /lint:ignore:(.+)/
-          checks = Regexp.last_match(1).strip.split(/\s*,\s*/)
+        elsif comment_text =~ /lint:ignore/i
+          # Robust extraction: find every "lint:ignore:" and take the following name(s)
+          # until the next "lint:" directive or end of comment.
+          checks = []
+          text = comment_text
+          while (idx = text.index(/lint:ignore:/i))
+            # Take from after this directive until the next directive or end
+            remaining = text[idx + 'lint:ignore:'.length .. -1]
+            next_dir = remaining.index(/lint:/i) || remaining.length
+            chunk = remaining[0...next_dir]
+            checks += chunk.split(/[,\s]+/).map { |s| s.strip.tr('-', '_').downcase }.reject(&:empty?)
+            # Advance past this directive for the next search
+            text = text[idx + 1 .. -1] || ''
+          end
+          checks.uniq!
+          if comment_text =~ /lint:ignore(?!\s*:)/i && checks.empty?
+            checks = []
+          end
+
           # If there's code on the same line before this comment, treat
           # it as inline-only (same line).  Otherwise open a block.
           if inline_ignore?(tok)
@@ -59,12 +78,6 @@ module OpenvoxLint
           else
             open_blocks.push({ start_line: tok.line, end_line: nil, checks: checks })
           end
-        elsif tok.value =~ /lint:ignore\b/
-          if inline_ignore?(tok)
-            results << { start_line: tok.line, end_line: tok.line, checks: [] }
-          else
-            open_blocks.push({ start_line: tok.line, end_line: nil, checks: [] })
-          end
         end
       end
 

data/lib/openvox-lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenvoxLint
-  VERSION = '1.3.0'
+  VERSION = '1.3.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openvox-lint
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.2
 platform: ruby
 authors:
 - Jerald Sheets
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-23 00:00:00.000000000 Z
+date: 2026-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake