openvox-lint 1.0.8 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abe996811c55331e6e81030b3b421c822f152e7e208767c0ba8154e8d6dfe628
-  data.tar.gz: bbd33e6c54ac940eb8b1a3e64ef511ef7ab6412282c12f48e3739508c3d9222c
+  metadata.gz: c93dcb31a47e58c1ff171d798789c1bfdc202cf9d0f950c6eb35c0942eeaa8ca
+  data.tar.gz: 3bf2d9f13f3bc7e39f651626f1c4dcb22b628d45e5a330e146a14d2c3ec9e138
 SHA512:
-  metadata.gz: 4b1e8359096a9156ef02eb2d18dd5af1171593d0f4c47a1957827a043212185dabd09608786c1df606257ca3b21a183978c084d289c7550f900e863367f8697b
-  data.tar.gz: 54bb7aba3f2afef0d6ba51f0346a8f05b7bf495a944a93af14e89144c2d28008ff09243e469b9330cc715a6200c42ea9172a83cebac57164e21088f3c9117c25
+  metadata.gz: e685e7c01d060ae7d1235ebb8d3164e0eac81a72ec0e4cb63f214aca7acde911ad16cc79c5fcbd0f5994d796a6ce8be13f62a43aba92e4c8c1e9d6126dc172e0
+  data.tar.gz: 0b789ecf9210c095ab2c5abb128583e3fd7717aede849a45b0cf5ffc5419fc59d7b62a6ad4fc79495841fce369581fb67ad657a04bc60cdf666e105e3ad0259d

data/CHANGELOG.md

@@ -2,6 +2,114 @@
 
 All notable changes to openvox-lint will be documented in this file.
 
+## [1.3.1] - 2026-05-23
+
+### Fixed
+- Critical false positive in `unquoted_resource_title`: resource types (e.g. `file`) inside `class { ... }` or `define { ... }` bodies were incorrectly reported as unquoted titles.
+- `lint:ignore` parser now correctly handles multiple `lint:ignore:check` directives on a single comment line (space or comma separated) and bare `lint:ignore`.
+- Added comprehensive regression tests for the above fixes plus real `--fix` verification for the five supported checks.
+- Expanded unit test coverage across many previously untested checks and edge cases (legacy facts in lambdas/parameters, etc.).
+
+## [1.3.0] - 2026-05-23
+
+### Fixed / Production Readiness
+
+- **Real `--fix` support implemented** for 5 high-value checks (previously non-functional scaffolding only; all 37 raised `NoFix`):
+  - `trailing_whitespace` — strips trailing ws from lines
+  - `hard_tabs` — replaces `\t` with two spaces
+  - `quoted_booleans` — unquotes `true`/`false` values
+  - `double_quoted_strings` — converts unnecessary `"...` (no interp/escapes) to `'...`
+  - `single_quote_string_with_variables` — converts `'...$var...` to `"...$var...`
+  - Linter now writes mutated `manifest_lines` back to disk on `--fix` (with final-NL normalization per style guide). Fixes are line-based and safe; complex structural fixes (arrow_alignment) remain future work. Tested on real manifests.
+- **`legacy_facts` crash fixed** (in active workspace): `require 'set'` present + exclusion logic for local class/define params and `|$var|` lambdas fully verified (no false positives, no NameError).
+- Removed committed stale `openvox-lint-1.0.8.gem` (violated `.gitignore`).
+- **Version/doc sync**: All references now 1.3.1 (source, docs header, comparison table, this changelog). Bumped for the --fix + hygiene milestone.
+- Updated README links and comparison to point to canonical OpenVox style guide and note real --fix status.
+- Architecture decision: retained OpenVox's lightweight `CheckPlugin` + depth-aware helpers (superior to puppet-lint Data for some cases); added minimal mutation support for fixes without porting heavy token-rewiring singleton.
+
+### Changed
+- `--fix` now production-usable for the listed checks (edits in place like puppet-lint).
+- Style guide references prioritize OpenVox canonical docs.
+
+### Contributors (for 1.3.0 modernization)
+- Grok Build (lead modernization per full analysis reports)
+
+## [1.2.0] - 2026-03-12
+
+### Fixed
+
+- **`legacy_facts` false positives on local variables** — The check no longer
+  flags class/define parameters or lambda block parameters that happen to share
+  names with legacy facts (`$path`, `$type`, `$os`, etc.). Previously, any
+  variable with a legacy fact name would trigger a warning, even when it was
+  clearly a locally-scoped parameter with no relation to facts.
+
+  **Contributed by [@hbro](https://github.com/hbro) (Hans Broeckx)** in
+  [PR #1](https://github.com/cvquesty/openvox-lint/pull/1). This is openvox-lint's
+  first community contribution! 🎉
+
+  The fix adds a pre-scan phase that collects all locally declared variable names
+  from:
+  - Class and defined type parameter lists
+  - Lambda block parameter lists (`|$var|`)
+
+  These local variables are then excluded from the legacy fact name check,
+  eliminating false positives while still correctly detecting actual legacy
+  fact references.
+
+### Contributors
+
+- **Hans Broeckx ([@hbro](https://github.com/hbro))** — First community contributor!
+
+## [1.1.1] - 2026-03-12
+
+### Documentation
+
+- **Comprehensive technical documentation rewrite**: Complete overhaul of
+  [DOCUMENTATION.md](DOCUMENTATION.md) with:
+  - Full API reference for all classes (Token, Lexer, CheckPlugin, Configuration,
+    Linter, Report)
+  - Complete documentation for all 37 checks with good/bad code examples
+  - Organized checks by category (Whitespace, Strings, Variables, Resources, etc.)
+  - Comprehensive token types reference
+  - Plugin development guide with examples
+  - Migration guide from puppet-lint
+
+- **New CONTRIBUTING.md**: Added comprehensive contributor guide with:
+  - Development setup instructions
+  - Project structure documentation
+  - Testing instructions
+  - Check plugin writing guide
+  - Coding standards
+  - Release process
+
+- **Hiera 3 → Hiera 5 clarification**: Updated all documentation to clarify
+  that Hiera 3 is fully deprecated and only Hiera 5 is supported in Puppet 8 /
+  OpenVox 8. The `hiera3_function` check now explicitly references "Hiera 5
+  lookup()" as the replacement.
+
+### Changed
+
+- **`hiera3_function` error message**: Improved to explicitly mention Hiera 5:
+  "deprecated Hiera 3 function 'hiera()' — use Hiera 5 lookup() instead"
+
+## [1.1.0] - 2026-03-05
+
+### Removed
+
+- **`relative_classname_inclusion` check**: This check warned when
+  `include`, `require`, or `contain` statements used relative (non-`::`)
+  multi-segment class names instead of fully qualified ones.  Since
+  Puppet 4, the Puppet language resolver correctly handles relative class
+  name resolution, making relative class name inclusion safe and the
+  check obsolete.  The check has been removed entirely.  Users who had
+  disabled it via `--no-relative_classname_inclusion-check` or
+  `.openvox-lint.rc` can safely remove those overrides.
+
+### Changed
+
+- **Check count**: 38 → 37 built-in checks.
+
 ## [1.0.8] - 2026-03-04
 
 ### Fixed
@@ -146,7 +254,7 @@ All notable changes to openvox-lint will be documented in this file.
   - **Resources**: `ensure_first_param`, `ensure_not_symlink_target`, `file_mode`, `unquoted_file_mode`, `unquoted_resource_title`, `duplicate_params`, `trailing_comma`
   - **Classes**: `documentation`, `nested_classes_or_defines`, `parameter_order`, `class_inherits_params`, `inherits_across_namespaces`
   - **Conditionals**: `case_without_default`, `selector_inside_resource`
-  - **References**: `leading_zero`, `resource_reference_without_title_capital`, `relative_classname_inclusion`, `autoloader_layout`
+  - **References**: `leading_zero`, `resource_reference_without_title_capital`, `autoloader_layout`
   - **Comments**: `star_comments`
   - **URLs**: `puppet_url_without_modules`
   - **Nodes**: `node_name_unquoted`