openvox-lint 1.0.1 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c88e7f7c408afd3a75f203e4b9be28bc34fdbea11bba5245f5315a930cca516
-  data.tar.gz: 3096af92ef4d33f90c50529778930d51a979992ca62e2a96990d5e2b1a8e1936
+  metadata.gz: 71723fc4a281f7c3536d6432b44c5e139836acc8c92fa5bfdb88889f106d6abb
+  data.tar.gz: d17a05a915f9f10b1e132a7eae9587f4877c14094e8d5104fb61c9ff4dbc63c2
 SHA512:
-  metadata.gz: b7d189b56162653881f90a3ff60cdbfda158e252425904e0bd4e49b7adb169a78ba13214dfdd3439498125b9892d6d7e8bdae4fc247711fb3a43d501d5cb7a88
-  data.tar.gz: db0220c84a03ce7f32acb448410ccd3ac61b1733c193b8f765a4eb91080bdf295c041f205e4e0841737b7a00a8c30975803115d2979e309eb090b7dfbfdf78c6
+  metadata.gz: 6b15cf28730f168002763c7d5c3c193514897b890285ca8a3ab28cdc8d8b2db6cb0afd9368244c29e1f7cc343db833a84bd4ff5ffca6e858492edc97d8d85442
+  data.tar.gz: 4d738c4820d2266bff5ca38ab59e7e889614e6f1acf12362e00c0e2ebf2f818be3f19a021605f8bf92cd2a1e76b5a1a867304eac8718d99554394f275df93065

data/CHANGELOG.md

@@ -2,6 +2,27 @@
 
 All notable changes to openvox-lint will be documented in this file.
 
+## [1.0.3] - 2026-02-09
+
+### Fixed
+
+- **double_quoted_strings**: No longer flags double-quoted strings that
+  contain nested single-quote characters (e.g. `"it's running"`,
+  `"use 'ensure' as first parameter"`).  Double quotes are the correct
+  choice when the string body contains literal single quotes, and this
+  is now recognised and skipped.
+
+## [1.0.2] - 2026-02-09
+
+### Fixed
+
+- **duplicate_params**: No longer generates false positives when multiple
+  resource blocks inside a class or defined type share the same parameter
+  names (e.g. `command`, `path`, `onlyif` across separate `exec` blocks).
+  The underlying `compute_resource_indexes` helper now scopes each
+  resource's `param_tokens` to brace depth 1, so tokens belonging to
+  nested resource declarations are excluded.
+
 ## [1.0.1] - 2026-02-09
 
 ### Fixed

data/DOCUMENTATION.md

@@ -46,7 +46,7 @@ the lexer token types, the plugin system, and integration guidance.
 
 | Constant | Value | Description |
 |----------|-------|-------------|
-| `VERSION` | `'1.0.1'` | Gem version |
+| `VERSION` | `'1.0.3'` | Gem version |
 
 ### Class Methods
 

data/README.md

@@ -175,7 +175,7 @@ openvox-lint ships with **38 built-in checks** organized into categories:
 
 | Check | Severity | Description |
 |-------|----------|-------------|
-| `double_quoted_strings` | warning | Use single quotes for strings without interpolation |
+| `double_quoted_strings` | warning | Use single quotes for strings without interpolation, escapes, or nested quotes |
 | `only_variable_string` | warning | Don't quote strings containing only a variable |
 | `single_quote_string_with_variables` | warning | Use double quotes for strings with variables |
 | `variables_not_enclosed` | warning | Variables in strings must use `${var}` braces |

data/lib/openvox-lint/check_plugin.rb

@@ -97,7 +97,10 @@ module OpenvoxLint
             when :LBRACE then depth += 1
             when :RBRACE then depth -= 1
             end
-            params << sem[j] if depth > 0
+            # Only collect tokens at depth 1 — the resource's own
+            # parameters.  Tokens at depth >= 2 belong to nested
+            # resource declarations and must not be included.
+            params << sem[j] if depth == 1 && sem[j].type != :RBRACE
             j += 1
           end
           results << { type: rtype, start: brace, end: j - 1, param_tokens: params }

data/lib/openvox-lint/plugins/checks/double_quoted_strings.rb

@@ -2,6 +2,11 @@
 
 # Double-quoted strings that do not contain variables or escape sequences
 # should use single quotes instead.
+#
+# Exception: when the string body contains literal single-quote characters
+# (e.g. "it's running", "use 'ensure'"), double quotes are the correct
+# choice to avoid backslash-escaping those quotes.  This is standard
+# Puppet style and must not be flagged.
 OpenvoxLint.new_check(:double_quoted_strings) do
   def check
     tokens.each do |tok|
@@ -10,6 +15,9 @@ OpenvoxLint.new_check(:double_quoted_strings) do
       # STRING type means double-quoted without interpolation
       next if val =~ /\\[nt\\$"]/  # has meaningful escapes
       next if val.length <= 2      # empty string ""
+      # Strip surrounding double quotes to inspect inner content.
+      inner = val[1..-2] || ''
+      next if inner.include?("'")  # contains nested single quotes
       notify :warning,
         message: 'string does not contain variables or escapes; use single quotes',
         line: tok.line,

data/lib/openvox-lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenvoxLint
-  VERSION = '1.0.1'
+  VERSION = '1.0.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openvox-lint
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
 platform: ruby
 authors:
 - Johnny Sheets