openurl 0.4.3 → 0.5.0

data/lib/openurl/context_object.rb

@@ -441,11 +441,15 @@ module OpenURL
       # if we don't have a referent format (most likely because we have a 0.1
       # OpenURL), try to determine something from the genre.  If that doesn't 
       # exist, just call it a journal since most 0.1 OpenURLs would be one,
-      # anyway.
-      unless @referent.format        
+      # anyway. Case insensitive match, because some providers play fast and
+      # loose. (BorrowDirect sends 'Book', which can confuse us otherwise)
+      unless @referent.format
         fmt = case @referent.metadata['genre']
-        when /article|journal|issue|proceeding|conference|preprint/ then 'journal'
-        when /book|bookitem|report|document/ then 'book'
+        when /article|journal|issue|proceeding|conference|preprint/i then 'journal'
+        when /book|bookitem|report|document/i then 'book'
+        # 'dissertation' is not a real 'genre', but some use it anyway, and should
+        # map to format 'dissertation' which is real. 
+        when /dissertation/i then 'dissertation' 
         else 'journal'
         end
         @referent.set_format(fmt)

data/test/from_form_vars_test.rb

@@ -0,0 +1,37 @@
+# encoding: UTF-8
+
+# This test is not complete, most of OpenURL was written without tests,
+# just adding tests as we fix bugs or change things. 
+
+Encoding.default_external = "UTF-8" if defined? Encoding
+
+class FromFormVarsTest < Test::Unit::TestCase
+
+  def test_basic_0_1_book
+    co = OpenURL::ContextObject.new_from_form_vars("genre" => "book", "title" => "some book", "au" => "some author")
+
+    assert_equal "book", co.referent.format
+    assert_equal "book", co.referent.metadata['genre']
+    assert_equal "some author", co.referent.metadata['au']
+    assert_equal "some book", co.referent.metadata['title']
+  end
+
+  def test_wrong_case_0_1_book
+    co = OpenURL::ContextObject.new_from_form_vars("genre" => "Book", "title" => "some book", "au" => "some author")
+
+    assert_equal "book", co.referent.format
+    assert_equal "Book", co.referent.metadata['genre']
+    assert_equal "some author", co.referent.metadata['au']
+    assert_equal "some book", co.referent.metadata['title']
+  end
+
+  def test_0_1_dissertation
+    co = OpenURL::ContextObject.new_from_form_vars("genre" => "dissertation", "title" => "some book", "au" => "some author")
+
+    assert_equal "dissertation", co.referent.format
+    assert_equal "dissertation", co.referent.metadata['genre']
+    assert_equal "some author", co.referent.metadata['au']
+    assert_equal "some book", co.referent.metadata['title']
+  end
+
+end

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: openurl
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
+  prerelease: 
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -9,11 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-17 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: marc
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -21,6 +23,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -28,6 +31,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: ensure_valid_encoding
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -35,6 +39,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -48,61 +53,64 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- lib/openurl.rb
+- lib/openurl/context_object.rb
 - lib/openurl/context_object_entity.rb
 - lib/openurl/metadata_formats/book.rb
-- lib/openurl/metadata_formats/journal.rb
-- lib/openurl/metadata_formats/scholarly_service_type.rb
+- lib/openurl/metadata_formats/dissertation.rb
 - lib/openurl/metadata_formats/dublin_core.rb
-- lib/openurl/metadata_formats/scholarly_common.rb
+- lib/openurl/metadata_formats/journal.rb
 - lib/openurl/metadata_formats/marc.rb
 - lib/openurl/metadata_formats/patent.rb
-- lib/openurl/metadata_formats/dissertation.rb
+- lib/openurl/metadata_formats/scholarly_common.rb
+- lib/openurl/metadata_formats/scholarly_service_type.rb
 - lib/openurl/transport.rb
-- lib/openurl/context_object.rb
-- test/data/metalib_sap2_post_params.yml
-- test/data/dc_ctx.xml
-- test/data/yu.xml
-- test/data/scholarly_au_ctx.xml
-- test/data/marc_ctx.xml
+- lib/openurl.rb
 - test/context_object_entity_test.rb
-- test/test.yml
 - test/context_object_test.rb
+- test/data/dc_ctx.xml
+- test/data/marc_ctx.xml
+- test/data/metalib_sap2_post_params.yml
+- test/data/scholarly_au_ctx.xml
+- test/data/yu.xml
 - test/encoding_test.rb
+- test/from_form_vars_test.rb
 - test/scholarly_common_test.rb
+- test/test.yml
 - README.md
 homepage: https://github.com/openurl/openurl
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: a Ruby library to create, parse and use NISO Z39.88 OpenURLs
 test_files:
-- test/data/metalib_sap2_post_params.yml
-- test/data/dc_ctx.xml
-- test/data/yu.xml
-- test/data/scholarly_au_ctx.xml
-- test/data/marc_ctx.xml
 - test/context_object_entity_test.rb
-- test/test.yml
 - test/context_object_test.rb
+- test/data/dc_ctx.xml
+- test/data/marc_ctx.xml
+- test/data/metalib_sap2_post_params.yml
+- test/data/scholarly_au_ctx.xml
+- test/data/yu.xml
 - test/encoding_test.rb
+- test/from_form_vars_test.rb
 - test/scholarly_common_test.rb
+- test/test.yml
 has_rdoc: 

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NWViZjIwOWQ1ODhmMzYzYzc1NTg5ZDI1MDQwODc2Y2FmNGNjMDk4Ng==
-  data.tar.gz: !binary |-
-    YmU1ODM5YTA4NzM1ZDk3MmUxMmJlYjBkZTg2YmQzM2ZhNTJhZTRjYQ==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    YzVhZDBiNzAwNGYyYThiZGM2NTk0NmU0NWExNjJiYjNhYTRhNmRmNWYxYzFm
-    ZGRjNjdlNjRlOTgwMWY0ODA1ZjFjMjY3MmJlMjRkY2M0NzFkNTZkNDE5ZmEx
-    YjlmYzgwMGMzY2Q0MDFlODI3M2JkOTc2OGQyNTFmMDVmOWM2ZDc=
-  data.tar.gz: !binary |-
-    YjRjNDE2MjJmYzI1MDMyNDkyOGM2YzE3MDc5ZjczYTk2ZWMwNTY4YzNiYjc5
-    YWVkMGRmMWUwMTYyNDAwYWM0MWFmMzk2MTU4NTU2YTM2OTJkZTYxYTA4ZWEw
-    YzI2OWRlNzEwNmZkM2UxOTNiZjk2NzQ4MTBkZWEwOTFkYTBkYzI=