opentracing-instrumentation 0.1.17 → 0.1.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ca5229070a9ceefdba01deafe855a8c506018111a073bc627f52b77e67ec07b
-  data.tar.gz: 7afb446993601e8fa9df04c0fca0537495b7125724449c6eab721a45c5e7e5cc
+  metadata.gz: 27eec95422a0be40785c0b5369e6a40a5de45399b263577824159b33fc681e1e
+  data.tar.gz: 8ad8c27eca4ba30b3995b771322904b9d11d034e2e07b4571d989042a51ef927
 SHA512:
-  metadata.gz: 2ff9411175de0c6b489c05da90e068cc85c4ba177f17bea72658b51ec6258935fdc0b264e4577d64a0ecfc04cb670085ea438c0ff04485f4e97bd3de9008d902
-  data.tar.gz: 1058ed6b1b347a9a596a8e76e14a3822b51cf6b0911fe05f03933dee533db10cd3fd138f3d659523ee907c5cf8b394ef1251bb1332a6705ad306c3e50e3fb297
+  metadata.gz: adbff7a43740935e4c5f6286f8ea1be501b6b6c9f8dce9b9cdc320da329b3c7bc29bb5697fed07ab178d28f2d8e85125474081dd8e1ecb0cf8562dc73fbfde58
+  data.tar.gz: 38618d53fc21fca58c21e9bee8b1fad7620f94604bab2470bb9d6df3dfdbdff56d89c335ab1b402f9ac8a3472dbf75b989548f07d2395a0e316ca04c0b537d6b

data/GEM_VERSION

@@ -1 +1 @@
-0.1.17
+0.1.18

data/Gemfile.lock

@@ -18,7 +18,7 @@ GIT
 PATH
   remote: .
   specs:
-    opentracing-instrumentation (0.1.17)
+    opentracing-instrumentation (0.1.18)
       json
       opentracing (~> 0.5.0)
 

data/lib/opentracing/instrumentation/mongo.rb

@@ -9,6 +9,8 @@ module OpenTracing
                'opentracing/instrumentation/mongo/operation_name_builder'
       autoload :TraceSubscriber, 'opentracing/instrumentation/mongo/trace_subscriber'
       autoload :QuerySanitazer, 'opentracing/instrumentation/mongo/query_sanitazer'
+      autoload :SampleSafetyArgumentChecker,
+               'opentracing/instrumentation/mongo/sample_safety_argument_checker'
     end
   end
 end

data/lib/opentracing/instrumentation/mongo/query_sanitazer.rb

@@ -19,9 +19,11 @@ module OpenTracing
         DEFAULT_EXCLUDE_KEYS = %w[lsid].freeze
 
         def initialize(
+          safety_argument_checker: SampleSafetyArgumentChecker.new,
           safe_classes: DEFAULT_SAFE_CLASSES,
           exclude_keys: DEFAULT_EXCLUDE_KEYS
         )
+          @safety_argument_checker = safety_argument_checker
           @safe_classes = safe_classes
           @exclude_keys = exclude_keys
         end
@@ -38,6 +40,7 @@ module OpenTracing
 
         attr_reader :safe_classes
         attr_reader :exclude_keys
+        attr_reader :safety_argument_checker
 
         OBJECT_ID_PLACEHOLDER = '$oid'
         STRING_PLACEHOLDER = '$string'
@@ -68,9 +71,18 @@ module OpenTracing
         end
 
         def sanitaze_hash(hash)
-          hash.transform_values do |value|
-            sanitaze_value(value)
-          end
+          hash.map do |(key, value)|
+            # TODO: pass command name.
+            # TODO: recursive build path to key
+            safe_value =
+              if safety_argument_checker.argument_safe?(nil, key, value)
+                value
+              else
+                sanitaze_value(value)
+              end
+
+            [key, safe_value]
+          end.to_h
         end
 
         def sanitaze_array(array)

data/lib/opentracing/instrumentation/mongo/sample_safety_argument_checker.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module OpenTracing
+  module Instrumentation
+    module Mongo
+      # SampleSafetyArgumentChecker check argument to safety
+      # Draft implementation
+      class SampleSafetyArgumentChecker
+        DEFAULT_SAFE_ARGUMENTS = [
+          '$readPreference',
+          '$clusterTime',
+        ].freeze
+
+        attr_reader :safe_arguments
+
+        def initialize(safe_arguments: DEFAULT_SAFE_ARGUMENTS)
+          @safe_arguments = safe_arguments
+        end
+
+        # check
+        #
+        # @return (TrueClass, FalseClass) `true`, if argument safe and not
+        # not should be cleaned. Otherwise return `false``.
+        def argument_safe?(_command_name, argument_path, _argument_value)
+          safe_arguments.include?(argument_path)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentracing-instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.1.17
+  version: 0.1.18
 platform: ruby
 authors:
 - Fedorenko Dmitrij
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-07 00:00:00.000000000 Z
+date: 2020-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -299,6 +299,7 @@ files:
 - lib/opentracing/instrumentation/mongo/direct_sanitazer.rb
 - lib/opentracing/instrumentation/mongo/operation_name_builder.rb
 - lib/opentracing/instrumentation/mongo/query_sanitazer.rb
+- lib/opentracing/instrumentation/mongo/sample_safety_argument_checker.rb
 - lib/opentracing/instrumentation/mongo/trace_subscriber.rb
 - lib/opentracing/instrumentation/object_wrapper.rb
 - lib/opentracing/instrumentation/rack.rb