RubyGems - opentelemetry-instrumentation-http - Versions diffs - 0.27.0 → 0.27.1 - Mend

opentelemetry-instrumentation-http 0.27.0 → 0.27.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (9) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +4 -0
data/lib/opentelemetry/instrumentation/http/http_helper.rb +86 -0
data/lib/opentelemetry/instrumentation/http/patches/dup/client.rb +13 -9
data/lib/opentelemetry/instrumentation/http/patches/old/client.rb +11 -8
data/lib/opentelemetry/instrumentation/http/patches/stable/client.rb +12 -8
data/lib/opentelemetry/instrumentation/http/version.rb +1 -1
data/lib/opentelemetry/instrumentation/http.rb +1 -0
metadata +5 -4

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5cfca1b61fff002488ab722c3dad56886a7569dfa448ed35bba74306c0f65bda
-  data.tar.gz: 413fe154ab17f00a83de985900f510f26be7799a72b6c497ef5c05178f8ff842
+  metadata.gz: 850cb2d0a9d8d18cf00cade03d86e379a2338f626a0f1468e32b37c186de0869
+  data.tar.gz: d89c15de55426a730fdaef82e1b8212fa20981b645b9985f66712ceff7cab2b3
 SHA512:
-  metadata.gz: 50204b9e16fc37d0c2769fb35c391d127c1fb34da299d271be43198287d1b72336ab0e86f2325332b13e29bd34a2784f063fe80b76350cd02fb10644a3c09419
-  data.tar.gz: 4a46af4051a0eda05a4663eecaf78b4f129a83f89ac198d436b4ef3a5063403bca81ea0cceffe08e5030a02e0e863abbe8f07d3f2eed7aa108bd5f4f6577552e
+  metadata.gz: 676dd8c1071ed0c9f0927c6def794f71637919a3303be4df314ebfe2cdb8037f04e64c5ccbdc649326f51c920437714cd504699a59e26dbfeb33569aed5172e0
+  data.tar.gz: a681dc2912300b21a16e1d7d069cf8e35eb3f9899917e87f89522f15e7b949de8f963bb894eb5efd887cc0a2cd8120077b25b3c29dc125dd0beffd7a150e3bb8

data/CHANGELOG.md CHANGED Viewed

@@ -1,5 +1,9 @@
 # Release History: opentelemetry-instrumentation-http
+### v0.27.1 / 2025-11-25
+* FIXED: Update support for unknown HTTP methods to match semantic conventions
 ### v0.27.0 / 2025-10-22
 * BREAKING CHANGE: Min Ruby Version 3.2

data/lib/opentelemetry/instrumentation/http/http_helper.rb ADDED Viewed

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+# Copyright The OpenTelemetry Authors
+#
+# SPDX-License-Identifier: Apache-2.0
+module OpenTelemetry
+  module Instrumentation
+    module HTTP
+      # Module for normalizing HTTP methods
+      # @api private
+      module HttpHelper
+        # Lightweight struct to hold span creation attributes
+        SpanCreationAttributes = Struct.new(:span_name, :normalized_method, :original_method, keyword_init: true)
+        # Pre-computed mapping to avoid string allocations during normalization
+        METHOD_CACHE = {
+          'CONNECT' => 'CONNECT',
+          'DELETE' => 'DELETE',
+          'GET' => 'GET',
+          'HEAD' => 'HEAD',
+          'OPTIONS' => 'OPTIONS',
+          'PATCH' => 'PATCH',
+          'POST' => 'POST',
+          'PUT' => 'PUT',
+          'TRACE' => 'TRACE',
+          'connect' => 'CONNECT',
+          'delete' => 'DELETE',
+          'get' => 'GET',
+          'head' => 'HEAD',
+          'options' => 'OPTIONS',
+          'patch' => 'PATCH',
+          'post' => 'POST',
+          'put' => 'PUT',
+          'trace' => 'TRACE',
+          :connect => 'CONNECT',
+          :delete => 'DELETE',
+          :get => 'GET',
+          :head => 'HEAD',
+          :options => 'OPTIONS',
+          :patch => 'PATCH',
+          :post => 'POST',
+          :put => 'PUT',
+          :trace => 'TRACE'
+        }.freeze
+        # Pre-computed span names for old semantic conventions to avoid allocations
+        OLD_SPAN_NAMES = {
+          'CONNECT' => 'HTTP CONNECT',
+          'DELETE' => 'HTTP DELETE',
+          'GET' => 'HTTP GET',
+          'HEAD' => 'HTTP HEAD',
+          'OPTIONS' => 'HTTP OPTIONS',
+          'PATCH' => 'HTTP PATCH',
+          'POST' => 'HTTP POST',
+          'PUT' => 'HTTP PUT',
+          'TRACE' => 'HTTP TRACE'
+        }.freeze
+        private_constant :METHOD_CACHE, :OLD_SPAN_NAMES
+        # Prepares all span data for the specified semantic convention in a single call
+        # @param method [String, Symbol] The HTTP method
+        # @param semconv [Symbol] The semantic convention to use (:stable or :old)
+        # @return [SpanCreationAttributes] struct containing span_name, normalized_method, and original_method
+        def self.span_attrs_for(method, semconv: :stable)
+          normalized = METHOD_CACHE[method]
+          if normalized
+            span_name = semconv == :old ? OLD_SPAN_NAMES[normalized] : normalized
+            SpanCreationAttributes.new(
+              span_name: span_name,
+              normalized_method: normalized,
+              original_method: nil
+            )
+          else
+            SpanCreationAttributes.new(
+              span_name: 'HTTP',
+              normalized_method: '_OTHER',
+              original_method: method.to_s
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opentelemetry/instrumentation/http/patches/dup/client.rb CHANGED Viewed

@@ -16,26 +16,28 @@ module OpenTelemetry
             HTTP_STATUS_SUCCESS_RANGE = (100..399)
             def perform(req, options)
+              span_data = HttpHelper.span_attrs_for(req.verb)
               uri = req.uri
-              request_method = req.verb.to_s.upcase
-              span_name = create_request_span_name(request_method, uri.path)
+              span_name = create_span_name(span_data, uri.path)
               attributes = {
                 # old semconv
-                'http.method' => request_method,
+                'http.method' => span_data.normalized_method,
                 'http.scheme' => uri.scheme,
                 'http.target' => uri.path,
                 'http.url' => "#{uri.scheme}://#{uri.host}",
                 'net.peer.name' => uri.host,
                 'net.peer.port' => uri.port,
                 # stable semconv
-                'http.request.method' => request_method,
+                'http.request.method' => span_data.normalized_method,
                 'url.scheme' => uri.scheme,
                 'url.path' => uri.path,
                 'url.full' => "#{uri.scheme}://#{uri.host}",
                 'server.address' => uri.host,
                 'server.port' => uri.port
               }
+              attributes['http.request.method_original'] = span_data.original_method if span_data.original_method
               attributes['url.query'] = uri.query unless uri.query.nil?
               attributes.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
@@ -62,15 +64,17 @@ module OpenTelemetry
               span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
             end
-            def create_request_span_name(request_method, request_path)
+            def create_span_name(span_data, request_path)
+              default_span_name = span_data.span_name
               if (implementation = config[:span_name_formatter])
-                updated_span_name = implementation.call(request_method, request_path)
-                updated_span_name.is_a?(String) ? updated_span_name : request_method.to_s
+                updated_span_name = implementation.call(span_data.normalized_method, request_path)
+                updated_span_name.is_a?(String) ? updated_span_name : default_span_name
               else
-                request_method.to_s
+                default_span_name
               end
             rescue StandardError
-              request_method.to_s
+              default_span_name
             end
             def tracer

data/lib/opentelemetry/instrumentation/http/patches/old/client.rb CHANGED Viewed

@@ -16,12 +16,13 @@ module OpenTelemetry
             HTTP_STATUS_SUCCESS_RANGE = (100..399)
             def perform(req, options)
+              span_data = HttpHelper.span_attrs_for(req.verb, semconv: :old)
               uri = req.uri
-              request_method = req.verb.to_s.upcase
-              span_name = create_request_span_name(request_method, uri.path)
+              span_name = create_span_name(span_data, uri.path)
               attributes = {
-                'http.method' => request_method,
+                'http.method' => span_data.normalized_method,
                 'http.scheme' => uri.scheme,
                 'http.target' => uri.path,
                 'http.url' => "#{uri.scheme}://#{uri.host}",
@@ -51,15 +52,17 @@ module OpenTelemetry
               span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
             end
-            def create_request_span_name(request_method, request_path)
+            def create_span_name(span_data, request_path)
+              default_span_name = span_data.span_name
               if (implementation = config[:span_name_formatter])
-                updated_span_name = implementation.call(request_method, request_path)
-                updated_span_name.is_a?(String) ? updated_span_name : "HTTP #{request_method}"
+                updated_span_name = implementation.call(span_data.normalized_method, request_path)
+                updated_span_name.is_a?(String) ? updated_span_name : default_span_name
               else
-                "HTTP #{request_method}"
+                default_span_name
               end
             rescue StandardError
-              "HTTP #{request_method}"
+              default_span_name
             end
             def tracer

data/lib/opentelemetry/instrumentation/http/patches/stable/client.rb CHANGED Viewed

@@ -16,18 +16,20 @@ module OpenTelemetry
             HTTP_STATUS_SUCCESS_RANGE = (100..399)
             def perform(req, options)
+              span_data = HttpHelper.span_attrs_for(req.verb)
               uri = req.uri
-              request_method = req.verb.to_s.upcase
-              span_name = create_request_span_name(request_method, uri.path)
+              span_name = create_span_name(span_data, uri.path)
               attributes = {
-                'http.request.method' => request_method,
+                'http.request.method' => span_data.normalized_method,
                 'url.scheme' => uri.scheme,
                 'url.path' => uri.path,
                 'url.full' => "#{uri.scheme}://#{uri.host}",
                 'server.address' => uri.host,
                 'server.port' => uri.port
               }
+              attributes['http.request.method_original'] = span_data.original_method if span_data.original_method
               attributes['url.query'] = uri.query unless uri.query.nil?
               attributes.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes)
@@ -53,15 +55,17 @@ module OpenTelemetry
               span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status_code)
             end
-            def create_request_span_name(request_method, request_path)
+            def create_span_name(span_data, request_path)
+              default_span_name = span_data.span_name
               if (implementation = config[:span_name_formatter])
-                updated_span_name = implementation.call(request_method, request_path)
-                updated_span_name.is_a?(String) ? updated_span_name : request_method.to_s
+                updated_span_name = implementation.call(span_data.normalized_method, request_path)
+                updated_span_name.is_a?(String) ? updated_span_name : default_span_name
               else
-                request_method.to_s
+                default_span_name
               end
             rescue StandardError
-              request_method.to_s
+              default_span_name
             end
             def tracer

data/lib/opentelemetry/instrumentation/http/version.rb CHANGED Viewed

@@ -7,7 +7,7 @@
 module OpenTelemetry
   module Instrumentation
     module HTTP
-      VERSION = '0.27.0'
+      VERSION = '0.27.1'
     end
   end
 end

data/lib/opentelemetry/instrumentation/http.rb CHANGED Viewed

@@ -15,5 +15,6 @@ module OpenTelemetry
   end
 end
+require_relative 'http/http_helper'
 require_relative 'http/instrumentation'
 require_relative 'http/version'

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-instrumentation-http
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.27.1
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-22 00:00:00.000000000 Z
+date: 2025-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-instrumentation-base
@@ -38,6 +38,7 @@ files:
 - lib/opentelemetry-instrumentation-http.rb
 - lib/opentelemetry/instrumentation.rb
 - lib/opentelemetry/instrumentation/http.rb
+- lib/opentelemetry/instrumentation/http/http_helper.rb
 - lib/opentelemetry/instrumentation/http/instrumentation.rb
 - lib/opentelemetry/instrumentation/http/patches/dup/client.rb
 - lib/opentelemetry/instrumentation/http/patches/dup/connection.rb
@@ -50,10 +51,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby-contrib
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http/0.27.0/file/CHANGELOG.md
+  changelog_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http/0.27.1/file/CHANGELOG.md
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/http
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues
-  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http/0.27.0
+  documentation_uri: https://rubydoc.info/gems/opentelemetry-instrumentation-http/0.27.1
 post_install_message:
 rdoc_options: []
 require_paths: