opentelemetry-instrumentation-active_job 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c341fbc24129813db37f6b8b83719df56bfd042378b97619969a5a7684647dc
-  data.tar.gz: 4d436b96869793778d0b1a237cca48b69dfc1ef53e7c0a4fa1cfff7ccd9a3432
+  metadata.gz: cf28c56776d6925a23e7a0dd65162cc217c7e5fd4e591b471cd77912241d5f89
+  data.tar.gz: 728c70ce03a1d03f28242dabcee397ce7bd7186f05fd747cd2e3451f6fdc7ab4
 SHA512:
-  metadata.gz: d72fbe4abcd71905d858f8fe7baf4d6ff94feadbc0c64bf2be8bdd44da158510c0b07997d2feaa851435394e48a824a6eccb0aac5ce7b16d99afea3b350b4ffa
-  data.tar.gz: 4aa9e51f6bbd8cb640f2ae177602d9381844b1394effe1e152bf3ebfebee16dbfde87ac47a59fcf2b6389fc83e41f251b1e1609a9da189845f84018b9695dd50
+  metadata.gz: 35f01f133c73ff36562554d783b890c928f81e24256dbd4c9d91a4b024f4dff4e07e8a853b888d1542aa444f0505774d618b671462d598ab0e19f34169de4ae5
+  data.tar.gz: 9e23409ef225df507335da04b877bb9e82cb3d13569687577ca2f7e1d6e856f26278054740762d521a9e311228364d86a4b6351b740524424afe3c00fc0016d7

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Release History: opentelemetry-instrumentation-active_job
 
+### v0.2.0 / 2022-05-02
+
+* ADDED: Validate Using Enums 
+* ADDED: Make the context available in ActiveJob notifications 
+* FIXED: Fix deserialization of jobs that are missing metadata 
+* FIXED: RubyGems Fallback 
+
 ### v0.1.5 / 2021-12-02
 
 * (No significant changes)

data/lib/opentelemetry/instrumentation/active_job/instrumentation.rb

@@ -21,7 +21,7 @@ module OpenTelemetry
         end
 
         compatible do
-          Gem.loaded_specs['activejob'].version >= MINIMUM_VERSION
+          gem_version >= MINIMUM_VERSION
         end
 
         ## Supported configuration keys for the install config hash:
@@ -52,12 +52,16 @@ module OpenTelemetry
         # spans will always be children of the enqueueing spans. This is due to the way
         # ActiveJob immediately executes jobs during the process of "enqueueing" jobs when
         # using the `:inline` adapter.
-        option :propagation_style, default: :link, validate: ->(opt) { %i[link child none].include?(opt) }
+        option :propagation_style, default: :link, validate: %i[link child none]
         option :force_flush, default: false, validate: :boolean
-        option :span_naming, default: :queue, validate: ->(opt) { %i[job_class queue].include?(opt) }
+        option :span_naming, default: :queue, validate: %i[job_class queue]
 
         private
 
+        def gem_version
+          ::ActiveJob.version
+        end
+
         def require_dependencies
           require_relative 'patches/base'
           require_relative 'patches/active_job_callbacks'

data/lib/opentelemetry/instrumentation/active_job/patches/active_job_callbacks.rb

@@ -10,8 +10,8 @@ module OpenTelemetry
       module Patches
         # Module to prepend to ActiveJob::Base for instrumentation.
         module ActiveJobCallbacks
-          def self.prepended(base) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-            base.class_eval do # rubocop:disable Metrics/BlockLength
+          def self.prepended(base)
+            base.class_eval do
               around_enqueue do |job, block|
                 span_kind = job.class.queue_adapter_name == 'inline' ? :client : :producer
                 span_name = "#{otel_config[:span_naming] == :job_class ? job.class : job.queue_name} send"
@@ -21,45 +21,46 @@ module OpenTelemetry
                   block.call
                 end
               end
+            end
+          end
 
-              around_perform do |job, block| # rubocop:disable Metrics/BlockLength
-                span_kind = job.class.queue_adapter_name == 'inline' ? :server : :consumer
-                span_name = "#{otel_config[:span_naming] == :job_class ? job.class : job.queue_name} process"
-                span_attributes = job_attributes(job).merge('messaging.operation' => 'process')
+          def perform_now # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+            span_kind = self.class.queue_adapter_name == 'inline' ? :server : :consumer
+            span_name = "#{otel_config[:span_naming] == :job_class ? self.class : queue_name} process"
+            span_attributes = job_attributes(self).merge('messaging.operation' => 'process')
+            executions_count = (executions || 0) + 1 # because we run before the count is incremented in ActiveJob::Execution
 
-                extracted_context = OpenTelemetry.propagation.extract(job.metadata)
-                OpenTelemetry::Context.with_current(extracted_context) do
-                  if otel_config[:propagation_style] == :child
-                    otel_tracer.in_span(span_name, attributes: span_attributes, kind: span_kind) do |span|
-                      span.set_attribute('messaging.active_job.executions', job.executions)
-                      block.call
-                    end
-                  else
-                    span_links = []
-                    if otel_config[:propagation_style] == :link
-                      span_context = OpenTelemetry::Trace.current_span(extracted_context).context
-                      span_links << OpenTelemetry::Trace::Link.new(span_context) if span_context.valid?
-                    end
+            extracted_context = OpenTelemetry.propagation.extract(metadata)
+            OpenTelemetry::Context.with_current(extracted_context) do
+              if otel_config[:propagation_style] == :child
+                otel_tracer.in_span(span_name, attributes: span_attributes, kind: span_kind) do |span|
+                  span.set_attribute('messaging.active_job.executions', executions_count)
+                  super
+                end
+              else
+                span_links = []
+                if otel_config[:propagation_style] == :link
+                  span_context = OpenTelemetry::Trace.current_span(extracted_context).context
+                  span_links << OpenTelemetry::Trace::Link.new(span_context) if span_context.valid?
+                end
 
-                    root_span = otel_tracer.start_root_span(span_name, attributes: span_attributes, links: span_links, kind: span_kind)
-                    OpenTelemetry::Trace.with_span(root_span) do |span|
-                      span.set_attribute('messaging.active_job.executions', job.executions)
-                      block.call
-                    rescue Exception => e # rubocop:disable Lint/RescueException
-                      span.record_exception(e)
-                      span.status = OpenTelemetry::Trace::Status.error("Unhandled exception of type: #{e.class}")
-                      raise e
-                    ensure
-                      root_span.finish
-                    end
-                  end
+                root_span = otel_tracer.start_root_span(span_name, attributes: span_attributes, links: span_links, kind: span_kind)
+                OpenTelemetry::Trace.with_span(root_span) do |span|
+                  span.set_attribute('messaging.active_job.executions', executions_count)
+                  super
+                rescue Exception => e # rubocop:disable Lint/RescueException
+                  span.record_exception(e)
+                  span.status = OpenTelemetry::Trace::Status.error("Unhandled exception of type: #{e.class}")
+                  raise e
+                ensure
+                  root_span.finish
                 end
-              ensure
-                # We may be in a job system (eg: resque) that forks and kills worker processes often.
-                # We don't want to lose spans by not flushing any span processors, so we optionally force it here.
-                OpenTelemetry.tracer_provider.force_flush if otel_config[:force_flush]
               end
             end
+          ensure
+            # We may be in a job system (eg: resque) that forks and kills worker processes often.
+            # We don't want to lose spans by not flushing any span processors, so we optionally force it here.
+            OpenTelemetry.tracer_provider.force_flush if otel_config[:force_flush]
           end
 
           private

data/lib/opentelemetry/instrumentation/active_job/patches/base.rb

@@ -27,7 +27,7 @@ module OpenTelemetry
           end
 
           def deserialize(job_data)
-            self.metadata = (deserialize_arguments(job_data['metadata']) || []).to_h
+            self.metadata = deserialize_arguments(job_data['metadata'] || []).to_h
             super
           end
         end

data/lib/opentelemetry/instrumentation/active_job/version.rb

@@ -7,7 +7,7 @@
 module OpenTelemetry
   module Instrumentation
     module ActiveJob
-      VERSION = '0.1.5'
+      VERSION = '0.2.0'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-instrumentation-active_job
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-02 00:00:00.000000000 Z
+date: 2022-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.20.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.20.0
 - !ruby/object:Gem::Dependency
   name: activejob
   requirement: !ruby/object:Gem::Requirement
@@ -228,10 +228,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-instrumentation-active_job/v0.1.5/file.CHANGELOG.html
+  changelog_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-instrumentation-active_job/v0.2.0/file.CHANGELOG.html
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby/tree/main/instrumentation/active_job
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby/issues
-  documentation_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-instrumentation-active_job/v0.1.5
+  documentation_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-instrumentation-active_job/v0.2.0
 post_install_message: 
 rdoc_options: []
 require_paths: